)]}'
{"anchor/validators.py":[{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"2635d96eca7c3823da5fc8252a5fc88ca651a754","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    pass"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def csr_require_cn(csr):"},{"line_number":32,"context_line":"    cns \u003d csr.get_subject_cn()"},{"line_number":33,"context_line":"    if not cns:"},{"line_number":34,"context_line":"        raise ValidationError(\"CSR is lacking a CN in the Subject\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_155d9678","line":31,"updated":"2015-08-06 11:33:32.000000000","message":"Is requiring a CN a good move going forwards?","commit_id":"53df52322835312185fba38494b2c56bd214be90"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"7beb37b2d81e0b8a0d1f1688d44b658a70f4cf3c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    pass"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def csr_require_cn(csr):"},{"line_number":32,"context_line":"    cns \u003d csr.get_subject_cn()"},{"line_number":33,"context_line":"    if not cns:"},{"line_number":34,"context_line":"        raise ValidationError(\"CSR is lacking a CN in the Subject\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_717913fc","line":31,"in_reply_to":"1a4dcd0f_155d9678","updated":"2015-08-18 05:51:15.000000000","message":"The function already did that. I\u0027m just fixing the name rather than functionality here.\n\nThe blueprint validator-improvement is dealing with change to a proper DNS-ID querying instead of current CN/altname hacks.","commit_id":"53df52322835312185fba38494b2c56bd214be90"},{"author":{"_account_id":11397,"name":"Doug Chivers","email":"dougchivers@gmail.com","username":"dg"},"change_message_id":"7535e43493e6c4b1e6843aa209e8d62f8ffe48ec","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    pass"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def csr_require_cn(csr):"},{"line_number":32,"context_line":"    cns \u003d csr.get_subject_cn()"},{"line_number":33,"context_line":"    if not cns:"},{"line_number":34,"context_line":"        raise ValidationError(\"CSR is lacking a CN in the Subject\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_c4bfedce","line":31,"in_reply_to":"fa1b9901_717913fc","updated":"2015-08-18 11:43:28.000000000","message":"Yes, I know. I just dont think we should change it explicity to require a CN, instead we should fix it.","commit_id":"53df52322835312185fba38494b2c56bd214be90"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"c70ee8334e250990b5c9c9bb7af5ef392674d92c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    pass"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def csr_require_cn(csr):"},{"line_number":32,"context_line":"    cns \u003d csr.get_subject_cn()"},{"line_number":33,"context_line":"    if not cns:"},{"line_number":34,"context_line":"        raise ValidationError(\"CSR is lacking a CN in the Subject\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_3162dbae","line":31,"in_reply_to":"fa1b9901_c4bfedce","updated":"2015-09-01 17:38:06.000000000","message":"As this is a validator, I\u0027m happy to have a function available for users who have decided that according to their policy, they _do_ want a CN. However, for the sake of sanity there should probably be some check that when we don\u0027t have a CN we do have SAN.","commit_id":"53df52322835312185fba38494b2c56bd214be90"}],"tests/validators/test_base_validation_functions.py":[{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"c70ee8334e250990b5c9c9bb7af5ef392674d92c","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def test_csr_require_cn(self):"},{"line_number":90,"context_line":"        name \u003d validators.csr_require_cn(self.csr)"},{"line_number":91,"context_line":"        self.assertEqual(name, \"ossg.test.com\")"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        self.csr.from_buffer(TestBaseValidators.csr_data_without_cn)"},{"line_number":94,"context_line":"        with self.assertRaises(validators.ValidationError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_71685388","line":91,"updated":"2015-09-01 17:38:06.000000000","message":"example.org","commit_id":"53df52322835312185fba38494b2c56bd214be90"}]}