)]}'
{"anchor/X509/signing_request.py":[{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"e68650aab53986e93702f58a101984a6c91a7af9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            raise TypeError(\"subject must be an X509Name\")"},{"line_number":107,"context_line":"        ri \u003d self.get_request_info()"},{"line_number":108,"context_line":"        if ri[\u0027subject\u0027] is None:"},{"line_number":109,"context_line":"            ri[\u0027subject\u0027] \u003d None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        ri[\u0027subject\u0027][0] \u003d subject._name_obj"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_78259608","line":109,"updated":"2015-09-19 11:41:51.000000000","message":"This doesn\u0027t look right to me, I think perhaps 109 was supposed to assign something other than None ?\n\nIt\u0027s indexed on line 111, I think that\u0027ll break if it\u0027s None.","commit_id":"327ec241831323ee0b1aeea0154f9c2654f5f036"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"f60869c3133a0edc395e2d94454aae22a846bbeb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            raise TypeError(\"subject must be an X509Name\")"},{"line_number":107,"context_line":"        ri \u003d self.get_request_info()"},{"line_number":108,"context_line":"        if ri[\u0027subject\u0027] is None:"},{"line_number":109,"context_line":"            ri[\u0027subject\u0027] \u003d None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        ri[\u0027subject\u0027][0] \u003d subject._name_obj"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_d0d7d2bd","line":109,"in_reply_to":"ba15a1d1_78259608","updated":"2015-09-20 09:34:56.000000000","message":"This is right. Pyasn1 interface is... interesting. What happens on assignment of None is the attribute gets the default/empty value instead. So for example instead of `RDNSequence(with_some_very_long_tags, and_some_very_long_null_value)`, you can assign None. I though about adding comments, but there are so many places this happens, this module would be filled with them. (see line 87, 97, 107, ...) In cases with tags, \"very long\" means 2-3 lines that define just one empty element.\n\nIt\u0027s not a nice interface, but that\u0027s what we get.","commit_id":"327ec241831323ee0b1aeea0154f9c2654f5f036"},{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"e574044cbc887d9433965e332481c429d46fd06c","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            raise TypeError(\"subject must be an X509Name\")"},{"line_number":107,"context_line":"        ri \u003d self.get_request_info()"},{"line_number":108,"context_line":"        if ri[\u0027subject\u0027] is None:"},{"line_number":109,"context_line":"            ri[\u0027subject\u0027] \u003d None"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        ri[\u0027subject\u0027][0] \u003d subject._name_obj"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_0e419b39","line":109,"in_reply_to":"ba15a1d1_d0d7d2bd","updated":"2015-09-21 12:36:42.000000000","message":"Wow, that\u0027s horrible. Maybe add a comment at the top of the file or something, I can easily see this causing confusion down the road when someone tries to maintain this.","commit_id":"327ec241831323ee0b1aeea0154f9c2654f5f036"}]}
