)]}'
{"anchor/validators_standards.py":[{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"2e44acc4e62c57a72d735aaadbadb02d116efb53","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This module provides validators which should be included in all deployments and"},{"line_number":18,"context_line":"which are based directly on the standards documents. All exceptions must have a"},{"line_number":19,"context_line":"comment referencing the document / section they\u0027re based on."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"All the rules are pulled into a single validator: ``standards_compliance``."},{"line_number":22,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_bca83221","line":19,"updated":"2015-09-07 08:58:42.000000000","message":"I would like to see this info in the exception message as well.","commit_id":"e6044914ee2b2fde8ad0e4a7cf23c44c722599d5"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"2e44acc4e62c57a72d735aaadbadb02d116efb53","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        oid \u003d ext.get_oid()"},{"line_number":48,"context_line":"        if oid in seen_oids:"},{"line_number":49,"context_line":"            raise validators.ValidationError("},{"line_number":50,"context_line":"                \"Duplicate extension with oid %s\" % oid)"},{"line_number":51,"context_line":"        seen_oids.add(oid)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_3c6bc2f2","line":50,"updated":"2015-09-07 08:58:42.000000000","message":"see above comment","commit_id":"e6044914ee2b2fde8ad0e4a7cf23c44c722599d5"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"2e44acc4e62c57a72d735aaadbadb02d116efb53","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            # RFC5280 section 4.1.2.6"},{"line_number":59,"context_line":"            if len(csr.get_subject()) \u003d\u003d 0 and not ext.get_critical():"},{"line_number":60,"context_line":"                raise validators.ValidationError("},{"line_number":61,"context_line":"                    \"SAN must be critical if subject is empty\")"},{"line_number":62,"context_line":"        if isinstance(ext, extension.X509ExtensionBasicConstraints):"},{"line_number":63,"context_line":"            # RFC5280 section 4.1.2.9"},{"line_number":64,"context_line":"            if not ext.get_critical():"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_bc7fd2a9","line":61,"updated":"2015-09-07 08:58:42.000000000","message":"see above comment","commit_id":"e6044914ee2b2fde8ad0e4a7cf23c44c722599d5"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"2e44acc4e62c57a72d735aaadbadb02d116efb53","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            # RFC5280 section 4.1.2.9"},{"line_number":64,"context_line":"            if not ext.get_critical():"},{"line_number":65,"context_line":"                raise validators.ValidationError("},{"line_number":66,"context_line":"                    \"Basic constraints has to be marked critical\")"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# RFC1034 allows a simple \" \" too, but it\u0027s not allowed in certificates, so it"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_dc7ac6b9","line":66,"updated":"2015-09-07 08:58:42.000000000","message":"see above comment","commit_id":"e6044914ee2b2fde8ad0e4a7cf23c44c722599d5"},{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"2e44acc4e62c57a72d735aaadbadb02d116efb53","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    for domain in ext.get_dns_ids():"},{"line_number":97,"context_line":"        if not check_domains(domain):"},{"line_number":98,"context_line":"            raise validators.ValidationError("},{"line_number":99,"context_line":"                \"SAN entry \u003c%s\u003e is not a valid domain\" % (domain,))"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_9c4f6e91","line":99,"updated":"2015-09-07 08:58:42.000000000","message":"see above comment","commit_id":"e6044914ee2b2fde8ad0e4a7cf23c44c722599d5"}],"config.json":[{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"2e44acc4e62c57a72d735aaadbadb02d116efb53","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      \"authentication\": \"method_1\","},{"line_number":22,"context_line":"      \"signing_ca\": \"local\","},{"line_number":23,"context_line":"      \"validators\": {"},{"line_number":24,"context_line":"\t\"standards_compliance\": {},"},{"line_number":25,"context_line":"        \"ca_status\": {"},{"line_number":26,"context_line":"          \"ca_requested\": false"},{"line_number":27,"context_line":"        },"}],"source_content_type":"application/json","patch_set":3,"id":"da20952f_1c87deb5","line":24,"updated":"2015-09-07 08:58:42.000000000","message":"tab issue?","commit_id":"e6044914ee2b2fde8ad0e4a7cf23c44c722599d5"}],"doc/source/validators.rst":[{"author":{"_account_id":7063,"name":"Robert Clark","email":"hyakuhei@gmail.com","username":"hyakuhei"},"change_message_id":"251106b93d15f0ee0cf71c4fdb7526be4d420701","unresolved":false,"context_lines":[{"line_number":15,"context_line":"    Verifies: CSR."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    Ensures that the CSR does not break any rules defined in the standards"},{"line_number":18,"context_line":"    docuents (mostly RFC5280). Specific checks may be added over time in new"},{"line_number":19,"context_line":"    versions of Anchor. This validator should be only skipped if there\u0027s a"},{"line_number":20,"context_line":"    known compatibility issue. Otherwise it should be used in all environments."},{"line_number":21,"context_line":"    Any requests produced using standard tooling that fail this check should be"}],"source_content_type":"text/x-rst","patch_set":5,"id":"ba15a1d1_58f8d249","line":18,"updated":"2015-09-19 11:56:09.000000000","message":"typo: documents","commit_id":"7166f9948eb59240e51fb8b48c8653d58306b901"}],"tests/validators/test_standards_validator.py":[{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"2e44acc4e62c57a72d735aaadbadb02d116efb53","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        validators_standards._critical_flags(csr)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"class TestValidDomains(unittest.TestCase):"},{"line_number":124,"context_line":"    def test_all_valid(self):"},{"line_number":125,"context_line":"        csr \u003d signing_request.X509Csr()"},{"line_number":126,"context_line":"        ext \u003d extension.X509ExtensionSubjectAltName()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_570a1121","line":123,"updated":"2015-09-07 08:58:42.000000000","message":"there seems to be a lot of duplication in these test methods, maybe add a helper?","commit_id":"e6044914ee2b2fde8ad0e4a7cf23c44c722599d5"}]}
