)]}'
{"anchor/X509/certificate.py":[{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"d07adedadbcc557e1393cd5531cafaf23c93f330","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self._cert[\u0027tbsCertificate\u0027][\u0027serialNumber\u0027] \u003d serial"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_serial_number(self,):"},{"line_number":201,"context_line":"        return self._cert[\u0027tbsCertificate\u0027][\u0027serialNumber\u0027]"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_extensions(self):"},{"line_number":204,"context_line":"        if self._cert[\u0027tbsCertificate\u0027][\u0027extensions\u0027] is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_14246bad","line":201,"updated":"2016-02-02 16:11:47.000000000","message":"are these always in the dict?  If not you might want to wrap a try","commit_id":"78c9840b403f58f881aaebccf1e1e2b62cf0e084"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"ce0f3f2805794065e2c6e5322aedb1e661f888a7","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        self._cert[\u0027tbsCertificate\u0027][\u0027serialNumber\u0027] \u003d serial"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_serial_number(self,):"},{"line_number":201,"context_line":"        return self._cert[\u0027tbsCertificate\u0027][\u0027serialNumber\u0027]"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def _get_extensions(self):"},{"line_number":204,"context_line":"        if self._cert[\u0027tbsCertificate\u0027][\u0027extensions\u0027] is None:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_f41c2115","line":201,"in_reply_to":"7a5de9d1_14246bad","updated":"2016-02-02 21:33:24.000000000","message":"It\u0027s a parsed asn1 structure, just looks like a dict. [\u0027serialNumber\u0027] will return None if not set. \u0027tbsCertificate\u0027 is there under normal conditions - if it\u0027s missing that\u0027s exception-worthy.","commit_id":"78c9840b403f58f881aaebccf1e1e2b62cf0e084"}],"anchor/X509/extension.py":[{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"d07adedadbcc557e1393cd5531cafaf23c93f330","unresolved":false,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    @uses_ext_value"},{"line_number":464,"context_line":"    def get_key_id(self, ext_value\u003dNone):"},{"line_number":465,"context_line":"        return ext_value[\u0027keyIdentifier\u0027].asOctets()"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @uses_ext_value"},{"line_number":468,"context_line":"    def get_serial(self, ext_value\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_f4f18f02","line":465,"updated":"2016-02-02 16:11:47.000000000","message":"do we need to wrap try\u0027s here?","commit_id":"78c9840b403f58f881aaebccf1e1e2b62cf0e084"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"ce0f3f2805794065e2c6e5322aedb1e661f888a7","unresolved":false,"context_lines":[{"line_number":462,"context_line":""},{"line_number":463,"context_line":"    @uses_ext_value"},{"line_number":464,"context_line":"    def get_key_id(self, ext_value\u003dNone):"},{"line_number":465,"context_line":"        return ext_value[\u0027keyIdentifier\u0027].asOctets()"},{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @uses_ext_value"},{"line_number":468,"context_line":"    def get_serial(self, ext_value\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_b4ed49f1","line":465,"in_reply_to":"7a5de9d1_f4f18f02","updated":"2016-02-02 21:33:24.000000000","message":"Yes actually, we do.","commit_id":"78c9840b403f58f881aaebccf1e1e2b62cf0e084"},{"author":{"_account_id":11861,"name":"Travis McPeak","email":"tmcpeak@us.ibm.com","username":"travis-mcpeak"},"change_message_id":"d07adedadbcc557e1393cd5531cafaf23c93f330","unresolved":false,"context_lines":[{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @uses_ext_value"},{"line_number":468,"context_line":"    def get_serial(self, ext_value\u003dNone):"},{"line_number":469,"context_line":"        return ext_value[\u0027authorityCertSerialNumber\u0027]"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    @modifies_ext_value"},{"line_number":472,"context_line":"    def set_key_id(self, key, ext_value\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_b4dc7775","line":469,"updated":"2016-02-02 16:11:47.000000000","message":"try?","commit_id":"78c9840b403f58f881aaebccf1e1e2b62cf0e084"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"ce0f3f2805794065e2c6e5322aedb1e661f888a7","unresolved":false,"context_lines":[{"line_number":466,"context_line":""},{"line_number":467,"context_line":"    @uses_ext_value"},{"line_number":468,"context_line":"    def get_serial(self, ext_value\u003dNone):"},{"line_number":469,"context_line":"        return ext_value[\u0027authorityCertSerialNumber\u0027]"},{"line_number":470,"context_line":""},{"line_number":471,"context_line":"    @modifies_ext_value"},{"line_number":472,"context_line":"    def set_key_id(self, key, ext_value\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a5de9d1_94c7ed63","line":469,"in_reply_to":"7a5de9d1_b4dc7775","updated":"2016-02-02 21:33:24.000000000","message":"pyasn1 thing - it will return None if needed.","commit_id":"78c9840b403f58f881aaebccf1e1e2b62cf0e084"}]}
