)]}'
{"anchor/validators/standards.py":[{"author":{"_account_id":11716,"name":"Tim Kelsey","email":"timothy.kelsey@uk.ibm.com","username":"tkelsey"},"change_message_id":"6d18e460f7daa71b6a30f7e3b9570177e9ea0df3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"def _csr_signature(csr):"},{"line_number":88,"context_line":"    \"\"\"Ensure that the CSR has a valid self-signature.\"\"\""},{"line_number":89,"context_line":"    try:"},{"line_number":90,"context_line":"        if not csr.verify():"},{"line_number":91,"context_line":"            raise errors.ValidationError(\"Signature on the CSR is not valid\")"},{"line_number":92,"context_line":"    except x509_errors.X509Error:"},{"line_number":93,"context_line":"        raise errors.ValidationError(\"Signature on the CSR is not valid\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_7a662f52","line":90,"updated":"2016-02-08 09:21:30.000000000","message":"perhaps csr.verify should raise the Validation error directly, instead of returning false? or is is used as a query somewhere?","commit_id":"7c625fefc9125b702ba7eeaa885ae3e812078464"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"607516d7325e8a6233626990acca051f8929aec9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"def _csr_signature(csr):"},{"line_number":88,"context_line":"    \"\"\"Ensure that the CSR has a valid self-signature.\"\"\""},{"line_number":89,"context_line":"    try:"},{"line_number":90,"context_line":"        if not csr.verify():"},{"line_number":91,"context_line":"            raise errors.ValidationError(\"Signature on the CSR is not valid\")"},{"line_number":92,"context_line":"    except x509_errors.X509Error:"},{"line_number":93,"context_line":"        raise errors.ValidationError(\"Signature on the CSR is not valid\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_cb24af61","line":90,"in_reply_to":"5a5ae5dd_7a662f52","updated":"2016-02-23 04:57:14.000000000","message":"It\u0027s not, but I think these are completely separate ideas. Both CSR and certificate can have the signature verified, but they don\u0027t even know validators exist. It\u0027s kind of like hash comparison should return a bool rather than throw AuthorizationError.","commit_id":"7c625fefc9125b702ba7eeaa885ae3e812078464"}]}
