)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"61a1691dc8b364b6537fca60e21dfbb637175b01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ec1fbb84_c718166d","updated":"2021-12-20 13:36:13.000000000","message":"recheck","commit_id":"b80300b494f24d5e147eb7ec0607d965f207ce64"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f49705421e2d0c28d7a2aad2c3ceb379e94e5a59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ec2e6a99_3deb6c8a","updated":"2022-03-23 15:56:39.000000000","message":"ah, one issue found","commit_id":"529160f9866148433c8593e39f3dde08a5138f0c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3bf49ed07c0f0f0c8b8317a5bfcfef62bc202760","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dfd8b7b7_721caf2b","updated":"2022-03-23 15:49:57.000000000","message":"thanks","commit_id":"529160f9866148433c8593e39f3dde08a5138f0c"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"42183edd38c2e0d93f888ee8c1dcd863e2273eea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2edee3c4_a81310a2","updated":"2022-03-23 15:57:11.000000000","message":"it\u0027s correct now","commit_id":"6c81058e74fe0c8eb313a83dfdb973de7bf7b83b"}],"roles/baremetal/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2d6b51575ea4cb3723d083e6706e50b11fee9238","unresolved":true,"context_lines":[{"line_number":40,"context_line":"create_kolla_user: True"},{"line_number":41,"context_line":"create_kolla_user_sudoers: \"{{ create_kolla_user }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"kolla_user: \"kolla\""},{"line_number":44,"context_line":"kolla_group: \"kolla\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"change_selinux: True"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"34ca85f6_da66d313","side":"PARENT","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":20},"updated":"2022-03-16 15:26:10.000000000","message":"remove after moving all the other tasks to the new role","commit_id":"60999cb37fcfbed65fa3e214944bec07a10b13cb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39c673f2e2d56b0b03fe24598cecc0563cc69222","unresolved":true,"context_lines":[{"line_number":40,"context_line":"create_kolla_user: True"},{"line_number":41,"context_line":"create_kolla_user_sudoers: \"{{ create_kolla_user }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"kolla_user: \"kolla\""},{"line_number":44,"context_line":"kolla_group: \"kolla\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"change_selinux: True"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3e983917_cc973a6f","side":"PARENT","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":20},"in_reply_to":"34ca85f6_da66d313","updated":"2022-03-18 14:14:52.000000000","message":"Still referenced by docker_sdk and node_config_directory stuff.","commit_id":"60999cb37fcfbed65fa3e214944bec07a10b13cb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3bf49ed07c0f0f0c8b8317a5bfcfef62bc202760","unresolved":false,"context_lines":[{"line_number":40,"context_line":"create_kolla_user: True"},{"line_number":41,"context_line":"create_kolla_user_sudoers: \"{{ create_kolla_user }}\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"kolla_user: \"kolla\""},{"line_number":44,"context_line":"kolla_group: \"kolla\""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"change_selinux: True"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"b55ac7da_edb4ff3b","side":"PARENT","line":44,"range":{"start_line":43,"start_character":0,"end_line":44,"end_character":20},"in_reply_to":"3e983917_cc973a6f","updated":"2022-03-23 15:49:57.000000000","message":"Ack.","commit_id":"60999cb37fcfbed65fa3e214944bec07a10b13cb"}],"roles/baremetal/tasks/post-install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2d6b51575ea4cb3723d083e6706e50b11fee9238","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    owner: \"{{ kolla_user }}\""},{"line_number":45,"context_line":"    group: \"{{ kolla_group }}\""},{"line_number":46,"context_line":"    mode: 0755"},{"line_number":47,"context_line":"  become: True"},{"line_number":48,"context_line":"  when: create_kolla_user | bool"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Ensure node_config_directory directory exists"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8fe0e9df_ae5055ae","side":"PARENT","line":47,"updated":"2022-03-16 15:26:10.000000000","message":"this should not be doneby default; not all users rely on the kolla_user to exist, please move all kolla-user-related stuff to the new role","commit_id":"60999cb37fcfbed65fa3e214944bec07a10b13cb"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39c673f2e2d56b0b03fe24598cecc0563cc69222","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    owner: \"{{ kolla_user }}\""},{"line_number":45,"context_line":"    group: \"{{ kolla_group }}\""},{"line_number":46,"context_line":"    mode: 0755"},{"line_number":47,"context_line":"  become: True"},{"line_number":48,"context_line":"  when: create_kolla_user | bool"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Ensure node_config_directory directory exists"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"af0c0ed8_8f606a32","side":"PARENT","line":47,"in_reply_to":"8fe0e9df_ae5055ae","updated":"2022-03-18 14:14:52.000000000","message":"I\u0027m not sure I agree that anything referencing kolla_user belongs in the new role - it\u0027s a role to create the user account and related bits.\n\nI\u0027ve made the owner and group dependent on create_kolla_user.","commit_id":"60999cb37fcfbed65fa3e214944bec07a10b13cb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"3bf49ed07c0f0f0c8b8317a5bfcfef62bc202760","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    owner: \"{{ kolla_user }}\""},{"line_number":45,"context_line":"    group: \"{{ kolla_group }}\""},{"line_number":46,"context_line":"    mode: 0755"},{"line_number":47,"context_line":"  become: True"},{"line_number":48,"context_line":"  when: create_kolla_user | bool"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- name: Ensure node_config_directory directory exists"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"45e323c3_339e2c5d","side":"PARENT","line":47,"in_reply_to":"af0c0ed8_8f606a32","updated":"2022-03-23 15:49:57.000000000","message":"Agreed. I accept the fix.","commit_id":"60999cb37fcfbed65fa3e214944bec07a10b13cb"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2d6b51575ea4cb3723d083e6706e50b11fee9238","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_role:"},{"line_number":3,"context_line":"    name: openstack.kolla.kolla_user"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Ensure virtualenv has correct ownership"},{"line_number":6,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"41a9a276_643cd68a","line":3,"updated":"2022-03-16 15:26:10.000000000","message":"could use a when here...","commit_id":"bb6adaeb615e80a48d4306ba9c17be916cfb89e6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39c673f2e2d56b0b03fe24598cecc0563cc69222","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- import_role:"},{"line_number":3,"context_line":"    name: openstack.kolla.kolla_user"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"- name: Ensure virtualenv has correct ownership"},{"line_number":6,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ebdd3ce1_9326ee39","line":3,"in_reply_to":"41a9a276_643cd68a","updated":"2022-03-18 14:14:52.000000000","message":"Done","commit_id":"bb6adaeb615e80a48d4306ba9c17be916cfb89e6"}],"roles/kolla_user/tasks/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"2d6b51575ea4cb3723d083e6706e50b11fee9238","unresolved":true,"context_lines":[{"line_number":10,"context_line":"    name: \"{{ kolla_group }}\""},{"line_number":11,"context_line":"    state: present"},{"line_number":12,"context_line":"  become: True"},{"line_number":13,"context_line":"  when: create_kolla_user | bool"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Create kolla user"},{"line_number":16,"context_line":"  user:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"816322a2_be968810","line":13,"updated":"2022-03-16 15:26:10.000000000","message":"... rather than whens here","commit_id":"bb6adaeb615e80a48d4306ba9c17be916cfb89e6"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"39c673f2e2d56b0b03fe24598cecc0563cc69222","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    name: \"{{ kolla_group }}\""},{"line_number":11,"context_line":"    state: present"},{"line_number":12,"context_line":"  become: True"},{"line_number":13,"context_line":"  when: create_kolla_user | bool"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Create kolla user"},{"line_number":16,"context_line":"  user:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9132b8d8_defa4591","line":13,"in_reply_to":"816322a2_be968810","updated":"2022-03-18 14:14:52.000000000","message":"Done","commit_id":"bb6adaeb615e80a48d4306ba9c17be916cfb89e6"}]}