)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"f4b871d1b6aa3396a2862200e9acbdd5fa0f49fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ea59904d_0ff4524c","updated":"2022-04-21 12:54:41.000000000","message":"other distros\u0027 testing in https://review.opendev.org/c/openstack/ansible-collection-kolla/+/838864","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fd58a2fd379d33e2b084ceb889e2faf77067fa65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7b2c3685_09e512bd","updated":"2022-05-06 13:47:00.000000000","message":"recheck","commit_id":"e8be2e8b4a31e4c5bec2b01cef875be91f85a11d"}],"roles/baremetal/tasks/install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dee455967e6710c1151ca209c9c5d2530671afa0","unresolved":true,"context_lines":[{"line_number":61,"context_line":"  when:"},{"line_number":62,"context_line":"    - ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":63,"context_line":"    - ansible_facts.distribution !\u003d \u0027openEuler\u0027"},{"line_number":64,"context_line":"  register: rpm_install_result"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- name: Install RPM packages for openEuler"},{"line_number":67,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"8ea2dd2d_18fa013c","line":64,"updated":"2022-04-21 12:30:50.000000000","message":"why keep this one?","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d72277b6c3ed17bd22e7f7b91e600d1887c19d6a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  when:"},{"line_number":62,"context_line":"    - ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":63,"context_line":"    - ansible_facts.distribution !\u003d \u0027openEuler\u0027"},{"line_number":64,"context_line":"  register: rpm_install_result"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"- name: Install RPM packages for openEuler"},{"line_number":67,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fb7bf3dd_a74bfb75","line":64,"in_reply_to":"8ea2dd2d_18fa013c","updated":"2022-05-03 11:22:54.000000000","message":"Done","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dee455967e6710c1151ca209c9c5d2530671afa0","unresolved":true,"context_lines":[{"line_number":70,"context_line":"    update_cache: yes"},{"line_number":71,"context_line":"  become: True"},{"line_number":72,"context_line":"  when: ansible_facts.distribution \u003d\u003d \u0027openEuler\u0027"},{"line_number":73,"context_line":"  register: rpm_install_result"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- import_role:"},{"line_number":76,"context_line":"    name: openstack.kolla.docker"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"21d2b8a9_41867391","line":73,"updated":"2022-04-21 12:30:50.000000000","message":"why keep this one?","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d72277b6c3ed17bd22e7f7b91e600d1887c19d6a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    update_cache: yes"},{"line_number":71,"context_line":"  become: True"},{"line_number":72,"context_line":"  when: ansible_facts.distribution \u003d\u003d \u0027openEuler\u0027"},{"line_number":73,"context_line":"  register: rpm_install_result"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- import_role:"},{"line_number":76,"context_line":"    name: openstack.kolla.docker"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ee1a554f_a46fe95c","line":73,"in_reply_to":"21d2b8a9_41867391","updated":"2022-05-03 11:22:54.000000000","message":"Done","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"}],"roles/baremetal/tasks/post-install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dee455967e6710c1151ca209c9c5d2530671afa0","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    - docker_configure_for_zun | bool"},{"line_number":29,"context_line":"    - \"\u0027zun-compute\u0027 in group_names\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Warn about deprecations"},{"line_number":32,"context_line":"  debug:"},{"line_number":33,"context_line":"    msg: \u003e"},{"line_number":34,"context_line":"      docker_custom_option is deprecated in favor of docker_custom_config"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bd79ac0a_e43967bc","side":"PARENT","line":31,"updated":"2022-04-21 12:30:50.000000000","message":"this warning is lost - I guess we should simply remove this var by now","commit_id":"07b42a9c85a9a8e5b56307717d680185a819dfa9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d72277b6c3ed17bd22e7f7b91e600d1887c19d6a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    - docker_configure_for_zun | bool"},{"line_number":29,"context_line":"    - \"\u0027zun-compute\u0027 in group_names\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Warn about deprecations"},{"line_number":32,"context_line":"  debug:"},{"line_number":33,"context_line":"    msg: \u003e"},{"line_number":34,"context_line":"      docker_custom_option is deprecated in favor of docker_custom_config"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fafafb84_f9b3bbfb","side":"PARENT","line":31,"in_reply_to":"bd79ac0a_e43967bc","updated":"2022-05-03 11:22:54.000000000","message":"Agreed. I\u0027ll remove it.","commit_id":"07b42a9c85a9a8e5b56307717d680185a819dfa9"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dee455967e6710c1151ca209c9c5d2530671afa0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027data-root\u0027: docker_runtime_directory}) }}\""},{"line_number":52,"context_line":"  when: docker_runtime_directory | length \u003e 0"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: Warn about docker default iptables"},{"line_number":55,"context_line":"  debug:"},{"line_number":56,"context_line":"    msg: \u003e-"},{"line_number":57,"context_line":"      Docker default iptables rules will be disabled by default from the Wallaby 12.0.0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e1cbb1df_ad32ffa9","side":"PARENT","line":54,"updated":"2022-04-21 12:30:50.000000000","message":"the following warnings are lost too but I guess it\u0027s ok here","commit_id":"07b42a9c85a9a8e5b56307717d680185a819dfa9"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d72277b6c3ed17bd22e7f7b91e600d1887c19d6a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    docker_config: \"{{ docker_config | combine({\u0027data-root\u0027: docker_runtime_directory}) }}\""},{"line_number":52,"context_line":"  when: docker_runtime_directory | length \u003e 0"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"- name: Warn about docker default iptables"},{"line_number":55,"context_line":"  debug:"},{"line_number":56,"context_line":"    msg: \u003e-"},{"line_number":57,"context_line":"      Docker default iptables rules will be disabled by default from the Wallaby 12.0.0"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4108a216_5457b73d","side":"PARENT","line":54,"in_reply_to":"e1cbb1df_ad32ffa9","updated":"2022-05-03 11:22:54.000000000","message":"Yeah, I think it\u0027s time to move on.","commit_id":"07b42a9c85a9a8e5b56307717d680185a819dfa9"}],"roles/docker/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dee455967e6710c1151ca209c9c5d2530671afa0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Apt cache TTL in seconds."},{"line_number":3,"context_line":"apt_cache_valid_time: 3600"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Whether to enable a package repository for Docker."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"faec751a_db1fb983","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":6},"updated":"2022-04-21 12:30:50.000000000","message":"nit: APT","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d72277b6c3ed17bd22e7f7b91e600d1887c19d6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Apt cache TTL in seconds."},{"line_number":3,"context_line":"apt_cache_valid_time: 3600"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Whether to enable a package repository for Docker."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"6cdee258_67c2cbe6","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":6},"in_reply_to":"faec751a_db1fb983","updated":"2022-05-03 11:22:54.000000000","message":"Done","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dee455967e6710c1151ca209c9c5d2530671afa0","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# List of packages to install."},{"line_number":23,"context_line":"docker_packages:"},{"line_number":24,"context_line":"  - \"{{ docker_apt_package if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else docker_yum_package }}\""},{"line_number":25,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"docker_storage_driver: \"\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"88cd2c1d_b8fa76b4","line":24,"updated":"2022-04-21 12:30:50.000000000","message":"need to keep support for openEuler","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fd58a2fd379d33e2b084ceb889e2faf77067fa65","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# List of packages to install."},{"line_number":23,"context_line":"docker_packages:"},{"line_number":24,"context_line":"  - \"{{ docker_apt_package if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else docker_yum_package }}\""},{"line_number":25,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"docker_storage_driver: \"\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"e0369083_e902625e","line":24,"in_reply_to":"2e7ee25c_b4b98f08","updated":"2022-05-06 13:47:00.000000000","message":"/me blind","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d72277b6c3ed17bd22e7f7b91e600d1887c19d6a","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# List of packages to install."},{"line_number":23,"context_line":"docker_packages:"},{"line_number":24,"context_line":"  - \"{{ docker_apt_package if ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 else docker_yum_package }}\""},{"line_number":25,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"docker_storage_driver: \"\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2e7ee25c_b4b98f08","line":24,"in_reply_to":"88cd2c1d_b8fa76b4","updated":"2022-05-03 11:22:54.000000000","message":"See L20","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dee455967e6710c1151ca209c9c5d2530671afa0","unresolved":true,"context_lines":[{"line_number":32,"context_line":"docker_https_proxy: \"\""},{"line_number":33,"context_line":"docker_no_proxy: \"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# From group_vars/all.yml:"},{"line_number":36,"context_line":"docker_log_max_file: \"5\""},{"line_number":37,"context_line":"docker_log_max_size: \"50m\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2fac7e1b_240de1ef","line":35,"updated":"2022-04-21 12:30:50.000000000","message":"we could drop this comment as more vars moved from there now","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d72277b6c3ed17bd22e7f7b91e600d1887c19d6a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"docker_https_proxy: \"\""},{"line_number":33,"context_line":"docker_no_proxy: \"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# From group_vars/all.yml:"},{"line_number":36,"context_line":"docker_log_max_file: \"5\""},{"line_number":37,"context_line":"docker_log_max_size: \"50m\""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"487acffb_20fec915","line":35,"in_reply_to":"2fac7e1b_240de1ef","updated":"2022-05-03 11:22:54.000000000","message":"Done","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"}],"roles/docker/vars/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"dee455967e6710c1151ca209c9c5d2530671afa0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_config:"},{"line_number":3,"context_line":"  log-opts:"},{"line_number":4,"context_line":"    max-file: \"{{ docker_log_max_file }}\""},{"line_number":5,"context_line":"    max-size: \"{{ docker_log_max_size }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fd5fc5c6_18e30431","line":2,"updated":"2022-04-21 12:30:50.000000000","message":"this should then be removed from baremetal/vars","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"},{"author":{"_account_id":14826,"name":"Mark Goddard","email":"markgoddard86@gmail.com","username":"mgoddard"},"change_message_id":"d72277b6c3ed17bd22e7f7b91e600d1887c19d6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"docker_config:"},{"line_number":3,"context_line":"  log-opts:"},{"line_number":4,"context_line":"    max-file: \"{{ docker_log_max_file }}\""},{"line_number":5,"context_line":"    max-size: \"{{ docker_log_max_size }}\""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f70c8aa1_958a0cfe","line":2,"in_reply_to":"fd5fc5c6_18e30431","updated":"2022-05-03 11:22:54.000000000","message":"Done","commit_id":"4e9e85ed8dcce75d3e9482849b672691fd386605"}]}