)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"fca3120a0cf7b16d68c0e90a826687b566b11e45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0eff27c0_22337395","updated":"2022-02-22 10:44:24.000000000","message":"Mark this Patch WIP until https://review.opendev.org/c/openstack/kolla-ansible/+/830115 ready for review","commit_id":"0dfd2c280ec04f2dbdbfe78df929ae4a33a471ac"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a350ae905aae9cbd7e4102c6a020d5f636ba65f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"23359ce9_522a6095","updated":"2022-03-21 10:33:02.000000000","message":"thanks","commit_id":"609de4722e2846bc72856858a9b4d1661e5ebe56"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c0cd702ad766b8c20b6f2650617223719ad1dd9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"affc2be2_e70ba711","updated":"2022-03-30 06:22:31.000000000","message":"CI works now. Need a finial +A 😊","commit_id":"c90cf14b6ae1d9fa40e6e1d73e3c22de83e1c42d"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"34140d232c71c5a58da18a0f4e7fc16c8ccdfb5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"20b46a32_f3e06ccd","updated":"2022-03-28 10:51:00.000000000","message":"for the CI to pass, we need to merge https://review.opendev.org/c/openstack/kayobe/+/835093","commit_id":"c90cf14b6ae1d9fa40e6e1d73e3c22de83e1c42d"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"bd558958c9265a9f011f6cc152ec231bf684ddc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0e14fd0e_279ca46a","updated":"2022-03-30 01:30:50.000000000","message":"recheck","commit_id":"c90cf14b6ae1d9fa40e6e1d73e3c22de83e1c42d"}],"roles/baremetal/defaults/main.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"a6a6a87d59dfb9694cb91d649867b8589ddd0362","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Whether to enable a package repository for Docker."},{"line_number":3,"context_line":"enable_docker_repo: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Docker APT repository configuration."},{"line_number":6,"context_line":"docker_apt_url: \"https://download.docker.com/linux/{{ ansible_facts.distribution | lower }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4cba7e56_36f8bde6","line":3,"updated":"2022-02-22 08:16:43.000000000","message":"I think then you also want to set this to false for openEuler, no? As the Docker upstream repo is not present.","commit_id":"2144ff48fbf8f5b66cc8a2001bbeb67d6b1b20c7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"0424145c23bc08d16def192a81bbdfde6222c3bd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Whether to enable a package repository for Docker."},{"line_number":3,"context_line":"enable_docker_repo: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Docker APT repository configuration."},{"line_number":6,"context_line":"docker_apt_url: \"https://download.docker.com/linux/{{ ansible_facts.distribution | lower }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"e2dafa4f_4b577dbb","line":3,"in_reply_to":"4cba7e56_36f8bde6","updated":"2022-02-22 10:01:19.000000000","message":"Yeah, I set it here https://review.opendev.org/c/openstack/kolla-ansible/+/830115/17/tests/templates/globals-default.j2\n\nNot sure if the place is correct.","commit_id":"2144ff48fbf8f5b66cc8a2001bbeb67d6b1b20c7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"7bc83b92dea487452592d6476e4357b3cdf56b32","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Whether to enable a package repository for Docker."},{"line_number":3,"context_line":"enable_docker_repo: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Docker APT repository configuration."},{"line_number":6,"context_line":"docker_apt_url: \"https://download.docker.com/linux/{{ ansible_facts.distribution | lower }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dbf52db3_345eebf7","line":3,"in_reply_to":"8b2b9d17_9ae11b0f","updated":"2022-02-23 08:03:03.000000000","message":"Ack, will add it back later","commit_id":"2144ff48fbf8f5b66cc8a2001bbeb67d6b1b20c7"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"b78d3ddf388b995aef94e595517aab1e390c5b52","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Whether to enable a package repository for Docker."},{"line_number":3,"context_line":"enable_docker_repo: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Docker APT repository configuration."},{"line_number":6,"context_line":"docker_apt_url: \"https://download.docker.com/linux/{{ ansible_facts.distribution | lower }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"22bf655e_a7121483","line":3,"in_reply_to":"dbf52db3_345eebf7","updated":"2022-03-01 08:14:35.000000000","message":"Done","commit_id":"2144ff48fbf8f5b66cc8a2001bbeb67d6b1b20c7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"91ad0ca5892b03d93a32c76d5848b57a0daca884","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Whether to enable a package repository for Docker."},{"line_number":3,"context_line":"enable_docker_repo: true"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Docker APT repository configuration."},{"line_number":6,"context_line":"docker_apt_url: \"https://download.docker.com/linux/{{ ansible_facts.distribution | lower }}\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8b2b9d17_9ae11b0f","line":3,"in_reply_to":"e2dafa4f_4b577dbb","updated":"2022-02-22 10:47:07.000000000","message":"I would do it here.","commit_id":"2144ff48fbf8f5b66cc8a2001bbeb67d6b1b20c7"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"14d2f092c485263a7f1f63c32f645868972d4447","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Whether to enable a package repository for Docker."},{"line_number":3,"context_line":"enable_docker_repo: \"{% if ansible_facts.distribution \u003d\u003d \u0027openEuler\u0027 %}False{% else %}true{% endif %}\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Docker APT repository configuration."},{"line_number":6,"context_line":"docker_apt_url: \"https://download.docker.com/linux/{{ ansible_facts.distribution | lower }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bc41ad01_0ca2834f","line":3,"range":{"start_line":3,"start_character":71,"end_line":3,"end_character":76},"updated":"2022-03-19 16:27:45.000000000","message":"false","commit_id":"f4621aca1bf960f6a894ce3294a851b4afbba7ea"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"745c30ffa1db1422526f24ab9a74afe8e9301ade","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Whether to enable a package repository for Docker."},{"line_number":3,"context_line":"enable_docker_repo: \"{% if ansible_facts.distribution \u003d\u003d \u0027openEuler\u0027 %}False{% else %}true{% endif %}\""},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"# Docker APT repository configuration."},{"line_number":6,"context_line":"docker_apt_url: \"https://download.docker.com/linux/{{ ansible_facts.distribution | lower }}\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fc465a3a_fee221ac","line":3,"range":{"start_line":3,"start_character":71,"end_line":3,"end_character":76},"in_reply_to":"bc41ad01_0ca2834f","updated":"2022-03-21 01:21:54.000000000","message":"Done","commit_id":"f4621aca1bf960f6a894ce3294a851b4afbba7ea"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fbe7a75debc5031efe09fb5b3049219225736ef6","unresolved":true,"context_lines":[{"line_number":14,"context_line":"docker_yum_baseurl: \"{{ docker_yum_url }}/$releasever/$basearch/stable\""},{"line_number":15,"context_line":"docker_yum_gpgkey: \"{{ docker_yum_url }}/gpg\""},{"line_number":16,"context_line":"docker_yum_gpgcheck: true"},{"line_number":17,"context_line":"docker_yum_package: \"{% if ansible_facts.distribution \u003d\u003d \u0027openEuler\u0027 %}docker{% else %}docker-ce{% endif %}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ceph_version: \"pacific\""},{"line_number":20,"context_line":"epel_version: \"8\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"8f3ac8aa_579f47c8","line":17,"updated":"2022-03-25 11:11:14.000000000","message":"no need to change it now...","commit_id":"2aae5f7b3d27025e4576c4b47e0cfed32a2ab033"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c2e37dedc993f92206768ab42af0733e71b97052","unresolved":false,"context_lines":[{"line_number":14,"context_line":"docker_yum_baseurl: \"{{ docker_yum_url }}/$releasever/$basearch/stable\""},{"line_number":15,"context_line":"docker_yum_gpgkey: \"{{ docker_yum_url }}/gpg\""},{"line_number":16,"context_line":"docker_yum_gpgcheck: true"},{"line_number":17,"context_line":"docker_yum_package: \"{% if ansible_facts.distribution \u003d\u003d \u0027openEuler\u0027 %}docker{% else %}docker-ce{% endif %}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ceph_version: \"pacific\""},{"line_number":20,"context_line":"epel_version: \"8\""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"d8600d77_612128e9","line":17,"in_reply_to":"8f3ac8aa_579f47c8","updated":"2022-03-26 01:14:11.000000000","message":"Done","commit_id":"2aae5f7b3d27025e4576c4b47e0cfed32a2ab033"},{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fbe7a75debc5031efe09fb5b3049219225736ef6","unresolved":true,"context_lines":[{"line_number":73,"context_line":" - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"openeuler_pkg_install:"},{"line_number":76,"context_line":" - \"{{ docker_yum_package }}\""},{"line_number":77,"context_line":" - python3-docker"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"redhat_pkg_install:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"11bd3c76_6331993e","line":76,"updated":"2022-03-25 11:11:14.000000000","message":"... let\u0027s just set the correct name here","commit_id":"2aae5f7b3d27025e4576c4b47e0cfed32a2ab033"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c2e37dedc993f92206768ab42af0733e71b97052","unresolved":false,"context_lines":[{"line_number":73,"context_line":" - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"openeuler_pkg_install:"},{"line_number":76,"context_line":" - \"{{ docker_yum_package }}\""},{"line_number":77,"context_line":" - python3-docker"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"redhat_pkg_install:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"56a8e6a7_4f1f6ccd","line":76,"in_reply_to":"11bd3c76_6331993e","updated":"2022-03-26 01:14:11.000000000","message":"Done","commit_id":"2aae5f7b3d27025e4576c4b47e0cfed32a2ab033"}],"roles/baremetal/tasks/install.yml":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"fbe7a75debc5031efe09fb5b3049219225736ef6","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    - running_containers.rc \u003d\u003d 0"},{"line_number":134,"context_line":"    - running_containers.stdout !\u003d \u0027\u0027"},{"line_number":135,"context_line":"  vars:"},{"line_number":136,"context_line":"    install_result: \"{{ rpm_install_result if ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027 else apt_install_result }}\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- name: Install latest pip in the virtualenv"},{"line_number":139,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"ca9aadc2_b831175c","line":136,"updated":"2022-03-25 11:11:14.000000000","message":"please modify this var instead","commit_id":"2aae5f7b3d27025e4576c4b47e0cfed32a2ab033"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"c2e37dedc993f92206768ab42af0733e71b97052","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    - running_containers.rc \u003d\u003d 0"},{"line_number":134,"context_line":"    - running_containers.stdout !\u003d \u0027\u0027"},{"line_number":135,"context_line":"  vars:"},{"line_number":136,"context_line":"    install_result: \"{{ rpm_install_result if ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027 else apt_install_result }}\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"- name: Install latest pip in the virtualenv"},{"line_number":139,"context_line":"  pip:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"6e44050e_61e7ded9","line":136,"in_reply_to":"ca9aadc2_b831175c","updated":"2022-03-26 01:14:11.000000000","message":"Done, merged into rpm_install_result since openEuler is also a RPM based OS","commit_id":"2aae5f7b3d27025e4576c4b47e0cfed32a2ab033"}],"roles/baremetal/templates/docker_systemd_service.j2":[{"author":{"_account_id":30491,"name":"Radosław Piliszek","display_name":"Radek","email":"radek@piliszek.it","username":"yoctozepto","status":"self-employed techologist, collaborating mostly with 7bulls.com"},"change_message_id":"91ad0ca5892b03d93a32c76d5848b57a0daca884","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"ExecStart\u003d"},{"line_number":12,"context_line":"# ExecStart commandline copied from \u0027docker-ce\u0027 package. Same on CentOS/Debian/Ubuntu systems."},{"line_number":13,"context_line":"ExecStart\u003d/usr/bin/dockerd -H fd:// --containerd\u003d/run/containerd/containerd.sock{% if docker_custom_option %} {{ docker_custom_option }}{% endif %}{% if docker_configure_for_zun|bool and \u0027zun-compute\u0027 in group_names %} {{ docker_zun_options }}{% endif %}{% if ansible_facts.distribution \u003d\u003d \u0027openEuler\u0027 %}--exec-opt native.umask\u003dnormal{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"9bf1ba13_da8406f7","line":13,"range":{"start_line":13,"start_character":304,"end_line":13,"end_character":305},"updated":"2022-02-22 10:47:07.000000000","message":"add a space; also - is it something openEuler-specific? I don\u0027t see this documented in the upstream docker","commit_id":"0dfd2c280ec04f2dbdbfe78df929ae4a33a471ac"},{"author":{"_account_id":15054,"name":"wangxiyuan","email":"wangxiyuan1007@gmail.com","username":"wangxiyuan"},"change_message_id":"7bc83b92dea487452592d6476e4357b3cdf56b32","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{% endif %}"},{"line_number":11,"context_line":"ExecStart\u003d"},{"line_number":12,"context_line":"# ExecStart commandline copied from \u0027docker-ce\u0027 package. Same on CentOS/Debian/Ubuntu systems."},{"line_number":13,"context_line":"ExecStart\u003d/usr/bin/dockerd -H fd:// --containerd\u003d/run/containerd/containerd.sock{% if docker_custom_option %} {{ docker_custom_option }}{% endif %}{% if docker_configure_for_zun|bool and \u0027zun-compute\u0027 in group_names %} {{ docker_zun_options }}{% endif %}{% if ansible_facts.distribution \u003d\u003d \u0027openEuler\u0027 %}--exec-opt native.umask\u003dnormal{% endif %}"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"e001e8e2_66ff6587","line":13,"range":{"start_line":13,"start_character":304,"end_line":13,"end_character":305},"in_reply_to":"9bf1ba13_da8406f7","updated":"2022-02-23 08:03:03.000000000","message":"the docker security level in openEuler is higher by default. It\u0027s will raise permission error by default:\nhttps://9b51f8e3ee7c689d2c78-7d9ee8e46cfbda0590b7875fc069534a.ssl.cf2.rackcdn.com/830115/18/check/kolla-ansible-openeuler-20.03-lts-sp2-source/57f6515/primary/logs/kolla/nova/nova-compute.txt\n\nset umake to normal can fix it. \n\nI moved the changed here: https://review.opendev.org/c/openstack/kolla-ansible/+/830115/19/tests/templates/globals-default.j2#201\n\nOf cause, I can move the change back to this Patch","commit_id":"0dfd2c280ec04f2dbdbfe78df929ae4a33a471ac"}]}