)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"04a9c7af558a968e2f9a59768d5f769f9d8d19cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a67185de_856f6bbb","updated":"2022-10-24 22:32:20.000000000","message":"Thanks for sticking with this 👍","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"1a15545674f2cc9c3de0adfc22e0b4b538f24676","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7e78c25a_82026b3a","updated":"2022-10-27 10:29:51.000000000","message":"Looking good","commit_id":"419612947d34beb7a3f231e4a0e144c9ccbe0121"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c61d2cfe982e82099fca0eddd59d1a6572e23236","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4efca54e_0eea4db4","updated":"2022-10-27 11:26:20.000000000","message":"roles/podman/ and roles/podman_py/ names mess my head. Can one of them be renamed some way to have more visible split?","commit_id":"9f84de3b74247cde175b3aab83d51fb26f7ec661"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9ea43cf0b03deb0ca66555dcdc85f197441819cc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"01488c24_06d01060","updated":"2023-03-15 12:45:11.000000000","message":"Ok, now we need a CI job that tests this - is it in any of the patches in topic?","commit_id":"4a66ac104855f4223b49f80eb8c2c5c26fa56913"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"bfd1b1eaacbcb0edbed84973c01292aa695ffc03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ac96c1de_e25b16b9","in_reply_to":"01488c24_06d01060","updated":"2023-08-23 15:03:13.000000000","message":"Done.","commit_id":"4a66ac104855f4223b49f80eb8c2c5c26fa56913"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6782bfdc1dd22c13495e0a460ef978d7039bfb14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d3ef4f08_889a7e90","updated":"2023-03-28 10:25:53.000000000","message":"Needs \"Depends-On\" on a patch that has podman related CI jobs.","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"eff8055fb022e06ad6fdb64d5daf6bbfb3a45bf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"615e68fc_7416ed17","updated":"2023-08-25 17:19:33.000000000","message":"Looks good. Just minor nits/suggestions.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b4f156dc38c64951daa0d37abe6693b09bba26f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"e13d4d3b_d3c124ce","updated":"2023-08-25 20:00:46.000000000","message":"please address last comments","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"304316b1983d6c0bd99f24ce15ebadab5c30384c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"56548bb5_53c2cb39","updated":"2023-08-28 19:11:49.000000000","message":"Looks good to me","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f7a5627e1a3b3d2ff5cbf7022e14b025a6bb194b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"baa8bf28_f144a186","updated":"2023-08-29 08:01:17.000000000","message":"Please try to stay consistent with \"true\" vs. \"True\", IMO the former is the preferred variant in yaml?","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"12289455d33f432a0510170ff038f560f2199f69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"56b067a2_ad10607c","updated":"2023-10-09 07:51:28.000000000","message":"I think the current handling of gpg files is to insecure to be used and opens a risk for supply chain attacks.\n\nSee my detailed comment below.\n\nAn idea to at least partially fix this could be to hardcode the current gpg key id, to offer some kind of protection. Notice that you need to use long gpg key ids for that, because short gpg key ids are vulnerable to collision attacks. I don\u0027t know if it is possible to hardcode long key ids, all hard coded key ids I have seen so far in openstack are short key ids.\n\nSee this posting for an overview and further links why short key ids are insecure:\n\nhttps://security.stackexchange.com/q/84280\n\nIdeally the remote server would of course also support https, but I don\u0027t know how easy or hard it would be to fix this on the debian side (probably hard if a server has still not HTTPS in 2023, but I really don\u0027t know).\n\nI don\u0027t know if this fits our standards for \"security\" so I\u0027m not voting -1, for now.\n\nThis is, of course, just my opinion and your mileage may vary. :)","commit_id":"9f89de1f38e1ca0c64d36caa4cdb08a4905c3799"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"590b6879ebf676bda242263359b761b4fd0443a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"0486342b_195cd99d","updated":"2023-10-17 14:52:47.000000000","message":"fwiw I agree with the open comments.\nI think it\u0027s debatable if we want to have tests in ansible-collection-kolla first before merging this, though.\n\nFrom a QA perspective it would be better.","commit_id":"1d399a34f796e2ca5f7a8072ceb2e51535ff2786"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9b41106d893f763240330025b314821cd21efbbf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":33,"id":"283f76e1_80442af7","updated":"2023-10-17 10:45:27.000000000","message":"should we have podman jobs in ansible-collection-kolla as well? now it\u0027s all docker so podman is not tested","commit_id":"1d399a34f796e2ca5f7a8072ceb2e51535ff2786"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"7c078e7ceccc179827ab4e967e1fdd36c095a7d2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":33,"id":"57dc396b_22bdef2b","in_reply_to":"283f76e1_80442af7","updated":"2023-10-17 14:57:24.000000000","message":"after revisiting the code, I think the same.","commit_id":"1d399a34f796e2ca5f7a8072ceb2e51535ff2786"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"81d5ef6cf8aea63255554b20bde7ed1d12a886f6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":33,"id":"687d3788_976daf9f","in_reply_to":"57dc396b_22bdef2b","updated":"2023-10-19 09:52:14.000000000","message":"I agree but I think it would be better to add them after this patch is merged. Right now it would try to test this patch without the main K-A patch and afaik it is not permitted to create a cycle with Depends-On tags.","commit_id":"1d399a34f796e2ca5f7a8072ceb2e51535ff2786"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"2e5c264541f0359a100228548bc12007f39e82ac","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":33,"id":"d11ed4a7_5744183e","in_reply_to":"687d3788_976daf9f","updated":"2023-10-19 11:37:26.000000000","message":"Ack","commit_id":"1d399a34f796e2ca5f7a8072ceb2e51535ff2786"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"7583608de290ebdf1f483dea1e1b973f2d7dbbdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"730e99e5_3e62191e","in_reply_to":"d11ed4a7_5744183e","updated":"2023-10-19 17:52:09.000000000","message":"Done","commit_id":"1d399a34f796e2ca5f7a8072ceb2e51535ff2786"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"92c16e20b68a0fcc04e2ec38bdd128e212f99d25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"0ec297c5_6cf73c84","updated":"2023-10-19 13:49:55.000000000","message":"So what about the remaining open comments?","commit_id":"b218df2b064973789831a540d1d06c3ac2e21f86"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e73d4f8cc8de722762bfbcb6406f3136674f32dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"b1e6d4b6_eaa6f417","updated":"2023-10-19 17:20:42.000000000","message":"Thx, will +2 once tests complete","commit_id":"9961e9051e79db6249ac394d9c890600a159af48"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"485606851aa5c9043c44e0e18a1e29af0abad492","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"f170b5e7_466e49c8","updated":"2023-10-19 17:52:35.000000000","message":"Let\u0027s merge after zuul will verify :)","commit_id":"4ac11fabcf7bb064cbbb21261dedc52d8dc6e952"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"1372233b87353273c87b25f56a6551bdf8c2d536","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"ad3df994_5368954b","updated":"2023-10-19 18:45:55.000000000","message":"let\u0027s merge :)","commit_id":"4ac11fabcf7bb064cbbb21261dedc52d8dc6e952"}],"roles/baremetal/defaults/main.yml":[{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"a024304e556bc2a3b959e25c644241e4cdfc33bd","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"node_config_directory: \"/etc/kolla\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"container_engine: \"{{ kolla_container_engine | default(\u0027docker\u0027)}}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"939463b3_ce177b9f","line":40,"updated":"2022-08-15 09:25:35.000000000","message":"\"{{ kolla_container_engine | default(\u0027docker\u0027) }}\"","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"53056658ff34e1abebaad4265b682d6b61c4e5c6","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"node_config_directory: \"/etc/kolla\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"container_engine: \"{{ kolla_container_engine | default(\u0027docker\u0027)}}\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3b1a9ac3_fb6d03d1","line":40,"in_reply_to":"939463b3_ce177b9f","updated":"2022-08-16 11:58:18.000000000","message":"Done","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"}],"roles/baremetal/tasks/post-install.yml":[{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c61d2cfe982e82099fca0eddd59d1a6572e23236","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- import_role:"},{"line_number":7,"context_line":"    name: openstack.kolla.docker_sdk"},{"line_number":8,"context_line":"  when: container_engine \u003d\u003d \u0027docker\u0027"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- import_role:"},{"line_number":11,"context_line":"    name: openstack.kolla.podman_py"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9d11eed2_6778eddf","line":8,"updated":"2022-10-27 11:26:20.000000000","message":"can\u0027t it be done like in install.yml?","commit_id":"9f84de3b74247cde175b3aab83d51fb26f7ec661"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"7599c2cf5f00801ff6ec5a62655e6bfbe6683119","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"- import_role:"},{"line_number":7,"context_line":"    name: openstack.kolla.docker_sdk"},{"line_number":8,"context_line":"  when: container_engine \u003d\u003d \u0027docker\u0027"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- import_role:"},{"line_number":11,"context_line":"    name: openstack.kolla.podman_py"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"26dd3e43_9679af94","line":8,"in_reply_to":"9d11eed2_6778eddf","updated":"2022-10-28 14:44:08.000000000","message":"Done","commit_id":"9f84de3b74247cde175b3aab83d51fb26f7ec661"}],"roles/docker/tasks/config.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4055a748aff9199402ab094cfaacc3613c943be0","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    state: directory"},{"line_number":95,"context_line":"  become: True"},{"line_number":96,"context_line":"  when:"},{"line_number":97,"context_line":"    - docker_registry is not none"},{"line_number":98,"context_line":"    - docker_registry_ca is not none"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- name: Ensure the CA file for private registry exists"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"43239eed_5b50868e","line":97,"updated":"2023-09-06 13:23:13.000000000","message":"that is unrelated","commit_id":"ef9e7f7ca4ce5a97b506dbd672a3bef1b35fa8b2"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"330f4310ff1d1f6526ee7e7745fec6a1735e7e32","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    state: directory"},{"line_number":95,"context_line":"  become: True"},{"line_number":96,"context_line":"  when:"},{"line_number":97,"context_line":"    - docker_registry is not none"},{"line_number":98,"context_line":"    - docker_registry_ca is not none"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"- name: Ensure the CA file for private registry exists"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"e4828fa5_6d767df8","line":97,"in_reply_to":"43239eed_5b50868e","updated":"2023-09-07 13:08:46.000000000","message":"Done","commit_id":"ef9e7f7ca4ce5a97b506dbd672a3bef1b35fa8b2"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4055a748aff9199402ab094cfaacc3613c943be0","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    mode: 0600"},{"line_number":107,"context_line":"  become: True"},{"line_number":108,"context_line":"  when:"},{"line_number":109,"context_line":"    - docker_registry is not none"},{"line_number":110,"context_line":"    - docker_registry_ca is not none"},{"line_number":111,"context_line":"  notify:"},{"line_number":112,"context_line":"    - Restart docker"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"dd03a528_37410ffa","line":109,"updated":"2023-09-06 13:23:13.000000000","message":"ditto","commit_id":"ef9e7f7ca4ce5a97b506dbd672a3bef1b35fa8b2"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"330f4310ff1d1f6526ee7e7745fec6a1735e7e32","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    mode: 0600"},{"line_number":107,"context_line":"  become: True"},{"line_number":108,"context_line":"  when:"},{"line_number":109,"context_line":"    - docker_registry is not none"},{"line_number":110,"context_line":"    - docker_registry_ca is not none"},{"line_number":111,"context_line":"  notify:"},{"line_number":112,"context_line":"    - Restart docker"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"737c916f_c363bb37","line":109,"in_reply_to":"dd03a528_37410ffa","updated":"2023-09-07 13:08:46.000000000","message":"Done","commit_id":"ef9e7f7ca4ce5a97b506dbd672a3bef1b35fa8b2"}],"roles/docker_sdk/tasks/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f587502153901f1523db075a7cb93b27e44dd0a4","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"abf74c3f_c017897b","line":14,"updated":"2023-08-25 13:52:34.000000000","message":"why?","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e58485467e280492310d26cf4c00ea1f735402f1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"566cc242_20d334e2","line":14,"in_reply_to":"abf74c3f_c017897b","updated":"2023-08-25 13:58:43.000000000","message":"we didn\u0027t set the variable in default/main.yml","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"eff8055fb022e06ad6fdb64d5daf6bbfb3a45bf0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7c9e3b5d_ef660746","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":66},"updated":"2023-08-25 17:19:33.000000000","message":"You could write this as `\"{{ virtualenv | default(omit) }}\"` if the module variable is not defined/required.\n\nhttps://docs.ansible.com/ansible/latest/playbook_guide/playbooks_filters.html#making-variables-optional","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"e49b2d984f1767932ba10984a5bdeff36d16f215","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5bff9692_fd044511","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":66},"in_reply_to":"6cb2ffdc_4beb3471","updated":"2023-10-11 14:37:06.000000000","message":"Reverted podman side to mirror current docker approach.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"287b8c344ccf0e59168c870ad68bb5e271e11873","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"8d51d93c_419b9505","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":66},"in_reply_to":"7c9e3b5d_ef660746","updated":"2023-08-28 10:08:34.000000000","message":"Changed for both Docker and Podman.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"330f4310ff1d1f6526ee7e7745fec6a1735e7e32","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"6cb2ffdc_4beb3471","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":66},"in_reply_to":"89d6f3e7_73683ead","updated":"2023-09-07 13:08:46.000000000","message":"Right. Reverted all changes on the docker side but I will keep this comment open for any future discussions regarding this refactor on our side.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"69b3ba434ab7407a417512efe6d25b81fbf8348e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"cb138768_81179532","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":66},"in_reply_to":"8d51d93c_419b9505","updated":"2023-08-28 11:46:08.000000000","message":"Did not work.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"e040de70_970b7b85","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":66},"in_reply_to":"ae5de85a_fd330855","updated":"2023-08-30 12:54:29.000000000","message":"Okay, changed my parts accordingly. Btw, shouldn\u0027t docker role receive the same treatment?","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"304316b1983d6c0bd99f24ce15ebadab5c30384c","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"ae5de85a_fd330855","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":66},"in_reply_to":"cb138768_81179532","updated":"2023-08-28 19:11:49.000000000","message":"Yeah, it wouldn\u0027t work with an unset default, sorry about the lack of clarification there.\n\nI\u0027ve made a suggested change for docker_sdk here, https://review.opendev.org/c/openstack/ansible-collection-kolla/+/892990","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"4055a748aff9199402ab094cfaacc3613c943be0","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"89d6f3e7_73683ead","line":14,"range":{"start_line":14,"start_character":20,"end_line":14,"end_character":66},"in_reply_to":"e040de70_970b7b85","updated":"2023-09-06 13:23:13.000000000","message":"What is wrong with the docker role now that we are altering it in a Podman patchset? it is unrelated and we shouldn\u0027t touch that role, right?","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"eff8055fb022e06ad6fdb64d5daf6bbfb3a45bf0","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  become_user: \"{{ docker_sdk_virtualenv_owner }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"6c00c743_6d3df5bc","line":15,"range":{"start_line":15,"start_character":34,"end_line":15,"end_character":94},"updated":"2023-08-25 17:19:33.000000000","message":"ditto.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"287b8c344ccf0e59168c870ad68bb5e271e11873","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  become_user: \"{{ docker_sdk_virtualenv_owner }}\""}],"source_content_type":"text/x-yaml","patch_set":20,"id":"13d33eed_860bdfc0","line":15,"range":{"start_line":15,"start_character":34,"end_line":15,"end_character":94},"in_reply_to":"6c00c743_6d3df5bc","updated":"2023-08-28 10:08:34.000000000","message":"Done","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"}],"roles/podman/defaults/main.yml":[{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"a024304e556bc2a3b959e25c644241e4cdfc33bd","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"podman_runtime_directory: \"/run/containers/storage\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Podman can work with docker registries so it can stay this way"},{"line_number":22,"context_line":"# URL of docker registry"},{"line_number":23,"context_line":"docker_registry:"},{"line_number":24,"context_line":"docker_registry_insecure: false"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Path to a CA file for Docker registry"},{"line_number":27,"context_line":"docker_registry_ca:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"71c9853b_c932ac9c","line":27,"range":{"start_line":21,"start_character":0,"end_line":27,"end_character":19},"updated":"2022-08-15 09:25:35.000000000","message":"If both types of registries (Docker and Podman) are supported and both can be used what about to use some general name like just registry, registry_insecure and registry_ca ?","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"b735a402f69bb02e270183b0bc3cc3bb240d880c","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"podman_runtime_directory: \"/run/containers/storage\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Podman can work with docker registries so it can stay this way"},{"line_number":22,"context_line":"# URL of docker registry"},{"line_number":23,"context_line":"docker_registry:"},{"line_number":24,"context_line":"docker_registry_insecure: false"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Path to a CA file for Docker registry"},{"line_number":27,"context_line":"docker_registry_ca:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"f2e4c103_9315ba08","line":27,"range":{"start_line":21,"start_character":0,"end_line":27,"end_character":19},"in_reply_to":"030e08c4_535a4a7d","updated":"2022-11-10 10:12:19.000000000","message":"ok, understand, maybe it can be changed in future together with change in kolla-ansible.","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"c17d54e3a2b0c478bb538e2f098feba8f0b91fae","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"podman_runtime_directory: \"/run/containers/storage\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# Podman can work with docker registries so it can stay this way"},{"line_number":22,"context_line":"# URL of docker registry"},{"line_number":23,"context_line":"docker_registry:"},{"line_number":24,"context_line":"docker_registry_insecure: false"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Path to a CA file for Docker registry"},{"line_number":27,"context_line":"docker_registry_ca:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"030e08c4_535a4a7d","line":27,"range":{"start_line":21,"start_character":0,"end_line":27,"end_character":19},"in_reply_to":"71c9853b_c932ac9c","updated":"2022-10-07 12:52:33.000000000","message":"It takes values from globals from kolla-ansible so it would need to change it there also","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c61d2cfe982e82099fca0eddd59d1a6572e23236","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"podman_storage_driver: \"\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"docker_http_proxy: \"\""},{"line_number":13,"context_line":"docker_https_proxy: \"\""},{"line_number":14,"context_line":"docker_no_proxy: \"\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"docker_log_max_file: \"5\""},{"line_number":17,"context_line":"docker_log_max_size: \"50m\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"podman_runtime_directory: \"/run/containers/storage\""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0503bd87_395e646f","line":17,"range":{"start_line":12,"start_character":0,"end_line":17,"end_character":26},"updated":"2022-10-27 11:26:20.000000000","message":"docker_ not podman_ ?","commit_id":"9f84de3b74247cde175b3aab83d51fb26f7ec661"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"7599c2cf5f00801ff6ec5a62655e6bfbe6683119","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"podman_storage_driver: \"\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"docker_http_proxy: \"\""},{"line_number":13,"context_line":"docker_https_proxy: \"\""},{"line_number":14,"context_line":"docker_no_proxy: \"\""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"docker_log_max_file: \"5\""},{"line_number":17,"context_line":"docker_log_max_size: \"50m\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"podman_runtime_directory: \"/run/containers/storage\""},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"be5a7516_f7c510b8","line":17,"range":{"start_line":12,"start_character":0,"end_line":17,"end_character":26},"in_reply_to":"0503bd87_395e646f","updated":"2022-10-28 14:44:08.000000000","message":"Done","commit_id":"9f84de3b74247cde175b3aab83d51fb26f7ec661"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1cd77eb54a58d4c2be28c79778f2e54ba9c39f70","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"podman_storage_driver: \"\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"podman_runtime_directory: \"/run/containers/storage\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Podman can work with docker registries so it can stay this way"},{"line_number":15,"context_line":"# URL of private registry"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"baf8fe23_4ebb333c","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"updated":"2023-08-29 09:58:20.000000000","message":"this is already the default upstream[0], why do we set it explicitly?\n\n[0]: https://docs.podman.io/en/latest/markdown/podman.1.html#runroot-value","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"podman_storage_driver: \"\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"podman_runtime_directory: \"/run/containers/storage\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Podman can work with docker registries so it can stay this way"},{"line_number":15,"context_line":"# URL of private registry"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"64b6b2c4_af52abaa","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"baf8fe23_4ebb333c","updated":"2023-08-30 12:54:29.000000000","message":"Good point. Removed it, commented out the variables and reworked their task to only trigger when at least one of them is defined.","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f7a5627e1a3b3d2ff5cbf7022e14b025a6bb194b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"private_registry_insecure: false"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Path to a CA file for Docker registry"},{"line_number":20,"context_line":"docker_registry_ca:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"8c5e5780_188f75f1","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":18},"updated":"2023-08-29 08:01:17.000000000","message":"This should be \"private_registry_ca\" then for consistency?","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":false,"context_lines":[{"line_number":17,"context_line":"private_registry_insecure: false"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Path to a CA file for Docker registry"},{"line_number":20,"context_line":"docker_registry_ca:"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"23481ccd_6ef18535","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":18},"in_reply_to":"8c5e5780_188f75f1","updated":"2023-08-30 12:54:29.000000000","message":"Yes. Changed.","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"20c3a92ca42b68617a6718b3c26c18f3275c4e8b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# List of packages to install."},{"line_number":6,"context_line":"podman_packages:"},{"line_number":7,"context_line":"  - \"podman\""},{"line_number":8,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Podman config variables"},{"line_number":11,"context_line":"# podman_storage_driver:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"7ace8402_d0db2e86","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":52},"updated":"2023-10-09 14:52:12.000000000","message":"Can\u0027t find it in role defaults, add it there or it can fail when this is not defined","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0497598de2d2191d87c6f652ead261e30c2876cc","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# List of packages to install."},{"line_number":6,"context_line":"podman_packages:"},{"line_number":7,"context_line":"  - \"podman\""},{"line_number":8,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Podman config variables"},{"line_number":11,"context_line":"# podman_storage_driver:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"d9c60e1c_31d4cf83","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":52},"in_reply_to":"7ace8402_d0db2e86","updated":"2023-10-09 15:00:42.000000000","message":"I don\u0027t know :), i just adopted these podman patches, i will take a look.","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c6389f69affb2e94be0dd7e4266d107f3a01db4","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# List of packages to install."},{"line_number":6,"context_line":"podman_packages:"},{"line_number":7,"context_line":"  - \"podman\""},{"line_number":8,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Podman config variables"},{"line_number":11,"context_line":"# podman_storage_driver:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"dc0980c6_1a49d463","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":52},"in_reply_to":"d9c60e1c_31d4cf83","updated":"2023-10-19 14:57:23.000000000","message":"so set a default or handle the case when this is not set to not install a package.\n\nI\u0027d vouch for the latter, as it can\u0027t be decided to install a package when the variable is not set and I see not reason to introduce new behaviour for this in this changeset.\n\nif it would be desirable to change the default for `docker_disable_default_iptables_rules` it should be done in a separate changeset.","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5fed5003f0b448f21e3e354be4df627ebaea7523","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# List of packages to install."},{"line_number":6,"context_line":"podman_packages:"},{"line_number":7,"context_line":"  - \"podman\""},{"line_number":8,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Podman config variables"},{"line_number":11,"context_line":"# podman_storage_driver:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"8a3c5768_dd4a4691","line":8,"range":{"start_line":8,"start_character":15,"end_line":8,"end_character":52},"in_reply_to":"dc0980c6_1a49d463","updated":"2023-10-19 17:22:10.000000000","message":"Podman doesn\u0027t change iptables, tested locally, don\u0027t need to copy from docker.","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"20c3a92ca42b68617a6718b3c26c18f3275c4e8b","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Podman config variables"},{"line_number":11,"context_line":"# podman_storage_driver:"},{"line_number":12,"context_line":"# podman_runtime_directory:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Podman can work with docker registries so it can stay this way"},{"line_number":15,"context_line":"# URL of private registry"},{"line_number":16,"context_line":"# private_registry:"},{"line_number":17,"context_line":"# private_registry_insecure: false"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Path to a CA file for Docker registry"},{"line_number":20,"context_line":"# private_registry_ca:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"b082d535_4760c909","line":20,"range":{"start_line":11,"start_character":0,"end_line":20,"end_character":22},"updated":"2023-10-09 14:52:12.000000000","message":"why do we need commented out defaults? That should rather go in role docs if we want it like that, but previously we defined that as empty in other kolla related roles and checked for length \u003e 0\nIf we aim for changing the approach - we need it properly documented, role defaults is not documentation.","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"1c81fafafb270e7f2ae31c1883cc599bcc866106","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Podman config variables"},{"line_number":11,"context_line":"# podman_storage_driver:"},{"line_number":12,"context_line":"# podman_runtime_directory:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Podman can work with docker registries so it can stay this way"},{"line_number":15,"context_line":"# URL of private registry"},{"line_number":16,"context_line":"# private_registry:"},{"line_number":17,"context_line":"# private_registry_insecure: false"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Path to a CA file for Docker registry"},{"line_number":20,"context_line":"# private_registry_ca:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"84d8ec8d_56127a16","line":20,"range":{"start_line":11,"start_character":0,"end_line":20,"end_character":22},"in_reply_to":"7d6cb66a_6ee042bb","updated":"2023-10-09 15:08:34.000000000","message":"We don\u0027t, idk anymore what we should do with empty role variables, we asked multiple times and got different answers each time","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"e49b2d984f1767932ba10984a5bdeff36d16f215","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Podman config variables"},{"line_number":11,"context_line":"# podman_storage_driver:"},{"line_number":12,"context_line":"# podman_runtime_directory:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Podman can work with docker registries so it can stay this way"},{"line_number":15,"context_line":"# URL of private registry"},{"line_number":16,"context_line":"# private_registry:"},{"line_number":17,"context_line":"# private_registry_insecure: false"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Path to a CA file for Docker registry"},{"line_number":20,"context_line":"# private_registry_ca:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"9c86a5bf_2fb20c83","line":20,"range":{"start_line":11,"start_character":0,"end_line":20,"end_character":22},"in_reply_to":"84d8ec8d_56127a16","updated":"2023-10-11 14:37:06.000000000","message":"Reverted to uncommented approach.","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0497598de2d2191d87c6f652ead261e30c2876cc","unresolved":true,"context_lines":[{"line_number":8,"context_line":"  - \"{% if not docker_disable_default_iptables_rules | bool %}iptables{% endif %}\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# Podman config variables"},{"line_number":11,"context_line":"# podman_storage_driver:"},{"line_number":12,"context_line":"# podman_runtime_directory:"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Podman can work with docker registries so it can stay this way"},{"line_number":15,"context_line":"# URL of private registry"},{"line_number":16,"context_line":"# private_registry:"},{"line_number":17,"context_line":"# private_registry_insecure: false"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Path to a CA file for Docker registry"},{"line_number":20,"context_line":"# private_registry_ca:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"7d6cb66a_6ee042bb","line":20,"range":{"start_line":11,"start_character":0,"end_line":20,"end_character":22},"in_reply_to":"b082d535_4760c909","updated":"2023-10-09 15:00:42.000000000","message":"I don\u0027t know :), i just adopted these podman patches, i will take a look.","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"}],"roles/podman/handlers/main.yml":[{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"a024304e556bc2a3b959e25c644241e4cdfc33bd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"8f9cc567_d9b4b559","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"updated":"2022-08-15 09:25:35.000000000","message":"do we need this empty file?","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"53056658ff34e1abebaad4265b682d6b61c4e5c6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"082683c4_6d0de0aa","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"in_reply_to":"8f9cc567_d9b4b559","updated":"2022-08-16 11:58:18.000000000","message":"Done","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f587502153901f1523db075a7cb93b27e44dd0a4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ubuntu upgrade System before install"},{"line_number":3,"context_line":"  apt:"},{"line_number":4,"context_line":"    upgrade: yes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"f8b119ad_dd59e5cb","line":2,"updated":"2023-08-25 13:52:34.000000000","message":"I don\u0027t think that\u0027s required.","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a1fe7cf665a2898995bbcda0e6c805ae60dc1a21","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ubuntu upgrade System before install"},{"line_number":3,"context_line":"  apt:"},{"line_number":4,"context_line":"    upgrade: yes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5fd560e2_b5690934","line":2,"in_reply_to":"91542046_e4820df9","updated":"2023-08-25 14:35:18.000000000","message":"Done","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e58485467e280492310d26cf4c00ea1f735402f1","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ubuntu upgrade System before install"},{"line_number":3,"context_line":"  apt:"},{"line_number":4,"context_line":"    upgrade: yes"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"91542046_e4820df9","line":2,"in_reply_to":"f8b119ad_dd59e5cb","updated":"2023-08-25 13:58:43.000000000","message":"agree. update indexes is enough.","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"}],"roles/podman/tasks/config.yml":[{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"a024304e556bc2a3b959e25c644241e4cdfc33bd","unresolved":true,"context_lines":[{"line_number":42,"context_line":"    dest: /etc/containers/storage.conf.d/storage.conf"},{"line_number":43,"context_line":"    mode: 0644"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Ensure the path for CA file for private registry exists"},{"line_number":46,"context_line":"  file:"},{"line_number":47,"context_line":"    path: \"/etc/docker/certs.d/{{ docker_registry }}\""},{"line_number":48,"context_line":"    owner: root"},{"line_number":49,"context_line":"    group: root"},{"line_number":50,"context_line":"    mode: 0700"},{"line_number":51,"context_line":"    state: directory"},{"line_number":52,"context_line":"  become: True"},{"line_number":53,"context_line":"  when: docker_registry is not none and docker_registry_ca is not none"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":56,"context_line":"  copy:"},{"line_number":57,"context_line":"    src: \"{{ docker_registry_ca }}\""},{"line_number":58,"context_line":"    dest: \"/etc/docker/certs.d/{{ docker_registry }}/ca.crt\""},{"line_number":59,"context_line":"    owner: root"},{"line_number":60,"context_line":"    group: root"},{"line_number":61,"context_line":"    mode: 0600"},{"line_number":62,"context_line":"  become: True"},{"line_number":63,"context_line":"  when: docker_registry is not none and docker_registry_ca is not none"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0d5963a3_60948fd0","line":63,"range":{"start_line":45,"start_character":0,"end_line":63,"end_character":70},"updated":"2022-08-15 09:25:35.000000000","message":"this is still quite docker related, but probably both types of registries can be used, so maybe make it more general.","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"1b7b34b4790bd6b38c5548b5c2172e51ab94de3b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    dest: /etc/containers/storage.conf.d/storage.conf"},{"line_number":43,"context_line":"    mode: 0644"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Ensure the path for CA file for private registry exists"},{"line_number":46,"context_line":"  file:"},{"line_number":47,"context_line":"    path: \"/etc/docker/certs.d/{{ docker_registry }}\""},{"line_number":48,"context_line":"    owner: root"},{"line_number":49,"context_line":"    group: root"},{"line_number":50,"context_line":"    mode: 0700"},{"line_number":51,"context_line":"    state: directory"},{"line_number":52,"context_line":"  become: True"},{"line_number":53,"context_line":"  when: docker_registry is not none and docker_registry_ca is not none"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":56,"context_line":"  copy:"},{"line_number":57,"context_line":"    src: \"{{ docker_registry_ca }}\""},{"line_number":58,"context_line":"    dest: \"/etc/docker/certs.d/{{ docker_registry }}/ca.crt\""},{"line_number":59,"context_line":"    owner: root"},{"line_number":60,"context_line":"    group: root"},{"line_number":61,"context_line":"    mode: 0600"},{"line_number":62,"context_line":"  become: True"},{"line_number":63,"context_line":"  when: docker_registry is not none and docker_registry_ca is not none"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"355c7417_dbd946df","line":63,"range":{"start_line":45,"start_character":0,"end_line":63,"end_character":70},"in_reply_to":"0d5963a3_60948fd0","updated":"2023-03-15 12:07:48.000000000","message":"Done","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"04a9c7af558a968e2f9a59768d5f769f9d8d19cc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure podman root config directory exists"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: /etc/containers"},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"  become: True"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure docker config directory exists"},{"line_number":10,"context_line":"  file:"},{"line_number":11,"context_line":"    path: /etc/containers/{{ item }}"},{"line_number":12,"context_line":"    state: directory"},{"line_number":13,"context_line":"  become: True"},{"line_number":14,"context_line":"  with_items:"},{"line_number":15,"context_line":"    - \"containers.conf.d\""},{"line_number":16,"context_line":"    - \"registries.conf.d\""},{"line_number":17,"context_line":"    - \"storage.conf.d\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Write registries config"},{"line_number":20,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8e77fd4d_56068ef4","line":17,"range":{"start_line":2,"start_character":0,"end_line":17,"end_character":22},"updated":"2022-10-24 22:32:20.000000000","message":"Perhaps just one task with items?","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"f4b68c8bd8823105ac53ae185d3433db2ffc8967","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Ensure podman root config directory exists"},{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: /etc/containers"},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"  become: True"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- name: Ensure docker config directory exists"},{"line_number":10,"context_line":"  file:"},{"line_number":11,"context_line":"    path: /etc/containers/{{ item }}"},{"line_number":12,"context_line":"    state: directory"},{"line_number":13,"context_line":"  become: True"},{"line_number":14,"context_line":"  with_items:"},{"line_number":15,"context_line":"    - \"containers.conf.d\""},{"line_number":16,"context_line":"    - \"registries.conf.d\""},{"line_number":17,"context_line":"    - \"storage.conf.d\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- name: Write registries config"},{"line_number":20,"context_line":"  become: True"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8a237814_8d4802c9","line":17,"range":{"start_line":2,"start_character":0,"end_line":17,"end_character":22},"in_reply_to":"8e77fd4d_56068ef4","updated":"2022-10-26 13:46:54.000000000","message":"Done","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"04a9c7af558a968e2f9a59768d5f769f9d8d19cc","unresolved":true,"context_lines":[{"line_number":32,"context_line":"- name: Write registries config"},{"line_number":33,"context_line":"  become: True"},{"line_number":34,"context_line":"  vars:"},{"line_number":35,"context_line":"    podman_config_storage_driver: \"driver \u003d \u0027{{ podman_storage_driver }}\u0027\""},{"line_number":36,"context_line":"    podman_config_runtime_directory: \"runroot \u003d \u0027{{ podman_runtime_directory }}\u0027\""},{"line_number":37,"context_line":"    config: |"},{"line_number":38,"context_line":"         {{ podman_config_storage_driver if podman_storage_driver | length \u003e 0 else \u0027\u0027 }}"},{"line_number":39,"context_line":"         {{ podman_config_runtime_directory if podman_runtime_directory | length \u003e 0 else \u0027\u0027 }}"},{"line_number":40,"context_line":"  copy:"},{"line_number":41,"context_line":"    content: \"{{ config }}\""},{"line_number":42,"context_line":"    dest: /etc/containers/storage.conf.d/storage.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"c4d4e45f_3d8d7a49","line":39,"range":{"start_line":35,"start_character":0,"end_line":39,"end_character":95},"updated":"2022-10-24 22:32:20.000000000","message":"Could this perhaps be written as\n\n config: |\n   {% if podman_storage_driver is defined %}\n   driver \u003d {{ podman_storage_driver }}\n   {% endif %}\n   {% if podman_runtime_directory is defined %}\n   runroot \u003d {{ podman_runtime_directory }}\n   {% endif %}","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"f4b68c8bd8823105ac53ae185d3433db2ffc8967","unresolved":false,"context_lines":[{"line_number":32,"context_line":"- name: Write registries config"},{"line_number":33,"context_line":"  become: True"},{"line_number":34,"context_line":"  vars:"},{"line_number":35,"context_line":"    podman_config_storage_driver: \"driver \u003d \u0027{{ podman_storage_driver }}\u0027\""},{"line_number":36,"context_line":"    podman_config_runtime_directory: \"runroot \u003d \u0027{{ podman_runtime_directory }}\u0027\""},{"line_number":37,"context_line":"    config: |"},{"line_number":38,"context_line":"         {{ podman_config_storage_driver if podman_storage_driver | length \u003e 0 else \u0027\u0027 }}"},{"line_number":39,"context_line":"         {{ podman_config_runtime_directory if podman_runtime_directory | length \u003e 0 else \u0027\u0027 }}"},{"line_number":40,"context_line":"  copy:"},{"line_number":41,"context_line":"    content: \"{{ config }}\""},{"line_number":42,"context_line":"    dest: /etc/containers/storage.conf.d/storage.conf"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"21ca0204_9c516365","line":39,"range":{"start_line":35,"start_character":0,"end_line":39,"end_character":95},"in_reply_to":"c4d4e45f_3d8d7a49","updated":"2022-10-26 13:46:54.000000000","message":"Done","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"1a15545674f2cc9c3de0adfc22e0b4b538f24676","unresolved":true,"context_lines":[{"line_number":25,"context_line":"- name: Write registries config"},{"line_number":26,"context_line":"  become: True"},{"line_number":27,"context_line":"  vars:"},{"line_number":28,"context_line":"    podman_config_storage_driver: \"driver \u003d \u0027{{ podman_storage_driver }}\u0027\""},{"line_number":29,"context_line":"    podman_config_runtime_directory: \"runroot \u003d \u0027{{ podman_runtime_directory }}\u0027\""},{"line_number":30,"context_line":"    config: |"},{"line_number":31,"context_line":"      {% if podman_storage_driver is defined %}"},{"line_number":32,"context_line":"      driver \u003d {{ podman_storage_driver }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"d6efe5b9_88a8ac43","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":81},"updated":"2022-10-27 10:29:51.000000000","message":"With the updated config, doesn\u0027t look like these serve any purpose.","commit_id":"419612947d34beb7a3f231e4a0e144c9ccbe0121"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"6a7de9fc73226cac04c49546b473f432c1f843a4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"- name: Write registries config"},{"line_number":26,"context_line":"  become: True"},{"line_number":27,"context_line":"  vars:"},{"line_number":28,"context_line":"    podman_config_storage_driver: \"driver \u003d \u0027{{ podman_storage_driver }}\u0027\""},{"line_number":29,"context_line":"    podman_config_runtime_directory: \"runroot \u003d \u0027{{ podman_runtime_directory }}\u0027\""},{"line_number":30,"context_line":"    config: |"},{"line_number":31,"context_line":"      {% if podman_storage_driver is defined %}"},{"line_number":32,"context_line":"      driver \u003d {{ podman_storage_driver }}"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"16d3b970_83bc60a6","line":29,"range":{"start_line":28,"start_character":0,"end_line":29,"end_character":81},"in_reply_to":"d6efe5b9_88a8ac43","updated":"2022-10-27 10:59:45.000000000","message":"Done","commit_id":"419612947d34beb7a3f231e4a0e144c9ccbe0121"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c7fce0e374cec43809541442b409b97103cb299","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: /etc/containers/{{ item }}"},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    mode: 0755"},{"line_number":7,"context_line":"  become: True"},{"line_number":8,"context_line":"  with_items:"},{"line_number":9,"context_line":"    - \"containers.conf.d\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5261384d_3dfa3491","line":6,"range":{"start_line":6,"start_character":10,"end_line":6,"end_character":14},"updated":"2023-08-21 15:36:56.000000000","message":"are these wide permissions really needed?","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"bfd1b1eaacbcb0edbed84973c01292aa695ffc03","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: /etc/containers/{{ item }}"},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    mode: 0755"},{"line_number":7,"context_line":"  become: True"},{"line_number":8,"context_line":"  with_items:"},{"line_number":9,"context_line":"    - \"containers.conf.d\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"b89b57ad_1191a674","line":6,"range":{"start_line":6,"start_character":10,"end_line":6,"end_character":14},"in_reply_to":"5261384d_3dfa3491","updated":"2023-08-23 15:03:13.000000000","message":"I checked on Rocky 9 and it seems that Podman sets same permissions out of the box.","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e0c5ffbe61828ce838142508bc376f005e109503","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  file:"},{"line_number":4,"context_line":"    path: /etc/containers/{{ item }}"},{"line_number":5,"context_line":"    state: directory"},{"line_number":6,"context_line":"    mode: 0755"},{"line_number":7,"context_line":"  become: True"},{"line_number":8,"context_line":"  with_items:"},{"line_number":9,"context_line":"    - \"containers.conf.d\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"c58d1859_148168e1","line":6,"range":{"start_line":6,"start_character":10,"end_line":6,"end_character":14},"in_reply_to":"b89b57ad_1191a674","updated":"2023-08-24 09:46:56.000000000","message":"Ack","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"eff8055fb022e06ad6fdb64d5daf6bbfb3a45bf0","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    registry: |"},{"line_number":17,"context_line":"      [[registry]]"},{"line_number":18,"context_line":"      location \u003d \"{{ docker_registry }}\""},{"line_number":19,"context_line":"      insecure \u003d {{ \u0027true\u0027 if docker_registry_insecure | bool else \u0027false\u0027 }}"},{"line_number":20,"context_line":"  copy:"},{"line_number":21,"context_line":"    content: \"{{ registry }}\""},{"line_number":22,"context_line":"    dest: /etc/containers/registries.conf.d/registries.conf"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"a022ae11_067d6c7f","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":74},"updated":"2023-08-25 17:19:33.000000000","message":"`docker_registry_insecure | bool | lower` would look less convoluted.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"287b8c344ccf0e59168c870ad68bb5e271e11873","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    registry: |"},{"line_number":17,"context_line":"      [[registry]]"},{"line_number":18,"context_line":"      location \u003d \"{{ docker_registry }}\""},{"line_number":19,"context_line":"      insecure \u003d {{ \u0027true\u0027 if docker_registry_insecure | bool else \u0027false\u0027 }}"},{"line_number":20,"context_line":"  copy:"},{"line_number":21,"context_line":"    content: \"{{ registry }}\""},{"line_number":22,"context_line":"    dest: /etc/containers/registries.conf.d/registries.conf"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"16825a37_8002f5aa","line":19,"range":{"start_line":19,"start_character":20,"end_line":19,"end_character":74},"in_reply_to":"a022ae11_067d6c7f","updated":"2023-08-28 10:08:34.000000000","message":"Done","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"eff8055fb022e06ad6fdb64d5daf6bbfb3a45bf0","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    mode: 0700"},{"line_number":47,"context_line":"    state: directory"},{"line_number":48,"context_line":"  become: True"},{"line_number":49,"context_line":"  when: private_registry is not none and private_registry_ca is not none"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":52,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"b3948129_78285aec","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":7},"updated":"2023-08-25 17:19:33.000000000","message":"`when:` conditions with `and` can be written as a list; \n```\nwhen:\n  - private_registry is not none\n  - private_registry_ca is not none\n```","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"287b8c344ccf0e59168c870ad68bb5e271e11873","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    mode: 0700"},{"line_number":47,"context_line":"    state: directory"},{"line_number":48,"context_line":"  become: True"},{"line_number":49,"context_line":"  when: private_registry is not none and private_registry_ca is not none"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":52,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"b9bb5719_19b127fc","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":7},"in_reply_to":"115de1a6_0ac701d3","updated":"2023-08-28 10:08:34.000000000","message":"Changed for both Docker and Podman.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"2cf89d72808621d8f3b9206fe216de9fdf8bfd49","unresolved":true,"context_lines":[{"line_number":46,"context_line":"    mode: 0700"},{"line_number":47,"context_line":"    state: directory"},{"line_number":48,"context_line":"  become: True"},{"line_number":49,"context_line":"  when: private_registry is not none and private_registry_ca is not none"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":52,"context_line":"  copy:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"115de1a6_0ac701d3","line":49,"range":{"start_line":49,"start_character":2,"end_line":49,"end_character":7},"in_reply_to":"b3948129_78285aec","updated":"2023-08-28 07:32:03.000000000","message":"copied from docker, will change that","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"eff8055fb022e06ad6fdb64d5daf6bbfb3a45bf0","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    group: root"},{"line_number":57,"context_line":"    mode: 0600"},{"line_number":58,"context_line":"  become: True"},{"line_number":59,"context_line":"  when: docker_registry is not none and docker_registry_ca is not none"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"e70f9bc2_79716311","line":59,"updated":"2023-08-25 17:19:33.000000000","message":"ditto.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"287b8c344ccf0e59168c870ad68bb5e271e11873","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    group: root"},{"line_number":57,"context_line":"    mode: 0600"},{"line_number":58,"context_line":"  become: True"},{"line_number":59,"context_line":"  when: docker_registry is not none and docker_registry_ca is not none"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"acfb4611_e97aaa2f","line":59,"in_reply_to":"a983d8b5_4db53db6","updated":"2023-08-28 10:08:34.000000000","message":"Done","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"2cf89d72808621d8f3b9206fe216de9fdf8bfd49","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    group: root"},{"line_number":57,"context_line":"    mode: 0600"},{"line_number":58,"context_line":"  become: True"},{"line_number":59,"context_line":"  when: docker_registry is not none and docker_registry_ca is not none"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"a983d8b5_4db53db6","line":59,"in_reply_to":"e70f9bc2_79716311","updated":"2023-08-28 07:32:03.000000000","message":"copied from docker, will change that","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f7a5627e1a3b3d2ff5cbf7022e14b025a6bb194b","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    registry: |"},{"line_number":17,"context_line":"      [[registry]]"},{"line_number":18,"context_line":"      location \u003d \"{{ docker_registry }}\""},{"line_number":19,"context_line":"      insecure \u003d {{ docker_registry_insecure | bool | lower }}"},{"line_number":20,"context_line":"  copy:"},{"line_number":21,"context_line":"    content: \"{{ registry }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"4feb0ce4_9b135f33","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":36},"updated":"2023-08-29 08:01:17.000000000","message":"s/docker/private/?","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    registry: |"},{"line_number":17,"context_line":"      [[registry]]"},{"line_number":18,"context_line":"      location \u003d \"{{ docker_registry }}\""},{"line_number":19,"context_line":"      insecure \u003d {{ docker_registry_insecure | bool | lower }}"},{"line_number":20,"context_line":"  copy:"},{"line_number":21,"context_line":"    content: \"{{ registry }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"2208e1c5_e34d6f4c","line":18,"range":{"start_line":18,"start_character":21,"end_line":18,"end_character":36},"in_reply_to":"4feb0ce4_9b135f33","updated":"2023-08-30 12:54:29.000000000","message":"Yes. Changed.","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f7a5627e1a3b3d2ff5cbf7022e14b025a6bb194b","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":54,"context_line":"  copy:"},{"line_number":55,"context_line":"    src: \"{{ docker_registry_ca }}\""},{"line_number":56,"context_line":"    dest: \"/etc/containers/certs.d/{{ docker_registry }}/ca.crt\""},{"line_number":57,"context_line":"    owner: root"},{"line_number":58,"context_line":"    group: root"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"d1309f99_ea1ba06b","line":55,"range":{"start_line":55,"start_character":13,"end_line":55,"end_character":31},"updated":"2023-08-29 08:01:17.000000000","message":"private_registry_ca?","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":54,"context_line":"  copy:"},{"line_number":55,"context_line":"    src: \"{{ docker_registry_ca }}\""},{"line_number":56,"context_line":"    dest: \"/etc/containers/certs.d/{{ docker_registry }}/ca.crt\""},{"line_number":57,"context_line":"    owner: root"},{"line_number":58,"context_line":"    group: root"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"815fc030_1c22503c","line":55,"range":{"start_line":55,"start_character":13,"end_line":55,"end_character":31},"in_reply_to":"d1309f99_ea1ba06b","updated":"2023-08-30 12:54:29.000000000","message":"Done","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f7a5627e1a3b3d2ff5cbf7022e14b025a6bb194b","unresolved":true,"context_lines":[{"line_number":53,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":54,"context_line":"  copy:"},{"line_number":55,"context_line":"    src: \"{{ docker_registry_ca }}\""},{"line_number":56,"context_line":"    dest: \"/etc/containers/certs.d/{{ docker_registry }}/ca.crt\""},{"line_number":57,"context_line":"    owner: root"},{"line_number":58,"context_line":"    group: root"},{"line_number":59,"context_line":"    mode: 0600"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"62bb9b8a_eee7b61d","line":56,"range":{"start_line":56,"start_character":38,"end_line":56,"end_character":53},"updated":"2023-08-29 08:01:17.000000000","message":"private_registry?","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":false,"context_lines":[{"line_number":53,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":54,"context_line":"  copy:"},{"line_number":55,"context_line":"    src: \"{{ docker_registry_ca }}\""},{"line_number":56,"context_line":"    dest: \"/etc/containers/certs.d/{{ docker_registry }}/ca.crt\""},{"line_number":57,"context_line":"    owner: root"},{"line_number":58,"context_line":"    group: root"},{"line_number":59,"context_line":"    mode: 0600"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"4e6e0708_298959fa","line":56,"range":{"start_line":56,"start_character":38,"end_line":56,"end_character":53},"in_reply_to":"62bb9b8a_eee7b61d","updated":"2023-08-30 12:54:29.000000000","message":"Done","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f7a5627e1a3b3d2ff5cbf7022e14b025a6bb194b","unresolved":true,"context_lines":[{"line_number":60,"context_line":"  become: True"},{"line_number":61,"context_line":"  when:"},{"line_number":62,"context_line":"    - docker_registry is not none"},{"line_number":63,"context_line":"    - docker_registry_ca is not none"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"de07c5f7_42a8c043","line":63,"updated":"2023-08-29 08:01:17.000000000","message":"dito","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  become: True"},{"line_number":61,"context_line":"  when:"},{"line_number":62,"context_line":"    - docker_registry is not none"},{"line_number":63,"context_line":"    - docker_registry_ca is not none"}],"source_content_type":"text/x-yaml","patch_set":22,"id":"1f808953_47f4031d","line":63,"in_reply_to":"de07c5f7_42a8c043","updated":"2023-08-30 12:54:29.000000000","message":"Done","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"6178fb891c819fee141e07573d8cec29be865c62","unresolved":true,"context_lines":[{"line_number":16,"context_line":"    registry: |"},{"line_number":17,"context_line":"      [[registry]]"},{"line_number":18,"context_line":"      location \u003d \"{{ private_registry }}\""},{"line_number":19,"context_line":"      insecure \u003d {{ private_registry_insecure | bool | lower }}"},{"line_number":20,"context_line":"  copy:"},{"line_number":21,"context_line":"    content: \"{{ registry }}\""},{"line_number":22,"context_line":"    dest: /etc/containers/registries.conf.d/registries.conf"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"1d7bd2e9_a9e63474","line":19,"range":{"start_line":19,"start_character":55,"end_line":19,"end_character":60},"updated":"2023-09-06 13:24:23.000000000","message":"is this really needed?","commit_id":"ef9e7f7ca4ce5a97b506dbd672a3bef1b35fa8b2"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"330f4310ff1d1f6526ee7e7745fec6a1735e7e32","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    registry: |"},{"line_number":17,"context_line":"      [[registry]]"},{"line_number":18,"context_line":"      location \u003d \"{{ private_registry }}\""},{"line_number":19,"context_line":"      insecure \u003d {{ private_registry_insecure | bool | lower }}"},{"line_number":20,"context_line":"  copy:"},{"line_number":21,"context_line":"    content: \"{{ registry }}\""},{"line_number":22,"context_line":"    dest: /etc/containers/registries.conf.d/registries.conf"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"7c8477f9_f4c91e27","line":19,"range":{"start_line":19,"start_character":55,"end_line":19,"end_character":60},"in_reply_to":"1d7bd2e9_a9e63474","updated":"2023-09-07 13:08:46.000000000","message":"It isn\u0027t.","commit_id":"ef9e7f7ca4ce5a97b506dbd672a3bef1b35fa8b2"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"18c4c71699b6a4b5498b7d5b5eba61575a52e180","unresolved":true,"context_lines":[{"line_number":54,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":55,"context_line":"  copy:"},{"line_number":56,"context_line":"    src: \"{{ private_registry_ca }}\""},{"line_number":57,"context_line":"    dest: \"/etc/containers/certs.d/{{ private_registry }}/ca.crt\""},{"line_number":58,"context_line":"    owner: root"},{"line_number":59,"context_line":"    group: root"},{"line_number":60,"context_line":"    mode: 0600"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"c5788850_e6b46b86","line":57,"range":{"start_line":57,"start_character":12,"end_line":57,"end_character":35},"updated":"2023-10-06 15:32:28.000000000","message":"this will also create the directory `/etc/containers/certs.d` with permissions of `0600` if it doesn\u0027t exist yet.\n\nI\u0027m not sure if it already is present at this point in time in the ansible play.\n\nIt might be worthwhile to add this directory to the task `Ensure podman config directory exists`.\n\nThe permissions for this directory on my system are:\n\n`stat -c \"%a\" /etc/containers/certs.d\n755`\n\nThanks","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e0d5b90198e7004dbf891cb21ae87fae5219f849","unresolved":false,"context_lines":[{"line_number":54,"context_line":"- name: Ensure the CA file for private registry exists"},{"line_number":55,"context_line":"  copy:"},{"line_number":56,"context_line":"    src: \"{{ private_registry_ca }}\""},{"line_number":57,"context_line":"    dest: \"/etc/containers/certs.d/{{ private_registry }}/ca.crt\""},{"line_number":58,"context_line":"    owner: root"},{"line_number":59,"context_line":"    group: root"},{"line_number":60,"context_line":"    mode: 0600"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"026a8b1e_eff9dca7","line":57,"range":{"start_line":57,"start_character":12,"end_line":57,"end_character":35},"in_reply_to":"c5788850_e6b46b86","updated":"2023-10-07 18:39:48.000000000","message":"These install steps are copied from docker role when role installing docker package - so it is OK to do the same for podman, we have to be consistent. Or will we have different setup in docker role and different in podman role ?  Why ?","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"}],"roles/podman/tasks/install.yml":[{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"a024304e556bc2a3b959e25c644241e4cdfc33bd","unresolved":true,"context_lines":[{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if hostvars[inventory_hostname].ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ hostvars[inventory_hostname].ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ hostvars[inventory_hostname].ansible_distribution_version }}\""},{"line_number":18,"context_line":"  command: \u003e"},{"line_number":19,"context_line":"    sh -c \"echo \u0027deb http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/{{ repository }}/ /\u0027 \u003e /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list\" ;"},{"line_number":20,"context_line":"    wget -nv https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key -O- | sudo apt-key add -;"},{"line_number":21,"context_line":"    apt-get update -qq"},{"line_number":22,"context_line":"  when:"},{"line_number":23,"context_line":"    - ansible_os_family \u003d\u003d \u0027Debian\u0027"},{"line_number":24,"context_line":"    - hostvars[inventory_hostname].ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027)  # for Debian it is always true and that\u0027s how we need it"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6f89fcea_35738fc1","line":21,"range":{"start_line":18,"start_character":2,"end_line":21,"end_character":22},"updated":"2022-08-15 09:25:35.000000000","message":"I think paths and hyperlinks in this command will be better to have inside some variables.","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"c17d54e3a2b0c478bb538e2f098feba8f0b91fae","unresolved":false,"context_lines":[{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if hostvars[inventory_hostname].ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ hostvars[inventory_hostname].ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ hostvars[inventory_hostname].ansible_distribution_version }}\""},{"line_number":18,"context_line":"  command: \u003e"},{"line_number":19,"context_line":"    sh -c \"echo \u0027deb http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/{{ repository }}/ /\u0027 \u003e /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list\" ;"},{"line_number":20,"context_line":"    wget -nv https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key -O- | sudo apt-key add -;"},{"line_number":21,"context_line":"    apt-get update -qq"},{"line_number":22,"context_line":"  when:"},{"line_number":23,"context_line":"    - ansible_os_family \u003d\u003d \u0027Debian\u0027"},{"line_number":24,"context_line":"    - hostvars[inventory_hostname].ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027)  # for Debian it is always true and that\u0027s how we need it"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b152a89c_34c87f49","line":21,"range":{"start_line":18,"start_character":2,"end_line":21,"end_character":22},"in_reply_to":"6f89fcea_35738fc1","updated":"2022-10-07 12:52:33.000000000","message":"Done","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"a024304e556bc2a3b959e25c644241e4cdfc33bd","unresolved":true,"context_lines":[{"line_number":46,"context_line":"      delay: 10"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    - name: Ensure containers are running after Podman upgrade"},{"line_number":49,"context_line":"      command: \"podman start {{ running_containers.stdout }}\""},{"line_number":50,"context_line":"      become: true"},{"line_number":51,"context_line":"  when:"},{"line_number":52,"context_line":"    - podman_install_result is changed"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"078bd303_52c4a383","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":28},"updated":"2022-08-15 09:25:35.000000000","message":"Isn\u0027t it possible to use existing podman module for starting containers?","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"53056658ff34e1abebaad4265b682d6b61c4e5c6","unresolved":true,"context_lines":[{"line_number":46,"context_line":"      delay: 10"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    - name: Ensure containers are running after Podman upgrade"},{"line_number":49,"context_line":"      command: \"podman start {{ running_containers.stdout }}\""},{"line_number":50,"context_line":"      become: true"},{"line_number":51,"context_line":"  when:"},{"line_number":52,"context_line":"    - podman_install_result is changed"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"192f3ae5_394935b7","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":28},"in_reply_to":"078bd303_52c4a383","updated":"2022-08-16 11:58:18.000000000","message":"It is but we kept it as it is in docker version","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"b735a402f69bb02e270183b0bc3cc3bb240d880c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      delay: 10"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    - name: Ensure containers are running after Podman upgrade"},{"line_number":49,"context_line":"      command: \"podman start {{ running_containers.stdout }}\""},{"line_number":50,"context_line":"      become: true"},{"line_number":51,"context_line":"  when:"},{"line_number":52,"context_line":"    - podman_install_result is changed"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6e2a2f65_6c622424","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":28},"in_reply_to":"192f3ae5_394935b7","updated":"2022-11-10 10:12:19.000000000","message":"ok, lets keep it same like in case of docker","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"04a9c7af558a968e2f9a59768d5f769f9d8d19cc","unresolved":true,"context_lines":[{"line_number":13,"context_line":"- name: Allow podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if hostvars[inventory_hostname].ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ hostvars[inventory_hostname].ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ hostvars[inventory_hostname].ansible_distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cb05c6a9_cac8d027","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":57},"updated":"2022-10-24 22:32:20.000000000","message":"Isn\u0027t asking for {{ hostvars[inventory_hostname].ansible_distribution }} just the same as asking for {{ ansible_distribution }}?","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"f4b68c8bd8823105ac53ae185d3433db2ffc8967","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- name: Allow podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if hostvars[inventory_hostname].ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ hostvars[inventory_hostname].ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ hostvars[inventory_hostname].ansible_distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"522bcc43_1f3dd5fb","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":57},"in_reply_to":"cb05c6a9_cac8d027","updated":"2022-10-26 13:46:54.000000000","message":"Done","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"04a9c7af558a968e2f9a59768d5f769f9d8d19cc","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if hostvars[inventory_hostname].ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ hostvars[inventory_hostname].ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ hostvars[inventory_hostname].ansible_distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""},{"line_number":20,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2bcf8c31_afc36484","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":67},"updated":"2022-10-24 22:32:20.000000000","message":"Same","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"f4b68c8bd8823105ac53ae185d3433db2ffc8967","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if hostvars[inventory_hostname].ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ hostvars[inventory_hostname].ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ hostvars[inventory_hostname].ansible_distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""},{"line_number":20,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"2e55179f_eba37156","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":67},"in_reply_to":"2bcf8c31_afc36484","updated":"2022-10-26 13:46:54.000000000","message":"Done","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"04a9c7af558a968e2f9a59768d5f769f9d8d19cc","unresolved":true,"context_lines":[{"line_number":35,"context_line":"      when: podman_apt_repo.changed"},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - ansible_os_family \u003d\u003d \u0027Debian\u0027"},{"line_number":38,"context_line":"    - hostvars[inventory_hostname].ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027)  # for Debian it is always true and that\u0027s how we need it"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install packages"},{"line_number":41,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8da7bd3c_b4f1de88","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":35},"updated":"2022-10-24 22:32:20.000000000","message":"Same","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"f4b68c8bd8823105ac53ae185d3433db2ffc8967","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      when: podman_apt_repo.changed"},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - ansible_os_family \u003d\u003d \u0027Debian\u0027"},{"line_number":38,"context_line":"    - hostvars[inventory_hostname].ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027)  # for Debian it is always true and that\u0027s how we need it"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install packages"},{"line_number":41,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"831a3138_050b6873","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":35},"in_reply_to":"8da7bd3c_b4f1de88","updated":"2022-10-26 13:46:54.000000000","message":"Done","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c61d2cfe982e82099fca0eddd59d1a6572e23236","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  changed_when: false"},{"line_number":10,"context_line":"  register: running_containers"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Ubuntu supports podman repo only from 20.10 higher so it needs to be added manually"},{"line_number":13,"context_line":"- name: Allow podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b1326028_168516be","line":12,"updated":"2022-10-27 11:26:20.000000000","message":"From where you take Podman for Debian? Bullseye has 3.0.1 version...","commit_id":"9f84de3b74247cde175b3aab83d51fb26f7ec661"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"1b7b34b4790bd6b38c5548b5c2172e51ab94de3b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  changed_when: false"},{"line_number":10,"context_line":"  register: running_containers"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Ubuntu supports podman repo only from 20.10 higher so it needs to be added manually"},{"line_number":13,"context_line":"- name: Allow podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ffa2ce65_e6fee4c9","line":12,"in_reply_to":"8fa16c57_01b4351f","updated":"2023-03-15 12:07:48.000000000","message":"Done","commit_id":"9f84de3b74247cde175b3aab83d51fb26f7ec661"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"7599c2cf5f00801ff6ec5a62655e6bfbe6683119","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  changed_when: false"},{"line_number":10,"context_line":"  register: running_containers"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Ubuntu supports podman repo only from 20.10 higher so it needs to be added manually"},{"line_number":13,"context_line":"- name: Allow podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"8fa16c57_01b4351f","line":12,"in_reply_to":"b1326028_168516be","updated":"2022-10-28 14:44:08.000000000","message":"yea, realized that, in ubuntu it\u0027s present after 20.10 and debian supports it from 11, should be fixed now","commit_id":"9f84de3b74247cde175b3aab83d51fb26f7ec661"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"33315041ab0b8bede4fb81cba7f4a3441ffb7bbb","unresolved":true,"context_lines":[{"line_number":10,"context_line":"  register: running_containers"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Ubuntu supports podman repo only from 20.10 higher so it needs to be added manually"},{"line_number":13,"context_line":"- name: Allow podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_distribution }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"3746999e_248060f5","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":13},"updated":"2023-03-15 10:35:15.000000000","message":"nit: Add?","commit_id":"9c99c2b52f6102260e043d7e6c948ca06c22bc69"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"1b7b34b4790bd6b38c5548b5c2172e51ab94de3b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  register: running_containers"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Ubuntu supports podman repo only from 20.10 higher so it needs to be added manually"},{"line_number":13,"context_line":"- name: Allow podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_distribution }}\""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"5b8443a6_10b17bfd","line":13,"range":{"start_line":13,"start_character":8,"end_line":13,"end_character":13},"in_reply_to":"3746999e_248060f5","updated":"2023-03-15 12:07:48.000000000","message":"Done","commit_id":"9c99c2b52f6102260e043d7e6c948ca06c22bc69"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ec69ddc61c60c0dd06b9c6b44dd0c5638fec1b7","unresolved":true,"context_lines":[{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"0f026480_bf6af9ec","line":16,"range":{"start_line":16,"start_character":75,"end_line":16,"end_character":95},"updated":"2023-03-28 16:06:15.000000000","message":"ditto","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ec69ddc61c60c0dd06b9c6b44dd0c5638fec1b7","unresolved":true,"context_lines":[{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"f653135e_6912c332","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":49},"updated":"2023-03-28 16:06:15.000000000","message":"use ansible_facts here","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"67f545d16e8bef847ee82489578da09a52ca4731","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"38f75e22_631180f6","line":16,"range":{"start_line":16,"start_character":75,"end_line":16,"end_character":95},"in_reply_to":"0f026480_bf6af9ec","updated":"2023-03-29 09:13:15.000000000","message":"Done","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"67f545d16e8bef847ee82489578da09a52ca4731","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":14,"id":"207b2a8a_d7282626","line":16,"range":{"start_line":16,"start_character":29,"end_line":16,"end_character":49},"in_reply_to":"f653135e_6912c332","updated":"2023-03-29 09:13:15.000000000","message":"Done","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ec69ddc61c60c0dd06b9c6b44dd0c5638fec1b7","unresolved":true,"context_lines":[{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""},{"line_number":20,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"45769432_26160c01","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":67},"updated":"2023-03-28 16:06:15.000000000","message":"ditto","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"67f545d16e8bef847ee82489578da09a52ca4731","unresolved":false,"context_lines":[{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_distribution }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""},{"line_number":20,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"da1e88f5_7bc86e81","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":67},"in_reply_to":"45769432_26160c01","updated":"2023-03-29 09:13:15.000000000","message":"Done","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ec69ddc61c60c0dd06b9c6b44dd0c5638fec1b7","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        upgrade: yes"},{"line_number":35,"context_line":"      when: podman_apt_repo.changed"},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":38,"context_line":"      ansible_distribution \u003d\u003d \u0027Debian\u0027 and ansible_distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"48679972_2843f6d3","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":26},"updated":"2023-03-28 16:06:15.000000000","message":"ditto","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ec69ddc61c60c0dd06b9c6b44dd0c5638fec1b7","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        upgrade: yes"},{"line_number":35,"context_line":"      when: podman_apt_repo.changed"},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":38,"context_line":"      ansible_distribution \u003d\u003d \u0027Debian\u0027 and ansible_distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"73531e6e_022e714d","line":37,"range":{"start_line":37,"start_character":43,"end_line":37,"end_character":71},"updated":"2023-03-28 16:06:15.000000000","message":"ditto","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"67f545d16e8bef847ee82489578da09a52ca4731","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        upgrade: yes"},{"line_number":35,"context_line":"      when: podman_apt_repo.changed"},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":38,"context_line":"      ansible_distribution \u003d\u003d \u0027Debian\u0027 and ansible_distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"91fad645_2f3c23d5","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":26},"in_reply_to":"48679972_2843f6d3","updated":"2023-03-29 09:13:15.000000000","message":"Done","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"67f545d16e8bef847ee82489578da09a52ca4731","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        upgrade: yes"},{"line_number":35,"context_line":"      when: podman_apt_repo.changed"},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":38,"context_line":"      ansible_distribution \u003d\u003d \u0027Debian\u0027 and ansible_distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install packages"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"01741290_c2e5f397","line":37,"range":{"start_line":37,"start_character":43,"end_line":37,"end_character":71},"in_reply_to":"73531e6e_022e714d","updated":"2023-03-29 09:13:15.000000000","message":"Done","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ec69ddc61c60c0dd06b9c6b44dd0c5638fec1b7","unresolved":true,"context_lines":[{"line_number":35,"context_line":"      when: podman_apt_repo.changed"},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":38,"context_line":"      ansible_distribution \u003d\u003d \u0027Debian\u0027 and ansible_distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install packages"},{"line_number":41,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"70a02611_026049c1","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":26},"updated":"2023-03-28 16:06:15.000000000","message":"ditto","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"1ec69ddc61c60c0dd06b9c6b44dd0c5638fec1b7","unresolved":true,"context_lines":[{"line_number":35,"context_line":"      when: podman_apt_repo.changed"},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":38,"context_line":"      ansible_distribution \u003d\u003d \u0027Debian\u0027 and ansible_distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install packages"},{"line_number":41,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"a328915b_9b72c528","line":38,"range":{"start_line":38,"start_character":43,"end_line":38,"end_character":71},"updated":"2023-03-28 16:06:15.000000000","message":"ditto","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"67f545d16e8bef847ee82489578da09a52ca4731","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      when: podman_apt_repo.changed"},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":38,"context_line":"      ansible_distribution \u003d\u003d \u0027Debian\u0027 and ansible_distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install packages"},{"line_number":41,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"01a91fb3_d4d72a20","line":38,"range":{"start_line":38,"start_character":6,"end_line":38,"end_character":26},"in_reply_to":"70a02611_026049c1","updated":"2023-03-29 09:13:15.000000000","message":"Done","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"67f545d16e8bef847ee82489578da09a52ca4731","unresolved":false,"context_lines":[{"line_number":35,"context_line":"      when: podman_apt_repo.changed"},{"line_number":36,"context_line":"  when:"},{"line_number":37,"context_line":"    - ansible_distribution \u003d\u003d \u0027Ubuntu\u0027 and ansible_distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":38,"context_line":"      ansible_distribution \u003d\u003d \u0027Debian\u0027 and ansible_distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install packages"},{"line_number":41,"context_line":"  package:"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"1d38e6e3_38eb067f","line":38,"range":{"start_line":38,"start_character":43,"end_line":38,"end_character":71},"in_reply_to":"a328915b_9b72c528","updated":"2023-03-29 09:13:15.000000000","message":"Done","commit_id":"7eae4c2fd2580e926bf89bc7ae03e2a0f7f53027"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"57c4aaabe1caa0b2676a61b4a44282a4de94c581","unresolved":true,"context_lines":[{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""},{"line_number":20,"context_line":"  block:"},{"line_number":21,"context_line":"    - name: Ubuntu | Add an Apt signing key used for podman repo"},{"line_number":22,"context_line":"      apt_key:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"42d07c80_bfc423f7","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":119},"updated":"2023-08-25 10:24:03.000000000","message":"can be this moved to the roles vars/main.yml or defaults/main.yml ?","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"bccd1c11b5541877b07f94fba2975070dd16d377","unresolved":true,"context_lines":[{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""},{"line_number":20,"context_line":"  block:"},{"line_number":21,"context_line":"    - name: Ubuntu | Add an Apt signing key used for podman repo"},{"line_number":22,"context_line":"      apt_key:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"de602155_e1a2a739","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":119},"in_reply_to":"42d07c80_bfc423f7","updated":"2023-08-25 10:36:00.000000000","message":"I thought its better to be directly there because that vars are not used anywhere else and everybody can see why we need them during task","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"f45de38536b1ac4891fa9bb641c2d429c32ed095","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""},{"line_number":20,"context_line":"  block:"},{"line_number":21,"context_line":"    - name: Ubuntu | Add an Apt signing key used for podman repo"},{"line_number":22,"context_line":"      apt_key:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"e9cc28d0_95684553","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":119},"in_reply_to":"5691bec4_095d5cf7","updated":"2023-08-25 12:42:57.000000000","message":"All of these were moved to vars/main.yml to better signal they are configurable.","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a1fe7cf665a2898995bbcda0e6c805ae60dc1a21","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""},{"line_number":20,"context_line":"  block:"},{"line_number":21,"context_line":"    - name: Ubuntu | Add an Apt signing key used for podman repo"},{"line_number":22,"context_line":"      apt_key:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"504466ae_1128f1ad","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":119},"in_reply_to":"56d9f885_1cf980e2","updated":"2023-08-25 14:35:18.000000000","message":"Done","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"267aa7adc3fde98457b5e25721c26c1e87f60fcb","unresolved":true,"context_lines":[{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""},{"line_number":20,"context_line":"  block:"},{"line_number":21,"context_line":"    - name: Ubuntu | Add an Apt signing key used for podman repo"},{"line_number":22,"context_line":"      apt_key:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5691bec4_095d5cf7","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":119},"in_reply_to":"de602155_e1a2a739","updated":"2023-08-25 10:49:24.000000000","message":"1. its hard to read this here\n2. this requires access to the Internet, this will breaks in the air-gapped environments.\n\nat least repo_url and key_url should be overridable variables","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ceeba7fc9043fbe3319bf86b665cb8596091d228","unresolved":true,"context_lines":[{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  vars:"},{"line_number":16,"context_line":"    distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":17,"context_line":"    repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":18,"context_line":"    repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }} /\""},{"line_number":19,"context_line":"    key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""},{"line_number":20,"context_line":"  block:"},{"line_number":21,"context_line":"    - name: Ubuntu | Add an Apt signing key used for podman repo"},{"line_number":22,"context_line":"      apt_key:"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"56d9f885_1cf980e2","line":19,"range":{"start_line":16,"start_character":0,"end_line":19,"end_character":119},"in_reply_to":"e9cc28d0_95684553","updated":"2023-08-25 13:45:29.000000000","message":"thanks, but role defaults would be best place imho because of variable precedence: https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_variables.html#understanding-variable-precedence","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"57c4aaabe1caa0b2676a61b4a44282a4de94c581","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      apt_repository:"},{"line_number":28,"context_line":"        repo: \"{{ repo_url }}\""},{"line_number":29,"context_line":"        filename: podman"},{"line_number":30,"context_line":"      notify: Ubuntu upgrade System before install"},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 and ansible_facts.distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":33,"context_line":"      ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 and ansible_facts.distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"49508c93_618c8e12","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":50},"updated":"2023-08-25 10:24:03.000000000","message":"do we really need the handler? I see \u0027update_cache: true\u0027 in the next task","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"ceeba7fc9043fbe3319bf86b665cb8596091d228","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      apt_repository:"},{"line_number":28,"context_line":"        repo: \"{{ repo_url }}\""},{"line_number":29,"context_line":"        filename: podman"},{"line_number":30,"context_line":"      notify: Ubuntu upgrade System before install"},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 and ansible_facts.distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":33,"context_line":"      ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 and ansible_facts.distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"2febce23_5d9bd483","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":50},"in_reply_to":"0493b134_ea8bfc39","updated":"2023-08-25 13:45:29.000000000","message":"but you already set \u0027update_cache: true\u0027 below, so for Debian family when package module use apt module with this option set it executes \u0027apt-get update\u0027 again. remove notify/handler and then check.","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a1fe7cf665a2898995bbcda0e6c805ae60dc1a21","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      apt_repository:"},{"line_number":28,"context_line":"        repo: \"{{ repo_url }}\""},{"line_number":29,"context_line":"        filename: podman"},{"line_number":30,"context_line":"      notify: Ubuntu upgrade System before install"},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 and ansible_facts.distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":33,"context_line":"      ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 and ansible_facts.distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"adf55a27_2c18cc54","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":50},"in_reply_to":"2febce23_5d9bd483","updated":"2023-08-25 14:35:18.000000000","message":"Removed it. Podman should get installed without a problem but other packages won\u0027t get upgraded, unlike on RedHats. Shouldn\u0027t be an issue imo.","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"f45de38536b1ac4891fa9bb641c2d429c32ed095","unresolved":true,"context_lines":[{"line_number":27,"context_line":"      apt_repository:"},{"line_number":28,"context_line":"        repo: \"{{ repo_url }}\""},{"line_number":29,"context_line":"        filename: podman"},{"line_number":30,"context_line":"      notify: Ubuntu upgrade System before install"},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 and ansible_facts.distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":33,"context_line":"      ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 and ansible_facts.distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"0493b134_ea8bfc39","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":50},"in_reply_to":"49508c93_618c8e12","updated":"2023-08-25 12:42:57.000000000","message":"I think the thought behind this was following:\nOn RH family, dnf update also downloads newer packages, so update_cache also does this.\nBut on Debian family, apt update just updates the cache and upgrade is then needed to download them.\n\nBut we probably don\u0027t need to upgrade the packages here since, iirc, users are advised to update/upgrade before starting the deployment.\nSo I want to leave it up to your decision, if we keep it or not.","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"afd39d769f432ddb03a3097bce66adc466ab2758","unresolved":false,"context_lines":[{"line_number":27,"context_line":"      apt_repository:"},{"line_number":28,"context_line":"        repo: \"{{ repo_url }}\""},{"line_number":29,"context_line":"        filename: podman"},{"line_number":30,"context_line":"      notify: Ubuntu upgrade System before install"},{"line_number":31,"context_line":"  when:"},{"line_number":32,"context_line":"    - ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 and ansible_facts.distribution_version is version(\u002720.10\u0027, \u0027\u003c\u0027) or"},{"line_number":33,"context_line":"      ansible_facts.os_family \u003d\u003d \u0027Debian\u0027 and ansible_facts.distribution_version is version(\u002711\u0027, \u0027\u003c\u0027)"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7f8a45f8_4bba9eb8","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":50},"in_reply_to":"adf55a27_2c18cc54","updated":"2023-08-25 15:24:53.000000000","message":"during the installation of podman package the apt manager will solve dependency problems and upgrade any package if needed, so don\u0027t worry.","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f587502153901f1523db075a7cb93b27e44dd0a4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Upgrading podman engine may cause containers to stop. Take a snapshot of the"},{"line_number":3,"context_line":"# running containers prior to a potential upgrade of Podman."},{"line_number":4,"context_line":"- name: Check which containers are running"},{"line_number":5,"context_line":"  command: podman ps -f \u0027status\u003drunning\u0027 -q"},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  # If Podman is not installed this command may exit non-zero."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"56b819a6_764ea063","line":4,"updated":"2023-08-25 13:52:34.000000000","message":"Are you sure that\u0027s the case, or is it just a copy from the docker side of things?","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5fed5003f0b448f21e3e354be4df627ebaea7523","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Upgrading podman engine may cause containers to stop. Take a snapshot of the"},{"line_number":3,"context_line":"# running containers prior to a potential upgrade of Podman."},{"line_number":4,"context_line":"- name: Check which containers are running"},{"line_number":5,"context_line":"  command: podman ps -f \u0027status\u003drunning\u0027 -q"},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  # If Podman is not installed this command may exit non-zero."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7b6d9d32_aa66b73f","line":4,"in_reply_to":"142048cf_844abc52","updated":"2023-10-19 17:22:10.000000000","message":"I will reply and close in a while.","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"645139b7d3a83089732a78b55436d8478b2d3db3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Upgrading podman engine may cause containers to stop. Take a snapshot of the"},{"line_number":3,"context_line":"# running containers prior to a potential upgrade of Podman."},{"line_number":4,"context_line":"- name: Check which containers are running"},{"line_number":5,"context_line":"  command: podman ps -f \u0027status\u003drunning\u0027 -q"},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  # If Podman is not installed this command may exit non-zero."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"142048cf_844abc52","line":4,"in_reply_to":"3e7e43f0_5db1e9c3","updated":"2023-09-08 08:46:05.000000000","message":"podman is daemonless, last time I looked, so there is no central service we can \"upgrade\" by restarting it.\n\nnevertheless, we might want to check which containers are currently running because we might want to \"automatically\" restart them with the upgraded podman binary.\n\nI hope ubuntu/other distributions do no magic stuff in that regard (auto restarting).","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a1fe7cf665a2898995bbcda0e6c805ae60dc1a21","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Upgrading podman engine may cause containers to stop. Take a snapshot of the"},{"line_number":3,"context_line":"# running containers prior to a potential upgrade of Podman."},{"line_number":4,"context_line":"- name: Check which containers are running"},{"line_number":5,"context_line":"  command: podman ps -f \u0027status\u003drunning\u0027 -q"},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  # If Podman is not installed this command may exit non-zero."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"3e7e43f0_5db1e9c3","line":4,"in_reply_to":"56b819a6_764ea063","updated":"2023-08-25 14:35:18.000000000","message":"It\u0027s just a copy but I think it\u0027s good to have just in case.","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"aeff6eceb683b7b30e0991675995a5f1226c4362","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Upgrading podman engine may cause containers to stop. Take a snapshot of the"},{"line_number":3,"context_line":"# running containers prior to a potential upgrade of Podman."},{"line_number":4,"context_line":"- name: Check which containers are running"},{"line_number":5,"context_line":"  command: podman ps -f \u0027status\u003drunning\u0027 -q"},{"line_number":6,"context_line":"  become: true"},{"line_number":7,"context_line":"  # If Podman is not installed this command may exit non-zero."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"216c0821_99c57694","line":4,"in_reply_to":"7b6d9d32_aa66b73f","updated":"2023-10-19 17:51:51.000000000","message":"Commented in last comment.","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"eff8055fb022e06ad6fdb64d5daf6bbfb3a45bf0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  changed_when: false"},{"line_number":10,"context_line":"  register: running_containers"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Ubuntu supports Podman repo only from 20.10 higher so it needs to be added manually"},{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"2f7d283a_a1448084","line":12,"updated":"2023-08-25 17:19:33.000000000","message":"Rephrase to something like; Earlier versions of debian/ubuntu did not bundle podman, and requires an external package repository.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b4f156dc38c64951daa0d37abe6693b09bba26f3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  changed_when: false"},{"line_number":10,"context_line":"  register: running_containers"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Ubuntu supports Podman repo only from 20.10 higher so it needs to be added manually"},{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"420a8388_a9a52f1f","line":12,"in_reply_to":"2f7d283a_a1448084","updated":"2023-08-25 20:00:46.000000000","message":"we planned to do backports?","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  changed_when: false"},{"line_number":10,"context_line":"  register: running_containers"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# Ubuntu supports Podman repo only from 20.10 higher so it needs to be added manually"},{"line_number":13,"context_line":"- name: Add podman repo"},{"line_number":14,"context_line":"  become: true"},{"line_number":15,"context_line":"  block:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"87f721e7_3f609103","line":12,"in_reply_to":"420a8388_a9a52f1f","updated":"2023-08-30 12:54:29.000000000","message":"I don\u0027t think so. It\u0027s probably there from long ago when under 20.10s were supported. Anyways, this repo addition has been removed in the current patch.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"20c3a92ca42b68617a6718b3c26c18f3275c4e8b","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      delay: 10"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Ensure containers are running after Podman upgrade"},{"line_number":35,"context_line":"      command: \"podman start {{ running_containers.stdout }}\""},{"line_number":36,"context_line":"      become: true"},{"line_number":37,"context_line":"      changed_when: true"},{"line_number":38,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"298eaf20_345de38f","line":35,"updated":"2023-10-09 14:52:12.000000000","message":"shouldn\u0027t we rather check systemd unit status here instead of bringing some mayhem in podman/systemd mix?","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"aeff6eceb683b7b30e0991675995a5f1226c4362","unresolved":false,"context_lines":[{"line_number":32,"context_line":"      delay: 10"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Ensure containers are running after Podman upgrade"},{"line_number":35,"context_line":"      command: \"podman start {{ running_containers.stdout }}\""},{"line_number":36,"context_line":"      become: true"},{"line_number":37,"context_line":"      changed_when: true"},{"line_number":38,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"35dbbbd7_9e2f6d63","line":35,"in_reply_to":"0c6ae142_0006a35c","updated":"2023-10-19 17:51:51.000000000","message":"This is not problem, because even if there is some mechanism or isn\u0027t - it doesn\u0027t matter because podman start \u003ccontainer\u003e will\n\n1. Do nothing if container started and running\n2. Start if was running before","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"1c81fafafb270e7f2ae31c1883cc599bcc866106","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      delay: 10"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Ensure containers are running after Podman upgrade"},{"line_number":35,"context_line":"      command: \"podman start {{ running_containers.stdout }}\""},{"line_number":36,"context_line":"      become: true"},{"line_number":37,"context_line":"      changed_when: true"},{"line_number":38,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"e1190c63_c1e3329d","line":35,"in_reply_to":"1943ddc8_f71f7fcb","updated":"2023-10-09 15:08:34.000000000","message":"What about containers that are not part of openstack? If they weren\u0027t deployed by kolla-ansible then they don\u0027t have systemd files and are not running as services.","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c6389f69affb2e94be0dd7e4266d107f3a01db4","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      delay: 10"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Ensure containers are running after Podman upgrade"},{"line_number":35,"context_line":"      command: \"podman start {{ running_containers.stdout }}\""},{"line_number":36,"context_line":"      become: true"},{"line_number":37,"context_line":"      changed_when: true"},{"line_number":38,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"0c6ae142_0006a35c","line":35,"in_reply_to":"1e6323ae_2c0cb8db","updated":"2023-10-19 14:57:23.000000000","message":"imho it\u0027s on the creator/enabler of a certain container to ensure they are (re)started correctly in any case. container engine upgrades do not only happen in kolla. servers get rebooted all the time. the container or systemd service config provided should be enough imho.\n\nif we have bugs in this regard for our own containers we should fix them.\nwe shouldn\u0027t cater to badly deployed stuff, where missing automatic restart options etc are a thing.","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0497598de2d2191d87c6f652ead261e30c2876cc","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      delay: 10"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Ensure containers are running after Podman upgrade"},{"line_number":35,"context_line":"      command: \"podman start {{ running_containers.stdout }}\""},{"line_number":36,"context_line":"      become: true"},{"line_number":37,"context_line":"      changed_when: true"},{"line_number":38,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"1943ddc8_f71f7fcb","line":35,"in_reply_to":"298eaf20_345de38f","updated":"2023-10-09 15:00:42.000000000","message":"I don\u0027t know :), i just adopted these podman patches, i will take a look.","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"33b21101e95f3b1703c2f281e921ff0831fb642b","unresolved":true,"context_lines":[{"line_number":32,"context_line":"      delay: 10"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    - name: Ensure containers are running after Podman upgrade"},{"line_number":35,"context_line":"      command: \"podman start {{ running_containers.stdout }}\""},{"line_number":36,"context_line":"      become: true"},{"line_number":37,"context_line":"      changed_when: true"},{"line_number":38,"context_line":"  when:"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"1e6323ae_2c0cb8db","line":35,"in_reply_to":"e1190c63_c1e3329d","updated":"2023-10-17 10:33:11.000000000","message":"I don\u0027t think we can cover everything here - probably if it\u0027s started podman start will not cause any mayhem (given that systemd will start the container or ensure it\u0027s started) - but I don\u0027t think we should have extra care for containers that are not deployed by Kolla-Ansible","commit_id":"5d0b1a86b3f950d75163fbcffb2ad0e81a1a48c3"}],"roles/podman/vars/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"91b328c935eb1a780bfed89d873b5b8f2ed48a98","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Podman repository configuration fo Debian OS family"},{"line_number":3,"context_line":"distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":4,"context_line":"repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"podman_repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"cb8eca26_8b68bf50","line":3,"updated":"2023-08-25 13:49:34.000000000","message":"podman_dist_name ?","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a1fe7cf665a2898995bbcda0e6c805ae60dc1a21","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Podman repository configuration fo Debian OS family"},{"line_number":3,"context_line":"distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":4,"context_line":"repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"podman_repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"43f4b3e2_3951d858","line":3,"in_reply_to":"cb8eca26_8b68bf50","updated":"2023-08-25 14:35:18.000000000","message":"Done","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"91b328c935eb1a780bfed89d873b5b8f2ed48a98","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Podman repository configuration fo Debian OS family"},{"line_number":3,"context_line":"distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":4,"context_line":"repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"podman_repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/\""},{"line_number":7,"context_line":"podman_repo_key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5c3b71ba_5a010965","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":10},"updated":"2023-08-25 13:49:34.000000000","message":"podman_repo_name ?","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a1fe7cf665a2898995bbcda0e6c805ae60dc1a21","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"# Podman repository configuration fo Debian OS family"},{"line_number":3,"context_line":"distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":4,"context_line":"repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"podman_repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/\""},{"line_number":7,"context_line":"podman_repo_key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"e9a5099a_24eee9bd","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":10},"in_reply_to":"5c3b71ba_5a010965","updated":"2023-08-25 14:35:18.000000000","message":"Done","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f587502153901f1523db075a7cb93b27e44dd0a4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":4,"context_line":"repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"podman_repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/\""},{"line_number":7,"context_line":"podman_repo_key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"6cc348d5_d1df6fa6","line":6,"updated":"2023-08-25 13:52:34.000000000","message":"Do we really need that? Aren\u0027t the versions in Ubuntu Jammy (3.4) and Debian Bookworm (4.3) enough?","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"330f4310ff1d1f6526ee7e7745fec6a1735e7e32","unresolved":false,"context_lines":[{"line_number":3,"context_line":"distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":4,"context_line":"repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"podman_repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/\""},{"line_number":7,"context_line":"podman_repo_key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"1e036ba4_e26a932d","line":6,"in_reply_to":"530caf91_abc9de8a","updated":"2023-09-07 13:08:46.000000000","message":"Tests on the kolla-ansible Podman patch pass (aarch64 seems unrelated) so I think it can be safely removed.","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"a1fe7cf665a2898995bbcda0e6c805ae60dc1a21","unresolved":true,"context_lines":[{"line_number":3,"context_line":"distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":4,"context_line":"repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"podman_repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/\""},{"line_number":7,"context_line":"podman_repo_key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"c12c9101_9989ccf4","line":6,"in_reply_to":"6cc348d5_d1df6fa6","updated":"2023-08-25 14:35:18.000000000","message":"Unless I\u0027m missing something whole names are needed.\n\nhttps://build.opensuse.org/repositories/devel:kubic:libcontainers:stable/podman","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"287b8c344ccf0e59168c870ad68bb5e271e11873","unresolved":true,"context_lines":[{"line_number":3,"context_line":"distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":4,"context_line":"repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"podman_repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/\""},{"line_number":7,"context_line":"podman_repo_key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"530caf91_abc9de8a","line":6,"in_reply_to":"86e5622e_647b8b48","updated":"2023-08-28 10:08:34.000000000","message":"I see. In that case it\u0027s probably unnecessary. I will remove it and see what the tests say.","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"afd39d769f432ddb03a3097bce66adc466ab2758","unresolved":true,"context_lines":[{"line_number":3,"context_line":"distribution: \"{{ \u0027x\u0027 if ansible_facts.os_family \u003d\u003d \u0027Ubuntu\u0027 else \u0027\u0027 }}{{ ansible_facts.os_family }}\""},{"line_number":4,"context_line":"repository: \"{{ distribution }}_{{ ansible_facts.distribution_version }}\""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"podman_repo_url: \"deb https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/\""},{"line_number":7,"context_line":"podman_repo_key_url: \"https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/{{ repository }}/Release.key\""}],"source_content_type":"text/x-yaml","patch_set":19,"id":"86e5622e_647b8b48","line":6,"in_reply_to":"c12c9101_9989ccf4","updated":"2023-08-25 15:24:53.000000000","message":"I think Michal said that podman package is available in the official repositories for Ubuntu 20.10 and newer, and Debian 11 (Bullseye) repositories and later.","commit_id":"9f24080bd1df094c0b48e3ac4527de3a8cac6b98"}],"roles/podman_py/defaults/main.yml":[{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"a024304e556bc2a3b959e25c644241e4cdfc33bd","unresolved":true,"context_lines":[{"line_number":6,"context_line":"  - \"{% if virtualenv is not none %}python3-virtualenv{% endif %}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# List of Python packages to install via Pip."},{"line_number":9,"context_line":"# NOTE(hrw) docker 2.4.2 is in kolla-ansible requirements"},{"line_number":10,"context_line":"# NOTE(mnasiadka): docker 5.0.0 lacks six in deps but requires it"},{"line_number":11,"context_line":"podman_pip_packages:"},{"line_number":12,"context_line":"  - \"podman\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fed35044_dce6344f","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":65},"updated":"2022-08-15 09:25:35.000000000","message":"These comments regarding docker are not needed here.","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"53056658ff34e1abebaad4265b682d6b61c4e5c6","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - \"{% if virtualenv is not none %}python3-virtualenv{% endif %}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# List of Python packages to install via Pip."},{"line_number":9,"context_line":"# NOTE(hrw) docker 2.4.2 is in kolla-ansible requirements"},{"line_number":10,"context_line":"# NOTE(mnasiadka): docker 5.0.0 lacks six in deps but requires it"},{"line_number":11,"context_line":"podman_pip_packages:"},{"line_number":12,"context_line":"  - \"podman\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"65a250bc_5b0c9d26","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":65},"in_reply_to":"fed35044_dce6344f","updated":"2022-08-16 11:58:18.000000000","message":"Done","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"a024304e556bc2a3b959e25c644241e4cdfc33bd","unresolved":true,"context_lines":[{"line_number":32,"context_line":"# Owner of the virtualenv."},{"line_number":33,"context_line":"podman_virtualenv_owner: \"{{ kolla_user if create_kolla_user | bool else omit }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# A pip constraints file to use when installing the Docker SDK."},{"line_number":36,"context_line":"podman_upper_constraints_file:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a80169b_e9c2bfd6","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":63},"updated":"2022-08-15 09:25:35.000000000","message":"This comment regarding docker is not needed here.","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"53056658ff34e1abebaad4265b682d6b61c4e5c6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# Owner of the virtualenv."},{"line_number":33,"context_line":"podman_virtualenv_owner: \"{{ kolla_user if create_kolla_user | bool else omit }}\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# A pip constraints file to use when installing the Docker SDK."},{"line_number":36,"context_line":"podman_upper_constraints_file:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"43a33ed0_6d838cb4","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":63},"in_reply_to":"9a80169b_e9c2bfd6","updated":"2022-08-16 11:58:18.000000000","message":"Done","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":24072,"name":"Marcin Juszkiewicz","email":"mjuszkiewicz@redhat.com","username":"hrw"},"change_message_id":"c61d2cfe982e82099fca0eddd59d1a6572e23236","unresolved":true,"context_lines":[{"line_number":8,"context_line":"# List of Python packages to install via Pip."},{"line_number":9,"context_line":"# NOTE(m.hiner): podman 4.2.0 is the first version to include exec functionality"},{"line_number":10,"context_line":"podman_pip_packages:"},{"line_number":11,"context_line":"  - \"podman\u003d\u003d4.3.0\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# APT cache TTL in seconds."},{"line_number":14,"context_line":"apt_cache_valid_time: 3600"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"545cdf78_158e3be8","line":11,"updated":"2022-10-27 11:26:20.000000000","message":"4.3.* to allow for fixes","commit_id":"9f84de3b74247cde175b3aab83d51fb26f7ec661"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"7599c2cf5f00801ff6ec5a62655e6bfbe6683119","unresolved":false,"context_lines":[{"line_number":8,"context_line":"# List of Python packages to install via Pip."},{"line_number":9,"context_line":"# NOTE(m.hiner): podman 4.2.0 is the first version to include exec functionality"},{"line_number":10,"context_line":"podman_pip_packages:"},{"line_number":11,"context_line":"  - \"podman\u003d\u003d4.3.0\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# APT cache TTL in seconds."},{"line_number":14,"context_line":"apt_cache_valid_time: 3600"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1ce1891f_f3d54ee0","line":11,"in_reply_to":"545cdf78_158e3be8","updated":"2022-10-28 14:44:08.000000000","message":"Done","commit_id":"9f84de3b74247cde175b3aab83d51fb26f7ec661"}],"roles/podman_py/tasks/main.yml":[{"author":{"_account_id":29636,"name":"Oliver Horecny","email":"oliver.horecny@tietoevry.com","username":"o.horecny2"},"change_message_id":"a024304e556bc2a3b959e25c644241e4cdfc33bd","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    dest: ~/podman-py"},{"line_number":38,"context_line":"    clone: yes"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install podman-py requirements"},{"line_number":41,"context_line":"  command: \u0027pip3 install -r ~/podman-py/requirements.txt\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Install podman-py"},{"line_number":44,"context_line":"  command: \u0027pip3 install ~/podman-py/\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Delete podman-py git clone"},{"line_number":47,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"0a249952_75a123c8","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":37},"updated":"2022-08-15 09:25:35.000000000","message":"is this not possible to install by pip module?","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"53056658ff34e1abebaad4265b682d6b61c4e5c6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    dest: ~/podman-py"},{"line_number":38,"context_line":"    clone: yes"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install podman-py requirements"},{"line_number":41,"context_line":"  command: \u0027pip3 install -r ~/podman-py/requirements.txt\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Install podman-py"},{"line_number":44,"context_line":"  command: \u0027pip3 install ~/podman-py/\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Delete podman-py git clone"},{"line_number":47,"context_line":"  file:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"25265b4f_194739e7","line":44,"range":{"start_line":40,"start_character":0,"end_line":44,"end_character":37},"in_reply_to":"0a249952_75a123c8","updated":"2022-08-16 11:58:18.000000000","message":"Done","commit_id":"2e510ee864dfd407578ba9963cdfe325c3452a16"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"04a9c7af558a968e2f9a59768d5f769f9d8d19cc","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# can be removed once new release (atleast 4.3) of podman-py is released"},{"line_number":34,"context_line":"- name: Clone podman-py"},{"line_number":35,"context_line":"  git:  # noqa git-latest"},{"line_number":36,"context_line":"    repo: https://github.com/containers/podman-py.git"},{"line_number":37,"context_line":"    dest: ~/podman-py"},{"line_number":38,"context_line":"    clone: yes"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install podman-py requirements"},{"line_number":41,"context_line":"  command: \u0027pip3 install -r ~/podman-py/requirements.txt\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Install podman-py"},{"line_number":44,"context_line":"  command: \u0027pip3 install ~/podman-py/\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Delete podman-py git clone"},{"line_number":47,"context_line":"  file:"},{"line_number":48,"context_line":"    state: absent"},{"line_number":49,"context_line":"    path: ~/podman-py/"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Start podman.socket"},{"line_number":52,"context_line":"  service:"},{"line_number":53,"context_line":"    name: podman.socket"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"543a928c_edcf99d6","line":50,"range":{"start_line":34,"start_character":0,"end_line":50,"end_character":0},"updated":"2022-10-24 22:32:20.000000000","message":"Shouldn\u0027t this go into a venv similar to docker_sdk? And could this be done in one swoop with the pip module?\n\n - ansible.builtin.pip:\n     name: git+https://github.com/containers/podman-py.git@v4.3.0 \n     # after \u0027@\u0027 can be commit,tag,branch\n\nGood news, v4.3.0 was tagged a few days back.","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"f4b68c8bd8823105ac53ae185d3433db2ffc8967","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# can be removed once new release (atleast 4.3) of podman-py is released"},{"line_number":34,"context_line":"- name: Clone podman-py"},{"line_number":35,"context_line":"  git:  # noqa git-latest"},{"line_number":36,"context_line":"    repo: https://github.com/containers/podman-py.git"},{"line_number":37,"context_line":"    dest: ~/podman-py"},{"line_number":38,"context_line":"    clone: yes"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"- name: Install podman-py requirements"},{"line_number":41,"context_line":"  command: \u0027pip3 install -r ~/podman-py/requirements.txt\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Install podman-py"},{"line_number":44,"context_line":"  command: \u0027pip3 install ~/podman-py/\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"- name: Delete podman-py git clone"},{"line_number":47,"context_line":"  file:"},{"line_number":48,"context_line":"    state: absent"},{"line_number":49,"context_line":"    path: ~/podman-py/"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"- name: Start podman.socket"},{"line_number":52,"context_line":"  service:"},{"line_number":53,"context_line":"    name: podman.socket"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"598851ff_ed574f81","line":50,"range":{"start_line":34,"start_character":0,"end_line":50,"end_character":0},"in_reply_to":"543a928c_edcf99d6","updated":"2022-10-26 13:46:54.000000000","message":"Done","commit_id":"02541f5b07241e6f83aa9674085bfd31d33496e2"}],"roles/podman_sdk/defaults/main.yml":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"57c4aaabe1caa0b2676a61b4a44282a4de94c581","unresolved":true,"context_lines":[{"line_number":3,"context_line":"podman_packages:"},{"line_number":4,"context_line":"  - \"python3-setuptools\""},{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":"  - \"{% if virtualenv is not none %}python3-virtualenv{% endif %}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# List of Python packages to install via Pip."},{"line_number":9,"context_line":"# NOTE(m.hiner): podman 4.2.0 is the first version to include exec functionality"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1d7949aa_66935447","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":66},"updated":"2023-08-25 10:24:03.000000000","message":"do we really need this?\nin the tasks you use \u0027python{{ host_python_version }} -m venv\u0027 in the pip module","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"bccd1c11b5541877b07f94fba2975070dd16d377","unresolved":true,"context_lines":[{"line_number":3,"context_line":"podman_packages:"},{"line_number":4,"context_line":"  - \"python3-setuptools\""},{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":"  - \"{% if virtualenv is not none %}python3-virtualenv{% endif %}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# List of Python packages to install via Pip."},{"line_number":9,"context_line":"# NOTE(m.hiner): podman 4.2.0 is the first version to include exec functionality"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"fe6938e1_03e062bd","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":66},"in_reply_to":"1d7949aa_66935447","updated":"2023-08-25 10:36:00.000000000","message":"not sure, it was probably just copied from docker version where it is no more so I guess we can remove that","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"f45de38536b1ac4891fa9bb641c2d429c32ed095","unresolved":false,"context_lines":[{"line_number":3,"context_line":"podman_packages:"},{"line_number":4,"context_line":"  - \"python3-setuptools\""},{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":"  - \"{% if virtualenv is not none %}python3-virtualenv{% endif %}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# List of Python packages to install via Pip."},{"line_number":9,"context_line":"# NOTE(m.hiner): podman 4.2.0 is the first version to include exec functionality"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"156196a2_ec5d8a3c","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":66},"in_reply_to":"7305e120_d4d72b66","updated":"2023-08-25 12:42:57.000000000","message":"Done","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"267aa7adc3fde98457b5e25721c26c1e87f60fcb","unresolved":true,"context_lines":[{"line_number":3,"context_line":"podman_packages:"},{"line_number":4,"context_line":"  - \"python3-setuptools\""},{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":"  - \"{% if virtualenv is not none %}python3-virtualenv{% endif %}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# List of Python packages to install via Pip."},{"line_number":9,"context_line":"# NOTE(m.hiner): podman 4.2.0 is the first version to include exec functionality"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7305e120_d4d72b66","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":66},"in_reply_to":"fe6938e1_03e062bd","updated":"2023-08-25 10:49:24.000000000","message":"lets remove it","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"eff8055fb022e06ad6fdb64d5daf6bbfb3a45bf0","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Path to a virtualenv in which to install python packages. If None, a"},{"line_number":19,"context_line":"# virtualenv will not be used."},{"line_number":20,"context_line":"virtualenv:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Whether the virtualenv will inherit packages from the global site-packages"},{"line_number":23,"context_line":"# directory. This is typically required for modules such as yum and apt which"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"db44b6ce_10b0597a","line":20,"updated":"2023-08-25 17:19:33.000000000","message":"Why are you providing a unset default? This feels like \"bad practice\".","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"304316b1983d6c0bd99f24ce15ebadab5c30384c","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Path to a virtualenv in which to install python packages. If None, a"},{"line_number":19,"context_line":"# virtualenv will not be used."},{"line_number":20,"context_line":"virtualenv:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Whether the virtualenv will inherit packages from the global site-packages"},{"line_number":23,"context_line":"# directory. This is typically required for modules such as yum and apt which"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"c9b554a1_07f092b3","line":20,"in_reply_to":"2f8efac1_d446d31f","updated":"2023-08-28 19:11:49.000000000","message":"I\u0027d comment it commented out. It\u0027s going as a argument to the pip module, which is [1] \"An optional path to a virtualenv directory to install into.\" So it\u0027s not meant to be a boolean.\n\n\n\n[1] https://docs.ansible.com/ansible/latest/collections/ansible/builtin/pip_module.html#parameter-virtualenv","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Path to a virtualenv in which to install python packages. If None, a"},{"line_number":19,"context_line":"# virtualenv will not be used."},{"line_number":20,"context_line":"virtualenv:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Whether the virtualenv will inherit packages from the global site-packages"},{"line_number":23,"context_line":"# directory. This is typically required for modules such as yum and apt which"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"5bb0c2d7_bb4b6b79","line":20,"in_reply_to":"c9b554a1_07f092b3","updated":"2023-08-30 12:54:29.000000000","message":"Done","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"2cf89d72808621d8f3b9206fe216de9fdf8bfd49","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Path to a virtualenv in which to install python packages. If None, a"},{"line_number":19,"context_line":"# virtualenv will not be used."},{"line_number":20,"context_line":"virtualenv:"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"# Whether the virtualenv will inherit packages from the global site-packages"},{"line_number":23,"context_line":"# directory. This is typically required for modules such as yum and apt which"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"2f8efac1_d446d31f","line":20,"in_reply_to":"db44b6ce_10b0597a","updated":"2023-08-28 07:32:03.000000000","message":"copied from docker, should we default it to False?","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":25600,"name":"Ebbex","display_name":"ebbex","email":"openstack@slipsprogrammor.no","username":"ebbex"},"change_message_id":"eff8055fb022e06ad6fdb64d5daf6bbfb3a45bf0","unresolved":true,"context_lines":[{"line_number":31,"context_line":"podman_virtualenv_owner: \"{{ kolla_user if create_kolla_user | bool else omit }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# A pip constraints file to use when installing the Podman API bindings."},{"line_number":34,"context_line":"podman_upper_constraints_file:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"287bc968_4fb46642","line":34,"updated":"2023-08-25 17:19:33.000000000","message":"Unset default. Feels like it should be set or commented out.","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"2cf89d72808621d8f3b9206fe216de9fdf8bfd49","unresolved":true,"context_lines":[{"line_number":31,"context_line":"podman_virtualenv_owner: \"{{ kolla_user if create_kolla_user | bool else omit }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# A pip constraints file to use when installing the Podman API bindings."},{"line_number":34,"context_line":"podman_upper_constraints_file:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"f2095459_44af41ae","line":34,"in_reply_to":"287bc968_4fb46642","updated":"2023-08-28 07:32:03.000000000","message":"copied from docker","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":false,"context_lines":[{"line_number":31,"context_line":"podman_virtualenv_owner: \"{{ kolla_user if create_kolla_user | bool else omit }}\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# A pip constraints file to use when installing the Podman API bindings."},{"line_number":34,"context_line":"podman_upper_constraints_file:"}],"source_content_type":"text/x-yaml","patch_set":20,"id":"4ddef19c_f9a000b4","line":34,"in_reply_to":"f2095459_44af41ae","updated":"2023-08-30 12:54:29.000000000","message":"Done","commit_id":"0f82cc920a2127b7e3ae9fa65c12e0c353329a5e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f7a5627e1a3b3d2ff5cbf7022e14b025a6bb194b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# List of Python packages to install via Pip."},{"line_number":8,"context_line":"# NOTE(m.hiner): podman 4.2.0 is the first version to include exec functionality"},{"line_number":9,"context_line":"podman_pip_packages:"},{"line_number":10,"context_line":"  - \"podman\u003e\u003d4.3.0\""},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"32a1e218_6951a4a1","line":8,"range":{"start_line":8,"start_character":24,"end_line":8,"end_character":29},"updated":"2023-08-29 08:01:17.000000000","message":"so why use \u003e\u003d4.3.0 then? looks inconsistent","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"dbba3794821361676776595d3f260d92969b8056","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# List of Python packages to install via Pip."},{"line_number":8,"context_line":"# NOTE(m.hiner): podman 4.2.0 is the first version to include exec functionality"},{"line_number":9,"context_line":"podman_pip_packages:"},{"line_number":10,"context_line":"  - \"podman\u003e\u003d4.3.0\""},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"dd6e6cd6_daf40492","line":8,"range":{"start_line":8,"start_character":24,"end_line":8,"end_character":29},"in_reply_to":"32a1e218_6951a4a1","updated":"2023-08-30 12:54:29.000000000","message":"Looked into it and seems like the 4.2 was an mistake and it should have been 4.3 all along. Changed the comment.","commit_id":"ec6c162c21f38912e64b7f28b4ccac2501fee6c1"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"645139b7d3a83089732a78b55436d8478b2d3db3","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# List of Python packages to install via Pip."},{"line_number":8,"context_line":"# NOTE(m.hiner): podman 4.3.0 is the first version to include exec functionality"},{"line_number":9,"context_line":"podman_pip_packages:"},{"line_number":10,"context_line":"  - \"podman\u003e\u003d4.3.0\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# APT cache TTL in seconds."},{"line_number":13,"context_line":"apt_cache_valid_time: 3600"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"368a9411_48664982","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":19},"updated":"2023-09-08 08:46:05.000000000","message":"I\u0027m not sure we want to use the lowest common denominator here, when introducing a new feature. We might want to use a newer version, as we don\u0027t need to care for users of older version (there are none).\n\nI tried to find out upstream how long this release will be even supported. But I did not find this information readily available, so I opened a bug report:\n\nhttps://github.com/containers/podman/issues/19898","commit_id":"fc57ed15c6850de51991ae40f3036d5feb2db768"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"2cec4c48837cbb30f4f564d77dcab86b2e25ca00","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# List of Python packages to install via Pip."},{"line_number":8,"context_line":"# NOTE(m.hiner): podman 4.3.0 is the first version to include exec functionality"},{"line_number":9,"context_line":"podman_pip_packages:"},{"line_number":10,"context_line":"  - \"podman\u003e\u003d4.3.0\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# APT cache TTL in seconds."},{"line_number":13,"context_line":"apt_cache_valid_time: 3600"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"2b486016_6d82ab6c","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":19},"in_reply_to":"2c2a6dfb_c7b0bddc","updated":"2023-10-06 13:40:39.000000000","message":"Done","commit_id":"fc57ed15c6850de51991ae40f3036d5feb2db768"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"806809374faf4ed1a00c10c630988195bae122da","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# List of Python packages to install via Pip."},{"line_number":8,"context_line":"# NOTE(m.hiner): podman 4.3.0 is the first version to include exec functionality"},{"line_number":9,"context_line":"podman_pip_packages:"},{"line_number":10,"context_line":"  - \"podman\u003e\u003d4.3.0\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# APT cache TTL in seconds."},{"line_number":13,"context_line":"apt_cache_valid_time: 3600"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"f54f9126_415d90f8","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":19},"in_reply_to":"368a9411_48664982","updated":"2023-09-08 08:54:20.000000000","message":"it\u0027s not new feature in podman but in podman-py which is python library to communicate with podman API. \n\nhttps://github.com/containers/podman-py","commit_id":"fc57ed15c6850de51991ae40f3036d5feb2db768"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"93911103e795d8f047360b28930e8cf245160842","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# List of Python packages to install via Pip."},{"line_number":8,"context_line":"# NOTE(m.hiner): podman 4.3.0 is the first version to include exec functionality"},{"line_number":9,"context_line":"podman_pip_packages:"},{"line_number":10,"context_line":"  - \"podman\u003e\u003d4.3.0\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# APT cache TTL in seconds."},{"line_number":13,"context_line":"apt_cache_valid_time: 3600"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"2c2a6dfb_c7b0bddc","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":19},"in_reply_to":"457cc770_4a754578","updated":"2023-09-22 08:06:34.000000000","message":"But I would also be open to bump this in a separate changeset, if you prefer that, you decide.","commit_id":"fc57ed15c6850de51991ae40f3036d5feb2db768"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1e011b68cb06485a4ce5e7ae34b02c902610f461","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# List of Python packages to install via Pip."},{"line_number":8,"context_line":"# NOTE(m.hiner): podman 4.3.0 is the first version to include exec functionality"},{"line_number":9,"context_line":"podman_pip_packages:"},{"line_number":10,"context_line":"  - \"podman\u003e\u003d4.3.0\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# APT cache TTL in seconds."},{"line_number":13,"context_line":"apt_cache_valid_time: 3600"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"457cc770_4a754578","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":19},"in_reply_to":"7fc2a51e_f27ce836","updated":"2023-09-22 08:05:33.000000000","message":"upstream replied:\n\nhttps://github.com/containers/podman/issues/19898#issuecomment-1715504039\n\n\u003e We only support the latest released version, so 4.6.2 at the moment. If distros ship older versions then the distro has to support that and backport security fixes when required.\n\nso it would be advisable to bump this imho.","commit_id":"fc57ed15c6850de51991ae40f3036d5feb2db768"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"ad66116a6af0651111ac1c4d5efb437d1af8264e","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# List of Python packages to install via Pip."},{"line_number":8,"context_line":"# NOTE(m.hiner): podman 4.3.0 is the first version to include exec functionality"},{"line_number":9,"context_line":"podman_pip_packages:"},{"line_number":10,"context_line":"  - \"podman\u003e\u003d4.3.0\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# APT cache TTL in seconds."},{"line_number":13,"context_line":"apt_cache_valid_time: 3600"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"7fc2a51e_f27ce836","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":19},"in_reply_to":"f376380e_2b1ae06e","updated":"2023-09-12 05:37:57.000000000","message":"because when we created this patchset the latest one was 4.3","commit_id":"fc57ed15c6850de51991ae40f3036d5feb2db768"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"b7af82569f86eb9eb7095659fe685139b5514043","unresolved":true,"context_lines":[{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"# List of Python packages to install via Pip."},{"line_number":8,"context_line":"# NOTE(m.hiner): podman 4.3.0 is the first version to include exec functionality"},{"line_number":9,"context_line":"podman_pip_packages:"},{"line_number":10,"context_line":"  - \"podman\u003e\u003d4.3.0\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"# APT cache TTL in seconds."},{"line_number":13,"context_line":"apt_cache_valid_time: 3600"}],"source_content_type":"text/x-yaml","patch_set":25,"id":"f376380e_2b1ae06e","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":19},"in_reply_to":"f54f9126_415d90f8","updated":"2023-09-11 07:52:27.000000000","message":"I\u0027m sorry, but I meant podman as a whole thing is new, so also podman-py, so why do we introduce it with version 4.3.0 not 4.6.0, which is the lastest upstream?","commit_id":"fc57ed15c6850de51991ae40f3036d5feb2db768"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"18c4c71699b6a4b5498b7d5b5eba61575a52e180","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":"  - \"python3-podman\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_key:"},{"line_number":10,"context_line":"  src: \"dists/pubkey.gpg\""},{"line_number":11,"context_line":"  dest: \"/etc/apt/keyrings/osbpo.asc\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"2e4c8197_a7854328","line":8,"range":{"start_line":8,"start_character":23,"end_line":8,"end_character":53},"updated":"2023-10-06 15:32:28.000000000","message":"I don\u0027t know this server, but I just wanted to state that it\u0027s sad that a download server does not have https support in 2023, at least we have gpg signing in place to verify downloaded files.","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"18c4c71699b6a4b5498b7d5b5eba61575a52e180","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_key:"},{"line_number":10,"context_line":"  src: \"dists/pubkey.gpg\""},{"line_number":11,"context_line":"  dest: \"/etc/apt/keyrings/osbpo.asc\""},{"line_number":12,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d{{ podman_osbpo_apt_key.dest }}] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"db0db1e9_9608917b","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":25},"updated":"2023-10-06 15:32:28.000000000","message":"where does it come from? I can\u0027t find it neither in this changeset nor in the repository:\n\n```\n ~/Dok/o/c/o/ansible-collection-kolla  on master  find . -type f -regex \"*.asc\"                                            ✔  at 17:16:17 \n ~/Dok/o/c/o/ansible-collection-kolla  on master                                                                           ✔  at 17:16:34 \n\n```","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"cd84b01d2158d4c5e4c4ce68ba483e5fb5b81730","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_key:"},{"line_number":10,"context_line":"  src: \"dists/pubkey.gpg\""},{"line_number":11,"context_line":"  dest: \"/etc/apt/keyrings/osbpo.asc\""},{"line_number":12,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d{{ podman_osbpo_apt_key.dest }}] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"803712b1_1d257103","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":25},"in_reply_to":"0719dbbc_2818c263","updated":"2023-10-09 09:08:30.000000000","message":"I just found out the server osbpo.debian.net seems to be run by the debian openstack team aka zigo. I just reached out via IRC in #opendev and asked if it would be possible to enable https for this server.\n\n:edit: he replied we should just use \"extrepo\", which takes care of the repository handling in a secure way, this works like:\n\n```\napt-get install extrepo\nextrepo enable openstack_bobcat\napt-get update\n```\n\nbasically extrepo is the equivalent to ubuntu ppas for the debian world.\n\nit also has an offline function.\n\nsee: https://wiki.debian.org/OpenStack (CTRL-F \"extrepo\") or directly in the source code:\n\nhttps://salsa.debian.org/extrepo-team/extrepo-data/-/tree/master/repos/debian\n\nI\u0027ll investigate if this would benefit our workflow.","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"12289455d33f432a0510170ff038f560f2199f69","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_key:"},{"line_number":10,"context_line":"  src: \"dists/pubkey.gpg\""},{"line_number":11,"context_line":"  dest: \"/etc/apt/keyrings/osbpo.asc\""},{"line_number":12,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d{{ podman_osbpo_apt_key.dest }}] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"0719dbbc_2818c263","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":25},"in_reply_to":"2a545e1b_c1834453","updated":"2023-10-09 07:51:28.000000000","message":"the docker gpg key file is at least served via HTTPS so not vulnerable to MITM attacks:\n\nhttps://github.com/openstack/ansible-collection-kolla/blob/19a684cb2ece2b830c7e7228269658b5e15e91f3/roles/docker/defaults/main.yml#L9-L10\n\nthe same is true for the yum repos:\n\nhttps://github.com/openstack/ansible-collection-kolla/blob/19a684cb2ece2b830c7e7228269658b5e15e91f3/roles/docker/defaults/main.yml#L16\n\non the other hand, here we are loading a gpg key via an untrusted remote http call.\n\nI would strongly advise not to do that for obvious reasons.\n\nUnfortunately it seems the remote server does not support https.\n\nI don\u0027t know this debian subdomain, is this some private maintainer subdomain?","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"790a48e5e83fc4429ca7f12a65a451d061fe2911","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_key:"},{"line_number":10,"context_line":"  src: \"dists/pubkey.gpg\""},{"line_number":11,"context_line":"  dest: \"/etc/apt/keyrings/osbpo.asc\""},{"line_number":12,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d{{ podman_osbpo_apt_key.dest }}] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"a521f4f1_7fc728e7","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":25},"in_reply_to":"687387d8_2dac74a9","updated":"2023-10-09 15:01:06.000000000","message":"Done","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"df84be671bb1c87eca3e3e19298defec4862ea68","unresolved":true,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_key:"},{"line_number":10,"context_line":"  src: \"dists/pubkey.gpg\""},{"line_number":11,"context_line":"  dest: \"/etc/apt/keyrings/osbpo.asc\""},{"line_number":12,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d{{ podman_osbpo_apt_key.dest }}] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"687387d8_2dac74a9","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":25},"in_reply_to":"803712b1_1d257103","updated":"2023-10-09 12:44:33.000000000","message":"Okay after some back and forth on IRC I also consulted the infra team and their preferred approach would be to serialize the key once and hardcode it in an ansible role (or wherever we need it).\n\nI agree that would improve reliability by reducing network calls. what do you think?","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e0d5b90198e7004dbf891cb21ae87fae5219f849","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_key:"},{"line_number":10,"context_line":"  src: \"dists/pubkey.gpg\""},{"line_number":11,"context_line":"  dest: \"/etc/apt/keyrings/osbpo.asc\""},{"line_number":12,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d{{ podman_osbpo_apt_key.dest }}] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""},{"line_number":13,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"2a545e1b_c1834453","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":25},"in_reply_to":"db0db1e9_9608917b","updated":"2023-10-07 18:39:48.000000000","message":"Check the code and where the variable is used, it\u0027s \u0027source\u0027 as it is located remotely on apt server, same pattern  used as in docker role.","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"92c16e20b68a0fcc04e2ec38bdd128e212f99d25","unresolved":true,"context_lines":[{"line_number":3,"context_line":"podman_packages:"},{"line_number":4,"context_line":"  - \"python3-setuptools\""},{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":"  - \"python3-podman\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d/etc/apt/keyrings/osbpo.asc] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""}],"source_content_type":"text/x-yaml","patch_set":34,"id":"cb369cae_42145717","line":6,"updated":"2023-10-19 13:49:55.000000000","message":"I\u0027m not sure whether I missed some of the discussion, but if we install the podman module from rpm/apt, it seems we neither need the other two pks nor any of the virtualenv things below?","commit_id":"b218df2b064973789831a540d1d06c3ac2e21f86"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e73d4f8cc8de722762bfbcb6406f3136674f32dc","unresolved":false,"context_lines":[{"line_number":3,"context_line":"podman_packages:"},{"line_number":4,"context_line":"  - \"python3-setuptools\""},{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":"  - \"python3-podman\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d/etc/apt/keyrings/osbpo.asc] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""}],"source_content_type":"text/x-yaml","patch_set":34,"id":"2bb9848e_c96da877","line":6,"in_reply_to":"5c1f5507_ece3713a","updated":"2023-10-19 17:20:42.000000000","message":"I\u0027m confused by this question, it was not my proposal to always use distro packages, it was what PS34 implemented. But with the latest update I think this question is obsolete.","commit_id":"b218df2b064973789831a540d1d06c3ac2e21f86"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"5fed5003f0b448f21e3e354be4df627ebaea7523","unresolved":false,"context_lines":[{"line_number":3,"context_line":"podman_packages:"},{"line_number":4,"context_line":"  - \"python3-setuptools\""},{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":"  - \"python3-podman\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d/etc/apt/keyrings/osbpo.asc] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""}],"source_content_type":"text/x-yaml","patch_set":34,"id":"41e7f031_65ce7304","line":6,"in_reply_to":"5c1f5507_ece3713a","updated":"2023-10-19 17:22:10.000000000","message":"Marking as resolved, docker_sdk and podman_sdk is EQUAL now. Podman_sdk has ONLY apt config more IF it\u0027s debian/bookworm.","commit_id":"b218df2b064973789831a540d1d06c3ac2e21f86"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"b755fbee856247eb21d9c3e227d2d2dc9d947a1b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"podman_packages:"},{"line_number":4,"context_line":"  - \"python3-setuptools\""},{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":"  - \"python3-podman\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d/etc/apt/keyrings/osbpo.asc] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""}],"source_content_type":"text/x-yaml","patch_set":34,"id":"4806c5ed_2990e7bc","line":6,"in_reply_to":"cb369cae_42145717","updated":"2023-10-19 14:55:14.000000000","message":"Debian bookworm disabled direct install into system via pip, and dance with env is hard to maintain I suppose. Docker module is now installed from apt also see \nhttps://review.opendev.org/c/openstack/ansible-collection-kolla/+/892323. \n\nSo, I\u0027ve built and upload package to official debian apt repository, BUT bookworm is now stable and it\u0027s not allowed to upload a new package, so I\u0027ve added this package also to osbpo apt repo which is maintained by Zigo mainly.","commit_id":"b218df2b064973789831a540d1d06c3ac2e21f86"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c6389f69affb2e94be0dd7e4266d107f3a01db4","unresolved":true,"context_lines":[{"line_number":3,"context_line":"podman_packages:"},{"line_number":4,"context_line":"  - \"python3-setuptools\""},{"line_number":5,"context_line":"  - \"python3-pip\""},{"line_number":6,"context_line":"  - \"python3-podman\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"podman_osbpo_apt_url: \"http://osbpo.debian.net/debian\""},{"line_number":9,"context_line":"podman_osbpo_apt_repo: \"deb [signed-by\u003d/etc/apt/keyrings/osbpo.asc] {{ podman_osbpo_apt_url }} bookworm-bobcat-backports-nochange main\""}],"source_content_type":"text/x-yaml","patch_set":34,"id":"5c1f5507_ece3713a","line":6,"in_reply_to":"cb369cae_42145717","updated":"2023-10-19 14:57:23.000000000","message":"did you (frickler) check that python-podman is both available in rpm/apt repos and that all versions provided are new enough for all distributions? That would be the work I would expect to be done when this is proposed as a solution, no?\n\nThe current approach at least works.\n\nI agree that, in theory, a distribution based package could simplify things, but it\u0027s quite a hassle to check all the distribution variants we support and I assume nobody has done this work exactly because of this.","commit_id":"b218df2b064973789831a540d1d06c3ac2e21f86"}],"roles/podman_sdk/tasks/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"33315041ab0b8bede4fb81cba7f4a3441ffb7bbb","unresolved":true,"context_lines":[{"line_number":23,"context_line":"    name: \"{{ podman_pip_packages }}\""},{"line_number":24,"context_line":"    executable: \"{{ virtualenv is none | ternary(\u0027pip3\u0027, omit) }}\""},{"line_number":25,"context_line":"    extra_args: \"{% if podman_upper_constraints_file %}-c {{ podman_upper_constraints_file }}{% endif %}\""},{"line_number":26,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":27,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":28,"context_line":"    virtualenv_python: \"{{ virtualenv is none | ternary(omit, \u0027python\u0027 ~ host_python_version) }}\""},{"line_number":29,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"7f65c7a1_0b55f5f2","line":26,"updated":"2023-03-15 10:35:15.000000000","message":"virtualenv_command missing - this way we\u0027re using only virtualenv (not venv)","commit_id":"9c99c2b52f6102260e043d7e6c948ca06c22bc69"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"1b7b34b4790bd6b38c5548b5c2172e51ab94de3b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    name: \"{{ podman_pip_packages }}\""},{"line_number":24,"context_line":"    executable: \"{{ virtualenv is none | ternary(\u0027pip3\u0027, omit) }}\""},{"line_number":25,"context_line":"    extra_args: \"{% if podman_upper_constraints_file %}-c {{ podman_upper_constraints_file }}{% endif %}\""},{"line_number":26,"context_line":"    virtualenv: \"{{ virtualenv is none | ternary(omit, virtualenv) }}\""},{"line_number":27,"context_line":"    virtualenv_site_packages: \"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }}\""},{"line_number":28,"context_line":"    virtualenv_python: \"{{ virtualenv is none | ternary(omit, \u0027python\u0027 ~ host_python_version) }}\""},{"line_number":29,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"14e57a87_7db6ebee","line":26,"in_reply_to":"7f65c7a1_0b55f5f2","updated":"2023-03-15 12:07:48.000000000","message":"Done","commit_id":"9c99c2b52f6102260e043d7e6c948ca06c22bc69"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"0c7fce0e374cec43809541442b409b97103cb299","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Install latest pip in the virtualenv"},{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"0a565e9f_785f9707","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":31},"updated":"2023-08-21 15:36:56.000000000","message":"I\u0027m not sure this comment is needed anymore, afaik we don\u0027t support python 2, do we?","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"bfd1b1eaacbcb0edbed84973c01292aa695ffc03","unresolved":true,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Install latest pip in the virtualenv"},{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"5e6a9a99_fe49c4e2","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"0a565e9f_785f9707","updated":"2023-08-23 15:03:13.000000000","message":"Same comment is in the docker counterpart of this task. So, they both can either be deleted now or it can be left to another patch.","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"e0c5ffbe61828ce838142508bc376f005e109503","unresolved":false,"context_lines":[{"line_number":9,"context_line":""},{"line_number":10,"context_line":"- name: Install latest pip in the virtualenv"},{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"b5dd2d14_a9b787a4","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":31},"in_reply_to":"5e6a9a99_fe49c4e2","updated":"2023-08-24 09:46:56.000000000","message":"okay, then I guess it can be done later as it\u0027s not super important imho.","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"57c4aaabe1caa0b2676a61b4a44282a4de94c581","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a2ea512_6740cb5d","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":33},"updated":"2023-08-25 10:24:03.000000000","message":"{{ virtualenv is none | ternary(omit, virtualenv) }} ?","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"f45de38536b1ac4891fa9bb641c2d429c32ed095","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"117a1e2d_80ba6767","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":33},"in_reply_to":"04183151_1f17d236","updated":"2023-08-25 12:42:57.000000000","message":"Both fixed.","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"bccd1c11b5541877b07f94fba2975070dd16d377","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"64016631_8dcc2b5e","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":33},"in_reply_to":"1a2ea512_6740cb5d","updated":"2023-08-25 10:36:00.000000000","message":"same as in docker file","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"267aa7adc3fde98457b5e25721c26c1e87f60fcb","unresolved":true,"context_lines":[{"line_number":11,"context_line":"  pip:"},{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"04183151_1f17d236","line":14,"range":{"start_line":14,"start_character":17,"end_line":14,"end_character":33},"in_reply_to":"64016631_8dcc2b5e","updated":"2023-08-25 10:49:24.000000000","message":"so we should fix this there too.\nlook at https://review.opendev.org/c/openstack/ansible-collection-kolla/+/852240/18/roles/podman_sdk/defaults/main.yml#21\nvariable not set in defaults, so we should check it","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"57c4aaabe1caa0b2676a61b4a44282a4de94c581","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  become_user: \"{{ podman_virtualenv_owner }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"161d2d86_3cbcbb3f","line":15,"range":{"start_line":15,"start_character":31,"end_line":15,"end_character":61},"updated":"2023-08-25 10:24:03.000000000","message":"{{ virtualenv is none | ternary(omit, virtualenv_site_packages) }} ?","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":35105,"name":"Ivan Halomi","username":"ihalomi","inactive":true},"change_message_id":"bccd1c11b5541877b07f94fba2975070dd16d377","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  become_user: \"{{ podman_virtualenv_owner }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1fbb8f16_c2a7d802","line":15,"range":{"start_line":15,"start_character":31,"end_line":15,"end_character":61},"in_reply_to":"161d2d86_3cbcbb3f","updated":"2023-08-25 10:36:00.000000000","message":"same as in docker file","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"267aa7adc3fde98457b5e25721c26c1e87f60fcb","unresolved":true,"context_lines":[{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  become_user: \"{{ podman_virtualenv_owner }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"7e8c26b7_457a0beb","line":15,"range":{"start_line":15,"start_character":31,"end_line":15,"end_character":61},"in_reply_to":"1fbb8f16_c2a7d802","updated":"2023-08-25 10:49:24.000000000","message":"ditto","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"f45de38536b1ac4891fa9bb641c2d429c32ed095","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    # NOTE(hrw) pip 19.3 is first version complaining about being run with Python 2"},{"line_number":13,"context_line":"    name: pip\u003e19.3"},{"line_number":14,"context_line":"    virtualenv: \"{{ virtualenv }}\""},{"line_number":15,"context_line":"    virtualenv_site_packages: \"{{ virtualenv_site_packages }}\""},{"line_number":16,"context_line":"    virtualenv_command: \"python{{ host_python_version }} -m venv\""},{"line_number":17,"context_line":"  become: true"},{"line_number":18,"context_line":"  become_user: \"{{ podman_virtualenv_owner }}\""}],"source_content_type":"text/x-yaml","patch_set":18,"id":"0ded1aaf_b44ee9d4","line":15,"range":{"start_line":15,"start_character":31,"end_line":15,"end_character":61},"in_reply_to":"7e8c26b7_457a0beb","updated":"2023-08-25 12:42:57.000000000","message":"Both fixed.","commit_id":"8b5a18cfa2708b7dfe29ecf907cb78621cc30464"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"18c4c71699b6a4b5498b7d5b5eba61575a52e180","unresolved":true,"context_lines":[{"line_number":7,"context_line":"        state: directory"},{"line_number":8,"context_line":"        recurse: yes"},{"line_number":9,"context_line":"      become: True"},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"    - name: Ensure apt keyrings directory exists"},{"line_number":12,"context_line":"      file:"},{"line_number":13,"context_line":"        path: /etc/apt/keyrings"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"9f4a80ca_113b0147","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"updated":"2023-10-06 15:32:28.000000000","message":"remove indentation","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a835452373d25d862f192ce80cd34acd5d09f26c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"        state: directory"},{"line_number":8,"context_line":"        recurse: yes"},{"line_number":9,"context_line":"      become: True"},{"line_number":10,"context_line":"    "},{"line_number":11,"context_line":"    - name: Ensure apt keyrings directory exists"},{"line_number":12,"context_line":"      file:"},{"line_number":13,"context_line":"        path: /etc/apt/keyrings"}],"source_content_type":"text/x-yaml","patch_set":26,"id":"b2df9590_96469553","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":4},"in_reply_to":"9f4a80ca_113b0147","updated":"2023-10-09 06:42:11.000000000","message":"Done","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"18c4c71699b6a4b5498b7d5b5eba61575a52e180","unresolved":true,"context_lines":[{"line_number":14,"context_line":"        state: directory"},{"line_number":15,"context_line":"        recurse: yes"},{"line_number":16,"context_line":"      become: True"},{"line_number":17,"context_line":"    "},{"line_number":18,"context_line":"    - name: Install osbpo apt gpg key"},{"line_number":19,"context_line":"      get_url:"},{"line_number":20,"context_line":"        url: \"{{ podman_osbpo_apt_url }}/{{ podman_osbpo_apt_key.src }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"ca6ea044_032f3f54","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":4},"updated":"2023-10-06 15:32:28.000000000","message":"remove indentation","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a835452373d25d862f192ce80cd34acd5d09f26c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"        state: directory"},{"line_number":15,"context_line":"        recurse: yes"},{"line_number":16,"context_line":"      become: True"},{"line_number":17,"context_line":"    "},{"line_number":18,"context_line":"    - name: Install osbpo apt gpg key"},{"line_number":19,"context_line":"      get_url:"},{"line_number":20,"context_line":"        url: \"{{ podman_osbpo_apt_url }}/{{ podman_osbpo_apt_key.src }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"86987b9e_f22fa5b0","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":4},"in_reply_to":"ca6ea044_032f3f54","updated":"2023-10-09 06:42:11.000000000","message":"Done","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"18c4c71699b6a4b5498b7d5b5eba61575a52e180","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        mode: \"0644\""},{"line_number":23,"context_line":"        force: true"},{"line_number":24,"context_line":"      become: True"},{"line_number":25,"context_line":"    "},{"line_number":26,"context_line":"    - name: Enable osbpo apt repository"},{"line_number":27,"context_line":"      apt_repository:"},{"line_number":28,"context_line":"        repo: \"{{ podman_osbpo_apt_repo }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"66de15fb_463b0fed","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":4},"updated":"2023-10-06 15:32:28.000000000","message":"remove indentation","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"a835452373d25d862f192ce80cd34acd5d09f26c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        mode: \"0644\""},{"line_number":23,"context_line":"        force: true"},{"line_number":24,"context_line":"      become: True"},{"line_number":25,"context_line":"    "},{"line_number":26,"context_line":"    - name: Enable osbpo apt repository"},{"line_number":27,"context_line":"      apt_repository:"},{"line_number":28,"context_line":"        repo: \"{{ podman_osbpo_apt_repo }}\""}],"source_content_type":"text/x-yaml","patch_set":26,"id":"14d1ec1b_2f9d4e31","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":4},"in_reply_to":"66de15fb_463b0fed","updated":"2023-10-09 06:42:11.000000000","message":"Done","commit_id":"3f86941c91994ca2218b09fbc2363317f610dd5b"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"121b75a3d1f6cafaf22113231407123b81e61f91","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    - name: Install osbpo apt gpg key"},{"line_number":19,"context_line":"      template:"},{"line_number":20,"context_line":"        src: osbpo_pubkey.gpg.j2"},{"line_number":21,"context_line":"        dest: /etc/apt/keyrings/osbpo.asc"},{"line_number":22,"context_line":"        mode: \"0644\""},{"line_number":23,"context_line":"      become: True"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"df17ac5c_da92cfce","line":20,"updated":"2023-10-12 10:53:10.000000000","message":"what if upstream key changed? should we download it from upsteram?\nhttp://osbpo.debian.net/debian/dists/pubkey.gpg","commit_id":"ccdab763084492eb46fca7e20479106b69e1d2e5"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"eff05c8ebc2904e2e9b22dc4b461736bc14448c4","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    - name: Install osbpo apt gpg key"},{"line_number":19,"context_line":"      template:"},{"line_number":20,"context_line":"        src: osbpo_pubkey.gpg.j2"},{"line_number":21,"context_line":"        dest: /etc/apt/keyrings/osbpo.asc"},{"line_number":22,"context_line":"        mode: \"0644\""},{"line_number":23,"context_line":"      become: True"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"46beeacc_71682448","line":20,"in_reply_to":"9610b4cc_ec89ead4","updated":"2023-10-13 08:47:07.000000000","message":"Ack","commit_id":"ccdab763084492eb46fca7e20479106b69e1d2e5"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"8e6014249a12bbb80a347a5c24d4357e13142186","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    - name: Install osbpo apt gpg key"},{"line_number":19,"context_line":"      template:"},{"line_number":20,"context_line":"        src: osbpo_pubkey.gpg.j2"},{"line_number":21,"context_line":"        dest: /etc/apt/keyrings/osbpo.asc"},{"line_number":22,"context_line":"        mode: \"0644\""},{"line_number":23,"context_line":"      become: True"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"8e6d749c_ebec5065","line":20,"in_reply_to":"df17ac5c_da92cfce","updated":"2023-10-13 08:26:16.000000000","message":"still the issue","commit_id":"ccdab763084492eb46fca7e20479106b69e1d2e5"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"9b30ed39387e42b10716ac816ce3af4d1757b8cc","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    - name: Install osbpo apt gpg key"},{"line_number":19,"context_line":"      template:"},{"line_number":20,"context_line":"        src: osbpo_pubkey.gpg.j2"},{"line_number":21,"context_line":"        dest: /etc/apt/keyrings/osbpo.asc"},{"line_number":22,"context_line":"        mode: \"0644\""},{"line_number":23,"context_line":"      become: True"}],"source_content_type":"text/x-yaml","patch_set":31,"id":"9610b4cc_ec89ead4","line":20,"in_reply_to":"df17ac5c_da92cfce","updated":"2023-10-13 08:28:33.000000000","message":"we discussed this for a long time in irc, see the logs (search for \"osbpo\"):\n\nhttps://meetings.opendev.org/irclogs/%23openstack-kolla/%23openstack-kolla.2023-10-09.log.html\n\nhttps://meetings.opendev.org/irclogs/%23openstack-kolla/%23openstack-kolla.2023-10-10.log.html\n\nzigo and kevko maintain this server|key and don\u0027t intend to change the key.\n\n_if_ the key needs to be changed we will be immediately aware because stuff will fail.\n\nit is not good practice to always download keys during each job run, they rarely change. this also makes infra people happy because we use less resources.\n\nto quote fungi:\n\n\"[..]why are jobs retrieving signing keys at all? in our (opendev\u0027s) jobs, we serialize the public keys we expect to sign things into the job data so it\u0027s never retrieved\"\n\nalso it\u0027s currently not possible to download the key securely, there is no https transport, sadly.\n\nthus it was decided to embed the key.\n\nI hope this helps clarify things?","commit_id":"ccdab763084492eb46fca7e20479106b69e1d2e5"}]}