)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"a7f34f4623c1b27d9a108e83db1f3fea2c20e6b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"97751f64_99dc4edb","updated":"2023-08-31 10:23:28.000000000","message":"I\u0027m propose merge this and also fix other issues in the separate change, but this was not accepted on the meeting.","commit_id":"bdf7e12e725a4b5fdb31eeee3da4416c40954139"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7a9f7728cb705150c52cdb9f7255400f6fb91e73","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d38b050_b78f9ace","updated":"2023-08-30 13:44:32.000000000","message":"Unless we implement listing for that, we will be replicating that so called bad practice in other roles (and that\u0027s not the only occurrence of this in this repository).","commit_id":"bdf7e12e725a4b5fdb31eeee3da4416c40954139"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"e2da8ffa30ef23898a1ae1c69ff544214a3e57a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a9964088_393bc532","updated":"2023-08-28 22:57:09.000000000","message":"finaly)","commit_id":"bdf7e12e725a4b5fdb31eeee3da4416c40954139"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"1e7710b42a837df0f4cf62bd201190b4901b79be","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f5f1436a_65455d31","in_reply_to":"22ccecf9_c192468b","updated":"2023-08-31 08:25:19.000000000","message":"so, I understand the attractiveness of perfect solutions being a perfectionist myself, that being said, sadly they are not achievable, most of the time.\n\nwhat am I getting at? just because something wrong could or is happening elsewhere doesn\u0027t mean we can fix it at one place.\n\nYou have to start somewhere, imho.\n\nIf you demand that every improvement shall be applied to the whole repository and no incremental advantage is possible you will get neither.\n\nit\u0027s imho a trap I have fallen into myself too in the past: demand a perfect solution when that\u0027s just an unreasonable amount of work for a single person.\n\nwe should imho strive for more incremental changes.\n\nif it\u0027s easy to implement for the whole codebase (e.g. by search and replace): agreed it should be done in one commit. if it\u0027s more nuanced imho the incremental approach is better.\n\nwhat do you think?","commit_id":"bdf7e12e725a4b5fdb31eeee3da4416c40954139"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"c95fddc6383c2502201d072d5d81930a1218becf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9f7a0ba_036df79b","in_reply_to":"7d38b050_b78f9ace","updated":"2023-08-30 13:48:01.000000000","message":"you mean linting not listing ?)","commit_id":"bdf7e12e725a4b5fdb31eeee3da4416c40954139"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"945a6c54eb7e7b20b834496ecb51815d7356d491","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a51f5253_448cb708","in_reply_to":"f5f1436a_65455d31","updated":"2023-08-31 10:26:33.000000000","message":"I don\u0027t have a problem with incremental approach, but consistency is key - right now it\u0027s a cosmetic change that doesn\u0027t bring anything instead of a no-op change to the code.","commit_id":"bdf7e12e725a4b5fdb31eeee3da4416c40954139"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ae1d115175a1118ff2c1ffa0966d41ae9d35b901","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"22ccecf9_c192468b","in_reply_to":"f9f7a0ba_036df79b","updated":"2023-08-30 13:53:11.000000000","message":"yes, bloody word linter 😊","commit_id":"bdf7e12e725a4b5fdb31eeee3da4416c40954139"}],"roles/docker_sdk/defaults/main.yml":[{"author":{"_account_id":34911,"name":"Martin Hiner","email":"m.hiner@partner.samsung.com","username":"m.hiner"},"change_message_id":"55d79df48f57d71616357a00604b533fe37376f1","unresolved":true,"context_lines":[{"line_number":16,"context_line":"# Version of python used to execute Ansible modules."},{"line_number":17,"context_line":"host_python_version: \"{{ ansible_facts.python.version.major }}.{{ ansible_facts.python.version.minor }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Path to a virtualenv in which to install python packages. If None, a"},{"line_number":20,"context_line":"# virtualenv will not be used."},{"line_number":21,"context_line":"# virtualenv:"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"00e06862_b4a58841","line":19,"range":{"start_line":19,"start_character":63,"end_line":19,"end_character":67},"updated":"2023-08-30 12:54:41.000000000","message":"Probably should be changed to \"commented out\" or something similar.","commit_id":"bdf7e12e725a4b5fdb31eeee3da4416c40954139"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f2a5722237aa74c1202387be84128e60f36267b3","unresolved":true,"context_lines":[{"line_number":16,"context_line":"# Version of python used to execute Ansible modules."},{"line_number":17,"context_line":"host_python_version: \"{{ ansible_facts.python.version.major }}.{{ ansible_facts.python.version.minor }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Path to a virtualenv in which to install python packages. If None, a"},{"line_number":20,"context_line":"# virtualenv will not be used."},{"line_number":21,"context_line":"# virtualenv:"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1220661d_9f47fd19","line":19,"range":{"start_line":19,"start_character":63,"end_line":19,"end_character":67},"in_reply_to":"00e06862_b4a58841","updated":"2023-08-30 13:37:24.000000000","message":"\"If not set, ...\"","commit_id":"bdf7e12e725a4b5fdb31eeee3da4416c40954139"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6be180677e94c6191ee3d53ad526e9417f27a95e","unresolved":true,"context_lines":[{"line_number":16,"context_line":"# Version of python used to execute Ansible modules."},{"line_number":17,"context_line":"host_python_version: \"{{ ansible_facts.python.version.major }}.{{ ansible_facts.python.version.minor }}\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Path to a virtualenv in which to install python packages. If None, a"},{"line_number":20,"context_line":"# virtualenv will not be used."},{"line_number":21,"context_line":"# virtualenv:"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dd73290e_0a5715ea","line":19,"range":{"start_line":19,"start_character":63,"end_line":19,"end_character":67},"in_reply_to":"1220661d_9f47fd19","updated":"2023-09-26 08:08:26.000000000","message":"Well, if we\u0027re removing that from defaults - then it should be removed from defaults and moved to some role docs/readme?","commit_id":"bdf7e12e725a4b5fdb31eeee3da4416c40954139"}]}