)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"da947d1e208cef5b09a547f88fa9a05845244aa0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1735c477_4677fe7a","updated":"2024-04-26 20:11:20.000000000","message":"So - no real bug, just deprecation on distro side. That’s not a fix, just necessary improvement, please rework reno - there is no need to backport this.","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"9d9ec0746cae3eea60cfcca29e614b2da266aaf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eb19e0f7_d8534b61","in_reply_to":"09680d20_3bf41027","updated":"2024-05-06 07:39:56.000000000","message":"We need it in C sooner or later, but not in B, A or whatever is older.","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"7200e3cbc4dff8f9398f07c4349e8f369a91fec6","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d1310232_05e94194","in_reply_to":"14b17a7a_b21d6a59","updated":"2024-04-27 05:22:19.000000000","message":"We don’t support Noble in C now, we surely won’t support Noble before C.","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"bdbc139cbe9acda2c63e04c7cacbf1ca1e092715","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"14b17a7a_b21d6a59","in_reply_to":"1735c477_4677fe7a","updated":"2024-04-26 21:13:16.000000000","message":"So - not only improvement to make all configuration files use the same format, but the real fix to give the ability to upgrade from Xena/Focal almost to Dalmatian/Noble. JFYI: Noble already released and apt-key dropped from the packages: https://packages.ubuntu.com/search?suite\u003dnoble\u0026arch\u003dany\u0026searchon\u003dnames\u0026keywords\u003dapt-key\nI think we need to backport this, and I\u0027ve already prepared and tested the same change for Yoga/Zed in Kayobe where A-C-K were not used. Would you mind?","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fb883ae1c6aaa655913ec88e37a432674659c2e4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"09680d20_3bf41027","in_reply_to":"d1310232_05e94194","updated":"2024-04-29 15:13:50.000000000","message":"soft-ack: yes it\u0027s not really a bugfix (I would use the category \"chore\" for this if we had it).\n\nBut at least we wrote down to backport 24.04 support for Caracal release[1], so now I\u0027m confused if this is needed for this or not, could you maybe clarify that?\n\nThanks\n\n[1]:https://etherpad.opendev.org/p/kolla-dalmatian-ptg#L506","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"}],"roles/baremetal/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d7487e57ef6c2656c395744d27f9ed246235e14b","unresolved":true,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Ceph APT repository configuration."},{"line_number":7,"context_line":"ceph_apt_url: \"{{ ceph_url }}/debian-{{ ceph_version }}/\""},{"line_number":8,"context_line":"ceph_apt_repo: \"deb {{ ceph_apt_url }} {{ ansible_facts.distribution_release }} main\""},{"line_number":9,"context_line":"ceph_apt_key_file: \"{{ ceph_url }}/keys/release.gpg\""},{"line_number":10,"context_line":"ceph_apt_package: \"ceph-common\""},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"b823cbc3_e2d9079f","line":8,"updated":"2024-04-24 15:50:19.000000000","message":"This var is no longer needed and can also be dropped?","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"08a08f209e04a3fc73a66d54d362e3a3421f0f57","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"# Ceph APT repository configuration."},{"line_number":7,"context_line":"ceph_apt_url: \"{{ ceph_url }}/debian-{{ ceph_version }}/\""},{"line_number":8,"context_line":"ceph_apt_repo: \"deb {{ ceph_apt_url }} {{ ansible_facts.distribution_release }} main\""},{"line_number":9,"context_line":"ceph_apt_key_file: \"{{ ceph_url }}/keys/release.gpg\""},{"line_number":10,"context_line":"ceph_apt_package: \"ceph-common\""},{"line_number":11,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6ee83100_20c0527a","line":8,"in_reply_to":"b823cbc3_e2d9079f","updated":"2024-04-24 21:17:20.000000000","message":"it used: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/916143/3/roles/baremetal/tasks/configure-ceph-for-zun.yml#38","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"}],"roles/baremetal/tasks/configure-ceph-for-zun.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f80963c9f9de415a5dfedbc7b986d49bb759bb58","unresolved":true,"context_lines":[{"line_number":21,"context_line":"            mode: \"0644\""},{"line_number":22,"context_line":"            force: true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        - name: Ensure old ceph repository absent"},{"line_number":25,"context_line":"          file:"},{"line_number":26,"context_line":"            path: /etc/apt/sources.list.d/ceph.list"},{"line_number":27,"context_line":"            state: absent"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        # TODO(mmalchuk): replace with ansible.builtin.deb822_repository module"},{"line_number":30,"context_line":"        # when all stable releases moves to the ansible-core \u003e\u003d 2.15"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ac91e103_356bf99b","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":25},"updated":"2024-04-18 15:13:46.000000000","message":"add a \"TODO: remove this in a future cycle\" comment here?","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"230e2a9802d59f72128d76cf3fc8e306e058d61b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"            mode: \"0644\""},{"line_number":22,"context_line":"            force: true"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"        - name: Ensure old ceph repository absent"},{"line_number":25,"context_line":"          file:"},{"line_number":26,"context_line":"            path: /etc/apt/sources.list.d/ceph.list"},{"line_number":27,"context_line":"            state: absent"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"        # TODO(mmalchuk): replace with ansible.builtin.deb822_repository module"},{"line_number":30,"context_line":"        # when all stable releases moves to the ansible-core \u003e\u003d 2.15"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"6cfe5825_2ee16e1a","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":25},"in_reply_to":"ac91e103_356bf99b","updated":"2024-04-18 20:15:04.000000000","message":"Thanks for mention it but I\u0027ve added TODO bellow. This is related, so no need to add several TODOs. Also this is cleanup task needed may be for upgrade jobs, so will take in account when it needed to remove it.","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f80963c9f9de415a5dfedbc7b986d49bb759bb58","unresolved":true,"context_lines":[{"line_number":78,"context_line":"            enablerepo: epel"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      when: ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":81,"context_line":"      become: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a9f4583f_7adb2e5d","line":81,"range":{"start_line":81,"start_character":5,"end_line":81,"end_character":18},"updated":"2024-04-18 15:13:46.000000000","message":"nit: this refactoring is - strictly speaking - a separate review ;)","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"230e2a9802d59f72128d76cf3fc8e306e058d61b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            enablerepo: epel"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      when: ansible_facts.os_family \u003d\u003d \u0027RedHat\u0027"},{"line_number":81,"context_line":"      become: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"40657bfd_da5caf6a","line":81,"range":{"start_line":81,"start_character":5,"end_line":81,"end_character":18},"in_reply_to":"a9f4583f_7adb2e5d","updated":"2024-04-18 20:15:04.000000000","message":"yep, nitpick) this is refactoring as mentioned in the commit message ;)","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"}],"roles/docker/tasks/repo-Debian.yml":[{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"f80963c9f9de415a5dfedbc7b986d49bb759bb58","unresolved":true,"context_lines":[{"line_number":42,"context_line":"  become: True"},{"line_number":43,"context_line":"  when: docker_apt_package_pin | length \u003e 0"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Ensure old docker repository absent"},{"line_number":46,"context_line":"  file:"},{"line_number":47,"context_line":"    path: /etc/apt/sources.list.d/docker.list"},{"line_number":48,"context_line":"    state: absent"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"589c5de0_be62bf85","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":2},"updated":"2024-04-18 15:13:46.000000000","message":"add a todo comment to remove it in the future","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"230e2a9802d59f72128d76cf3fc8e306e058d61b","unresolved":false,"context_lines":[{"line_number":42,"context_line":"  become: True"},{"line_number":43,"context_line":"  when: docker_apt_package_pin | length \u003e 0"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"- name: Ensure old docker repository absent"},{"line_number":46,"context_line":"  file:"},{"line_number":47,"context_line":"    path: /etc/apt/sources.list.d/docker.list"},{"line_number":48,"context_line":"    state: absent"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"a0c838e7_17e92fed","line":45,"range":{"start_line":45,"start_character":0,"end_line":45,"end_character":2},"in_reply_to":"589c5de0_be62bf85","updated":"2024-04-18 20:15:04.000000000","message":"ditto","commit_id":"2ab88e699019ae33b48c28ad4c9f87d0877e46e9"}]}