)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e026e4f7203f93db92699e18e2d8bb6f5089c150","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"61aa0333_4e1bdf52","updated":"2025-04-22 08:33:05.000000000","message":"why is this dnm?","commit_id":"06de658c10af53ea1d18d992c443122e8e6df732"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e46549c14e7e3a0d48741310dc4eb85ffc0e716c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80f6fcf5_fb69c6b3","in_reply_to":"61aa0333_4e1bdf52","updated":"2025-04-22 13:56:01.000000000","message":"Sorry, I will change the commit message, it was DNM because I knew that this will be used ..but in time of debugging/fixing bootstrap I just didn\u0027t want to have attention from you guys until it will be confirmed it\u0027s working and fixing the issue. I will fix.","commit_id":"06de658c10af53ea1d18d992c443122e8e6df732"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d564af98a94323267a9bbcb42306cb6b1ab772a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"03498689_4df1d109","updated":"2025-04-28 07:37:18.000000000","message":"I believe that this needs some rethinking on the weekly meeting, we’ve historically always tested non-venv install, and if we’re going to change this - we need at least minimal coverage for the non-venv case.","commit_id":"fb45d82cca3a0f8a8105a1ccbc62660fc4e30672"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"bd2e0d5061ceb8c8e6bb525f7a2630389f65100f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4b83b54e_d3e6ab6a","in_reply_to":"03498689_4df1d109","updated":"2025-04-28 07:55:27.000000000","message":"This isn\u0027t entirely true, because as far as I remember, there have been tasks in the CI for quite a long time that install various packages via pip, which is fundamentally wrong — this should be handled by bootstrap-servers, and the CI should call it. Basically, any pip install in a CI playbook is wrong — because it effectively means that for things to work, we require something from the user without documenting it anywhere, and without it, the bootstrap doesn\u0027t work or Kolla-Ansible functionality is broken.\n\nMoreover, even if it were true, CI testing should be done against a venv — that\u0027s the only way you can have a convenient development setup. It\u0027s because, for example, when you need the Docker library or the Podman library in a specific version — you don\u0027t want to rely on whether the distro repositories have that version. The combination of venv and bootstrap ensures this, and you can be sure you\u0027re testing what you should be testing.\n\nI would even argue that at the moment, bootstrap + install-deps with the system Python interpreter simply doesn\u0027t work.\n\nAnd if Kolla-Ansible is supposed to work with the default OS interpreter, then all pip install commands should be removed from the CI playbook, the hardcoded interpreter settings should be removed, and dependencies should be handled by bootstrap-servers + install-deps. Otherwise, we are breaking our own testing.","commit_id":"fb45d82cca3a0f8a8105a1ccbc62660fc4e30672"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"d7c9fecbe58b497d83948cc7749bbc2c4aa650ec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a15edf00_f7da1b12","in_reply_to":"3d25f1e1_939865f8","updated":"2025-04-28 12:03:50.000000000","message":"If it\u0027s broken - where is the bug report?","commit_id":"fb45d82cca3a0f8a8105a1ccbc62660fc4e30672"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"28ac4eca68d6b143c567395d4dffebb23e68305d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a332a061_124424ff","in_reply_to":"4b83b54e_d3e6ab6a","updated":"2025-04-28 08:11:18.000000000","message":"I might agree, but this is not the moment in the cycle I\u0027d like to have that change introduced.","commit_id":"fb45d82cca3a0f8a8105a1ccbc62660fc4e30672"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"f585faed6a3e8edb3ea27bf410a8047306d449f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"604af96e_e16581c9","in_reply_to":"a15edf00_f7da1b12","updated":"2025-05-07 06:57:07.000000000","message":"Done","commit_id":"fb45d82cca3a0f8a8105a1ccbc62660fc4e30672"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"e46fe2246ed4afaddcb6834189adb9455fc6113d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3d25f1e1_939865f8","in_reply_to":"a332a061_124424ff","updated":"2025-04-28 12:02:07.000000000","message":"So you\u0027re saying it\u0027s better not to fix the broken bootstrap-hosts and release it with bugs?\nBecause sure, everything works fine for us in CI... but only because we install it in the CI playbook before bootstrap-hosts.\n\nBut honestly, I don\u0027t really care — I\u0027m the kind of user who would just pull it into downstream Git without hesitation.\nBut if it were up to me, I would definitely merge it.\nMoreover — even if there were a fatal bug (which there isn\u0027t), it would only affect bootstrap-hosts, which could potentially break new deployments, but not existing ones, because it\u0027s just the bootstrap.\n\nThis really isn\u0027t a case where there could be room for a bug, because in the end it\u0027s very trivial.","commit_id":"fb45d82cca3a0f8a8105a1ccbc62660fc4e30672"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"77e110a360c697aa0c9df957846763d340560810","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d8f706de_dd246f46","updated":"2025-05-07 06:56:59.000000000","message":"Let me merge it before rc1 - if anybody knows a better solution let\u0027s just follow up","commit_id":"3e106fec797544049ed3e016499c789bc78e8303"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"5b54d5f7e85e85789aa0a6b6c97dcda46979189c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"97ccaa47_a0b92807","updated":"2025-05-08 03:38:18.000000000","message":"recheck CI fixed?","commit_id":"ecad94400eb7e78f8f44d7909e034ec5b0558dd1"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"35092d5b4971f31839acde0cbf496ba9982a183e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1f8037c0_df0d6f0b","updated":"2025-05-08 05:25:57.000000000","message":"recheck CI should be fixed","commit_id":"ecad94400eb7e78f8f44d7909e034ec5b0558dd1"},{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"367b5b98fae6e7a1e42657752b1406d766477fd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"b5b32320_dd607368","updated":"2025-05-07 15:53:04.000000000","message":"recheck keystone Internal Server Error (HTTP 500)","commit_id":"ecad94400eb7e78f8f44d7909e034ec5b0558dd1"}],"roles/docker_sdk/defaults/main.yml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e026e4f7203f93db92699e18e2d8bb6f5089c150","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"docker_sdk_packages_dbus_deps_debian:"},{"line_number":19,"context_line":"  - \"build-essential\""},{"line_number":20,"context_line":"  - \"python3-dev\""},{"line_number":21,"context_line":"  - \"libdbus-1-dev\""},{"line_number":22,"context_line":"  - \"libdbus-glib-1-dev\""},{"line_number":23,"context_line":"  - \"libglib2.0-dev\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6185d7ce_aeb33a00","line":20,"updated":"2025-04-22 08:33:05.000000000","message":"duplicated below","commit_id":"06de658c10af53ea1d18d992c443122e8e6df732"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"00dbd080ba75854d254345467affd63b70d2ad5b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"docker_sdk_packages_dbus_deps_debian:"},{"line_number":19,"context_line":"  - \"build-essential\""},{"line_number":20,"context_line":"  - \"python3-dev\""},{"line_number":21,"context_line":"  - \"libdbus-1-dev\""},{"line_number":22,"context_line":"  - \"libdbus-glib-1-dev\""},{"line_number":23,"context_line":"  - \"libglib2.0-dev\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4e60c047_c564981e","line":20,"in_reply_to":"6185d7ce_aeb33a00","updated":"2025-04-26 19:25:17.000000000","message":"Done","commit_id":"06de658c10af53ea1d18d992c443122e8e6df732"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"e026e4f7203f93db92699e18e2d8bb6f5089c150","unresolved":true,"context_lines":[{"line_number":24,"context_line":"  - \"python3-dev\""},{"line_number":25,"context_line":"  - \"python3-venv\""},{"line_number":26,"context_line":"  - \"python3-pip\""},{"line_number":27,"context_line":"  - \"pkg-config\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"docker_sdk_packages: \u003e-"},{"line_number":30,"context_line":"  {{ docker_sdk_packages_default +"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"40360a22_ba8da8bc","line":27,"updated":"2025-04-22 08:33:05.000000000","message":"nit: pk \u003c py","commit_id":"06de658c10af53ea1d18d992c443122e8e6df732"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"00dbd080ba75854d254345467affd63b70d2ad5b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  - \"python3-dev\""},{"line_number":25,"context_line":"  - \"python3-venv\""},{"line_number":26,"context_line":"  - \"python3-pip\""},{"line_number":27,"context_line":"  - \"pkg-config\""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"docker_sdk_packages: \u003e-"},{"line_number":30,"context_line":"  {{ docker_sdk_packages_default +"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"4fcaeae3_b78d0e39","line":27,"in_reply_to":"40360a22_ba8da8bc","updated":"2025-04-26 19:25:17.000000000","message":"Done","commit_id":"06de658c10af53ea1d18d992c443122e8e6df732"}]}