)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14200,"name":"Maksim Malchuk","email":"maksim.malchuk@gmail.com","username":"mmalchuk"},"change_message_id":"b11935fcc0351797c091a93c6209b627ca11248d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cb0ff799_bb6c53f4","updated":"2025-10-06 08:32:07.000000000","message":"indeed","commit_id":"c6538924ec03285d912ab48d842ce348f939fd09"},{"author":{"_account_id":32688,"name":"Victor Chembaev","email":"chembervint@gmail.com","username":"chembervint"},"change_message_id":"d4884f8b366c52764d19979790171dd7779db4a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"771d6050_f06c55b4","in_reply_to":"cb0ff799_bb6c53f4","updated":"2025-10-06 12:24:50.000000000","message":"fixed","commit_id":"c6538924ec03285d912ab48d842ce348f939fd09"}],"releasenotes/notes/podman-containers-config-154f36cbd6fd3f3a.yaml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2d6d8dbd4b29eac1eb773cd522866ed2e3f1bae7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Introduced default container configuration for Podman deployments, along"},{"line_number":4,"context_line":"    with the new \u0027podman_custom_config\u0027 variable. This allows operators to"},{"line_number":5,"context_line":"    customize Podman container settings, similar to how \u0027docker_custom_config\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"044e8780_6dc83b8a","line":2,"updated":"2025-10-01 13:39:04.000000000","message":"That should be in features: block - prelude is for release prelude","commit_id":"2782ff289b326d8f6ea806684d8673bb25ab0315"},{"author":{"_account_id":32688,"name":"Victor Chembaev","email":"chembervint@gmail.com","username":"chembervint"},"change_message_id":"b53f8f038b06ca1c44abee71ec1ef22e9507010c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Introduced default container configuration for Podman deployments, along"},{"line_number":4,"context_line":"    with the new \u0027podman_custom_config\u0027 variable. This allows operators to"},{"line_number":5,"context_line":"    customize Podman container settings, similar to how \u0027docker_custom_config\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"13269303_0da5437c","line":2,"in_reply_to":"044e8780_6dc83b8a","updated":"2025-10-02 07:28:44.000000000","message":"Fixed. Moved to features block","commit_id":"2782ff289b326d8f6ea806684d8673bb25ab0315"}],"roles/podman/defaults/main.yml":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"2d6d8dbd4b29eac1eb773cd522866ed2e3f1bae7","unresolved":true,"context_lines":[{"line_number":34,"context_line":"# Podman containers config"},{"line_number":35,"context_line":"podman_custom_config: {}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"podman_healthcheck_events: false"},{"line_number":38,"context_line":"podman_log_max_size: 131072"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"podman_engine_config:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"07f0e695_f836a72c","line":37,"updated":"2025-10-01 13:39:04.000000000","message":"Why these values as defaults?","commit_id":"2782ff289b326d8f6ea806684d8673bb25ab0315"},{"author":{"_account_id":32688,"name":"Victor Chembaev","email":"chembervint@gmail.com","username":"chembervint"},"change_message_id":"b53f8f038b06ca1c44abee71ec1ef22e9507010c","unresolved":true,"context_lines":[{"line_number":34,"context_line":"# Podman containers config"},{"line_number":35,"context_line":"podman_custom_config: {}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"podman_healthcheck_events: false"},{"line_number":38,"context_line":"podman_log_max_size: 131072"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"podman_engine_config:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a03d0b50_b9a18ad9","line":37,"in_reply_to":"07f0e695_f836a72c","updated":"2025-10-02 07:28:44.000000000","message":"Changed podman_log_max_size to 52428800 (50M) similar to docker defaults for log size in a-c-k\n\npodman_healthcheck_events: false - disables spamming huge amount of not important logs about regular healthchecks for each container in system journal. I thank that we have to give users this variable configurable (for example for debug reasons) but default I believe should be in False","commit_id":"2782ff289b326d8f6ea806684d8673bb25ab0315"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"ca4d87d875f1aeb26fb598da3570ecb8f8a4522d","unresolved":true,"context_lines":[{"line_number":34,"context_line":"# Podman containers config"},{"line_number":35,"context_line":"podman_custom_config: {}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"podman_healthcheck_events: false"},{"line_number":38,"context_line":"podman_log_max_size: 131072"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"podman_engine_config:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ea544ac7_641bb3be","line":37,"in_reply_to":"a03d0b50_b9a18ad9","updated":"2025-10-02 14:42:07.000000000","message":"That\u0027s fine, but can you add # NOTE: \u003ccontent\u003e on top of both these settings so we know from where they come from?","commit_id":"2782ff289b326d8f6ea806684d8673bb25ab0315"},{"author":{"_account_id":32688,"name":"Victor Chembaev","email":"chembervint@gmail.com","username":"chembervint"},"change_message_id":"9bef6eac016baafac33f3a70e3d0063ad4611d89","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# Podman containers config"},{"line_number":35,"context_line":"podman_custom_config: {}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"podman_healthcheck_events: false"},{"line_number":38,"context_line":"podman_log_max_size: 131072"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"podman_engine_config:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"caec7e52_18112aa4","line":37,"in_reply_to":"ea544ac7_641bb3be","updated":"2025-10-02 14:55:59.000000000","message":"Added NOTEs for both variables","commit_id":"2782ff289b326d8f6ea806684d8673bb25ab0315"}],"roles/podman/templates/kolla.conf.j2":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"c048aea9f8e893fa2397b359d64f6547d43bbda9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"{%- elif value is string -%}"},{"line_number":11,"context_line":"\"{{ value | replace(\u0027\"\u0027, \u0027\\\\\"\u0027) }}\""},{"line_number":12,"context_line":"{%- else -%}"},{"line_number":13,"context_line":"# Handle nulls/None if necessary, e.g., \"\" or a comment"},{"line_number":14,"context_line":"{%- endif -%}"},{"line_number":15,"context_line":"{%- endmacro -%}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"53d8aeec_99ab7f0a","line":13,"updated":"2025-10-03 13:54:03.000000000","message":"I think we don\u0027t need this rendered, put it in jinja2 comment block {# comment #}","commit_id":"c6538924ec03285d912ab48d842ce348f939fd09"},{"author":{"_account_id":32688,"name":"Victor Chembaev","email":"chembervint@gmail.com","username":"chembervint"},"change_message_id":"a07a9935433db7feeb0ed4f9993e784cbfc956ba","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{%- elif value is string -%}"},{"line_number":11,"context_line":"\"{{ value | replace(\u0027\"\u0027, \u0027\\\\\"\u0027) }}\""},{"line_number":12,"context_line":"{%- else -%}"},{"line_number":13,"context_line":"# Handle nulls/None if necessary, e.g., \"\" or a comment"},{"line_number":14,"context_line":"{%- endif -%}"},{"line_number":15,"context_line":"{%- endmacro -%}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"92bc6f34_cc14dba2","line":13,"in_reply_to":"53d8aeec_99ab7f0a","updated":"2025-10-03 14:08:59.000000000","message":"It will not be rendered, because it is jinja2 macros.\nHere is example of rendered file:\n\ncat /etc/containers/containers.conf.d/kolla.conf\n[engine]\nevents_logger \u003d \"file\"\nhealthcheck_events \u003d false\n\n[containers]\nlog_size_max \u003d 52428800\nlog_driver \u003d \"k8s-file\"","commit_id":"c6538924ec03285d912ab48d842ce348f939fd09"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"0ec8ab7f21eb2c3e66c4cc8ce4aa65d5637501af","unresolved":false,"context_lines":[{"line_number":10,"context_line":"{%- elif value is string -%}"},{"line_number":11,"context_line":"\"{{ value | replace(\u0027\"\u0027, \u0027\\\\\"\u0027) }}\""},{"line_number":12,"context_line":"{%- else -%}"},{"line_number":13,"context_line":"# Handle nulls/None if necessary, e.g., \"\" or a comment"},{"line_number":14,"context_line":"{%- endif -%}"},{"line_number":15,"context_line":"{%- endmacro -%}"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"3cf127d0_55e45717","line":13,"in_reply_to":"92bc6f34_cc14dba2","updated":"2025-10-03 14:10:52.000000000","message":"Ok, weird, it usually is - but if it looks fine - then I\u0027m ok.","commit_id":"c6538924ec03285d912ab48d842ce348f939fd09"},{"author":{"_account_id":23084,"name":"Bartosz Bezak","email":"bartosz@stackhpc.com","username":"b.bezak"},"change_message_id":"b602389c76d1408e5bb3fe5d491911a614f040b5","unresolved":true,"context_lines":[{"line_number":14,"context_line":"{%- endif -%}"},{"line_number":15,"context_line":"{%- endmacro -%}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% set podman_config \u003d podman_custom_config"},{"line_number":18,"context_line":"   | combine(podman_engine_config, recursive\u003dTrue)"},{"line_number":19,"context_line":"   | combine(podman_containers_config, recursive\u003dTrue)"},{"line_number":20,"context_line":"%}"},{"line_number":21,"context_line":"{% for section, settings in podman_config.items() %}"},{"line_number":22,"context_line":"[{{ section }}]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"2f8e250a_f75595f3","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":54},"updated":"2025-10-06 06:54:23.000000000","message":"currently this will override custom config with default ones, I recon we should do this like so:\n```suggestion\n{% set podman_config \u003d podman_engine_config\n   | combine(podman_containers_config, recursive\u003dTrue)\n   | combine(podman_custom_config, recursive\u003dTrue)\n```","commit_id":"c6538924ec03285d912ab48d842ce348f939fd09"},{"author":{"_account_id":32688,"name":"Victor Chembaev","email":"chembervint@gmail.com","username":"chembervint"},"change_message_id":"d4884f8b366c52764d19979790171dd7779db4a3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"{%- endif -%}"},{"line_number":15,"context_line":"{%- endmacro -%}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"{% set podman_config \u003d podman_custom_config"},{"line_number":18,"context_line":"   | combine(podman_engine_config, recursive\u003dTrue)"},{"line_number":19,"context_line":"   | combine(podman_containers_config, recursive\u003dTrue)"},{"line_number":20,"context_line":"%}"},{"line_number":21,"context_line":"{% for section, settings in podman_config.items() %}"},{"line_number":22,"context_line":"[{{ section }}]"}],"source_content_type":"text/x-jinja2","patch_set":4,"id":"8b75caa8_4f869365","line":19,"range":{"start_line":17,"start_character":0,"end_line":19,"end_character":54},"in_reply_to":"2f8e250a_f75595f3","updated":"2025-10-06 12:24:50.000000000","message":"Fix applied.","commit_id":"c6538924ec03285d912ab48d842ce348f939fd09"}]}