)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"8055ddb57359da87742904331ea6eb0705c899c4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3d7ee6c_26bfbc15","updated":"2026-10-16 12:06:23.000000000","message":"needs a changelog fragment as a starter","commit_id":"e4abe96006249056da89cbb983cd2f45aab5922a"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"5bf3e75bcd7f444b3a3b56e98de81fbe15a9dc86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"63de2f57_43676427","in_reply_to":"c3d7ee6c_26bfbc15","updated":"2026-10-16 12:23:03.000000000","message":"Done","commit_id":"e4abe96006249056da89cbb983cd2f45aab5922a"},{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"fa92f5d8c92c1aa3e481afabe159e4039fe9bef7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d9bc2752_2c4a6982","updated":"2026-10-21 08:43:26.000000000","message":"recheck","commit_id":"b355ba3c15702718d84d001c55011a893ab8abaf"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"8b44c58f7d2611995624c49a2ade4dfbc787670e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"11c8bde6_43c24a77","updated":"2026-10-22 10:54:01.000000000","message":"yup, works for me, thanks!","commit_id":"f1c5f7823f751446fdf3f1486c42dc1e8490871e"}],"plugins/modules/baremetal_node.py":[{"author":{"_account_id":17669,"name":"Doug Szumski","email":"doug@stackhpc.com","username":"DougSzumski"},"change_message_id":"81386aee838c5d0c3b0e276ab4734f2862e59274","unresolved":true,"context_lines":[{"line_number":664,"context_line":"                kwargs[\u0027properties\u0027] \u003d properties"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"        provision_state \u003d self.params[\u0027target_provision_state\u0027]"},{"line_number":667,"context_line":"        if provision_state \u003d\u003d \u0027available\u0027 and len(self.params[\u0027nics\u0027]) \u003e 0:"},{"line_number":668,"context_line":"            provision_state \u003d \u0027enroll\u0027"},{"line_number":669,"context_line":"        node \u003d self.conn.register_machine("},{"line_number":670,"context_line":"            nics\u003dself.params[\u0027nics\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"698df4fb_30c8c773","line":667,"updated":"2026-10-19 16:08:26.000000000","message":"I think we need `\u003d\u003d 0` not `\u003e 0` to match the previous behaviour?","commit_id":"107494c716a2064c52ca273fac2284056cd8efd0"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"2e75f823edf0754a80786c0dde04dc02d1625e57","unresolved":false,"context_lines":[{"line_number":664,"context_line":"                kwargs[\u0027properties\u0027] \u003d properties"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"        provision_state \u003d self.params[\u0027target_provision_state\u0027]"},{"line_number":667,"context_line":"        if provision_state \u003d\u003d \u0027available\u0027 and len(self.params[\u0027nics\u0027]) \u003e 0:"},{"line_number":668,"context_line":"            provision_state \u003d \u0027enroll\u0027"},{"line_number":669,"context_line":"        node \u003d self.conn.register_machine("},{"line_number":670,"context_line":"            nics\u003dself.params[\u0027nics\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"b9e873fe_8bf29992","line":667,"in_reply_to":"698df4fb_30c8c773","updated":"2026-10-19 16:42:58.000000000","message":"Good spot. Fixed","commit_id":"107494c716a2064c52ca273fac2284056cd8efd0"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"41b35c2acf3a3d401162716bebb0766a571acae8","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        - This option is ignored if the node already exists."},{"line_number":163,"context_line":"        - If set to available, the node will go through cleaning."},{"line_number":164,"context_line":"      choices: [\u0027enroll\u0027, \u0027manageable\u0027, \u0027available\u0027]"},{"line_number":165,"context_line":"      default: available"},{"line_number":166,"context_line":"      type: str"},{"line_number":167,"context_line":"    timeout:"},{"line_number":168,"context_line":"      description:"}],"source_content_type":"text/x-python","patch_set":4,"id":"2a07bf49_df5d1745","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":24},"updated":"2026-10-22 07:09:19.000000000","message":"I would say that default should be None here to keep the behavior.\nIf it\u0027s not supplied by the user - we keep the logic around len(nics). If it\u0027s supplied explicitly - we respect the input. WDYT?","commit_id":"b355ba3c15702718d84d001c55011a893ab8abaf"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"138725df5aabd4d9dd84cea6d89ac556dfeadb5e","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        - This option is ignored if the node already exists."},{"line_number":163,"context_line":"        - If set to available, the node will go through cleaning."},{"line_number":164,"context_line":"      choices: [\u0027enroll\u0027, \u0027manageable\u0027, \u0027available\u0027]"},{"line_number":165,"context_line":"      default: available"},{"line_number":166,"context_line":"      type: str"},{"line_number":167,"context_line":"    timeout:"},{"line_number":168,"context_line":"      description:"}],"source_content_type":"text/x-python","patch_set":4,"id":"efad6826_09ee7b0d","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":24},"in_reply_to":"2a07bf49_df5d1745","updated":"2026-10-22 09:46:31.000000000","message":"Yeah, although depending on how Ironic and/or the node is configured it might be fine going to available with no NICs set, or it might fail in cleaning. I guess the best bet in that situation would be to spit out a warning and if it fails that\u0027s on the user?","commit_id":"b355ba3c15702718d84d001c55011a893ab8abaf"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"6a85c5274bdb9075e9ab7de5e19677ac5bda881f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        - This option is ignored if the node already exists."},{"line_number":163,"context_line":"        - If set to available, the node will go through cleaning."},{"line_number":164,"context_line":"      choices: [\u0027enroll\u0027, \u0027manageable\u0027, \u0027available\u0027]"},{"line_number":165,"context_line":"      default: available"},{"line_number":166,"context_line":"      type: str"},{"line_number":167,"context_line":"    timeout:"},{"line_number":168,"context_line":"      description:"}],"source_content_type":"text/x-python","patch_set":4,"id":"4d417d9c_24f61e08","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":24},"in_reply_to":"efad6826_09ee7b0d","updated":"2026-10-22 10:11:02.000000000","message":"Done, I went for try-available rather than None.","commit_id":"b355ba3c15702718d84d001c55011a893ab8abaf"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"41b35c2acf3a3d401162716bebb0766a571acae8","unresolved":true,"context_lines":[{"line_number":663,"context_line":"            if properties:"},{"line_number":664,"context_line":"                kwargs[\u0027properties\u0027] \u003d properties"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"        provision_state \u003d self.params[\u0027target_provision_state\u0027]"},{"line_number":667,"context_line":"        if provision_state \u003d\u003d \u0027available\u0027 and len(self.params[\u0027nics\u0027]) \u003d\u003d 0:"},{"line_number":668,"context_line":"            provision_state \u003d \u0027enroll\u0027"},{"line_number":669,"context_line":"        node \u003d self.conn.register_machine("},{"line_number":670,"context_line":"            nics\u003dself.params[\u0027nics\u0027],"},{"line_number":671,"context_line":"            wait\u003dself.params[\u0027wait\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"c35f20ba_ac6c18f3","line":668,"range":{"start_line":666,"start_character":0,"end_line":668,"end_character":38},"updated":"2026-10-22 07:09:19.000000000","message":"This looks fishy to me. User has passed an explicit state it expects the resource to be in.\n\nInstead, we silently override direct user input and set our internal logic on top of that.","commit_id":"b355ba3c15702718d84d001c55011a893ab8abaf"},{"author":{"_account_id":39213,"name":"Jed Preist","display_name":"Jed Preist","email":"jed@stackhpc.com","username":"jed-preist"},"change_message_id":"6a85c5274bdb9075e9ab7de5e19677ac5bda881f","unresolved":false,"context_lines":[{"line_number":663,"context_line":"            if properties:"},{"line_number":664,"context_line":"                kwargs[\u0027properties\u0027] \u003d properties"},{"line_number":665,"context_line":""},{"line_number":666,"context_line":"        provision_state \u003d self.params[\u0027target_provision_state\u0027]"},{"line_number":667,"context_line":"        if provision_state \u003d\u003d \u0027available\u0027 and len(self.params[\u0027nics\u0027]) \u003d\u003d 0:"},{"line_number":668,"context_line":"            provision_state \u003d \u0027enroll\u0027"},{"line_number":669,"context_line":"        node \u003d self.conn.register_machine("},{"line_number":670,"context_line":"            nics\u003dself.params[\u0027nics\u0027],"},{"line_number":671,"context_line":"            wait\u003dself.params[\u0027wait\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"41bb1d5a_14ee16f1","line":668,"range":{"start_line":666,"start_character":0,"end_line":668,"end_character":38},"in_reply_to":"c35f20ba_ac6c18f3","updated":"2026-10-22 10:11:02.000000000","message":"Done","commit_id":"b355ba3c15702718d84d001c55011a893ab8abaf"}]}