)]}'
{"ci/roles/router/tasks/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"88132a2abbb0320aa5215f7e45f9d839b04314a3","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"- name: Gather routers info"},{"line_number":76,"context_line":"  openstack.cloud.os_routers_info:"},{"line_number":77,"context_line":"     cloud: \"{{ cloud }}\""},{"line_number":78,"context_line":"     name: \"{{ router_name }}\""},{"line_number":79,"context_line":"  register: result"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- name: Verify routers info"},{"line_number":82,"context_line":"  assert:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa7e38b_4fd9a581","line":79,"range":{"start_line":77,"start_character":0,"end_line":79,"end_character":18},"updated":"2020-01-28 14:56:17.000000000","message":"would be nice to have here at least one filter","commit_id":"fe6c20066aed92797d4a668757fd00e326cb8e31"}],"plugins/modules/os_routers_info.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9d6e5ec3e56960540efbef529cd66c38800ddf15","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            type: list"},{"line_number":132,"context_line":"\u0027\u0027\u0027"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"from ansible.module_utils.basic import AnsibleModule"},{"line_number":135,"context_line":"from ansible.module_utils.openstack import openstack_full_argument_spec, openstack_cloud_from_module"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0ef1a8de","line":135,"range":{"start_line":134,"start_character":0,"end_line":135,"end_character":100},"updated":"2020-01-23 12:48:46.000000000","message":"please change it to be collections ready: https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/modules/os_router.py#L208","commit_id":"7697e6bca8a006caf401c9f466002805b2034408"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"88132a2abbb0320aa5215f7e45f9d839b04314a3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        - Name or ID of the router"},{"line_number":30,"context_line":"     required: false"},{"line_number":31,"context_line":"     type: str"},{"line_number":32,"context_line":"   filters:"},{"line_number":33,"context_line":"     description:"},{"line_number":34,"context_line":"        - A dictionary of meta data to use for further filtering.  Elements of"},{"line_number":35,"context_line":"          this dictionary may be additional dictionaries."},{"line_number":36,"context_line":"     required: false"},{"line_number":37,"context_line":"     type: dict"},{"line_number":38,"context_line":"   availability_zone:"},{"line_number":39,"context_line":"     description:"},{"line_number":40,"context_line":"       - Ignored. Present for backwards compatibility"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8feb1d0f","line":37,"range":{"start_line":32,"start_character":0,"end_line":37,"end_character":15},"updated":"2020-01-28 14:56:17.000000000","message":"Can you please add here suboptions? See example inhttps://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/ansible_plugins/modules/os_baremetal_node_info.py#L63-L144","commit_id":"fe6c20066aed92797d4a668757fd00e326cb8e31"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"73935dbc574e2bcb93e5c3b821c641f7de28fe26","unresolved":false,"context_lines":[{"line_number":54,"context_line":"         description:"},{"line_number":55,"context_line":"           - Filter the list result by the administrative state of the resource, which is up (true) or down (false)."},{"line_number":56,"context_line":"         type: bool"},{"line_number":57,"context_line":"       revision_number:"},{"line_number":58,"context_line":"         description:"},{"line_number":59,"context_line":"           - Filter the list result by the revision number of the resource."},{"line_number":60,"context_line":"         type: int"},{"line_number":61,"context_line":"       tags:"},{"line_number":62,"context_line":"         description:"},{"line_number":63,"context_line":"           - A list of tags to filter the list result by. Resources that match all tags in this list will be returned."},{"line_number":64,"context_line":"         type: list"},{"line_number":65,"context_line":"       tags-any:"},{"line_number":66,"context_line":"         description:"},{"line_number":67,"context_line":"           - A list of tags to filter the list result by. Resources that match any tag in this list will be returned."},{"line_number":68,"context_line":"         type: list"},{"line_number":69,"context_line":"       not-tags:"},{"line_number":70,"context_line":"         description:"},{"line_number":71,"context_line":"           - A list of tags to filter the list result by. Resources that match all tags in this list will be excluded."},{"line_number":72,"context_line":"         type: list"},{"line_number":73,"context_line":"       not-tags-any:"},{"line_number":74,"context_line":"         description:"},{"line_number":75,"context_line":"           - A list of tags to filter the list result by. Resources that match any tag in this list will be excluded."},{"line_number":76,"context_line":"         type: list"},{"line_number":77,"context_line":"   availability_zone:"},{"line_number":78,"context_line":"     description:"},{"line_number":79,"context_line":"       - Ignored. Present for backwards compatibility"},{"line_number":80,"context_line":"     required: false"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e6d74cbc","line":77,"range":{"start_line":57,"start_character":7,"end_line":77,"end_character":21},"updated":"2020-01-29 11:31:13.000000000","message":"can you please paste a link where are those defined? I don\u0027t find such filters in https://docs.openstack.org/openstacksdk/latest/user/proxies/network.html#router-operations\n\nor here I have something else: https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/tests/unit/network/v2/test_router.py#L22\n\nIt would be useful for changing and updating this list","commit_id":"e753a4ee6ddf4b3c96f38ce7ab99aad6c70dfc32"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"fbd4a6f21335d354415fd5eaf247d0f6246341a1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"         description:"},{"line_number":63,"context_line":"           - A list of tags to filter the list result by. Resources that match all tags in this list will be returned."},{"line_number":64,"context_line":"         type: list"},{"line_number":65,"context_line":"   availability_zone:"},{"line_number":66,"context_line":"     description:"},{"line_number":67,"context_line":"       - Ignored. Present for backwards compatibility"},{"line_number":68,"context_line":"     required: false"},{"line_number":69,"context_line":"     type: str"},{"line_number":70,"context_line":"extends_documentation_fragment: openstack"},{"line_number":71,"context_line":"\u0027\u0027\u0027"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_6b9b0316","line":69,"range":{"start_line":65,"start_character":0,"end_line":69,"end_character":14},"updated":"2020-02-18 12:50:05.000000000","message":"This is a new module, so this should not be included.","commit_id":"8e8661aeb25fb133420dc2b224e0b46f003bf1f8"},{"author":{"_account_id":30547,"name":"Bram Verschueren","email":"verschueren.bram@gmail.com","username":"bverschueren"},"change_message_id":"cbafa9c89bb97442b163edd04f2b728c79ea65fa","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def main():"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    argument_spec \u003d openstack_full_argument_spec("},{"line_number":163,"context_line":"        name\u003ddict(required\u003dFalse, default\u003dNone),"},{"line_number":164,"context_line":"        filters\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003dNone)"},{"line_number":165,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_f901f4b5","line":162,"updated":"2020-02-19 11:55:42.000000000","message":"By using openstack.openstack_full_argument_spec, the \u0027availability_zone\u0027 key becomes part of your spec.\n\nhttps://github.com/openstack/ansible-collections-openstack/blob/7bd15ba000a6bb4341905a3f211b4a4beda9bb4d/plugins/module_utils/openstack.py#L84\n\nMost of these included keys\u0027 docs are covered by extending the doc fragment :\n\nhttps://github.com/openstack/ansible-collections-openstack/blob/7bd15ba000a6bb4341905a3f211b4a4beda9bb4d/plugins/doc_fragments/openstack.py\n\nExcept \u0027availability_zone\u0027 is not, so we can either document it in the module, or ignore the sanity test.\nThis might be something to fix in the OpenStackModule base class.","commit_id":"72944f1a3a3bb2642fa86fa595881dc99409d91d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"f49d3c8defd0e138bc7cb9236b20c82ff8bc4094","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"def main():"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    argument_spec \u003d openstack_full_argument_spec("},{"line_number":163,"context_line":"        name\u003ddict(required\u003dFalse, default\u003dNone),"},{"line_number":164,"context_line":"        filters\u003ddict(required\u003dFalse, type\u003d\u0027dict\u0027, default\u003dNone)"},{"line_number":165,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_74c42962","line":162,"in_reply_to":"3fa7e38b_f901f4b5","updated":"2020-02-19 13:00:18.000000000","message":"Ah, thank you for the explanation!","commit_id":"72944f1a3a3bb2642fa86fa595881dc99409d91d"}],"tests/sanity/ignore-2.10.txt":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"0f0befb08ecb7b4c68f4e3d201cb94ad7c41cc20","unresolved":false,"context_lines":[{"line_number":82,"context_line":"plugins/modules/os_router.py validate-modules:doc-missing-type"},{"line_number":83,"context_line":"plugins/modules/os_router.py validate-modules:parameter-type-not-in-doc"},{"line_number":84,"context_line":"plugins/modules/os_routers_info.py validate-modules:doc-missing-type"},{"line_number":85,"context_line":"plugins/modules/os_routers_info.py validate-modules:undocumented-parameter"},{"line_number":86,"context_line":"plugins/modules/os_security_group.py validate-modules:doc-missing-type"},{"line_number":87,"context_line":"plugins/modules/os_security_group_rule.py validate-modules:doc-missing-type"},{"line_number":88,"context_line":"plugins/modules/os_security_group_rule.py validate-modules:parameter-type-not-in-doc"}],"source_content_type":"text/plain","patch_set":6,"id":"3fa7e38b_feec7a92","line":85,"updated":"2020-02-19 11:27:09.000000000","message":"For my personal understanding - what is this all about?","commit_id":"72944f1a3a3bb2642fa86fa595881dc99409d91d"}]}