)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4767ce6da293900885b5aff420366c8440e765ed","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-02-17 15:20:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add os_server_tag module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I989265c975829484f11b55c7af4df5ce0b4d222b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_de6a0582","line":8,"updated":"2020-02-17 16:00:44.000000000","message":"Did you think of adding this to the os_server module? If so, please provide your rationale for not doing so.\n\nI don\u0027t know whether a new module or adding to os_server is the best approach, but I am interested in your rationale for choosing this approach.","commit_id":"ed453b8464ed55d688b7068b6d0821c83e31d3ca"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3dd467682c1b3a8115114e47d737726356096006","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-02-17 15:20:17 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"add os_server_tag module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I989265c975829484f11b55c7af4df5ce0b4d222b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_7ecf518a","line":8,"in_reply_to":"3fa7e38b_de6a0582","updated":"2020-02-17 16:03:08.000000000","message":"Oh, and please add tests like has been done in https://review.opendev.org/#/c/705719/1 so that we can see the module in action.","commit_id":"ed453b8464ed55d688b7068b6d0821c83e31d3ca"}],"plugins/modules/os_server_tag.py":[{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"567f52614143384fe4ea1d1c8cff8bdf7f14a741","unresolved":false,"context_lines":[{"line_number":40,"context_line":"       - Key and value for tags"},{"line_number":41,"context_line":"     required: true"},{"line_number":42,"context_line":"     type: list"},{"line_number":43,"context_line":"   availability_zone:"},{"line_number":44,"context_line":"     description:"},{"line_number":45,"context_line":"       - Ignored. Present for backwards compatibility"},{"line_number":46,"context_line":"     type: str"},{"line_number":47,"context_line":"requirements:"},{"line_number":48,"context_line":"    - \"python \u003e\u003d 2.7\""},{"line_number":49,"context_line":"    - \"openstacksdk \u003e\u003d 0.21.0\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_ad3cc52d","line":46,"range":{"start_line":43,"start_character":0,"end_line":46,"end_character":14},"updated":"2020-02-17 14:19:40.000000000","message":"It would seem that this is unnecessary for a new module?","commit_id":"fbe2f98fbf80695bca6331f2172af07447f3c316"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"4767ce6da293900885b5aff420366c8440e765ed","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    tags \u003d module.params[\u0027tags\u0027]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    conn \u003d connect()"},{"line_number":101,"context_line":"    sdk, cloud \u003d openstack_cloud_from_module(module)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    try:"},{"line_number":104,"context_line":"        changed \u003d False"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_3ea1d9f7","line":101,"range":{"start_line":101,"start_character":44,"end_line":101,"end_character":52},"updated":"2020-02-17 16:00:44.000000000","message":"The min_version should be specified here if it is different to the base min_version(0.12.0).","commit_id":"ed453b8464ed55d688b7068b6d0821c83e31d3ca"}]}
