)]}'
{"changelogs/fragments/62062-os_network-openstacksdk-min.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"80237822099847161edc710363da7c5b4cf938cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"bugfixes:"},{"line_number":2,"context_line":"  - bump the minimum openstacksdk version when os_network"},{"line_number":3,"context_line":"    uses the port_security_enabled or mtu arguments"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_9d532216","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":9},"updated":"2020-02-18 12:29:07.000000000","message":"It\u0027s called fixes, not bugfixes","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e2b60998a83ed1d56c1b6dcce3288302f8f78f6a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"bugfixes:"},{"line_number":2,"context_line":"  - bump the minimum openstacksdk version when os_network"},{"line_number":3,"context_line":"    uses the port_security_enabled or mtu arguments"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_1ddbb27a","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":9},"in_reply_to":"3fa7e38b_1dadf2e6","updated":"2020-02-18 12:33:16.000000000","message":"Ooops, sorry, I mixed it up with OpenStack release notes.","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"3e6b36237224a2c4184d9c078c180b1dc0765f69","unresolved":false,"context_lines":[{"line_number":1,"context_line":"bugfixes:"},{"line_number":2,"context_line":"  - bump the minimum openstacksdk version when os_network"},{"line_number":3,"context_line":"    uses the port_security_enabled or mtu arguments"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_1dadf2e6","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":9},"in_reply_to":"3fa7e38b_9d532216","updated":"2020-02-18 12:31:05.000000000","message":"Not according to https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"80237822099847161edc710363da7c5b4cf938cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"bugfixes:"},{"line_number":2,"context_line":"  - bump the minimum openstacksdk version when os_network"},{"line_number":3,"context_line":"    uses the port_security_enabled or mtu arguments"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_1d3f32b3","line":2,"updated":"2020-02-18 12:29:07.000000000","message":"\"Bump\", and let\u0027s mention the new version.","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"}],"plugins/modules/os_network.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9382c6156a19fe00139806f2386a14ff71960017","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    net_create_kwargs \u003d {}"},{"line_number":199,"context_line":"    min_version \u003d None"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    if module.params[\u0027mtu\u0027] is not None:"},{"line_number":202,"context_line":"        min_version \u003d \u00270.18.0\u0027"},{"line_number":203,"context_line":"        net_create_kwargs[\u0027mtu_size\u0027] \u003d module.params[\u0027mtu\u0027]"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    if module.params[\u0027port_security_enabled\u0027] is not None:"},{"line_number":206,"context_line":"        min_version \u003d \u00270.18.0\u0027"},{"line_number":207,"context_line":"        net_create_kwargs[\u0027port_security_enabled\u0027] \u003d module.params[\u0027port_security_enabled\u0027]"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    if module.params[\u0027dns_domain\u0027] is not None:"},{"line_number":210,"context_line":"        min_version \u003d \u00270.29.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ab481b89","line":207,"range":{"start_line":201,"start_character":0,"end_line":207,"end_character":91},"updated":"2020-02-18 12:20:18.000000000","message":"I think you can just do like:\n\nmin_version \u003d None\nnet_create_kwargs \u003d {\n        \u0027port_security_enabled\u0027: module.params[\u0027port_security_enabled\u0027],\n        \u0027mtu_size\u0027: module.params[\u0027mtu\u0027]\n    }\n\nif module.params[\u0027mtu\u0027] is not None or module.params[\u0027port_security_enabled\u0027] is not None:\n    min_version \u003d \u00270.18.0\u0027\nif module.params[\u0027dns_domain\u0027] is not None:\n    min_version \u003d \u00270.29.0\u0027\n\nIt doesn\u0027t make sense to add one by one, if there is even only one version conflict - it will just return error for all.","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"68ddb91f4c79ffb03130d1cd898108b93c50a655","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    net_create_kwargs \u003d {}"},{"line_number":199,"context_line":"    min_version \u003d None"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    if module.params[\u0027mtu\u0027] is not None:"},{"line_number":202,"context_line":"        min_version \u003d \u00270.18.0\u0027"},{"line_number":203,"context_line":"        net_create_kwargs[\u0027mtu_size\u0027] \u003d module.params[\u0027mtu\u0027]"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    if module.params[\u0027port_security_enabled\u0027] is not None:"},{"line_number":206,"context_line":"        min_version \u003d \u00270.18.0\u0027"},{"line_number":207,"context_line":"        net_create_kwargs[\u0027port_security_enabled\u0027] \u003d module.params[\u0027port_security_enabled\u0027]"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    if module.params[\u0027dns_domain\u0027] is not None:"},{"line_number":210,"context_line":"        min_version \u003d \u00270.29.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ddfbda11","line":207,"range":{"start_line":201,"start_character":0,"end_line":207,"end_character":91},"in_reply_to":"3fa7e38b_ab481b89","updated":"2020-02-18 12:25:09.000000000","message":"We can\u0027t pass them in the net_create_kwargs if the underlying sdk does not support those arguments. That is why we only check if the underlying sdk supports it if they\u0027re populated.\n\nOf course another way to do this is to selectively pop any entry that is none off the dict, but it seems much the same to me.","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"89b2fc373c954b54b0555de21dafb60e9314c0dc","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    net_create_kwargs \u003d {}"},{"line_number":199,"context_line":"    min_version \u003d None"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    if module.params[\u0027mtu\u0027] is not None:"},{"line_number":202,"context_line":"        min_version \u003d \u00270.18.0\u0027"},{"line_number":203,"context_line":"        net_create_kwargs[\u0027mtu_size\u0027] \u003d module.params[\u0027mtu\u0027]"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    if module.params[\u0027port_security_enabled\u0027] is not None:"},{"line_number":206,"context_line":"        min_version \u003d \u00270.18.0\u0027"},{"line_number":207,"context_line":"        net_create_kwargs[\u0027port_security_enabled\u0027] \u003d module.params[\u0027port_security_enabled\u0027]"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    if module.params[\u0027dns_domain\u0027] is not None:"},{"line_number":210,"context_line":"        min_version \u003d \u00270.29.0\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ddce7ab5","line":207,"range":{"start_line":201,"start_character":0,"end_line":207,"end_character":91},"in_reply_to":"3fa7e38b_ddfbda11","updated":"2020-02-18 12:33:49.000000000","message":"ack, fine by me","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9382c6156a19fe00139806f2386a14ff71960017","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        min_version \u003d \u00270.29.0\u0027"},{"line_number":211,"context_line":"        net_create_kwargs[\u0027dns_domain\u0027] \u003d module.params[\u0027dns_domain\u0027]"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    if min_version is not None:"},{"line_number":214,"context_line":"        sdk, cloud \u003d openstack_cloud_from_module(module, min_version)"},{"line_number":215,"context_line":"    else:"},{"line_number":216,"context_line":"        sdk, cloud \u003d openstack_cloud_from_module(module)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    try:"},{"line_number":219,"context_line":"        if project is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_cb89d7c8","line":216,"range":{"start_line":213,"start_character":0,"end_line":216,"end_character":56},"updated":"2020-02-18 12:20:18.000000000","message":"you can just always pass min_version, None is totally fine","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e9e833d9c8154ebb0d925a2397bd9c5bff4c8cea","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        min_version \u003d \u00270.29.0\u0027"},{"line_number":211,"context_line":"        net_create_kwargs[\u0027dns_domain\u0027] \u003d module.params[\u0027dns_domain\u0027]"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    if min_version is not None:"},{"line_number":214,"context_line":"        sdk, cloud \u003d openstack_cloud_from_module(module, min_version)"},{"line_number":215,"context_line":"    else:"},{"line_number":216,"context_line":"        sdk, cloud \u003d openstack_cloud_from_module(module)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    try:"},{"line_number":219,"context_line":"        if project is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_bd57fecc","line":216,"range":{"start_line":213,"start_character":0,"end_line":216,"end_character":56},"in_reply_to":"3fa7e38b_ab2d7bae","updated":"2020-02-18 12:36:24.000000000","message":"In a brief test that results in min_version\u003dNone, so the version check will always pass which is not what we want. We want the default version (0.12.0) in openstack.py to be checked and we do not want to duplicate that default here.","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"89b2fc373c954b54b0555de21dafb60e9314c0dc","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        min_version \u003d \u00270.29.0\u0027"},{"line_number":211,"context_line":"        net_create_kwargs[\u0027dns_domain\u0027] \u003d module.params[\u0027dns_domain\u0027]"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    if min_version is not None:"},{"line_number":214,"context_line":"        sdk, cloud \u003d openstack_cloud_from_module(module, min_version)"},{"line_number":215,"context_line":"    else:"},{"line_number":216,"context_line":"        sdk, cloud \u003d openstack_cloud_from_module(module)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    try:"},{"line_number":219,"context_line":"        if project is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_fddd766e","line":216,"range":{"start_line":213,"start_character":0,"end_line":216,"end_character":56},"in_reply_to":"3fa7e38b_ab2d7bae","updated":"2020-02-18 12:33:49.000000000","message":"yes, it\u0027s 0.12.0, and it\u0027s default for all modules, so I think it\u0027s fine to use it","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"68ddb91f4c79ffb03130d1cd898108b93c50a655","unresolved":false,"context_lines":[{"line_number":210,"context_line":"        min_version \u003d \u00270.29.0\u0027"},{"line_number":211,"context_line":"        net_create_kwargs[\u0027dns_domain\u0027] \u003d module.params[\u0027dns_domain\u0027]"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    if min_version is not None:"},{"line_number":214,"context_line":"        sdk, cloud \u003d openstack_cloud_from_module(module, min_version)"},{"line_number":215,"context_line":"    else:"},{"line_number":216,"context_line":"        sdk, cloud \u003d openstack_cloud_from_module(module)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    try:"},{"line_number":219,"context_line":"        if project is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ab2d7bae","line":216,"range":{"start_line":213,"start_character":0,"end_line":216,"end_character":56},"in_reply_to":"3fa7e38b_cb89d7c8","updated":"2020-02-18 12:25:09.000000000","message":"Will that take the default from openstack_cloud_from_module then?","commit_id":"a802f52ee88ef4973ff51077f7ed9bd38f7ddaef"}]}