)]}'
{"ci/roles/volume/tasks/main.yml":[{"author":{"_account_id":28022,"name":"Bharat Kunwar","email":"brtknr@bath.edu","username":"brtknr"},"change_message_id":"92d0131f1888df5b7110a11128ffc577ebe2369f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"     display_description: Test volume"},{"line_number":9,"context_line":"  register: vol"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Create voluime backup"},{"line_number":12,"context_line":"  openstack.cloud.os_volume_backup:"},{"line_number":13,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":14,"context_line":"    state: present"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df33271e_06a2ae4b","line":11,"range":{"start_line":11,"start_character":19,"end_line":11,"end_character":20},"updated":"2020-04-08 15:45:06.000000000","message":"extra i","commit_id":"9ba219d45b1ec0480c6a59545098a96f7ed683ca"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2142274dd081130f11fb2f547ad7b7194d2f3c78","unresolved":false,"context_lines":[{"line_number":8,"context_line":"     display_description: Test volume"},{"line_number":9,"context_line":"  register: vol"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- name: Create volume backup"},{"line_number":12,"context_line":"  openstack.cloud.os_volume_backup:"},{"line_number":13,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":14,"context_line":"    state: present"},{"line_number":15,"context_line":"    display_name: ansible_volume_backup"},{"line_number":16,"context_line":"    volume: ansible_volume"},{"line_number":17,"context_line":"  register: vol_backup"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- debug: var\u003dvol"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f493fa4_3dd6d9c4","line":17,"range":{"start_line":11,"start_character":0,"end_line":17,"end_character":22},"updated":"2020-04-25 07:17:05.000000000","message":"better to add here the same task for checking idempotency","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2142274dd081130f11fb2f547ad7b7194d2f3c78","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"- debug: var\u003dvol_backup"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"- name: Delete volume backup"},{"line_number":24,"context_line":"  openstack.cloud.os_volume_backup:"},{"line_number":25,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":26,"context_line":"    display_name: ansible_volume_backup"},{"line_number":27,"context_line":"    state: absent"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"- name: Delete volume"},{"line_number":30,"context_line":"  openstack.cloud.os_volume:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f493fa4_9de56dab","line":27,"range":{"start_line":23,"start_character":0,"end_line":27,"end_character":17},"updated":"2020-04-25 07:17:05.000000000","message":"ditto about idempotency","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"}],"meta/runtime.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5632c9b32f2816f14c7fe51182bb7f1d648cf49f","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    - os_user_role"},{"line_number":269,"context_line":"    - os_user_role"},{"line_number":270,"context_line":"    - os_volume"},{"line_number":271,"context_line":"    - os_volume_backup"},{"line_number":272,"context_line":"    - os_volume_snapshot"},{"line_number":273,"context_line":"    - os_zone"},{"line_number":274,"context_line":"    - os_zone"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f560f44_e68a90ba","line":271,"range":{"start_line":271,"start_character":6,"end_line":271,"end_character":22},"updated":"2020-09-28 18:11:11.000000000","message":"let\u0027s not create deprecated","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f7e84f0f74d6265e5ad9586679825f9dfa366946","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    - os_user_role"},{"line_number":269,"context_line":"    - os_user_role"},{"line_number":270,"context_line":"    - os_volume"},{"line_number":271,"context_line":"    - os_volume_backup"},{"line_number":272,"context_line":"    - os_volume_snapshot"},{"line_number":273,"context_line":"    - os_zone"},{"line_number":274,"context_line":"    - os_zone"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"9f560f44_51b7b4f9","line":271,"range":{"start_line":271,"start_character":6,"end_line":271,"end_character":22},"in_reply_to":"9f560f44_e68a90ba","updated":"2020-09-28 18:42:10.000000000","message":"Done","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"}],"plugins/modules/os_volume_backup.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2e3e7b4282c3d7fbfa711e9a133adbafe160c4af","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    state: absent"},{"line_number":120,"context_line":"\u0027\u0027\u0027"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"import time"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"from ansible_collections.openstack.cloud.plugins.module_utils.openstack import OpenStackModule"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_1f235a07","line":122,"updated":"2020-04-06 11:37:25.000000000","message":"linters: F401 \u0027time\u0027 imported but unused","commit_id":"9ba219d45b1ec0480c6a59545098a96f7ed683ca"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2e3e7b4282c3d7fbfa711e9a133adbafe160c4af","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    state: absent"},{"line_number":120,"context_line":"\u0027\u0027\u0027"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"import time"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"from ansible_collections.openstack.cloud.plugins.module_utils.openstack import OpenStackModule"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_ff0cb695","line":122,"updated":"2020-04-06 11:37:25.000000000","message":"linters: F401 \u0027time\u0027 imported but unused","commit_id":"9ba219d45b1ec0480c6a59545098a96f7ed683ca"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2e3e7b4282c3d7fbfa711e9a133adbafe160c4af","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    state: absent"},{"line_number":120,"context_line":"\u0027\u0027\u0027"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"import time"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"from ansible_collections.openstack.cloud.plugins.module_utils.openstack import OpenStackModule"},{"line_number":125,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_bf77ce08","line":122,"updated":"2020-04-06 11:37:25.000000000","message":"pep8: F401 \u0027time\u0027 imported but unused","commit_id":"9ba219d45b1ec0480c6a59545098a96f7ed683ca"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2e3e7b4282c3d7fbfa711e9a133adbafe160c4af","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def run(self):"},{"line_number":211,"context_line":"        name \u003d self.params[\u0027display_name\u0027]"},{"line_number":212,"context_line":"        description \u003d self.params[\u0027display_description\u0027]"},{"line_number":213,"context_line":"        volume \u003d self.params[\u0027volume\u0027]"},{"line_number":214,"context_line":"        snapshot \u003d self.params[\u0027snapshot\u0027]"},{"line_number":215,"context_line":"        force \u003d self.params[\u0027force\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_7f20a6f8","line":212,"updated":"2020-04-06 11:37:25.000000000","message":"linters: F841 local variable \u0027description\u0027 is assigned to but never used","commit_id":"9ba219d45b1ec0480c6a59545098a96f7ed683ca"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2e3e7b4282c3d7fbfa711e9a133adbafe160c4af","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def run(self):"},{"line_number":211,"context_line":"        name \u003d self.params[\u0027display_name\u0027]"},{"line_number":212,"context_line":"        description \u003d self.params[\u0027display_description\u0027]"},{"line_number":213,"context_line":"        volume \u003d self.params[\u0027volume\u0027]"},{"line_number":214,"context_line":"        snapshot \u003d self.params[\u0027snapshot\u0027]"},{"line_number":215,"context_line":"        force \u003d self.params[\u0027force\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_df11f2ae","line":212,"updated":"2020-04-06 11:37:25.000000000","message":"linters: F841 local variable \u0027description\u0027 is assigned to but never used","commit_id":"9ba219d45b1ec0480c6a59545098a96f7ed683ca"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2e3e7b4282c3d7fbfa711e9a133adbafe160c4af","unresolved":false,"context_lines":[{"line_number":209,"context_line":""},{"line_number":210,"context_line":"    def run(self):"},{"line_number":211,"context_line":"        name \u003d self.params[\u0027display_name\u0027]"},{"line_number":212,"context_line":"        description \u003d self.params[\u0027display_description\u0027]"},{"line_number":213,"context_line":"        volume \u003d self.params[\u0027volume\u0027]"},{"line_number":214,"context_line":"        snapshot \u003d self.params[\u0027snapshot\u0027]"},{"line_number":215,"context_line":"        force \u003d self.params[\u0027force\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_9f7c8aec","line":212,"updated":"2020-04-06 11:37:25.000000000","message":"pep8: F841 local variable \u0027description\u0027 is assigned to but never used","commit_id":"9ba219d45b1ec0480c6a59545098a96f7ed683ca"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2e3e7b4282c3d7fbfa711e9a133adbafe160c4af","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        metadata \u003d self.params[\u0027metadata\u0027]"},{"line_number":218,"context_line":"        timeout \u003d self.params[\u0027timeout\u0027]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        data \u003d None"},{"line_number":221,"context_line":"        changed \u003d False"},{"line_number":222,"context_line":"        backup \u003d None"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_3f261e18","line":220,"updated":"2020-04-06 11:37:25.000000000","message":"linters: F841 local variable \u0027data\u0027 is assigned to but never used","commit_id":"9ba219d45b1ec0480c6a59545098a96f7ed683ca"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2e3e7b4282c3d7fbfa711e9a133adbafe160c4af","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        metadata \u003d self.params[\u0027metadata\u0027]"},{"line_number":218,"context_line":"        timeout \u003d self.params[\u0027timeout\u0027]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        data \u003d None"},{"line_number":221,"context_line":"        changed \u003d False"},{"line_number":222,"context_line":"        backup \u003d None"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_5f1de2bb","line":220,"updated":"2020-04-06 11:37:25.000000000","message":"linters: F841 local variable \u0027data\u0027 is assigned to but never used","commit_id":"9ba219d45b1ec0480c6a59545098a96f7ed683ca"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2e3e7b4282c3d7fbfa711e9a133adbafe160c4af","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        metadata \u003d self.params[\u0027metadata\u0027]"},{"line_number":218,"context_line":"        timeout \u003d self.params[\u0027timeout\u0027]"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        data \u003d None"},{"line_number":221,"context_line":"        changed \u003d False"},{"line_number":222,"context_line":"        backup \u003d None"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_ff8156c5","line":220,"updated":"2020-04-06 11:37:25.000000000","message":"pep8: F841 local variable \u0027data\u0027 is assigned to but never used","commit_id":"9ba219d45b1ec0480c6a59545098a96f7ed683ca"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2142274dd081130f11fb2f547ad7b7194d2f3c78","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        force\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":123,"context_line":"        metadata\u003ddict(default\u003dNone, type\u003d\u0027dict\u0027),"},{"line_number":124,"context_line":"        incremental\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":125,"context_line":"        wait\u003ddict(type\u003d\u0027bool\u0027, default\u003dTrue),"},{"line_number":126,"context_line":"        timeout\u003ddict(type\u003d\u0027int\u0027, default\u003d180)"},{"line_number":127,"context_line":"    )"},{"line_number":128,"context_line":"    module_kwargs \u003d dict("},{"line_number":129,"context_line":"        required_if\u003d["}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_ddc7f511","line":126,"range":{"start_line":125,"start_character":8,"end_line":126,"end_character":45},"updated":"2020-04-25 07:17:05.000000000","message":"this is already included: https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/module_utils/openstack.py#L93-L94","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"788d4bbdf8ae1bdb7ca806aa280868ed679fdbd0","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        force\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":123,"context_line":"        metadata\u003ddict(default\u003dNone, type\u003d\u0027dict\u0027),"},{"line_number":124,"context_line":"        incremental\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":125,"context_line":"        wait\u003ddict(type\u003d\u0027bool\u0027, default\u003dTrue),"},{"line_number":126,"context_line":"        timeout\u003ddict(type\u003d\u0027int\u0027, default\u003d180)"},{"line_number":127,"context_line":"    )"},{"line_number":128,"context_line":"    module_kwargs \u003d dict("},{"line_number":129,"context_line":"        required_if\u003d["}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_05129662","line":126,"range":{"start_line":125,"start_character":8,"end_line":126,"end_character":45},"in_reply_to":"1f493fa4_ddc7f511","updated":"2020-07-09 14:11:23.000000000","message":"cool","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2142274dd081130f11fb2f547ad7b7194d2f3c78","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def _system_state_change(self, obj):"},{"line_number":136,"context_line":"        state \u003d self.params[\u0027state\u0027]"},{"line_number":137,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":138,"context_line":"            if not object:"},{"line_number":139,"context_line":"                return True"},{"line_number":140,"context_line":"        elif state \u003d\u003d \u0027absent\u0027 and obj:"},{"line_number":141,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_dd79b5fc","line":138,"range":{"start_line":138,"start_character":19,"end_line":138,"end_character":25},"updated":"2020-04-25 07:17:05.000000000","message":"should be \"obj\"?","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"788d4bbdf8ae1bdb7ca806aa280868ed679fdbd0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def _system_state_change(self, obj):"},{"line_number":136,"context_line":"        state \u003d self.params[\u0027state\u0027]"},{"line_number":137,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":138,"context_line":"            if not object:"},{"line_number":139,"context_line":"                return True"},{"line_number":140,"context_line":"        elif state \u003d\u003d \u0027absent\u0027 and obj:"},{"line_number":141,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_c51b8e7e","line":138,"range":{"start_line":138,"start_character":19,"end_line":138,"end_character":25},"in_reply_to":"1f493fa4_dd79b5fc","updated":"2020-07-09 14:11:23.000000000","message":"Done","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2142274dd081130f11fb2f547ad7b7194d2f3c78","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                return True"},{"line_number":140,"context_line":"        elif state \u003d\u003d \u0027absent\u0027 and obj:"},{"line_number":141,"context_line":"            return True"},{"line_number":142,"context_line":"        return False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def find_backup(self, backup):"},{"line_number":145,"context_line":"        res \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_1d84bdd3","line":142,"range":{"start_line":142,"start_character":1,"end_line":142,"end_character":20},"updated":"2020-04-25 07:17:05.000000000","message":"can be just\nreturn (self.params[\u0027state\u0027] \u003d\u003d \u0027absent\u0027 and obj)\nor (self.params[\u0027state\u0027] \u003d\u003d \u0027present\u0027 and not obj)","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"788d4bbdf8ae1bdb7ca806aa280868ed679fdbd0","unresolved":false,"context_lines":[{"line_number":139,"context_line":"                return True"},{"line_number":140,"context_line":"        elif state \u003d\u003d \u0027absent\u0027 and obj:"},{"line_number":141,"context_line":"            return True"},{"line_number":142,"context_line":"        return False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def find_backup(self, backup):"},{"line_number":145,"context_line":"        res \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_6529da99","line":142,"range":{"start_line":142,"start_character":1,"end_line":142,"end_character":20},"in_reply_to":"1f493fa4_1d84bdd3","updated":"2020-07-09 14:11:23.000000000","message":"initially this condition is simple, but we might want to check additional properties (to figure out whether we need an update), i.e. description, metadata. Therefore I do not think such simplification is helpful in the long run","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"2142274dd081130f11fb2f547ad7b7194d2f3c78","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            return True"},{"line_number":142,"context_line":"        return False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def find_backup(self, backup):"},{"line_number":145,"context_line":"        res \u003d None"},{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            res \u003d self.conn.block_storage.get_backup(backup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_5d56455e","line":144,"range":{"start_line":144,"start_character":9,"end_line":144,"end_character":20},"updated":"2020-04-25 07:17:05.000000000","message":"just thought, all these \"find\" functions are good candidates for openstackSDK methods","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"788d4bbdf8ae1bdb7ca806aa280868ed679fdbd0","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            return True"},{"line_number":142,"context_line":"        return False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def find_backup(self, backup):"},{"line_number":145,"context_line":"        res \u003d None"},{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            res \u003d self.conn.block_storage.get_backup(backup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1f493fa4_857ea6ac","line":144,"range":{"start_line":144,"start_character":9,"end_line":144,"end_character":20},"in_reply_to":"1f493fa4_5d56455e","updated":"2020-07-09 14:11:23.000000000","message":"that\u0027s true. The only problem is that those are currently note implemented. Relying on those meaning waiting for another SDK release. Do we want that?","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9d8f817fdb76d7712881580180659a87c3fe31","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            return True"},{"line_number":142,"context_line":"        return False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def find_backup(self, backup):"},{"line_number":145,"context_line":"        res \u003d None"},{"line_number":146,"context_line":"        try:"},{"line_number":147,"context_line":"            res \u003d self.conn.block_storage.get_backup(backup)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9f560f44_80e57ca7","line":144,"range":{"start_line":144,"start_character":9,"end_line":144,"end_character":20},"in_reply_to":"1f493fa4_857ea6ac","updated":"2020-09-28 18:00:39.000000000","message":"I\u0027d like to have such option.","commit_id":"07b6a67a0b834e200534e6ba5521082d3b1797d5"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9d8f817fdb76d7712881580180659a87c3fe31","unresolved":false,"context_lines":[{"line_number":1,"context_line":"volume_backup.py"}],"source_content_type":"x-git/symlink","patch_set":11,"id":"9f560f44_c0fe5438","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":16},"updated":"2020-09-28 18:00:39.000000000","message":"let\u0027s not create a module with deprecated naming","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9549ba3783e66a6330956b710773e75baed01bb1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"volume_backup.py"}],"source_content_type":"x-git/symlink","patch_set":11,"id":"9f560f44_4f2a6391","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":16},"in_reply_to":"9f560f44_c0fe5438","updated":"2020-09-29 13:14:06.000000000","message":"Still exists","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5ffe3cdb0ad06933fd8db92014bf4f8e1ef59c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9f560f44_515df47a","line":103,"updated":"2020-09-28 18:50:52.000000000","message":"linters-2.9: E201 whitespace after \u0027(\u0027","commit_id":"ba13fd7bc2db90601bb1bce0b12dadc8f9f20cf4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5ffe3cdb0ad06933fd8db92014bf4f8e1ef59c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9f560f44_3162003f","line":103,"updated":"2020-09-28 18:50:52.000000000","message":"linters: E201 whitespace after \u0027(\u0027","commit_id":"ba13fd7bc2db90601bb1bce0b12dadc8f9f20cf4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5ffe3cdb0ad06933fd8db92014bf4f8e1ef59c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9f560f44_f16ec82a","line":103,"updated":"2020-09-28 18:50:52.000000000","message":"linters: E201 whitespace after \u0027(\u0027","commit_id":"ba13fd7bc2db90601bb1bce0b12dadc8f9f20cf4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5ffe3cdb0ad06933fd8db92014bf4f8e1ef59c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"9f560f44_91578c5b","line":103,"updated":"2020-09-28 18:50:52.000000000","message":"pep8: E201 whitespace after \u0027(\u0027","commit_id":"ba13fd7bc2db90601bb1bce0b12dadc8f9f20cf4"}],"plugins/modules/volume_backup.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9d8f817fdb76d7712881580180659a87c3fe31","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# Copyright (c) 2020 by Open Telekom Cloud, operated by T-Systems International GmbH"},{"line_number":5,"context_line":"# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"ANSIBLE_METADATA \u003d {\u0027metadata_version\u0027: \u00271.1\u0027,"},{"line_number":9,"context_line":"                    \u0027status\u0027: [\u0027preview\u0027],"},{"line_number":10,"context_line":"                    \u0027supported_by\u0027: \u0027community\u0027}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":13,"context_line":"---"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_409084f4","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":48},"updated":"2020-09-28 18:00:39.000000000","message":"this is not needed anymore","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f7e84f0f74d6265e5ad9586679825f9dfa366946","unresolved":false,"context_lines":[{"line_number":4,"context_line":"# Copyright (c) 2020 by Open Telekom Cloud, operated by T-Systems International GmbH"},{"line_number":5,"context_line":"# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"ANSIBLE_METADATA \u003d {\u0027metadata_version\u0027: \u00271.1\u0027,"},{"line_number":9,"context_line":"                    \u0027status\u0027: [\u0027preview\u0027],"},{"line_number":10,"context_line":"                    \u0027supported_by\u0027: \u0027community\u0027}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":13,"context_line":"---"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_91b14c05","line":10,"range":{"start_line":7,"start_character":0,"end_line":10,"end_character":48},"in_reply_to":"9f560f44_409084f4","updated":"2020-09-28 18:42:10.000000000","message":"Yeah, missed that","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9d8f817fdb76d7712881580180659a87c3fe31","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    type: bool"},{"line_number":58,"context_line":"    default: False"},{"line_number":59,"context_line":"  wait:"},{"line_number":60,"context_line":"    description:"},{"line_number":61,"context_line":"      - If the module should wait for the cluster to be created or deleted."},{"line_number":62,"context_line":"    type: bool"},{"line_number":63,"context_line":"    default: \u0027yes\u0027"},{"line_number":64,"context_line":"  timeout:"},{"line_number":65,"context_line":"    description:"},{"line_number":66,"context_line":"      - The amount of time the module should wait."},{"line_number":67,"context_line":"    default: 180"},{"line_number":68,"context_line":"    type: int"},{"line_number":69,"context_line":"requirements: [\"openstacksdk\"]"},{"line_number":70,"context_line":"\u0027\u0027\u0027"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_e08a78ba","line":68,"range":{"start_line":60,"start_character":0,"end_line":68,"end_character":13},"updated":"2020-09-28 18:00:39.000000000","message":"this is included in OpenstackModule class","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f7e84f0f74d6265e5ad9586679825f9dfa366946","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    type: bool"},{"line_number":58,"context_line":"    default: False"},{"line_number":59,"context_line":"  wait:"},{"line_number":60,"context_line":"    description:"},{"line_number":61,"context_line":"      - If the module should wait for the cluster to be created or deleted."},{"line_number":62,"context_line":"    type: bool"},{"line_number":63,"context_line":"    default: \u0027yes\u0027"},{"line_number":64,"context_line":"  timeout:"},{"line_number":65,"context_line":"    description:"},{"line_number":66,"context_line":"      - The amount of time the module should wait."},{"line_number":67,"context_line":"    default: 180"},{"line_number":68,"context_line":"    type: int"},{"line_number":69,"context_line":"requirements: [\"openstacksdk\"]"},{"line_number":70,"context_line":"\u0027\u0027\u0027"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_71b638fc","line":68,"range":{"start_line":60,"start_character":0,"end_line":68,"end_character":13},"in_reply_to":"9f560f44_e08a78ba","updated":"2020-09-28 18:42:10.000000000","message":"Done","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5632c9b32f2816f14c7fe51182bb7f1d648cf49f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"backup:"},{"line_number":79,"context_line":"    description: Dictionary describing the Cluster."},{"line_number":80,"context_line":"    returned: On success when C(state\u003dpresent)"},{"line_number":81,"context_line":"    type: complex"},{"line_number":82,"context_line":"    contains:"},{"line_number":83,"context_line":"        id:"},{"line_number":84,"context_line":"            description: Unique UUID."}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_c65aec4f","line":81,"range":{"start_line":81,"start_character":10,"end_line":81,"end_character":17},"updated":"2020-09-28 18:11:11.000000000","message":"it looks like a dictionary","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f7e84f0f74d6265e5ad9586679825f9dfa366946","unresolved":false,"context_lines":[{"line_number":78,"context_line":"backup:"},{"line_number":79,"context_line":"    description: Dictionary describing the Cluster."},{"line_number":80,"context_line":"    returned: On success when C(state\u003dpresent)"},{"line_number":81,"context_line":"    type: complex"},{"line_number":82,"context_line":"    contains:"},{"line_number":83,"context_line":"        id:"},{"line_number":84,"context_line":"            description: Unique UUID."}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_71abd887","line":81,"range":{"start_line":81,"start_character":10,"end_line":81,"end_character":17},"in_reply_to":"9f560f44_c65aec4f","updated":"2020-09-28 18:42:10.000000000","message":"Well, so to speaking everything is a dictionary. Previously in modules \"complex\" was used.","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5632c9b32f2816f14c7fe51182bb7f1d648cf49f","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"EXAMPLES \u003d \u0027\u0027\u0027"},{"line_number":94,"context_line":"- name: Create backup"},{"line_number":95,"context_line":"  volume_backup:"},{"line_number":96,"context_line":"    display_name: test_volume_backup"},{"line_number":97,"context_line":"    volume: \"test_volume\""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_86b3d49a","line":95,"range":{"start_line":95,"start_character":1,"end_line":95,"end_character":16},"updated":"2020-09-28 18:11:11.000000000","message":"I\u0027d add openstack.cloud.volume_backup for clarity","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f7e84f0f74d6265e5ad9586679825f9dfa366946","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"EXAMPLES \u003d \u0027\u0027\u0027"},{"line_number":94,"context_line":"- name: Create backup"},{"line_number":95,"context_line":"  volume_backup:"},{"line_number":96,"context_line":"    display_name: test_volume_backup"},{"line_number":97,"context_line":"    volume: \"test_volume\""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_d18f442d","line":95,"range":{"start_line":95,"start_character":1,"end_line":95,"end_character":16},"in_reply_to":"9f560f44_86b3d49a","updated":"2020-09-28 18:42:10.000000000","message":"Done","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5632c9b32f2816f14c7fe51182bb7f1d648cf49f","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class VolumeBackupModule(OpenStackModule):"},{"line_number":115,"context_line":"    argument_spec \u003d dict("},{"line_number":116,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027]),"},{"line_number":117,"context_line":"        display_description\u003ddict(default\u003dNone, aliases\u003d[\u0027description\u0027]),"},{"line_number":118,"context_line":"        volume\u003ddict(),"},{"line_number":119,"context_line":"        snapshot\u003ddict(default\u003dNone),"},{"line_number":120,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"},{"line_number":121,"context_line":"        force\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":122,"context_line":"        metadata\u003ddict(default\u003dNone, type\u003d\u0027dict\u0027),"},{"line_number":123,"context_line":"        incremental\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_666de002","line":120,"range":{"start_line":116,"start_character":8,"end_line":120,"end_character":69},"updated":"2020-09-28 18:11:11.000000000","message":"there are no types of variables\n\ndefault\u003dNone no need to specify, all of options w/o default specified have it","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"bda03d652efe7c75105fb76a81c669b24e6244b9","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class VolumeBackupModule(OpenStackModule):"},{"line_number":115,"context_line":"    argument_spec \u003d dict("},{"line_number":116,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027]),"},{"line_number":117,"context_line":"        display_description\u003ddict(default\u003dNone, aliases\u003d[\u0027description\u0027]),"},{"line_number":118,"context_line":"        volume\u003ddict(),"},{"line_number":119,"context_line":"        snapshot\u003ddict(default\u003dNone),"},{"line_number":120,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"},{"line_number":121,"context_line":"        force\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":122,"context_line":"        metadata\u003ddict(default\u003dNone, type\u003d\u0027dict\u0027),"},{"line_number":123,"context_line":"        incremental\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_f21d1763","line":120,"range":{"start_line":116,"start_character":8,"end_line":120,"end_character":69},"in_reply_to":"9f560f44_4f55431e","updated":"2020-09-29 16:58:06.000000000","message":"Those are not really required","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f7e84f0f74d6265e5ad9586679825f9dfa366946","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class VolumeBackupModule(OpenStackModule):"},{"line_number":115,"context_line":"    argument_spec \u003d dict("},{"line_number":116,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027]),"},{"line_number":117,"context_line":"        display_description\u003ddict(default\u003dNone, aliases\u003d[\u0027description\u0027]),"},{"line_number":118,"context_line":"        volume\u003ddict(),"},{"line_number":119,"context_line":"        snapshot\u003ddict(default\u003dNone),"},{"line_number":120,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"},{"line_number":121,"context_line":"        force\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":122,"context_line":"        metadata\u003ddict(default\u003dNone, type\u003d\u0027dict\u0027),"},{"line_number":123,"context_line":"        incremental\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_b18c503a","line":120,"range":{"start_line":116,"start_character":8,"end_line":120,"end_character":69},"in_reply_to":"9f560f44_666de002","updated":"2020-09-28 18:42:10.000000000","message":"Done","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9549ba3783e66a6330956b710773e75baed01bb1","unresolved":false,"context_lines":[{"line_number":113,"context_line":""},{"line_number":114,"context_line":"class VolumeBackupModule(OpenStackModule):"},{"line_number":115,"context_line":"    argument_spec \u003d dict("},{"line_number":116,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027]),"},{"line_number":117,"context_line":"        display_description\u003ddict(default\u003dNone, aliases\u003d[\u0027description\u0027]),"},{"line_number":118,"context_line":"        volume\u003ddict(),"},{"line_number":119,"context_line":"        snapshot\u003ddict(default\u003dNone),"},{"line_number":120,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"},{"line_number":121,"context_line":"        force\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":122,"context_line":"        metadata\u003ddict(default\u003dNone, type\u003d\u0027dict\u0027),"},{"line_number":123,"context_line":"        incremental\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_4f55431e","line":120,"range":{"start_line":116,"start_character":8,"end_line":120,"end_character":69},"in_reply_to":"9f560f44_b18c503a","updated":"2020-09-29 13:14:06.000000000","message":"Still no types","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9d8f817fdb76d7712881580180659a87c3fe31","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        force\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":122,"context_line":"        metadata\u003ddict(default\u003dNone, type\u003d\u0027dict\u0027),"},{"line_number":123,"context_line":"        incremental\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":124,"context_line":"        wait\u003ddict(type\u003d\u0027bool\u0027, default\u003dTrue),"},{"line_number":125,"context_line":"        timeout\u003ddict(type\u003d\u0027int\u0027, default\u003d180)"},{"line_number":126,"context_line":"    )"},{"line_number":127,"context_line":"    module_kwargs \u003d dict("},{"line_number":128,"context_line":"        required_if\u003d["}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_80b3bc9a","line":125,"range":{"start_line":124,"start_character":1,"end_line":125,"end_character":45},"updated":"2020-09-28 18:00:39.000000000","message":"this is included already in OpenstackModule class","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f7e84f0f74d6265e5ad9586679825f9dfa366946","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        force\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":122,"context_line":"        metadata\u003ddict(default\u003dNone, type\u003d\u0027dict\u0027),"},{"line_number":123,"context_line":"        incremental\u003ddict(default\u003dFalse, type\u003d\u0027bool\u0027),"},{"line_number":124,"context_line":"        wait\u003ddict(type\u003d\u0027bool\u0027, default\u003dTrue),"},{"line_number":125,"context_line":"        timeout\u003ddict(type\u003d\u0027int\u0027, default\u003d180)"},{"line_number":126,"context_line":"    )"},{"line_number":127,"context_line":"    module_kwargs \u003d dict("},{"line_number":128,"context_line":"        required_if\u003d["}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_9194ac38","line":125,"range":{"start_line":124,"start_character":1,"end_line":125,"end_character":45},"in_reply_to":"9f560f44_80b3bc9a","updated":"2020-09-28 18:42:10.000000000","message":"Done","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9d8f817fdb76d7712881580180659a87c3fe31","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def _system_state_change(self, obj):"},{"line_number":135,"context_line":"        state \u003d self.params[\u0027state\u0027]"},{"line_number":136,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":137,"context_line":"            if not object:"},{"line_number":138,"context_line":"                return True"},{"line_number":139,"context_line":"        elif state \u003d\u003d \u0027absent\u0027 and obj:"},{"line_number":140,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_e0a39842","line":137,"range":{"start_line":137,"start_character":19,"end_line":137,"end_character":25},"updated":"2020-09-28 18:00:39.000000000","message":"obj?","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f7e84f0f74d6265e5ad9586679825f9dfa366946","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def _system_state_change(self, obj):"},{"line_number":135,"context_line":"        state \u003d self.params[\u0027state\u0027]"},{"line_number":136,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":137,"context_line":"            if not object:"},{"line_number":138,"context_line":"                return True"},{"line_number":139,"context_line":"        elif state \u003d\u003d \u0027absent\u0027 and obj:"},{"line_number":140,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_7199186c","line":137,"range":{"start_line":137,"start_character":19,"end_line":137,"end_character":25},"in_reply_to":"9f560f44_e0a39842","updated":"2020-09-28 18:42:10.000000000","message":"Done","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5632c9b32f2816f14c7fe51182bb7f1d648cf49f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        if self.ansible.check_mode:"},{"line_number":158,"context_line":"            self.exit_json(changed\u003dself._system_state_change(backup))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if self.params[\u0027state\u0027] \u003d\u003d \u0027present\u0027:"},{"line_number":161,"context_line":"            if not backup:"},{"line_number":162,"context_line":"                cloud_volume \u003d self.conn.block_storage.find_volume(volume)"},{"line_number":163,"context_line":"                cloud_snapshot_id \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_860f5438","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":45},"updated":"2020-09-28 18:11:11.000000000","message":"I\u0027d prefer to use separate functions for states like here: https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/modules/server.py#L681-L686 \nbut not blocking on that.","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f7e84f0f74d6265e5ad9586679825f9dfa366946","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        if self.ansible.check_mode:"},{"line_number":158,"context_line":"            self.exit_json(changed\u003dself._system_state_change(backup))"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if self.params[\u0027state\u0027] \u003d\u003d \u0027present\u0027:"},{"line_number":161,"context_line":"            if not backup:"},{"line_number":162,"context_line":"                cloud_volume \u003d self.conn.block_storage.find_volume(volume)"},{"line_number":163,"context_line":"                cloud_snapshot_id \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_d19d8459","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":45},"in_reply_to":"9f560f44_860f5438","updated":"2020-09-28 18:42:10.000000000","message":"Done","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5632c9b32f2816f14c7fe51182bb7f1d648cf49f","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                                \u0027to complete\u0027"},{"line_number":207,"context_line":"                        )"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"            else:"},{"line_number":210,"context_line":"                # Decide whether update is required"},{"line_number":211,"context_line":"                pass"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            self.exit_json("},{"line_number":214,"context_line":"                changed\u003dchanged,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_462c1cb2","line":211,"range":{"start_line":209,"start_character":12,"end_line":211,"end_character":20},"updated":"2020-09-28 18:11:11.000000000","message":"what does it mean?","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"f7e84f0f74d6265e5ad9586679825f9dfa366946","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                                \u0027to complete\u0027"},{"line_number":207,"context_line":"                        )"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"            else:"},{"line_number":210,"context_line":"                # Decide whether update is required"},{"line_number":211,"context_line":"                pass"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"            self.exit_json("},{"line_number":214,"context_line":"                changed\u003dchanged,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9f560f44_71b2b8e7","line":211,"range":{"start_line":209,"start_character":12,"end_line":211,"end_character":20},"in_reply_to":"9f560f44_462c1cb2","updated":"2020-09-28 18:42:10.000000000","message":"updated comment. We might want sometime in future to update some backup properties. So far I do not see real need for that and therefore not implementing currently.","commit_id":"0fcd248d493ff9b9e462f666f00f1e5342a218d4"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5d9a537155e211b1a521b9b340fd3d31071e3c0c","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"class VolumeBackupModule(OpenStackModule):"},{"line_number":101,"context_line":"    argument_spec \u003d dict("},{"line_number":102,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027]),"},{"line_number":103,"context_line":"        display_description\u003ddict( aliases\u003d[\u0027description\u0027]),"},{"line_number":104,"context_line":"        volume\u003ddict(),"},{"line_number":105,"context_line":"        snapshot\u003ddict(),"},{"line_number":106,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_7684690c","line":103,"range":{"start_line":102,"start_character":8,"end_line":103,"end_character":59},"updated":"2020-09-28 23:35:48.000000000","message":"Still need to specify types of variables","commit_id":"ba13fd7bc2db90601bb1bce0b12dadc8f9f20cf4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5ffe3cdb0ad06933fd8db92014bf4f8e1ef59c6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"class VolumeBackupModule(OpenStackModule):"},{"line_number":101,"context_line":"    argument_spec \u003d dict("},{"line_number":102,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027]),"},{"line_number":103,"context_line":"        display_description\u003ddict( aliases\u003d[\u0027description\u0027]),"},{"line_number":104,"context_line":"        volume\u003ddict(),"},{"line_number":105,"context_line":"        snapshot\u003ddict(),"},{"line_number":106,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_d1674452","line":103,"updated":"2020-09-28 18:50:52.000000000","message":"linters-2.9: E201 whitespace after \u0027(\u0027","commit_id":"ba13fd7bc2db90601bb1bce0b12dadc8f9f20cf4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5ffe3cdb0ad06933fd8db92014bf4f8e1ef59c6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"class VolumeBackupModule(OpenStackModule):"},{"line_number":101,"context_line":"    argument_spec \u003d dict("},{"line_number":102,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027]),"},{"line_number":103,"context_line":"        display_description\u003ddict( aliases\u003d[\u0027description\u0027]),"},{"line_number":104,"context_line":"        volume\u003ddict(),"},{"line_number":105,"context_line":"        snapshot\u003ddict(),"},{"line_number":106,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_7183d8cc","line":103,"updated":"2020-09-28 18:50:52.000000000","message":"linters: E201 whitespace after \u0027(\u0027","commit_id":"ba13fd7bc2db90601bb1bce0b12dadc8f9f20cf4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5ffe3cdb0ad06933fd8db92014bf4f8e1ef59c6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"class VolumeBackupModule(OpenStackModule):"},{"line_number":101,"context_line":"    argument_spec \u003d dict("},{"line_number":102,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027]),"},{"line_number":103,"context_line":"        display_description\u003ddict( aliases\u003d[\u0027description\u0027]),"},{"line_number":104,"context_line":"        volume\u003ddict(),"},{"line_number":105,"context_line":"        snapshot\u003ddict(),"},{"line_number":106,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_b164504f","line":103,"updated":"2020-09-28 18:50:52.000000000","message":"linters: E201 whitespace after \u0027(\u0027","commit_id":"ba13fd7bc2db90601bb1bce0b12dadc8f9f20cf4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"b5ffe3cdb0ad06933fd8db92014bf4f8e1ef59c6","unresolved":false,"context_lines":[{"line_number":100,"context_line":"class VolumeBackupModule(OpenStackModule):"},{"line_number":101,"context_line":"    argument_spec \u003d dict("},{"line_number":102,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027]),"},{"line_number":103,"context_line":"        display_description\u003ddict( aliases\u003d[\u0027description\u0027]),"},{"line_number":104,"context_line":"        volume\u003ddict(),"},{"line_number":105,"context_line":"        snapshot\u003ddict(),"},{"line_number":106,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f560f44_11725c13","line":103,"updated":"2020-09-28 18:50:52.000000000","message":"pep8: E201 whitespace after \u0027(\u0027","commit_id":"ba13fd7bc2db90601bb1bce0b12dadc8f9f20cf4"}]}