)]}'
{"id":"openstack%2Fansible-collections-openstack~710296","triplet_id":"openstack%2Fansible-collections-openstack~master~I92d4d1e82935e30ae42a0e14e641cbe36fd6e811","project":"openstack/ansible-collections-openstack","branch":"master","hashtags":[],"change_id":"I92d4d1e82935e30ae42a0e14e641cbe36fd6e811","subject":"Fix W504 and remove exclusion","status":"MERGED","created":"2020-02-27 15:29:28.000000000","updated":"2020-03-02 13:31:35.000000000","submitted":"2020-03-02 13:31:35.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"710296-1583155895680-1d1e633c","meta_rev_id":"1df9fcfe89bbd20340f5518a1aea049adb607497","_number":710296,"virtual_id_number":710296,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-02 13:31:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-02-29 14:12:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":2,"date":"2020-02-27 19:56:52.000000000","_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-02-29 14:12:02.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-02-27 16:19:25.000000000","updated_by":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"reviewer":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"state":"REVIEWER"},{"updated":"2020-02-29 14:12:02.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-03-02 13:31:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e5035759d9b98bd7f48e9c00be1450d86501bf86","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-02-27 15:29:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"78dddb8341e8a876d27331f9c34a5bcb7b324b39","author":{"_account_id":3099,"name":"David Shrewsbury","email":"dshrewsb@redhat.com","username":"dshrews"},"date":"2020-02-27 16:19:25.000000000","message":"Patch Set 1: Code-Review+2\n\nW504 seems to be the recommended path going forward anyway.\n\nhttps://www.flake8rules.com/rules/W504.html","accounts_in_message":[],"_revision_number":1},{"id":"b5c2aa6a55083f9dcf917498e0d6237eadfc290c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-27 18:40:12.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/2e6092d04d0d47d19b58c429b682fd8f : SUCCESS in 6m 39s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/b809ea66e08d4183a719f2c129cd822f : FAILURE in 6m 38s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/1eac671c91a545cc9884010d92eb6a7a : RETRY_LIMIT in 9m 21s","accounts_in_message":[],"_revision_number":1},{"id":"fc60f44a54038fcabb15cb7efb7024ab462fc106","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-02-27 19:56:52.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"ef1f575e506bc80a0ed5a91f652a03246b460ea3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-02-27 21:23:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/d0823b8ebe114f0280d33b9f657dc30a : SUCCESS in 5m 53s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/79393987d2b846268a6a1757ad8d97d8 : SUCCESS in 4m 32s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/ed0a8c6e098549c9ae6dad9a62aa79db : SUCCESS in 49m 25s","accounts_in_message":[],"_revision_number":2},{"id":"0b8a9ea286526e2ea5c849b954f2cf659ea294bb","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-02-29 14:12:02.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nI\u0027m with Knuth on this one.","accounts_in_message":[],"_revision_number":2},{"id":"b24ef47df9faff628126828a98c91a4e810648f3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-02 12:38:43.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"9e1909d93f01f21a8d30e84a02f40064d345a05b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-02 13:31:35.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/aecdfae33b704339b5d5a7b4d6a0b3f1 : SUCCESS in 4m 56s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/252dcfa47f684668bf7bf1c5454cf0e6 : SUCCESS in 6m 23s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/d7c5e6f6be5d41e18f04157d18797a45 : SUCCESS in 36m 57s","accounts_in_message":[],"_revision_number":2},{"id":"1df9fcfe89bbd20340f5518a1aea049adb607497","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-02 13:31:35.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"92d7d7caebca3f1cebabbfacb3ee90b2b874e5ab","revisions":{"5f0c7e6f436e5945b1e2f48b8f782ef5c3fb4003":{"kind":"REWORK","_number":1,"created":"2020-02-27 15:29:28.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/96/710296/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/96/710296/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/96/710296/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/96/710296/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/96/710296/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/96/710296/1"}}},"commit":{"parents":[{"commit":"a8e477e846893fb67b6f07426e2b8b0240352cbc","subject":"Fix E128 and remove exclusion","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a8e477e846893fb67b6f07426e2b8b0240352cbc"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2020-02-27 15:21:21.000000000","tz":-360},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2020-02-27 15:28:47.000000000","tz":-360},"subject":"Fix W504 and remove exclusion","message":"Fix W504 and remove exclusion\n\nThis is a topic where there are two points of view. While neither\nis fundamentally better than the other in reality, what\u0027s best is\nto not have any arguments about it. The tox.ini comments about 503\nand 504 that were in place make the argument that:\n\n  - 503 is intended to be disabled and 504 enabled by default\n  - Donald Knuth believes 504 is the right way\n\nSince Donald Knuth is smarter than all of us, align with 504, match\nthe comments in the file and turn on enforcement to keep it that way.\n\nChange-Id: I92d4d1e82935e30ae42a0e14e641cbe36fd6e811\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/5f0c7e6f436e5945b1e2f48b8f782ef5c3fb4003"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/5f0c7e6f436e5945b1e2f48b8f782ef5c3fb4003"}]},"branch":"refs/heads/master"},"92d7d7caebca3f1cebabbfacb3ee90b2b874e5ab":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-02-27 19:56:52.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/96/710296/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/96/710296/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/96/710296/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/96/710296/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/96/710296/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/96/710296/2"}}},"commit":{"parents":[{"commit":"72ba76f156ebb5db53b1e9a9d0e67857bfa9614a","subject":"Fix E128 and remove exclusion","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/72ba76f156ebb5db53b1e9a9d0e67857bfa9614a"}]}],"author":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2020-02-27 15:21:21.000000000","tz":-360},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2020-02-27 19:56:48.000000000","tz":-360},"subject":"Fix W504 and remove exclusion","message":"Fix W504 and remove exclusion\n\nThis is a topic where there are two points of view. While neither\nis fundamentally better than the other in reality, what\u0027s best is\nto not have any arguments about it. The tox.ini comments about 503\nand 504 that were in place make the argument that:\n\n  - 503 is intended to be disabled and 504 enabled by default\n  - Donald Knuth believes 504 is the right way\n\nSince Donald Knuth is smarter than all of us, align with 504, match\nthe comments in the file and turn on enforcement to keep it that way.\n\nChange-Id: I92d4d1e82935e30ae42a0e14e641cbe36fd6e811\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/92d7d7caebca3f1cebabbfacb3ee90b2b874e5ab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/92d7d7caebca3f1cebabbfacb3ee90b2b874e5ab"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}