)]}'
{"plugins/modules/os_floating_ip.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c77d08bb4482d3671ce36dc0475e6b94dca2392","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        - When attaching a floating IP address, specify whether to wait for it to appear as attached."},{"line_number":58,"context_line":"        - Must be set to C(yes) for the module to return the value of the floating IP."},{"line_number":59,"context_line":"     type: bool"},{"line_number":60,"context_line":"     default: \u0027no\u0027"},{"line_number":61,"context_line":"   timeout:"},{"line_number":62,"context_line":"     description:"},{"line_number":63,"context_line":"        - Time to wait for an IP address to appear as attached. See wait."}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_5719ca85","line":60,"updated":"2020-03-17 09:29:41.000000000","message":"nit: false? or what\u0027s the current consensus?","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"change_message_id":"e86ed574a4f9e5f38683b07684a97aafa1534631","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        - When attaching a floating IP address, specify whether to wait for it to appear as attached."},{"line_number":58,"context_line":"        - Must be set to C(yes) for the module to return the value of the floating IP."},{"line_number":59,"context_line":"     type: bool"},{"line_number":60,"context_line":"     default: \u0027no\u0027"},{"line_number":61,"context_line":"   timeout:"},{"line_number":62,"context_line":"     description:"},{"line_number":63,"context_line":"        - Time to wait for an IP address to appear as attached. See wait."}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_524c7875","line":60,"in_reply_to":"1fa4df85_5719ca85","updated":"2020-03-17 09:42:18.000000000","message":"The advice I was getting from felixfontein was generally to move towards an unquoted true/false.  I\u0027d avoided mass-updating this just because it was yet more.  I can do so if you\u0027d prefer","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c77d08bb4482d3671ce36dc0475e6b94dca2392","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        - When I(state) is absent, indicates whether or not to delete the floating"},{"line_number":76,"context_line":"          IP completely, or only detach it from the server. Default is to detach only."},{"line_number":77,"context_line":"     type: bool"},{"line_number":78,"context_line":"     default: \u0027no\u0027"},{"line_number":79,"context_line":"requirements:"},{"line_number":80,"context_line":"    - \"python \u003e\u003d 3.6\""},{"line_number":81,"context_line":"    - \"openstacksdk\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_771c0677","line":78,"updated":"2020-03-17 09:29:41.000000000","message":"ditto?","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"}],"plugins/modules/os_ironic.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c77d08bb4482d3671ce36dc0475e6b94dca2392","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            description:"},{"line_number":61,"context_line":"                - Information necessary to turn this server on / off."},{"line_number":62,"context_line":"                  This often includes such things as IPMI username, password, and IP address."},{"line_number":63,"context_line":"            required: true"},{"line_number":64,"context_line":"        deploy:"},{"line_number":65,"context_line":"            description:"},{"line_number":66,"context_line":"                - Information necessary to deploy this server directly, without using Nova. THIS IS NOT RECOMMENDED."}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_17135268","line":63,"updated":"2020-03-17 09:29:41.000000000","message":"nit: these all are dicts as well","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c77d08bb4482d3671ce36dc0475e6b94dca2392","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            required: true"},{"line_number":64,"context_line":"        deploy:"},{"line_number":65,"context_line":"            description:"},{"line_number":66,"context_line":"                - Information necessary to deploy this server directly, without using Nova. THIS IS NOT RECOMMENDED."},{"line_number":67,"context_line":"        console:"},{"line_number":68,"context_line":"            description:"},{"line_number":69,"context_line":"                - Information necessary to connect to this server\u0027s serial console.  Not all drivers support this."}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_37168e57","line":66,"updated":"2020-03-17 09:29:41.000000000","message":"very nit: this \"NOT RECOMMENDED\" should be removed","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c77d08bb4482d3671ce36dc0475e6b94dca2392","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        cpu_arch:"},{"line_number":85,"context_line":"          description:"},{"line_number":86,"context_line":"            - CPU architecture (x86_64, i686, ...)"},{"line_number":87,"context_line":"          default: x86_64"},{"line_number":88,"context_line":"        cpus:"},{"line_number":89,"context_line":"          description:"},{"line_number":90,"context_line":"            - Number of CPU cores this machine has"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_d70cda43","line":87,"updated":"2020-03-17 09:29:41.000000000","message":"nit: types of suboptions","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"change_message_id":"e86ed574a4f9e5f38683b07684a97aafa1534631","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        cpu_arch:"},{"line_number":85,"context_line":"          description:"},{"line_number":86,"context_line":"            - CPU architecture (x86_64, i686, ...)"},{"line_number":87,"context_line":"          default: x86_64"},{"line_number":88,"context_line":"        cpus:"},{"line_number":89,"context_line":"          description:"},{"line_number":90,"context_line":"            - Number of CPU cores this machine has"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_f23a44c2","line":87,"in_reply_to":"1fa4df85_d70cda43","updated":"2020-03-17 09:42:18.000000000","message":"Good catch, I was relying on ansible-test catching them, apparently it\u0027s not entirely consistent yet.  I might follow up on the core side of things.","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c77d08bb4482d3671ce36dc0475e6b94dca2392","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            - Root disk device hints for deployment."},{"line_number":109,"context_line":"            - See U(https://docs.openstack.org/ironic/latest/install/advanced.html#specifying-the-disk-for-deployment-root-device-hints)"},{"line_number":110,"context_line":"              for allowed hints."},{"line_number":111,"context_line":"          default: \"\""},{"line_number":112,"context_line":"    skip_update_of_masked_password:"},{"line_number":113,"context_line":"      description:"},{"line_number":114,"context_line":"        - Allows the code that would assert changes to nodes to skip the"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_f707961c","line":111,"updated":"2020-03-17 09:29:41.000000000","message":"(thinking aloud) this is actually a dict, I wonder if default:\"\" makes any sense..","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ab6102dafc74423ce73f29b35ec53e9b0465f4c4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            - Root disk device hints for deployment."},{"line_number":109,"context_line":"            - See U(https://docs.openstack.org/ironic/latest/install/advanced.html#specifying-the-disk-for-deployment-root-device-hints)"},{"line_number":110,"context_line":"              for allowed hints."},{"line_number":111,"context_line":"          default: \"\""},{"line_number":112,"context_line":"    skip_update_of_masked_password:"},{"line_number":113,"context_line":"      description:"},{"line_number":114,"context_line":"        - Allows the code that would assert changes to nodes to skip the"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_abc8d273","line":111,"in_reply_to":"1fa4df85_f707961c","updated":"2020-03-17 15:58:17.000000000","message":"Probably not...","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"}],"plugins/modules/os_ironic_node.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c77d08bb4482d3671ce36dc0475e6b94dca2392","unresolved":false,"context_lines":[{"line_number":33,"context_line":"       - Indicates if the resource should be deployed. Allows for deployment"},{"line_number":34,"context_line":"         logic to be disengaged and control of the node power or maintenance"},{"line_number":35,"context_line":"         state to be changed."},{"line_number":36,"context_line":"      type: str"},{"line_number":37,"context_line":"      default: \u0027yes\u0027"},{"line_number":38,"context_line":"    uuid:"},{"line_number":39,"context_line":"      description:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_97066220","line":36,"updated":"2020-03-17 09:29:41.000000000","message":"Why not a bool?","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ab6102dafc74423ce73f29b35ec53e9b0465f4c4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"       - Indicates if the resource should be deployed. Allows for deployment"},{"line_number":34,"context_line":"         logic to be disengaged and control of the node power or maintenance"},{"line_number":35,"context_line":"         state to be changed."},{"line_number":36,"context_line":"      type: str"},{"line_number":37,"context_line":"      default: \u0027yes\u0027"},{"line_number":38,"context_line":"    uuid:"},{"line_number":39,"context_line":"      description:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_cb150ee7","line":36,"in_reply_to":"1fa4df85_528eb827","updated":"2020-03-17 15:58:17.000000000","message":"I agree - let\u0027s change it to bool and fix the spec in this case.","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"change_message_id":"e86ed574a4f9e5f38683b07684a97aafa1534631","unresolved":false,"context_lines":[{"line_number":33,"context_line":"       - Indicates if the resource should be deployed. Allows for deployment"},{"line_number":34,"context_line":"         logic to be disengaged and control of the node power or maintenance"},{"line_number":35,"context_line":"         state to be changed."},{"line_number":36,"context_line":"      type: str"},{"line_number":37,"context_line":"      default: \u0027yes\u0027"},{"line_number":38,"context_line":"    uuid:"},{"line_number":39,"context_line":"      description:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_d26868bb","line":36,"in_reply_to":"1fa4df85_97066220","updated":"2020-03-17 09:42:18.000000000","message":"The spec itself leaves this undefined, which means it\u0027s implicitly a string.  Rather than trying to mess with some of the logic I wanted to ensure the docs at least match the specs.","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"edf764bf03781d51bacad72de5cf69438391233f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"       - Indicates if the resource should be deployed. Allows for deployment"},{"line_number":34,"context_line":"         logic to be disengaged and control of the node power or maintenance"},{"line_number":35,"context_line":"         state to be changed."},{"line_number":36,"context_line":"      type: str"},{"line_number":37,"context_line":"      default: \u0027yes\u0027"},{"line_number":38,"context_line":"    uuid:"},{"line_number":39,"context_line":"      description:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_528eb827","line":36,"in_reply_to":"1fa4df85_d26868bb","updated":"2020-03-17 09:53:52.000000000","message":"I\u0027d rather make a potentially breaking change than end up supporting an incorrect type..","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c77d08bb4482d3671ce36dc0475e6b94dca2392","unresolved":false,"context_lines":[{"line_number":59,"context_line":"      suboptions:"},{"line_number":60,"context_line":"        image_source:"},{"line_number":61,"context_line":"          description:"},{"line_number":62,"context_line":"            - An HTTP(S) URL where the image can be retrieved from."},{"line_number":63,"context_line":"        image_checksum:"},{"line_number":64,"context_line":"          description:"},{"line_number":65,"context_line":"            - The checksum of image_source."}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_b7011e09","line":62,"updated":"2020-03-17 09:29:41.000000000","message":"nit: types here","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"5c77d08bb4482d3671ce36dc0475e6b94dca2392","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        - A setting to allow the direct control if a node is in"},{"line_number":80,"context_line":"          maintenance mode."},{"line_number":81,"context_line":"        - I(maintenance) can be C(\u0027yes\u0027), C(\u0027no\u0027), C(\u0027True\u0027), or C(\u0027False\u0027)."},{"line_number":82,"context_line":"      type: str"},{"line_number":83,"context_line":"    maintenance_reason:"},{"line_number":84,"context_line":"      description:"},{"line_number":85,"context_line":"        - A string expression regarding the reason a node is in a"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_52feb805","line":82,"updated":"2020-03-17 09:29:41.000000000","message":"This is a boolean actually, why change it?","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"ab6102dafc74423ce73f29b35ec53e9b0465f4c4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        - A setting to allow the direct control if a node is in"},{"line_number":80,"context_line":"          maintenance mode."},{"line_number":81,"context_line":"        - I(maintenance) can be C(\u0027yes\u0027), C(\u0027no\u0027), C(\u0027True\u0027), or C(\u0027False\u0027)."},{"line_number":82,"context_line":"      type: str"},{"line_number":83,"context_line":"    maintenance_reason:"},{"line_number":84,"context_line":"      description:"},{"line_number":85,"context_line":"        - A string expression regarding the reason a node is in a"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_2bdce244","line":82,"in_reply_to":"1fa4df85_32a77c0e","updated":"2020-03-17 15:58:17.000000000","message":"Same - let\u0027s fix the spec.","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"},{"author":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"change_message_id":"e86ed574a4f9e5f38683b07684a97aafa1534631","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        - A setting to allow the direct control if a node is in"},{"line_number":80,"context_line":"          maintenance mode."},{"line_number":81,"context_line":"        - I(maintenance) can be C(\u0027yes\u0027), C(\u0027no\u0027), C(\u0027True\u0027), or C(\u0027False\u0027)."},{"line_number":82,"context_line":"      type: str"},{"line_number":83,"context_line":"    maintenance_reason:"},{"line_number":84,"context_line":"      description:"},{"line_number":85,"context_line":"        - A string expression regarding the reason a node is in a"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_32a77c0e","line":82,"in_reply_to":"1fa4df85_52feb805","updated":"2020-03-17 09:42:18.000000000","message":"See above, it\u0027s used as a bool, but the spec technically considers it a string.","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"}],"plugins/modules/os_quota.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f642e1757299e57ed2244513c69d96c62fbc95c7","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    volumes_types:"},{"line_number":131,"context_line":"        description:"},{"line_number":132,"context_line":"            - Per-driver volume count quotas.  Keys should be"},{"line_number":133,"context_line":"              prefixed with C(gigabytes_) values should be ints."},{"line_number":134,"context_line":"        type: dict"},{"line_number":135,"context_line":"    project:"},{"line_number":136,"context_line":"        description: Unused, kept for compatability"}],"source_content_type":"text/x-python","patch_set":1,"id":"1fa4df85_ef8255c8","line":133,"range":{"start_line":133,"start_character":14,"end_line":133,"end_character":41},"updated":"2020-03-17 16:57:32.000000000","message":"Maybe it\u0027s only me, but I don\u0027t quite get the \"Prefixed with gigabytes\" part.. Also, missing comma before \"values\"? (ditto above)","commit_id":"1849f8bd4750f1d5f40b95811a934b1547a1bde4"}]}