)]}'
{"id":"openstack%2Fansible-collections-openstack~713256","triplet_id":"openstack%2Fansible-collections-openstack~master~Iac23d54512b23f031460d1b7281ccb8d93e20cad","project":"openstack/ansible-collections-openstack","branch":"master","topic":"sanity/mass-clean-1","hashtags":[],"change_id":"Iac23d54512b23f031460d1b7281ccb8d93e20cad","subject":"Add missing type information to docs","status":"MERGED","created":"2020-03-16 15:05:20.000000000","updated":"2020-03-17 17:39:23.000000000","submitted":"2020-03-17 17:39:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"713256-1584466763860-3b0434b8","meta_rev_id":"7165d345dba68d35a2aee01f1fde854b5b6d7c1b","_number":713256,"virtual_id_number":713256,"owner":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-17 17:39:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"date":"2020-03-17 09:42:18.000000000","_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},{"value":2,"date":"2020-03-17 16:02:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-03-17 16:57:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"value":0,"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-17 16:02:04.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-03-17 16:57:32.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-03-17 17:39:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4b5ed9eec756436ed2408b782a194621874ac6d5","author":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"date":"2020-03-16 15:05:20.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"a8815f764298a106ca1efa0de7acf721b8ed0f7b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-16 15:44:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/58127af3a2ce4fe59e861eefa7a4308a : SUCCESS in 6m 21s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/77704b08c2704a23aaf042398187eec5 : SUCCESS in 4m 42s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/2c382684aa0b4a9f94ae9053092d1867 : SUCCESS in 36m 17s","accounts_in_message":[],"_revision_number":1},{"id":"5c77d08bb4482d3671ce36dc0475e6b94dca2392","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-17 09:29:41.000000000","message":"Patch Set 1:\n\n(9 comments)\n\nThank you, this is a lot of work!\n\nI\u0027m somewhat confused by what is happening to booleans here. In some places you change yes/no to true/false, in some - not. For ironic you change some boolean fields to strings, why is that?","accounts_in_message":[],"_revision_number":1},{"id":"e86ed574a4f9e5f38683b07684a97aafa1534631","author":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"date":"2020-03-17 09:42:18.000000000","message":"Patch Set 1:\n\n(4 comments)\n\nThe bools thing is a little weird, there are a number of places where it would be good to follow up and switch out \u0027str\u0027 for \u0027bool\u0027, but doing so means also tweaking the arg spec, which could in theory break existing playbooks.","accounts_in_message":[],"_revision_number":1},{"id":"edf764bf03781d51bacad72de5cf69438391233f","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-17 09:53:52.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"ab6102dafc74423ce73f29b35ec53e9b0465f4c4","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-03-17 15:58:17.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nVery much like this! I agree with dtantsur though - let\u0027s fix those bools.","accounts_in_message":[],"_revision_number":1},{"id":"d4304584b5203b691378774e0523808cc6397026","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-03-17 16:02:04.000000000","message":"Patch Set 1: Code-Review+2\n\nWe\u0027ll do these in a followup.","accounts_in_message":[],"_revision_number":1},{"id":"f642e1757299e57ed2244513c69d96c62fbc95c7","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-03-17 16:57:32.000000000","message":"Patch Set 1: Workflow+1\n\n(1 comment)\n\nGreat job, thanks!","accounts_in_message":[],"_revision_number":1},{"id":"c61121c1615906b3508cce88ea0290bf86bb0dd2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 16:58:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f056ed69a120b0e3d6d0f87506038bb54aeb21bb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 17:39:23.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/6ba4674f532640e6b4a00804beac3625 : SUCCESS in 4m 59s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/aefb03644e5a478c8c6643d1c8030ce6 : SUCCESS in 3m 32s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/3c0170068b8b4afb97167b3d9dd28dfb : SUCCESS in 38m 28s","accounts_in_message":[],"_revision_number":1},{"id":"0b51af0f0809e87afef3be304b46ad1f263f8e8d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-17 17:39:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1849f8bd4750f1d5f40b95811a934b1547a1bde4","revisions":{"1849f8bd4750f1d5f40b95811a934b1547a1bde4":{"kind":"REWORK","_number":1,"created":"2020-03-16 15:05:20.000000000","uploader":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"ref":"refs/changes/56/713256/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/56/713256/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/56/713256/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/56/713256/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/56/713256/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/56/713256/1"}}},"commit":{"parents":[{"commit":"9e9dacdf3c82611f406bb3d8ff317bfccf8cec26","subject":"Fix doc requirements, and consistently require python 3.6+","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/9e9dacdf3c82611f406bb3d8ff317bfccf8cec26"}]}],"author":{"name":"Mark Chappell","email":"mchappel@redhat.com","date":"2020-03-16 11:38:42.000000000","tz":60},"committer":{"name":"Mark Chappell","email":"mchappel@redhat.com","date":"2020-03-16 12:56:58.000000000","tz":60},"subject":"Add missing type information to docs","message":"Add missing type information to docs\n\nChange-Id: Iac23d54512b23f031460d1b7281ccb8d93e20cad\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1849f8bd4750f1d5f40b95811a934b1547a1bde4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1849f8bd4750f1d5f40b95811a934b1547a1bde4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}