)]}'
{"plugins/modules/os_keystone_mapping_info.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6dcad7e5e676c53ae23ede004c5185caaf1ae29b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"from ansible_collections.openstack.cloud.plugins.module_utils.openstack import ("},{"line_number":49,"context_line":"    openstack_full_argument_spec,"},{"line_number":50,"context_line":"    openstack_module_kwargs,"},{"line_number":51,"context_line":"    openstack_cloud_from_module)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def normalize_mapping(mapping):"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_2f0e55e4","line":51,"updated":"2020-04-01 08:42:39.000000000","message":"nit: one import per line","commit_id":"24eac36c79a7480d58d839a0f1ea5dfce30429c5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6dcad7e5e676c53ae23ede004c5185caaf1ae29b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            module.fail_json(msg\u003d\u0027Failed to find mapping\u0027)"},{"line_number":92,"context_line":"        mapping \u003d normalize_mapping(mapping)"},{"line_number":93,"context_line":"        module.exit_json(changed\u003dFalse, mappings\u003d[mapping])"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    try:"},{"line_number":96,"context_line":"        mappings \u003d cloud.identity.mappings()"},{"line_number":97,"context_line":"    except sdk.exceptions.ResourceNotFound:"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_0f11d104","line":94,"updated":"2020-04-01 08:42:39.000000000","message":"nit: \"else\" (for readability)","commit_id":"24eac36c79a7480d58d839a0f1ea5dfce30429c5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6dcad7e5e676c53ae23ede004c5185caaf1ae29b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    try:"},{"line_number":96,"context_line":"        mappings \u003d cloud.identity.mappings()"},{"line_number":97,"context_line":"    except sdk.exceptions.ResourceNotFound:"},{"line_number":98,"context_line":"        module.fail_json(msg\u003d\u0027Failed to list mappings\u0027)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    all_mappings \u003d []"},{"line_number":101,"context_line":"    for mapping in mappings:"}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_6ffb3dc0","line":98,"updated":"2020-04-01 08:42:39.000000000","message":"Why do you expect ResourceNotFound here? Because of too old Keystone? Maybe make it explicit?","commit_id":"24eac36c79a7480d58d839a0f1ea5dfce30429c5"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"6dcad7e5e676c53ae23ede004c5185caaf1ae29b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    all_mappings \u003d []"},{"line_number":101,"context_line":"    for mapping in mappings:"},{"line_number":102,"context_line":"        all_mappings.append(normalize_mapping(mapping))"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    module.exit_json(changed\u003dFalse, mappings\u003dall_mappings)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"df33271e_4ff639d9","line":103,"updated":"2020-04-01 08:42:39.000000000","message":"nit:\n\n all_mappings \u003d list(map(normalize_mapping, cloud.identity.mappings()))","commit_id":"24eac36c79a7480d58d839a0f1ea5dfce30429c5"}]}