)]}'
{"ci/roles/keystone_federation_protocol/tasks/main.yml":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"002de8c6072b85ab994cb52a38752bab5aac69ae","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    # \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":256,"context_line":"    #   Basic tests of os_keystone_federation_protocol_info"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"    #- name: \u0027Fetch Protocol info (a specific protocol)\u0027"},{"line_number":259,"context_line":"    #  openstack.cloud.os_keystone_federation_protocol_info:"},{"line_number":260,"context_line":"    #    name: \u0027{{ protocol_name }}\u0027"},{"line_number":261,"context_line":"    #  register: protocol_info"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"df33271e_5074da9c","line":258,"updated":"2020-04-03 15:17:24.000000000","message":"When leaving something commented out, please at least comment why (not implemented, needs fixing, etc)","commit_id":"8729b8da72ec901382e7b6abf1453df7aabf1891"}],"meta/action_groups.yml":[{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"32d0c77e432e1dd6c8864d6e775056c491db4af7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"- os_keystone_identity_provider_info"},{"line_number":21,"context_line":"- os_keystone_mapping"},{"line_number":22,"context_line":"- os_keystone_mapping_info"},{"line_number":23,"context_line":"- os_keystone_protocol"},{"line_number":24,"context_line":"- os_keystone_role"},{"line_number":25,"context_line":"- os_keystone_service"},{"line_number":26,"context_line":"- os_listener"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"df33271e_4468b7f3","line":23,"updated":"2020-04-02 15:21:48.000000000","message":"os_keystone_federation_protocol","commit_id":"6e5affdfe1b53a1cde79d74c9fcd02ac8b8ffc45"}],"plugins/modules/os_keystone_federation_protocol.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"002de8c6072b85ab994cb52a38752bab5aac69ae","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    idp_name \u003d module.params.get(\u0027idp_id\u0027)"},{"line_number":123,"context_line":"    mapping_id \u003d module.params.get(\u0027mapping_id\u0027)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    attributes \u003d {"},{"line_number":126,"context_line":"        \u0027idp_id\u0027: idp_name,"},{"line_number":127,"context_line":"        \u0027mapping_id\u0027: mapping_id,"},{"line_number":128,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":9,"id":"df33271e_30795693","line":125,"updated":"2020-04-03 15:17:24.000000000","message":"nit: no need for this dict, just pass arguments to create_federation_protocol","commit_id":"8729b8da72ec901382e7b6abf1453df7aabf1891"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"002de8c6072b85ab994cb52a38752bab5aac69ae","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    attributes \u003d {}"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    if (mapping_id is not None) and (mapping_id !\u003d protocol.mapping_id):"},{"line_number":149,"context_line":"        attributes[\u0027mapping_id\u0027] \u003d mapping_id"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    if not attributes:"}],"source_content_type":"text/x-python","patch_set":9,"id":"df33271e_906e62c7","line":148,"updated":"2020-04-03 15:17:24.000000000","message":"nit: redundant brackets","commit_id":"8729b8da72ec901382e7b6abf1453df7aabf1891"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"002de8c6072b85ab994cb52a38752bab5aac69ae","unresolved":false,"context_lines":[{"line_number":190,"context_line":"    except sdk.exceptions.ResourceNotFound:"},{"line_number":191,"context_line":"        protocol \u003d None"},{"line_number":192,"context_line":"    except sdk.exceptions.OpenStackCloudException as ex:"},{"line_number":193,"context_line":"        module.fail_json(msg\u003d\u0027Failed to get protocol: {0}\u0027.format(str(ex)))"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    if state \u003d\u003d \u0027absent\u0027:"},{"line_number":196,"context_line":"        if protocol is not None:"}],"source_content_type":"text/x-python","patch_set":9,"id":"df33271e_7073deb2","line":193,"updated":"2020-04-03 15:17:24.000000000","message":"nit: str() calls are not needed when formatting in most cases (applies to other places too)","commit_id":"8729b8da72ec901382e7b6abf1453df7aabf1891"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"002de8c6072b85ab994cb52a38752bab5aac69ae","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    # state \u003d\u003d \u0027present\u0027"},{"line_number":201,"context_line":"    else:"},{"line_number":202,"context_line":"        if protocol is None:"},{"line_number":203,"context_line":"            if module.params.get(\u0027mapping_id\u0027) is None:"},{"line_number":204,"context_line":"                module.fail_json(msg\u003d\u0027A mapping_id must be passed when creating\u0027"},{"line_number":205,"context_line":"                                 \u0027 a protocol\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"df33271e_d0674aea","line":202,"updated":"2020-04-03 15:17:24.000000000","message":"very nit: use \u0027elif\u0027","commit_id":"8729b8da72ec901382e7b6abf1453df7aabf1891"}]}