)]}'
{"id":"openstack%2Fansible-collections-openstack~719429","triplet_id":"openstack%2Fansible-collections-openstack~master~I84f93888059ec09b182a03e751ade6810e133a29","project":"openstack/ansible-collections-openstack","branch":"master","hashtags":[],"change_id":"I84f93888059ec09b182a03e751ade6810e133a29","subject":"Moved openstack inventory script from community.general","status":"MERGED","created":"2020-04-13 09:52:22.000000000","updated":"2020-04-20 11:22:52.000000000","submitted":"2020-04-20 11:22:52.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"719429-1587381772758-77dd523e","meta_rev_id":"dae9fc8866018ceaec171588958470e5bdc337cb","_number":719429,"virtual_id_number":719429,"owner":{"_account_id":22578,"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","username":"akasurde"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"date":"2020-04-20 09:01:56.000000000","_account_id":22578,"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","username":"akasurde"},{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-20 11:22:52.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2020-04-14 09:41:12.000000000","_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":2,"date":"2020-04-13 18:46:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22578,"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","username":"akasurde"},{"value":2,"date":"2020-04-20 09:10:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":22578,"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","username":"akasurde"},{"value":1,"date":"2020-04-20 09:11:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22578,"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","username":"akasurde"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-13 18:46:12.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-04-14 09:41:12.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"},{"updated":"2020-04-20 09:11:24.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"},{"updated":"2020-04-20 11:22:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e640fe7373823301945467a00fa6f1a91036e603","author":{"_account_id":22578,"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","username":"akasurde"},"date":"2020-04-13 09:52:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"db8635e62f64a02a1ae757919a87b3cdb6aa2502","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-13 10:58:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/7c861192734741da9dd765353c6a3c7e : SUCCESS in 3m 19s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/76b01fdfe3654f49bfcada55550c86f7 : SUCCESS in 5m 13s (non-voting)\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/106ec7cea9f44c798675359dcbf02526 : SUCCESS in 6m 23s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/6d7cbb7e2e074aa8aa92cc1500e9e1dc : SUCCESS in 39m 19s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/8986f82501c74d468393661eb9fcafe8 : SUCCESS in 39m 53s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/8587ab6864244689b137a42affd5c66a : SUCCESS in 42m 37s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/f1b129809a4b4357884e68a1773a8acb : SUCCESS in 40m 48s\n- ansible-collections-openstack-functional-devstack-train-ansible-devel https://zuul.opendev.org/t/openstack/build/2d7cf7d9b6324d58852c60421911b677 : SUCCESS in 42m 21s (non-voting)\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/8c738b6bb32a4a9ba4f37293fc420e89 : SUCCESS in 41m 14s\n- ansible-collections-openstack-functional-devstack-stein-ansible-devel https://zuul.opendev.org/t/openstack/build/afad77dca5e54ed49afe3a6d3763dc2a : SUCCESS in 43m 26s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/44c1bb7f8a294d28a490881640801a61 : SUCCESS in 41m 33s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-devel https://zuul.opendev.org/t/openstack/build/5581bcd5854746dc81a1467c25d55893 : SUCCESS in 39m 49s (non-voting)\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/f599574ac69c4d0397328fcb264e8400 : SUCCESS in 47m 22s","accounts_in_message":[],"_revision_number":1},{"id":"ae558e05e77fc93a5334e1f6b4222f828ef6fae3","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-04-13 18:46:12.000000000","message":"Patch Set 1: Code-Review+2\n\nWe should add a big flashing warning somewhere \"please stop using this and use the inventory plugin instead\"","accounts_in_message":[],"_revision_number":1},{"id":"312f682ca9cbebb514760b8b004c1ac7fb755f69","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2020-04-14 09:41:12.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"2de560f8104498e75d73e50f2c7f189ee6f9e60d","author":{"_account_id":22578,"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","username":"akasurde"},"date":"2020-04-16 10:03:02.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n\nThis file is used as a configuration example for openstack_inventory.py. Users usually, keep these two files together (at least in ansible/ansible repo)","accounts_in_message":[],"_revision_number":1},{"id":"6c2cffc449cdbff70d75ad6e52f4c900e65d2059","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-04-19 15:49:26.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)\n\nWhat is this script for? Isn\u0027t it covered by inventory module that we already have in ./plugins/inventory/openstack.py ? And where is it from? Looks like very old version of inventory module.","accounts_in_message":[],"_revision_number":1},{"id":"107c5619989f240069c4dc4c8c31163f4530c5ec","author":{"_account_id":22578,"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","username":"akasurde"},"date":"2020-04-20 04:34:38.000000000","message":"Patch Set 1:\n\nThis is an old inventory script that is referred in the Ansible documentation. The script is removed from ansible/ansible repo and we need this script in this repo for backward compatibility. We will add a warning to use a new inventory plugin instead of this script and in 4 release cycles remove it all together.","accounts_in_message":[],"_revision_number":1},{"id":"6ce134ca7c3c93b72af78a55c535d50309b0e4f1","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-04-20 08:32:07.000000000","message":"Patch Set 1:\n\nHmm, I don\u0027t find it in ansible 2.9, when was it removed? In which version?","accounts_in_message":[],"_revision_number":1},{"id":"b89ba05e901e88ad1c984cba695a1c31823e00f9","author":{"_account_id":22578,"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","username":"akasurde"},"date":"2020-04-20 09:01:56.000000000","message":"Patch Set 1:\n\nIt is here in 2.9 - https://github.com/ansible/ansible/blob/stable-2.9/contrib/inventory/openstack_inventory.py\n\nBut in 2.10, it is not removed - https://github.com/ansible/ansible/blob/devel/contrib/inventory/openstack_inventory.py","accounts_in_message":[],"_revision_number":1},{"id":"8558873686d94d442b0d586017867c4454aa0540","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-04-20 09:10:31.000000000","message":"Patch Set 1: Code-Review+2\n\nseems like people still can use old script instead of inventory module, let\u0027s not deprive them of this joy","accounts_in_message":[],"_revision_number":1},{"id":"d55e3db1cde08cc11ec2d1da0e2075faa544145e","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-04-20 09:11:24.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"cda9c6ce8ab47936f39a660ef2bc82ee7874a689","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-20 09:11:36.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"35a873530e289b88ccd9d19b1ca3eb22cd0ad36c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-20 11:22:52.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"dae9fc8866018ceaec171588958470e5bdc337cb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-20 11:22:52.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/03c5d1a17320499680ff4076aebbccb5 : SUCCESS in 3m 37s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/7127f659361746149e6c867cdc7ee8c7 : SUCCESS in 6m 20s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/6c568692342e41819ff7753834a6aa06 : SUCCESS in 50m 06s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/700ed79c9a654137a8898a443e691262 : SUCCESS in 41m 49s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/6dae89bf070e49fb8c170442f87f3c5a : SUCCESS in 41m 21s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/4fdccee73f814aed8208b2e9b470f61b : SUCCESS in 42m 05s\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/5f0ad18f680343cf94a57c5da03ac37b : SUCCESS in 45m 23s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/a220bb69b83a4045894e7390c1813231 : SUCCESS in 41m 03s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5576eea3ce636c67ed956fddc93e1e00042d5756","revisions":{"5576eea3ce636c67ed956fddc93e1e00042d5756":{"kind":"REWORK","_number":1,"created":"2020-04-13 09:52:22.000000000","uploader":{"_account_id":22578,"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","username":"akasurde"},"ref":"refs/changes/29/719429/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/29/719429/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/29/719429/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/29/719429/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/29/719429/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/29/719429/1"}}},"commit":{"parents":[{"commit":"2b51a58da2af92e2e2f41d4e424548ec64bf635b","subject":"Merge \"New Module: os_keystone_federation_protocol_info\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/2b51a58da2af92e2e2f41d4e424548ec64bf635b"}]}],"author":{"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","date":"2020-04-13 09:37:44.000000000","tz":330},"committer":{"name":"Abhijeet Kasurde","email":"akasurde@redhat.com","date":"2020-04-13 09:52:18.000000000","tz":330},"subject":"Moved openstack inventory script from community.general","message":"Moved openstack inventory script from community.general\n\nMoved Openstack inventory script from Ansible community.general to openstack collection.\n\nChange-Id: I84f93888059ec09b182a03e751ade6810e133a29\nSigned-off-by: Abhijeet Kasurde \u003cakasurde@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/5576eea3ce636c67ed956fddc93e1e00042d5756"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/5576eea3ce636c67ed956fddc93e1e00042d5756"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}