)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e9a7abf62dc12f2d04fdb2ba987faffafe796a98","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Amol Kahat \u003camolkahat@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-04-21 17:47:12 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if any changes has been made to the os_router then it was"},{"line_number":8,"context_line":"deleting the interfaces. It causes the module failure."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Fixes: GH 68208"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_21b57832","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":57},"updated":"2020-04-21 13:33:26.000000000","message":"please have first line of commit separate:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\n\n\u003e Provide a brief description of the change in the first line.\nInsert a single blank line after the first line.","commit_id":"f06ca82152733ad2f420e35209c465c48e0d1ea0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1bdac8d257ef6fbb80b3f957c5f43908a417e430","unresolved":false,"context_lines":[{"line_number":7,"context_line":"if any changes has been made to the os_router then it was"},{"line_number":8,"context_line":"deleting the interfaces. It causes the module failure."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Fixes: GH 68208"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I52b406fc7cc6207a5e89b6ff31205ae6016862c7"},{"line_number":13,"context_line":"Signed-off-by: Amol Kahat \u003camolkahat@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_e109d031","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":15},"updated":"2020-04-21 14:09:43.000000000","message":"in case of github issue worth to paste a link, it\u0027s unclear what is it and in which project to look for it","commit_id":"f06ca82152733ad2f420e35209c465c48e0d1ea0"}],"plugins/modules/os_router.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"9ee91708405d2ce101643047949282353d7de27f","unresolved":false,"context_lines":[{"line_number":457,"context_line":"                    if not updated_router:"},{"line_number":458,"context_line":"                        changed \u003d False"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"                    # On a router update, if any internal interfaces were supplied,"},{"line_number":461,"context_line":"                    # just detach all existing internal interfaces and attach the new."},{"line_number":462,"context_line":"                    if internal_portids or subnet_internal_ids:"},{"line_number":463,"context_line":"                        router \u003d updated_router"},{"line_number":464,"context_line":"                        ports \u003d _router_internal_interfaces(cloud, router)"},{"line_number":465,"context_line":"                        for port in ports:"},{"line_number":466,"context_line":"                            cloud.remove_router_interface(router, port_id\u003dport[\u0027id\u0027])"},{"line_number":467,"context_line":"                    if internal_portids:"},{"line_number":468,"context_line":"                        external_ids, subnet_internal_ids, internal_portids \u003d _validate_subnets(module, cloud, filters)"},{"line_number":469,"context_line":"                        for int_p_id in internal_portids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f493fa4_e13c30c1","side":"PARENT","line":466,"range":{"start_line":460,"start_character":18,"end_line":466,"end_character":85},"updated":"2020-04-21 13:29:47.000000000","message":"I think it might be more complex. For example case when we attach one networks and then replace it by another. In this case it\u0027s fine to delete the previous one. But this task should be more smart:\n\n1) to check which networks are provided in module arguments\n2) to check which networks the current router has (if at all)\n3) compare lists from 1 and 2 and to decide if we need to remove interfaces\n4) if we have to delete interface with FIP - fail the module with appropriate message (this should raise exception and will be handled by sdk)","commit_id":"466f3d4a0ac6298033c0348ded9c4efec7540938"}]}