)]}'
{"plugins/modules/server_action.py":[{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"573140c422c5f4e8a4641797f886b81086099c39","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        if not image:"},{"line_number":145,"context_line":"            self.fail_json(msg\u003d\"Image %s was not found!\" % self.params[\u0027image\u0027])"},{"line_number":146,"context_line":"        # admin_password is required by SDK, but not required by Nova API"},{"line_number":147,"context_line":"        if self.params[\u0027admin_password\u0027]:"},{"line_number":148,"context_line":"            self.conn.compute.rebuild_server("},{"line_number":149,"context_line":"                server\u003dos_server,"},{"line_number":150,"context_line":"                name\u003dos_server[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_a3da2f1a","line":147,"updated":"2020-06-09 10:14:53.000000000","message":"I thought we are fixing that and not hardcoding a new branch, which is terrible","commit_id":"6aacaa3872c5851d690cbd0026565793a973999c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d58638dd227a9bc0e8b0364ee392edde8954e482","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        if not image:"},{"line_number":145,"context_line":"            self.fail_json(msg\u003d\"Image %s was not found!\" % self.params[\u0027image\u0027])"},{"line_number":146,"context_line":"        # admin_password is required by SDK, but not required by Nova API"},{"line_number":147,"context_line":"        if self.params[\u0027admin_password\u0027]:"},{"line_number":148,"context_line":"            self.conn.compute.rebuild_server("},{"line_number":149,"context_line":"                server\u003dos_server,"},{"line_number":150,"context_line":"                name\u003dos_server[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_6ae4630f","line":147,"in_reply_to":"ff570b3c_a3da2f1a","updated":"2020-06-11 14:56:03.000000000","message":"We are fixing it in the newest release of openstacksdk, not in all previous ones though.\nWould you want to fix it in all releases till rocky? Because it will be breaking change.","commit_id":"6aacaa3872c5851d690cbd0026565793a973999c"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"573140c422c5f4e8a4641797f886b81086099c39","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Wait for the server to reach the desired state for the given action.\"\"\""},{"line_number":162,"context_line":"        if not self.params[\u0027wait\u0027]:"},{"line_number":163,"context_line":"            return"},{"line_number":164,"context_line":"        for count in self.sdk.utils.iterate_timeout("},{"line_number":165,"context_line":"                self.params[\u0027timeout\u0027],"},{"line_number":166,"context_line":"                \"Timeout waiting for server to complete %s\" % self.params[\u0027action\u0027]):"},{"line_number":167,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_03395b3e","line":164,"updated":"2020-06-09 10:14:53.000000000","message":"can\u0027t we use a wait_for_server method directly? This is pretty much same code","commit_id":"6aacaa3872c5851d690cbd0026565793a973999c"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d58638dd227a9bc0e8b0364ee392edde8954e482","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        \"\"\"Wait for the server to reach the desired state for the given action.\"\"\""},{"line_number":162,"context_line":"        if not self.params[\u0027wait\u0027]:"},{"line_number":163,"context_line":"            return"},{"line_number":164,"context_line":"        for count in self.sdk.utils.iterate_timeout("},{"line_number":165,"context_line":"                self.params[\u0027timeout\u0027],"},{"line_number":166,"context_line":"                \"Timeout waiting for server to complete %s\" % self.params[\u0027action\u0027]):"},{"line_number":167,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff570b3c_ce6e38ff","line":164,"in_reply_to":"ff570b3c_03395b3e","updated":"2020-06-11 14:56:03.000000000","message":"need to use two objects because of SDK speficics, not sure if it\u0027s better","commit_id":"6aacaa3872c5851d690cbd0026565793a973999c"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"5ebca653ca91172fecd6bf50db8c2f446158c67d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        description:"},{"line_number":43,"context_line":"        - Image the server should be rebuilt with"},{"line_number":44,"context_line":"        type: str"},{"line_number":45,"context_line":"    admin_password:"},{"line_number":46,"context_line":"        description:"},{"line_number":47,"context_line":"        - Admin password for server to rebuild"},{"line_number":48,"context_line":"        type: str"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_941c806b","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":18},"updated":"2020-06-16 09:48:56.000000000","message":"This is a new parameter - shouldn\u0027t it be noted as new for version \u003cinsert number here\u003e?","commit_id":"62c3f7fc3f184306f754222eb7e801a0cfdb7f41"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"69b778ca0bdc9ba8cee0fc42558aba8adc874cf6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        description:"},{"line_number":43,"context_line":"        - Image the server should be rebuilt with"},{"line_number":44,"context_line":"        type: str"},{"line_number":45,"context_line":"    admin_password:"},{"line_number":46,"context_line":"        description:"},{"line_number":47,"context_line":"        - Admin password for server to rebuild"},{"line_number":48,"context_line":"        type: str"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_9463e0dc","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":18},"in_reply_to":"bf51134e_941c806b","updated":"2020-06-16 09:52:23.000000000","message":"Right, but \"version_added\" of ansible 2.10 is going via changes and it\u0027s not anymore ansible version, but collection version, and I\u0027d avoid to add it until right syntax is established there.","commit_id":"62c3f7fc3f184306f754222eb7e801a0cfdb7f41"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"d2a6c15379768bdadb6c2c3875730c4942f5d46a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        description:"},{"line_number":43,"context_line":"        - Image the server should be rebuilt with"},{"line_number":44,"context_line":"        type: str"},{"line_number":45,"context_line":"    admin_password:"},{"line_number":46,"context_line":"        description:"},{"line_number":47,"context_line":"        - Admin password for server to rebuild"},{"line_number":48,"context_line":"        type: str"}],"source_content_type":"text/x-python","patch_set":15,"id":"bf51134e_3494948b","line":45,"range":{"start_line":45,"start_character":4,"end_line":45,"end_character":18},"in_reply_to":"bf51134e_9463e0dc","updated":"2020-06-16 09:53:51.000000000","message":"Fair enough. Given this is optional, it\u0027s not a big deal.","commit_id":"62c3f7fc3f184306f754222eb7e801a0cfdb7f41"}]}