)]}'
{"id":"openstack%2Fansible-collections-openstack~724420","triplet_id":"openstack%2Fansible-collections-openstack~master~I0edbdb634feb90d4c54476a4089fcb014c0b83b2","project":"openstack/ansible-collections-openstack","branch":"master","topic":"rebuild-image","hashtags":[],"change_id":"I0edbdb634feb90d4c54476a4089fcb014c0b83b2","subject":"os_server_action: pass imageRef to rebuild","status":"MERGED","created":"2020-04-29 20:56:50.000000000","updated":"2020-05-04 18:36:38.000000000","submitted":"2020-05-04 18:36:38.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"724420-1588617398896-57c03af8","meta_rev_id":"488b335bea9a324cd2885ab135558c0ea69b2cf4","_number":724420,"virtual_id_number":724420,"owner":{"_account_id":16211,"name":"Ken Dreyer (Red Hat)","email":"kdreyer@redhat.com","username":"kdreyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"date":"2020-05-04 17:50:31.000000000","_account_id":16211,"name":"Ken Dreyer (Red Hat)","email":"kdreyer@redhat.com","username":"kdreyer"},{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-05-04 18:36:38.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"all":[{"value":2,"date":"2020-04-29 21:26:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":16211,"name":"Ken Dreyer (Red Hat)","email":"kdreyer@redhat.com","username":"kdreyer"},{"value":2,"date":"2020-05-04 17:42:41.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":16211,"name":"Ken Dreyer (Red Hat)","email":"kdreyer@redhat.com","username":"kdreyer"},{"value":1,"date":"2020-05-04 17:42:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":16211,"name":"Ken Dreyer (Red Hat)","email":"kdreyer@redhat.com","username":"kdreyer"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-04-29 21:26:04.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-05-04 17:42:41.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"},{"updated":"2020-05-04 18:36:38.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"683bdca18682e09a2c79a2ea0a7cf7ef68d8be07","author":{"_account_id":16211,"name":"Ken Dreyer (Red Hat)","email":"kdreyer@redhat.com","username":"kdreyer"},"date":"2020-04-29 20:56:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"28461a2411a6cf3383fab88815ca4ef28f74311c","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-04-29 21:26:04.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"d69b6ab9ef9d8d28d1af65582fc303e9caecfbd8","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-29 21:55:58.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/6d7913e86c114e45800b2efafcc6ecc6 : SUCCESS in 3m 26s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/7547e88af1f54ee894a463fb7986e7ee : SUCCESS in 5m 26s (non-voting)\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/f4a922a7b4a548cb86eff51e1cb7b8b5 : SUCCESS in 7m 51s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/c9f4787f9502425ebf5b9b1a9dbb63c1 : SUCCESS in 34m 03s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/cc60d6225b7c466c9a5b46abc6fce5e7 : SUCCESS in 41m 04s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/1b33af1ee29a4065ac77c199cb36fe45 : SUCCESS in 41m 18s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/21cb966db849496681ec78afe428e3e2 : SUCCESS in 42m 32s\n- ansible-collections-openstack-functional-devstack-train-ansible-devel https://zuul.opendev.org/t/openstack/build/c8d7a458cf104e40a1e81a954ba1b8b2 : SUCCESS in 46m 43s (non-voting)\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/8df58ed141b14470879955ba735d8450 : SUCCESS in 40m 48s\n- ansible-collections-openstack-functional-devstack-stein-ansible-devel https://zuul.opendev.org/t/openstack/build/3cd6a4bb5e3a492eaf842a09de7abf73 : SUCCESS in 40m 29s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/a01b3ecf94bd4cc1a89dd025a7a65c38 : SUCCESS in 46m 44s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-devel https://zuul.opendev.org/t/openstack/build/4940e0f1fb284fdcbc424784f9d87803 : SUCCESS in 40m 22s (non-voting)\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/9ce1dea852a749aa94200f8f1128209c : SUCCESS in 43m 18s","accounts_in_message":[],"_revision_number":1},{"id":"ac052fae873d47dbfc1a53a964a02efcf1c4e22d","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-05-02 12:17:51.000000000","message":"Patch Set 1: Code-Review+1\n\nSeems like it should raise an exception? https://opendev.org/openstack/nova/src/commit/3a0e5f985fdd4b067d68450360cf62d57e82ecb2/nova/api/openstack/compute/servers.py#L1054-L1055\n\nCan we have test for that?","accounts_in_message":[],"_revision_number":1},{"id":"d93e232910fbcb0b21e30aeb23d7c4b1fb38b689","author":{"_account_id":16211,"name":"Ken Dreyer (Red Hat)","email":"kdreyer@redhat.com","username":"kdreyer"},"date":"2020-05-04 16:43:39.000000000","message":"Patch Set 1:\n\nI wrote a small standalone script and verified that the following call to post() does return a \"Response [400]\".\n\n  url \u003d \u0027/servers/%s/action\u0027 % server_id\n  result \u003d cloud.compute.post(url, json\u003d{\u0027rebuild\u0027: None})\n\nWith my change here to add imageRef, post() returns a \"Response [202]\" instead.\n\nI guess the bigger problem is that we never check the HTTP return code of any of these post() calls.\n\nHow would you like to proceed?","accounts_in_message":[],"_revision_number":1},{"id":"37e5eaf9a15d3bf9c3be7632e94f87461d82fdd8","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-05-04 17:42:41.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nI see.. Actually I have a patch that adds tests for server action, so I\u0027ll add rebuild test there as well: https://review.opendev.org/#/c/721746\nI think we can proceed with that, thanks for the fix!","accounts_in_message":[],"_revision_number":1},{"id":"2c9efb94c05b8a869f936a42f12f261b4950715b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-04 17:42:54.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ac3bd6e2d37c1a6a249ea0aeb5d387455650dfa1","author":{"_account_id":16211,"name":"Ken Dreyer (Red Hat)","email":"kdreyer@redhat.com","username":"kdreyer"},"date":"2020-05-04 17:50:31.000000000","message":"Patch Set 1:\n\nThanks!","accounts_in_message":[],"_revision_number":1},{"id":"073bf235ea24955afebac447373524e9538eab1d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-04 18:36:38.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"5ce30e7ad498059e7c3696e2e674608fc6d20c4b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-04 18:36:38.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/f759d0984ba44f5e81d5e149578f8a69 : SUCCESS in 4m 02s\n- openstack-tox-linters https://zuul.opendev.org/t/openstack/build/7ea2acd847a2489682e6f146e1f0f2e1 : SUCCESS in 4m 24s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/f30e054fbfd642dda229eac1a75b68d5 : SUCCESS in 45m 53s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/08625ee93f1845219371c41c60b3d310 : SUCCESS in 41m 07s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/43673ce77d0547178812c5eafe454228 : SUCCESS in 47m 42s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/7bee313be5a14283b100ff644e0afdec : SUCCESS in 50m 16s\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/9d666e15ce0e4755a55d3dad6f87492f : SUCCESS in 46m 41s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/8167a7c853ae43cc86d5d57bec7f1268 : SUCCESS in 46m 27s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"25ad4882b0d9d2f079762be0a167ee94b7ab264f","revisions":{"25ad4882b0d9d2f079762be0a167ee94b7ab264f":{"kind":"REWORK","_number":1,"created":"2020-04-29 20:56:50.000000000","uploader":{"_account_id":16211,"name":"Ken Dreyer (Red Hat)","email":"kdreyer@redhat.com","username":"kdreyer"},"ref":"refs/changes/20/724420/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/20/724420/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/20/724420/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/20/724420/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/20/724420/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/20/724420/1"}}},"commit":{"parents":[{"commit":"b824bf1c384428a73e381f8e809938cc591ccb2b","subject":"Convert os_server_info to use OpenStackModule","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/b824bf1c384428a73e381f8e809938cc591ccb2b"}]}],"author":{"name":"Ken Dreyer","email":"kdreyer@redhat.com","date":"2020-04-29 20:52:49.000000000","tz":-360},"committer":{"name":"Ken Dreyer","email":"kdreyer@redhat.com","date":"2020-04-29 20:56:49.000000000","tz":-360},"subject":"os_server_action: pass imageRef to rebuild","message":"os_server_action: pass imageRef to rebuild\n\nPrior to this change, the os_server_action module could not rebuild\nservers, because it passed no arguments to the \"rebuild\" object.\n\nThe imageRef parameter is mandatory. If the client does not specify\nimageRef, Nova takes no action to rebuild the server.\n\nChange-Id: I0edbdb634feb90d4c54476a4089fcb014c0b83b2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/25ad4882b0d9d2f079762be0a167ee94b7ab264f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/25ad4882b0d9d2f079762be0a167ee94b7ab264f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}