)]}'
{"id":"openstack%2Fansible-collections-openstack~734810","triplet_id":"openstack%2Fansible-collections-openstack~master~Iecb2ba09da8f7618ef9415675fe82f7f773a4e1c","project":"openstack/ansible-collections-openstack","branch":"master","hashtags":[],"change_id":"Iecb2ba09da8f7618ef9415675fe82f7f773a4e1c","subject":"Fix idempotency with server security groups","status":"ABANDONED","created":"2020-06-10 12:40:30.000000000","updated":"2022-02-22 08:46:41.000000000","total_comment_count":5,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"a63d77046b9ec7d17ee243cd0e2e68d6a1593ddd","_number":734810,"virtual_id_number":734810,"owner":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"date":"2020-07-08 23:40:51.000000000","_account_id":26299,"name":"Tatsuma Matsuki","email":"matsuki.tatsuma@jp.fujitsu.com","username":"tatsuma"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-06-10 15:09:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":-1,"date":"2020-06-12 18:53:40.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26299,"name":"Tatsuma Matsuki","email":"matsuki.tatsuma@jp.fujitsu.com","username":"tatsuma"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":26299,"name":"Tatsuma Matsuki","email":"matsuki.tatsuma@jp.fujitsu.com","username":"tatsuma"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26299,"name":"Tatsuma Matsuki","email":"matsuki.tatsuma@jp.fujitsu.com","username":"tatsuma"}],"CC":[{"_account_id":34581,"name":"Ian P. Christian","email":"pookey@pookey.co.uk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-10 15:09:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-06-12 18:53:40.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"},{"updated":"2020-07-08 23:40:51.000000000","updated_by":{"_account_id":26299,"name":"Tatsuma Matsuki","email":"matsuki.tatsuma@jp.fujitsu.com","username":"tatsuma"},"reviewer":{"_account_id":26299,"name":"Tatsuma Matsuki","email":"matsuki.tatsuma@jp.fujitsu.com","username":"tatsuma"},"state":"REVIEWER"},{"updated":"2022-02-22 08:46:41.000000000","updated_by":{"_account_id":34581,"name":"Ian P. Christian","email":"pookey@pookey.co.uk"},"reviewer":{"_account_id":34581,"name":"Ian P. Christian","email":"pookey@pookey.co.uk"},"state":"CC"}],"messages":[{"id":"4f161ea235f3cd7bf1fec8dddda73c753b07aeee","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-06-10 12:40:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"82145d8590d0936ef1bdb1115beb3d2bfa6b94c8","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-06-10 12:59:00.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)\n\nneed a test as well","accounts_in_message":[],"_revision_number":1},{"id":"3fa88239510458cd9c9868bfa1f2baee47580064","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-10 13:00:59.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/fcf39e892f794f1a87981de71212efab : SUCCESS in 3m 32s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/e9e98271d63e4246bb444f1c63e526f8 : FAILURE in 8m 11s (non-voting)\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/093e030478ce45dbb04e197fafd51d5b : FAILURE in 5m 49s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-train-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-stein-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-rocky-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.9-pip https://zuul.opendev.org/t/openstack/build/None : SKIPPED","accounts_in_message":[],"_revision_number":1},{"id":"9e74b18b6a15c29c54e6e90cb6545b93b862e9bd","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-06-10 13:45:57.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"010f6f579601af5647d9e8da820ffe7eca3a603c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-10 15:09:14.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/40ccb5562f734cf6bfeb7363fc85eb0d : SUCCESS in 4m 04s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/b957e543ca0340b0bcba4492c093bba6 : FAILURE in 11m 40s (non-voting)\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/ea54ccdeddc849ac9645582fbee709c2 : SUCCESS in 9m 23s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/601b88c9ad114afe95f8cd7d120367e3 : SUCCESS in 50m 33s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/b0c7df865c424e1081a10db997129542 : SUCCESS in 45m 39s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/c3c53baf1d5741529d1cd9a4448437f5 : SUCCESS in 51m 49s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/1193f47f106a461ea2e5138a88bb7f26 : SUCCESS in 1h 09m 24s\n- ansible-collections-openstack-functional-devstack-train-ansible-devel https://zuul.opendev.org/t/openstack/build/9b413f42bdc04648887ecde83c8f4a98 : SUCCESS in 50m 06s (non-voting)\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/b3195c66cc7a43959552a311b391848c : SUCCESS in 43m 39s\n- ansible-collections-openstack-functional-devstack-stein-ansible-devel https://zuul.opendev.org/t/openstack/build/41a85504988145a195ef3c11f455b394 : SUCCESS in 44m 27s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/e249963a49c24abc8e3e0cc791e3febb : SUCCESS in 53m 23s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-devel https://zuul.opendev.org/t/openstack/build/37aa892b9dc9466080a0c6de6970a434 : SUCCESS in 52m 38s (non-voting)\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/1e2316e4ae9c49d1b8a0facd6580df8c : SUCCESS in 51m 34s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.9 https://zuul.opendev.org/t/openstack/build/c9669746219b4da2af084600715360e8 : SUCCESS in 45m 27s\n- ansible-collections-openstack-functional-devstack-ansible-2.9-pip https://zuul.opendev.org/t/openstack/build/35353de44a5242ef8c3fd6a4f29f2d52 : SUCCESS in 1h 00m 11s","accounts_in_message":[],"_revision_number":2},{"id":"245e1979351bf1f04510acdbae9e0ecd0c71b5a2","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-06-12 18:53:40.000000000","message":"Patch Set 2: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"8fd182f6849c0d31bf63606567124bf22dd11264","author":{"_account_id":26299,"name":"Tatsuma Matsuki","email":"matsuki.tatsuma@jp.fujitsu.com","username":"tatsuma"},"date":"2020-07-08 23:40:51.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f0fba83baa7f4a2b3ca666ae111af3d8864892b2","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-07-10 12:54:05.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4ad572dcf7e8614daa86675c118cc34ed8900e48","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-08-05 11:37:29.000000000","message":"Abandoned\n\nThis patch will be abandoned due to the long inactivity, please feel free to restore it in case you would like to continue to work on it. Thanks","accounts_in_message":[],"_revision_number":2},{"id":"a63d77046b9ec7d17ee243cd0e2e68d6a1593ddd","author":{"_account_id":34581,"name":"Ian P. Christian","email":"pookey@pookey.co.uk"},"date":"2022-02-22 08:46:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b2f20669c509ff8494685f71c8158c13a1a5bf4e","revisions":{"731b85b9e021aa0be7b1c9fda6acea59b1ae2396":{"kind":"REWORK","_number":1,"created":"2020-06-10 12:40:30.000000000","uploader":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"ref":"refs/changes/10/734810/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/10/734810/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/734810/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/734810/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/734810/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/734810/1"}}},"commit":{"parents":[{"commit":"c9da50e7e7a14edc997240dd53528f2fdded7009","subject":"Add setup.py for install with pip","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/c9da50e7e7a14edc997240dd53528f2fdded7009"}]}],"author":{"name":"AndyO91","email":"andy.oboeuf@gmail.com","date":"2020-06-10 12:38:32.000000000","tz":-300},"committer":{"name":"Monty Taylor","email":"mordred@inaugust.com","date":"2020-06-10 12:38:32.000000000","tz":-300},"subject":"Fix idempotency with server security groups","message":"Fix idempotency with server security groups\n\nWhen a server is created with multiple nics which hold security\ngroups, the server module was applying a default SG to the server\nwhich removed SG on the nics. Since the default security group is,\nin fact, default, we don\u0027t need to force send it here.\n\nRemove the default value and let the server-side default value\nwork, which will allow people to correctly omit it from their\nmodules when needed.\n\nChange-Id: Iecb2ba09da8f7618ef9415675fe82f7f773a4e1c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/731b85b9e021aa0be7b1c9fda6acea59b1ae2396"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/731b85b9e021aa0be7b1c9fda6acea59b1ae2396"}]},"branch":"refs/heads/master"},"b2f20669c509ff8494685f71c8158c13a1a5bf4e":{"kind":"REWORK","_number":2,"created":"2020-06-10 13:45:57.000000000","uploader":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"ref":"refs/changes/10/734810/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/10/734810/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/734810/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/734810/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/734810/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/734810/2"}}},"commit":{"parents":[{"commit":"c9da50e7e7a14edc997240dd53528f2fdded7009","subject":"Add setup.py for install with pip","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/c9da50e7e7a14edc997240dd53528f2fdded7009"}]}],"author":{"name":"AndyO91","email":"andy.oboeuf@gmail.com","date":"2020-06-10 12:38:32.000000000","tz":-300},"committer":{"name":"Sagi Shnaidman","email":"sshnaidm@redhat.com","date":"2020-06-10 13:44:52.000000000","tz":0},"subject":"Fix idempotency with server security groups","message":"Fix idempotency with server security groups\n\nWhen a server is created with multiple nics which hold security\ngroups, the server module was applying a default SG to the server\nwhich removed SG on the nics. Since the default security group is,\nin fact, default, we don\u0027t need to force send it here.\n\nRemove the default value and let the server-side default value\nwork, which will allow people to correctly omit it from their\nmodules when needed.\n\nChange-Id: Iecb2ba09da8f7618ef9415675fe82f7f773a4e1c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/b2f20669c509ff8494685f71c8158c13a1a5bf4e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/b2f20669c509ff8494685f71c8158c13a1a5bf4e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}