)]}'
{"id":"openstack%2Fansible-collections-openstack~737519","triplet_id":"openstack%2Fansible-collections-openstack~master~I990098a5a33e0ccfbef9f853d3df7a1c30be7c8b","project":"openstack/ansible-collections-openstack","branch":"master","topic":"bug/2007845","hashtags":[],"change_id":"I990098a5a33e0ccfbef9f853d3df7a1c30be7c8b","subject":"Only remove/add interfaces when needed.","status":"ABANDONED","created":"2020-06-23 12:28:25.000000000","updated":"2021-08-05 11:37:19.000000000","total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d2b33fbb769d91e6fe7c043843d3e7570e0aa0f1","_number":737519,"virtual_id_number":737519,"owner":{"_account_id":31975,"name":"Olaf Seibert","email":"o.seibert@syseleven.de","username":"oseiberts11"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2020-06-23 18:56:54.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-23 18:56:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"dfd453d0c37866f424d12146ac7c017e40c672c2","author":{"_account_id":31975,"name":"Olaf Seibert","email":"o.seibert@syseleven.de","username":"oseiberts11"},"date":"2020-06-23 12:28:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cc3f28bf3ed63de87f8f43b54c0f339d7ba3004c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 12:48:17.000000000","message":"Patch Set 1: Verified-1\n\n(6 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/639b940cce9c410b8669e5af9b546c9c : FAILURE in 4m 57s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/79b26328b19a45ceb52b0580e430337b : POST_FAILURE in 5m 31s (non-voting)\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/68883cb7b00b47aea740cd9adb03d7c4 : FAILURE in 6m 31s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-train-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-stein-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-rocky-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.9-pip https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n\nWarning:\n  Job tox-pep8: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job tox-pep8: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job tox-pep8: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-devel: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-devel: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-devel: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Comments left for invalid file plugins/modules/os_router.py","accounts_in_message":[],"_revision_number":1},{"id":"76cb9d858296e5ea734bbddfa63758611a661c2a","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-06-23 18:42:25.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"94020252854de078dd646383582665e60cd75514","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 18:56:54.000000000","message":"Patch Set 2: Verified-1\n\n(12 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/93ba5a6725d041e6967feef134d682d4 : FAILURE in 4m 09s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/145294b53c0a4c7ca93b11d5cce4e0a0 : FAILURE in 5m 40s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/8766affdeac1437493c965b8c2fd6093 : FAILURE in 5m 51s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/ec1fb342cf50491289b89b329d0fac0d : FAILURE in 7m 56s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n\nWarning:\n  Job tox-pep8: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job tox-pep8: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job tox-pep8: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-2.10: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-2.10: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-2.10: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-devel: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-devel: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-devel: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-2.9: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-2.9: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-2.9: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_router.py has only 1 lines\u0027\n  Comments left for invalid file plugins/modules/os_router.py","accounts_in_message":[],"_revision_number":2},{"id":"d2b33fbb769d91e6fe7c043843d3e7570e0aa0f1","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-08-05 11:37:19.000000000","message":"Abandoned\n\nThis patch will be abandoned due to the long inactivity, please feel free to restore it in case you would like to continue to work on it. Thanks","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"47316b579b3a907ae2f0205502cd13a54de7bf48","revisions":{"4fc9da53804d233bd2b6eaff65554632aafadb44":{"kind":"REWORK","_number":1,"created":"2020-06-23 12:28:25.000000000","uploader":{"_account_id":31975,"name":"Olaf Seibert","email":"o.seibert@syseleven.de","username":"oseiberts11"},"ref":"refs/changes/19/737519/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/19/737519/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/19/737519/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/19/737519/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/19/737519/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/19/737519/1"}}},"commit":{"parents":[{"commit":"5e3a91a7c63355949a8b7c4cc664fab66a853f7c","subject":"Add OpenstackModule to os_server_action","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/5e3a91a7c63355949a8b7c4cc664fab66a853f7c"}]}],"author":{"name":"Olaf Seibert","email":"o.seibert@syseleven.de","date":"2020-06-23 12:02:32.000000000","tz":120},"committer":{"name":"Olaf Seibert","email":"o.seibert@syseleven.de","date":"2020-06-23 12:24:12.000000000","tz":120},"subject":"Only remove/add interfaces when needed.","message":"Only remove/add interfaces when needed.\n\nThis is a first stab at the problem. I have reused some principles from\na fix for the same problem in a much older version of this module.\n\nI\u0027m not quite sure about the criteria for deleting a port. According to\nthe data structures, a port can have multiple (fixed ip, subnet) pairs.\nHowever, given the description of a port (\"A port is a connection point\nfor attaching a single device, such as the NIC of a server, to a\nnetwork.\"), multiple subnets make no sense (and multiple IP addresses on\na single subnet ony marginally). So some guidance here would be welcome.\n\nChange-Id: I990098a5a33e0ccfbef9f853d3df7a1c30be7c8b\nStory: 2007845\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/4fc9da53804d233bd2b6eaff65554632aafadb44"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/4fc9da53804d233bd2b6eaff65554632aafadb44"}]},"branch":"refs/heads/master"},"47316b579b3a907ae2f0205502cd13a54de7bf48":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-06-23 18:42:25.000000000","uploader":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"ref":"refs/changes/19/737519/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/19/737519/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/19/737519/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/19/737519/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/19/737519/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/19/737519/2"}}},"commit":{"parents":[{"commit":"4b64ebe6233d54d498af037f93a565c62cef08c4","subject":"Fix typos in job definitions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/4b64ebe6233d54d498af037f93a565c62cef08c4"}]}],"author":{"name":"Olaf Seibert","email":"o.seibert@syseleven.de","date":"2020-06-23 12:02:32.000000000","tz":120},"committer":{"name":"Sagi Shnaidman","email":"sshnaidm@redhat.com","date":"2020-06-23 18:42:25.000000000","tz":0},"subject":"Only remove/add interfaces when needed.","message":"Only remove/add interfaces when needed.\n\nThis is a first stab at the problem. I have reused some principles from\na fix for the same problem in a much older version of this module.\n\nI\u0027m not quite sure about the criteria for deleting a port. According to\nthe data structures, a port can have multiple (fixed ip, subnet) pairs.\nHowever, given the description of a port (\"A port is a connection point\nfor attaching a single device, such as the NIC of a server, to a\nnetwork.\"), multiple subnets make no sense (and multiple IP addresses on\na single subnet ony marginally). So some guidance here would be welcome.\n\nChange-Id: I990098a5a33e0ccfbef9f853d3df7a1c30be7c8b\nStory: 2007845\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/47316b579b3a907ae2f0205502cd13a54de7bf48"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/47316b579b3a907ae2f0205502cd13a54de7bf48"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}