)]}'
{"plugins/modules/lb_health_monitor.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e9b344a285a56a5577a736ad8eda08df307618f9","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"__metaclass__ \u003d type"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"ANSIBLE_METADATA \u003d {\u0027metadata_version\u0027: \u00271.0\u0027,"},{"line_number":11,"context_line":"                    \u0027status\u0027: [\u0027preview\u0027],"},{"line_number":12,"context_line":"                    \u0027supported_by\u0027: \u0027community\u0027}"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":15,"context_line":"---"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_d94b1484","line":12,"range":{"start_line":10,"start_character":0,"end_line":12,"end_character":48},"updated":"2020-09-25 08:44:16.000000000","message":"not needed anymore, in general there are ansible-test failures that need to be resolved: https://zuul.opendev.org/t/openstack/build/9ac25e3a3ae44d8aa5e58687142e42da/log/job-output.txt#1434","commit_id":"10fbf1fac03efda3ceef35cf9d0f95badc48557d"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e9b344a285a56a5577a736ad8eda08df307618f9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"    )"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"def main():"},{"line_number":131,"context_line":"    argument_spec \u003d openstack_full_argument_spec("},{"line_number":132,"context_line":"        name\u003ddict(required\u003dTrue),"},{"line_number":133,"context_line":"        delay\u003ddict(required\u003dTrue),"},{"line_number":134,"context_line":"        max_retries\u003ddict(required\u003dTrue),"},{"line_number":135,"context_line":"        max_retries_down\u003ddict(required\u003dFalse, default\u003d\"3\", type\u003dstr),"},{"line_number":136,"context_line":"        timeout\u003ddict(required\u003dTrue, type\u003dint),"},{"line_number":137,"context_line":"        pool\u003ddict(required\u003dTrue),"},{"line_number":138,"context_line":"        expected_codes\u003ddict(required\u003dFalse, default\u003d\"200\", type\u003dstr),"},{"line_number":139,"context_line":"        admin_state_up\u003ddict(required\u003dFalse, default\u003dTrue, type\u003dbool),"},{"line_number":140,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"},{"line_number":141,"context_line":"        http_method\u003ddict(default\u003d\"GET\", requried\u003dFalse, type\u003dstr, choices\u003d[\"GET\", \"CONNECT\", \"DELETE\", \"HEAD\", \"OPTIONS\", \"PATCH\", \"POST\", \"PUT\", \"TRACE\"]),"},{"line_number":142,"context_line":"        url_path\u003ddict(default\u003d\"/\", requires\u003dFalse, type\u003dstr),"},{"line_number":143,"context_line":"        type\u003ddict(default\u003d\u0027HTTP\u0027,"},{"line_number":144,"context_line":"                  choices\u003d[\u0027HTTP\u0027, \u0027HTTPS\u0027, \u0027PING\u0027, \u0027SCTP\u0027, \u0027TCP\u0027, \u0027TLS-HELLO\u0027, \u0027UDP-CONNECT\u0027]),"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    )"},{"line_number":147,"context_line":"    module_kwargs \u003d openstack_module_kwargs("}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_590d443c","line":144,"range":{"start_line":130,"start_character":0,"end_line":144,"end_character":96},"updated":"2020-09-25 08:44:16.000000000","message":"please use the new format of Openstack modules using OpenstackModule class, it will save you a lot of code and fixes: https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/modules/server.py#L616\nor https://github.com/openstack/ansible-collections-openstack/blob/master/plugins/modules/server_info.py#L63","commit_id":"10fbf1fac03efda3ceef35cf9d0f95badc48557d"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"3b06f9b2add4415604151a572b16c18f70319bb2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"---"},{"line_number":12,"context_line":"module: lb_health_monitor"},{"line_number":13,"context_line":"author:"},{"line_number":14,"context_line":"    - Jesper Schmitz Mouridsen (@jsm222)\""},{"line_number":15,"context_line":"short_description: Add/Delete a health monitor to a pool in the load balancing service from OpenStack Cloud"},{"line_number":16,"context_line":"description:"},{"line_number":17,"context_line":"   - Add or Remove a health monitor from a pool in the OpenStack load-balancer service."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f799a07a","line":14,"updated":"2020-09-28 14:30:04.000000000","message":"We now place general SIG as an author (i.e. in https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/modules/baremetal_node.py#L11)","commit_id":"9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"3b06f9b2add4415604151a572b16c18f70319bb2","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        self._fail_json(msg\u003d\"timeout waiting for health monitor %s to transition to %s\" %"},{"line_number":218,"context_line":"                        (health_monitor_id, status)"},{"line_number":219,"context_line":"                        )"},{"line_number":220,"context_line":"    argument_spec \u003d dict("},{"line_number":221,"context_line":"        name\u003ddict(required\u003dTrue),"},{"line_number":222,"context_line":"        delay\u003ddict(required\u003dTrue),"},{"line_number":223,"context_line":"        max_retries\u003ddict(required\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f772404a","line":220,"updated":"2020-09-28 14:30:04.000000000","message":"my eye is missing empty line between lines","commit_id":"9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"3b06f9b2add4415604151a572b16c18f70319bb2","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        expected_codes\u003ddict(required\u003dFalse, default\u003d\"200\"),"},{"line_number":228,"context_line":"        admin_state_up\u003ddict(required\u003dFalse, default\u003dTrue, type\u003d\u0027bool\u0027),"},{"line_number":229,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"},{"line_number":230,"context_line":"        http_method\u003ddict(default\u003d\"GET\", requried\u003dFalse, choices\u003d[\"GET\", \"CONNECT\", \"DELETE\", \"HEAD\", \"OPTIONS\", \"PATCH\", \"POST\", \"PUT\", \"TRACE\"]),"},{"line_number":231,"context_line":"        url_path\u003ddict(default\u003d\"/\", requires\u003dFalse),"},{"line_number":232,"context_line":"        type\u003ddict(default\u003d\u0027HTTP\u0027,"},{"line_number":233,"context_line":"                  choices\u003d[\u0027HTTP\u0027, \u0027HTTPS\u0027, \u0027PING\u0027, \u0027SCTP\u0027, \u0027TCP\u0027, \u0027TLS-HELLO\u0027, \u0027UDP-CONNECT\u0027]),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_378af812","line":230,"updated":"2020-09-28 14:30:04.000000000","message":"perhaps make line shorter? Not sure though what is our pep verifying here","commit_id":"9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"3b06f9b2add4415604151a572b16c18f70319bb2","unresolved":false,"context_lines":[{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def run(self):"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        try:"},{"line_number":240,"context_line":"            changed \u003d False"},{"line_number":241,"context_line":"            health_monitor \u003d self.conn.load_balancer.find_health_monitor(name_or_id\u003dself.params[\u0027name\u0027])"},{"line_number":242,"context_line":"            pool \u003d self.conn.load_balancer.find_pool(name_or_id\u003dself.params[\u0027pool\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_57996c6b","line":239,"updated":"2020-09-28 14:30:04.000000000","message":"module is not supporting check mode (https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/modules/server_action.py#L101)\nOther LB modules doesn\u0027t support it either, but it is not a reason not to implement it for new module","commit_id":"9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"3b06f9b2add4415604151a572b16c18f70319bb2","unresolved":false,"context_lines":[{"line_number":258,"context_line":"                    health_monitor \u003d self.conn.load_balancer.create_health_monitor(**health_attrs)"},{"line_number":259,"context_line":"                    if not self.params[\u0027wait\u0027]:"},{"line_number":260,"context_line":"                        self.exit_json(changed\u003dchanged,"},{"line_number":261,"context_line":"                                       health_monitor\u003dhealth_monitor.to_dict())"},{"line_number":262,"context_line":"                    if self.params[\u0027wait\u0027]:"},{"line_number":263,"context_line":"                        health_monitor \u003d self._wait_for_health_monitor_status(health_monitor.id, \"ACTIVE\", [\"ERROR\"])"},{"line_number":264,"context_line":"                        self.exit_json(changed\u003dchanged,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f74360af","line":261,"updated":"2020-09-28 14:30:04.000000000","message":"on exit_json we prefer to \"export\" also id attribute explicitly","commit_id":"9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"3b06f9b2add4415604151a572b16c18f70319bb2","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                    if not self.params[\u0027wait\u0027]:"},{"line_number":260,"context_line":"                        self.exit_json(changed\u003dchanged,"},{"line_number":261,"context_line":"                                       health_monitor\u003dhealth_monitor.to_dict())"},{"line_number":262,"context_line":"                    if self.params[\u0027wait\u0027]:"},{"line_number":263,"context_line":"                        health_monitor \u003d self._wait_for_health_monitor_status(health_monitor.id, \"ACTIVE\", [\"ERROR\"])"},{"line_number":264,"context_line":"                        self.exit_json(changed\u003dchanged,"},{"line_number":265,"context_line":"                                       health_monitor\u003dhealth_monitor.to_dict())"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_77091083","line":262,"updated":"2020-09-28 14:30:04.000000000","message":"what about improving this to \"else\" or \"elif\" at least?","commit_id":"9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"3b06f9b2add4415604151a572b16c18f70319bb2","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                    if self.params[\u0027wait\u0027]:"},{"line_number":263,"context_line":"                        health_monitor \u003d self._wait_for_health_monitor_status(health_monitor.id, \"ACTIVE\", [\"ERROR\"])"},{"line_number":264,"context_line":"                        self.exit_json(changed\u003dchanged,"},{"line_number":265,"context_line":"                                       health_monitor\u003dhealth_monitor.to_dict())"},{"line_number":266,"context_line":"                else:"},{"line_number":267,"context_line":"                    self.exit_json(changed\u003dchanged, health_monitor\u003dhealth_monitor.to_dict())"},{"line_number":268,"context_line":"            elif self.params[\u0027state\u0027] \u003d\u003d \u0027absent\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_b7228801","line":265,"updated":"2020-09-28 14:30:04.000000000","message":"here the same - id","commit_id":"9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"3b06f9b2add4415604151a572b16c18f70319bb2","unresolved":false,"context_lines":[{"line_number":264,"context_line":"                        self.exit_json(changed\u003dchanged,"},{"line_number":265,"context_line":"                                       health_monitor\u003dhealth_monitor.to_dict())"},{"line_number":266,"context_line":"                else:"},{"line_number":267,"context_line":"                    self.exit_json(changed\u003dchanged, health_monitor\u003dhealth_monitor.to_dict())"},{"line_number":268,"context_line":"            elif self.params[\u0027state\u0027] \u003d\u003d \u0027absent\u0027:"},{"line_number":269,"context_line":"                if health_monitor:"},{"line_number":270,"context_line":"                    self.conn.load_balancer.delete_health_monitor(health_monitor)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f560f44_f71c00c4","line":267,"updated":"2020-09-28 14:30:04.000000000","message":"and here","commit_id":"9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f"}]}