)]}'
{"id":"openstack%2Fansible-collections-openstack~753306","triplet_id":"openstack%2Fansible-collections-openstack~master~I6119f5be02ace88253cba448f5a0699b39ea9ee1","project":"openstack/ansible-collections-openstack","branch":"master","topic":"healthmonitor","hashtags":[],"change_id":"I6119f5be02ace88253cba448f5a0699b39ea9ee1","subject":"Make it possible to create a health monitor to a pool","status":"MERGED","created":"2020-09-22 13:15:46.000000000","updated":"2020-09-30 07:54:37.000000000","submitted":"2020-09-30 07:54:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"753306-1601452477348-083bfdef","meta_rev_id":"5dfb8b07bee870f76c9e12c89a12428125cc5a88","_number":753306,"virtual_id_number":753306,"owner":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-09-30 07:54:37.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":2,"date":"2020-09-29 13:23:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":2,"date":"2020-09-30 06:31:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":1,"date":"2020-09-30 06:31:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-09-29 13:23:08.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"},{"updated":"2020-09-30 06:31:07.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2020-09-30 07:54:37.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"0ce8fe665127dcdbc7a7691312aee2e70ac95b95","author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"date":"2020-09-22 13:15:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c71e62f716880665150b7da1c92061ee31d39632","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-22 13:27:59.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/8cde8b53ad1e4072ad3d11b8b9360351 : SUCCESS in 2m 50s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/a203896eed2f4f79aa6973b7971806f9 : FAILURE in 5m 43s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/fe1cd6e505324932ac12e275c4733463 : FAILURE in 4m 32s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/6a2f8457360c4b1e83d69f76506ccee9 : FAILURE in 4m 55s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d8a267434f8a0e14d989576c9a21dda9903d463a","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-09-25 00:24:41.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"bfeb3a87b0bbd613890653855aff8c9a3b3dc521","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-25 00:37:00.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/b2e25836a0714161a61baec6b91a2066 : SUCCESS in 3m 53s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/d4e7493d4e1542aa8ee708c86852f4ad : FAILURE in 6m 36s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/04a053acc23d43a89a248315ca8ab9eb : FAILURE in 5m 39s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/9ac25e3a3ae44d8aa5e58687142e42da : FAILURE in 6m 38s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e9b344a285a56a5577a736ad8eda08df307618f9","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-09-25 08:44:16.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"40682830473d0c0b58dc270da7b02cad09fe60eb","author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"date":"2020-09-25 11:03:56.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"695d61a16e0d1083b3f529c270d7ce6e0966d618","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-25 12:31:49.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/9c3cbc3926e240e895558c8cf55deb2f : SUCCESS in 3m 40s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/30e7c3fccf38495c93122ed4aca7bc73 : SUCCESS in 6m 57s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/1c06a2e293b349259ba7a4d6044e528e : SUCCESS in 5m 53s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/4091b429ba774e52be59efd90a4e20af : SUCCESS in 7m 21s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/f5bbef3363bf4068b1bce566a7ed097b : SUCCESS in 46m 17s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/bc7a6c17f5db4d98a86fe11924c316e1 : SUCCESS in 45m 06s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/1f055671d72142a6a74cd6ffd5d8a997 : SUCCESS in 45m 20s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/c8fd867d832e4fe5bd96f2266d046ac4 : SUCCESS in 43m 01s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/7ea0e6b985294c1eaabbf821d82cdfa9 : SUCCESS in 38m 28s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/391c6127aafe4d488ef5c8e7772d3c53 : SUCCESS in 41m 22s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.9 https://zuul.opendev.org/t/openstack/build/b52ac3cf64ea4c04a46029c1270040aa : SUCCESS in 38m 32s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/a830f1d6fd33445888fab8e42ac74f1b : SUCCESS in 51m 18s\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/d150f0b930e54d1789712caca8f67f54 : SUCCESS in 47m 03s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/155fd280d3ad4e5699da7d2c0fae93d4 : SUCCESS in 50m 47s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.9 https://zuul.opendev.org/t/openstack/build/c9d7e52477084e10934d7ddf39d633bc : SUCCESS in 39m 07s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/9d35f690f3f4458bba2ba4f4d6e57f04 : SUCCESS in 24m 32s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/b75f04de9d3e43e5bb7547464c26e4e5 : SUCCESS in 22m 50s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"4d80ed030fc79fe92646d853aa0fa123a8f33faf","author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"date":"2020-09-25 12:53:50.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"1f83aac1b252f16fec9804b3f48a2ae1a8f7fa0f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-25 14:50:15.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/ba4e0670d7ac4b08bc175c509a447ae3 : SUCCESS in 3m 15s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/807e5f15c010457e9c1d3a90d8fd9259 : SUCCESS in 6m 03s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/16b68b4db47d4278a8ebf84c789f5377 : SUCCESS in 7m 36s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/89525b2e9d6f4493b7cdd34ff39ffdb6 : SUCCESS in 7m 56s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/071b5c7016f7431bb8d7ab3380df36d5 : SUCCESS in 38m 00s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/5bfe38d4866749b6a349d3046640afea : SUCCESS in 40m 52s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/2d62f38a174d464584b8767cfca495fd : SUCCESS in 44m 33s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/87a60c1da4684d15bdf3ff15f21f8caf : SUCCESS in 46m 05s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/7025693c1b8f4e1ba9ba6384b418e677 : SUCCESS in 47m 22s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/41ba98d4d9ba42a588287a1319d9d2d3 : SUCCESS in 44m 28s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.9 https://zuul.opendev.org/t/openstack/build/b26d195eb4124cffb189268162d0d67d : SUCCESS in 50m 01s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/b266da620eee479bbc75d1ac9e2ec01b : SUCCESS in 52m 31s\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/bd1cca9bed1c4216a02af495ede3f5aa : SUCCESS in 1h 41m 53s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/d747b1b6601d449982a3dc80c732a003 : SUCCESS in 48m 07s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.9 https://zuul.opendev.org/t/openstack/build/9b68cd60c51f4340b34ad281c3548268 : SUCCESS in 41m 19s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/cb057318af8a406faa666fe861a078f9 : SUCCESS in 20m 40s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/db117f5aa8254d19a7b589c6ef0a26f2 : SUCCESS in 25m 17s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"f10ffe8fc1293924af4bca305995ba788c1e4898","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-09-25 16:06:39.000000000","message":"Patch Set 4: Code-Review+1\n\n@Jesper, thanks! Can you think about tests for it?","accounts_in_message":[],"_revision_number":4},{"id":"17d905a9eddac8dc2f9d70e7ffd395167bca5774","author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"date":"2020-09-25 17:14:18.000000000","message":"Patch Set 4:\n\n\u003e @Jesper, thanks! Can you think about tests for it?\nIt seemss to me that a CI test requires changes to the devstack setup in the zuul jobs, since the octavia services does not seem to be in ENABLED_SERVICES.. I\u0027m I wrong? What else can be written for testing?","accounts_in_message":[],"_revision_number":4},{"id":"c5e7def975862a4ec7fc7f3ae91d63fc3a0e60f1","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-09-27 11:39:32.000000000","message":"Patch Set 4: Code-Review+2\n\nYeah, correct. We\u0027ll need a different setup. Let\u0027s not block on this, but I\u0027d appreciate if you have ideas how it should be set up and tested.","accounts_in_message":[],"_revision_number":4},{"id":"c25e6a7998adee5e43bb9355f00d854a887708fb","author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"date":"2020-09-27 21:27:24.000000000","message":"Patch Set 4:\n\n\u003e Yeah, correct. We\u0027ll need a different setup. Let\u0027s not block on\n \u003e this, but I\u0027d appreciate if you have ideas how it should be set up\n \u003e and tested.\n\n\nAs I see it it would require more than a role i.e a separate playbook, if the health monitor should have a live member to check. I made the following only syntax checked playbook https://gist.github.com/jsm222/352ea6fe7ae4446bed39ed788d738827 I\u0027m not sure the different return variables are used correctly, but the idea is to follow https://docs.openstack.org/devstack/latest/guides/devstack-with-lbaas-v2.html \n\nAnother thing in my EXAMPLE I have resp_timeout \u003e delay but timeout must be less than delay. Also this requirement should be in DOCUMENTATION as octavia api does not seem to error out on that. This requires a new PATCH SET (?), I\u0027ll wait with that until I or someone else has further comments.","accounts_in_message":[],"_revision_number":4},{"id":"3b06f9b2add4415604151a572b16c18f70319bb2","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2020-09-28 14:30:04.000000000","message":"Patch Set 4: Code-Review-1\n\n(8 comments)","accounts_in_message":[],"_revision_number":4},{"id":"aa772affb979b2d9e9b59ad1a3f45b43c2afe38d","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2020-09-28 14:33:16.000000000","message":"Patch Set 4:\n\n\u003e As I see it it would require more than a role i.e a separate\n \u003e playbook, if the health monitor should have a live member to check.\n \u003e I made the following only syntax checked playbook https://gist.github.com/jsm222/352ea6fe7ae4446bed39ed788d738827\n \u003e I\u0027m not sure the different return variables are used correctly, but\n \u003e the idea is to follow https://docs.openstack.org/devstack/latest/guides/devstack-with-lbaas-v2.html\n \u003e \n \u003e Another thing in my EXAMPLE I have resp_timeout \u003e delay but timeout\n \u003e must be less than delay. Also this requirement should be in\n \u003e DOCUMENTATION as octavia api does not seem to error out on that.\n \u003e This requires a new PATCH SET (?), I\u0027ll wait with that until I or\n \u003e someone else has further comments.\n\nI can think of 2 options:\n\n- do not try to verify Octavia itself. In this case I would vote for writing unittest ensuring module invokes SDK with the expected params\n\n- create https://opendev.org/openstack/openstacksdk/src/branch/master/.zuul.yaml#L135 job with octavia and a complex functional test:\n\n  - create lb\n  - create listener\n  - create pool\n  - create health monitor\n  - create member (sadly requires really provisioning VM)\n  - drop member\n  - drop HM\n  - drop pool\n  - drop listener\n  - drop lb","accounts_in_message":[],"_revision_number":4},{"id":"2ddcaaade4bf1546cafd20fcb58e7f8dc881e21c","author":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"date":"2020-09-28 17:37:44.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"fe7c1f3cbf4dd035e779e7b86a7d41e097e73c1c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-28 18:58:07.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/099f9f00c5ae42a38ab6c99c2470fd99 : SUCCESS in 3m 11s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/27f70634aef342d38b3892c726c2c3b4 : SUCCESS in 7m 05s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/199dfefc28d84514bdfe1750c33b6d3c : SUCCESS in 7m 26s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/ca1584ce9019442c8eb280d15717c54f : SUCCESS in 8m 00s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/012c49d07e22483192f6f693f3c5caa5 : SUCCESS in 50m 27s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/81a162a705204d8d9ea307925fcfe69d : SUCCESS in 47m 40s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/742a4836eadc404cbd66d1c6cf91f626 : SUCCESS in 48m 46s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/feefddf40eaf4e889274185b16557547 : SUCCESS in 45m 59s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/0c716e104a8a4b44865de03c693f3a66 : SUCCESS in 45m 17s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/6315cea014d042efb85582727afed8d7 : SUCCESS in 45m 36s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.9 https://zuul.opendev.org/t/openstack/build/f3ce87870dd94c08841d105b2da31c3b : SUCCESS in 39m 58s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/00ae2d5d4c4348d7b02b8073e913c6ec : SUCCESS in 46m 40s\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/ce07143ef4be4da9b67a0f9a2389260b : SUCCESS in 46m 44s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/7dc001d669df41ca912b658b195a2ed5 : SUCCESS in 44m 00s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.9 https://zuul.opendev.org/t/openstack/build/dfcae96666634ee5aa98f7a17000c520 : SUCCESS in 45m 43s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/079b7ebd7617486a8fd3a630fa59857e : SUCCESS in 21m 09s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/5d15305d4084428781466bdd305a3e8c : SUCCESS in 26m 40s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"25ae761b8d6933b28af4bf7e204448ee814ab7e9","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-09-29 13:23:08.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"4f3ff3463b724de808ad38ac7367694bd2f793a4","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2020-09-30 06:31:07.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"0258b45ee14a7763764995fc28649e859c3907c2","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-30 06:31:19.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"ddc954b59578039735caabec30ab75a8e81d5ac9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-30 07:54:37.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"b61aea870bfbdf4f396aedcedeff552392cf7823","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-09-30 07:54:37.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/c913e2abeb84421a878e2ac6a346cfe2 : SUCCESS in 3m 22s\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/ae2e5f7d503f48f283384761e4fbfee0 : SUCCESS in 7m 01s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/4677b5ab1c40470b8a5325998ff0ef6f : SUCCESS in 6m 43s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/66fea1ae8b684307af9d5e902b52a2a5 : SUCCESS in 42m 51s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/963ab7749a0a47a696ce3daff8e50234 : SUCCESS in 32m 49s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/0cab2742b2f04225b745398af329fe51 : SUCCESS in 1h 20m 24s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/2ed3f10cf0714fc7aaaa878f3cb75cd5 : SUCCESS in 47m 06s\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/29773b01175c48d7b587ad91c8d96437 : SUCCESS in 45m 49s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.9 https://zuul.opendev.org/t/openstack/build/5cc3ded2bc8b4c3394ec0faac1c6b114 : SUCCESS in 52m 33s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.9 https://zuul.opendev.org/t/openstack/build/25a219c4c88e4e399b51eef288a37586 : SUCCESS in 48m 00s\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.9 https://zuul.opendev.org/t/openstack/build/066e7a83a2b047cdb3169d8c3d695055 : SUCCESS in 50m 13s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.9 https://zuul.opendev.org/t/openstack/build/691b3d6a26d34570a2218473efc66c85 : SUCCESS in 51m 53s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.9 https://zuul.opendev.org/t/openstack/build/d722ed370868405da1b1fbc0d4d8c910 : SUCCESS in 44m 58s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"05da83520ed4e2af9993733296060ac6d696e1b8","revisions":{"5fa520bb36bd9b9194cb9f51646a7bf06e92fca3":{"kind":"REWORK","_number":1,"created":"2020-09-22 13:15:46.000000000","uploader":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"ref":"refs/changes/06/753306/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/06/753306/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/1"}}},"commit":{"parents":[{"commit":"a67272d1f5ae77b9df45a933dc6adf1d77931ee0","subject":"Add CI files config to bifrost jobs as well","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a67272d1f5ae77b9df45a933dc6adf1d77931ee0"}]}],"author":{"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","date":"2020-09-22 13:14:44.000000000","tz":120},"committer":{"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","date":"2020-09-22 13:14:44.000000000","tz":120},"subject":"MAke it possible to create a health monitor to a pool","message":"MAke it possible to create a health monitor to a pool\n\nChange-Id: I6119f5be02ace88253cba448f5a0699b39ea9ee1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/5fa520bb36bd9b9194cb9f51646a7bf06e92fca3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/5fa520bb36bd9b9194cb9f51646a7bf06e92fca3"}]},"branch":"refs/heads/master"},"10fbf1fac03efda3ceef35cf9d0f95badc48557d":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-09-25 00:24:41.000000000","uploader":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"ref":"refs/changes/06/753306/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/06/753306/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/2"}}},"commit":{"parents":[{"commit":"a6b52612de01a3791142dfef9e71921294e4d16f","subject":"Fix linters for new ansible release","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a6b52612de01a3791142dfef9e71921294e4d16f"}]}],"author":{"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","date":"2020-09-22 13:14:44.000000000","tz":120},"committer":{"name":"Sagi Shnaidman","email":"sshnaidm@redhat.com","date":"2020-09-25 00:24:41.000000000","tz":0},"subject":"MAke it possible to create a health monitor to a pool","message":"MAke it possible to create a health monitor to a pool\n\nChange-Id: I6119f5be02ace88253cba448f5a0699b39ea9ee1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/10fbf1fac03efda3ceef35cf9d0f95badc48557d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/10fbf1fac03efda3ceef35cf9d0f95badc48557d"}]},"branch":"refs/heads/master"},"bb14c9c53f398240237707ade274a9002bf9d04d":{"kind":"REWORK","_number":3,"created":"2020-09-25 11:03:56.000000000","uploader":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"ref":"refs/changes/06/753306/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/06/753306/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/3"}}},"commit":{"parents":[{"commit":"a67272d1f5ae77b9df45a933dc6adf1d77931ee0","subject":"Add CI files config to bifrost jobs as well","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a67272d1f5ae77b9df45a933dc6adf1d77931ee0"}]}],"author":{"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","date":"2020-09-22 13:14:44.000000000","tz":120},"committer":{"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","date":"2020-09-25 11:03:17.000000000","tz":120},"subject":"Make it possible to create a health monitor to a pool","message":"Make it possible to create a health monitor to a pool\n\nChange-Id: I6119f5be02ace88253cba448f5a0699b39ea9ee1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/bb14c9c53f398240237707ade274a9002bf9d04d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/bb14c9c53f398240237707ade274a9002bf9d04d"}]},"branch":"refs/heads/master"},"9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f":{"kind":"REWORK","_number":4,"created":"2020-09-25 12:53:50.000000000","uploader":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"ref":"refs/changes/06/753306/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/06/753306/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/4"}}},"commit":{"parents":[{"commit":"a67272d1f5ae77b9df45a933dc6adf1d77931ee0","subject":"Add CI files config to bifrost jobs as well","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a67272d1f5ae77b9df45a933dc6adf1d77931ee0"}]}],"author":{"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","date":"2020-09-22 13:14:44.000000000","tz":120},"committer":{"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","date":"2020-09-25 12:53:24.000000000","tz":120},"subject":"Make it possible to create a health monitor to a pool","message":"Make it possible to create a health monitor to a pool\n\nChange-Id: I6119f5be02ace88253cba448f5a0699b39ea9ee1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/9be7f4f317f0f60dc9c2eda2dc05f7e7db447e2f"}]},"branch":"refs/heads/master"},"05da83520ed4e2af9993733296060ac6d696e1b8":{"kind":"REWORK","_number":5,"created":"2020-09-28 17:37:44.000000000","uploader":{"_account_id":29260,"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","username":"jsmdk"},"ref":"refs/changes/06/753306/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/06/753306/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/06/753306/5"}}},"commit":{"parents":[{"commit":"a67272d1f5ae77b9df45a933dc6adf1d77931ee0","subject":"Add CI files config to bifrost jobs as well","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a67272d1f5ae77b9df45a933dc6adf1d77931ee0"}]}],"author":{"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","date":"2020-09-22 13:14:44.000000000","tz":120},"committer":{"name":"Jesper Schmitz Mouridsen","email":"jesper@schmitz.computer","date":"2020-09-28 17:37:24.000000000","tz":120},"subject":"Make it possible to create a health monitor to a pool","message":"Make it possible to create a health monitor to a pool\n\nChange-Id: I6119f5be02ace88253cba448f5a0699b39ea9ee1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/05da83520ed4e2af9993733296060ac6d696e1b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/05da83520ed4e2af9993733296060ac6d696e1b8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}