)]}'
{"plugins/module_utils/openstack.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f1f4e1aa3a094a503ea7ccfc93ae2f8422fec173","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    deprecated_names \u003d ()"},{"line_number":241,"context_line":"    argument_spec \u003d {}"},{"line_number":242,"context_line":"    module_kwargs \u003d {}"},{"line_number":243,"context_line":"    minimum_sdk_version \u003d None"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def __init__(self):"},{"line_number":246,"context_line":"        \"\"\"Initialize Openstack base class."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_6c7fba16","line":243,"range":{"start_line":243,"start_character":4,"end_line":243,"end_character":23},"updated":"2020-10-12 14:34:46.000000000","message":"maybe to be more descriptive - \"module_min_sdk_version\"?\n because we have a few sdk version things here","commit_id":"7ecbb9cb2805f025cb206c259f446abd69d5b56f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f1f4e1aa3a094a503ea7ccfc93ae2f8422fec173","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                version\u003d\u00272.10\u0027)"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"    def check_sdk_version(self):"},{"line_number":294,"context_line":"        min_version \u003d self.minimum_sdk_version"},{"line_number":295,"context_line":"        if min_version and StrictVersion(self.sdk_version) \u003c min_version:"},{"line_number":296,"context_line":"            self.fail("},{"line_number":297,"context_line":"                msg\u003d\"To utilize this module, the installed version of \""},{"line_number":298,"context_line":"                    \"the openstacksdk library MUST be \u003e\u003d{min_version}.\".format("},{"line_number":299,"context_line":"                        min_version\u003dmin_version))"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    def openstack_cloud_from_module(self):"},{"line_number":302,"context_line":"        \"\"\"Sets up connection to cloud using provided options. Checks if all"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f560f44_4cb0f6dc","line":299,"range":{"start_line":294,"start_character":8,"end_line":299,"end_character":49},"updated":"2020-10-12 14:34:46.000000000","message":"maybe to have it part of the function below? If we handle all parameters versions there","commit_id":"7ecbb9cb2805f025cb206c259f446abd69d5b56f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"45f311721b038fbc780dcb5ea42b0b6a3029c6d3","unresolved":false,"context_lines":[{"line_number":240,"context_line":"    deprecated_names \u003d ()"},{"line_number":241,"context_line":"    argument_spec \u003d {}"},{"line_number":242,"context_line":"    module_kwargs \u003d {}"},{"line_number":243,"context_line":"    module_min_sdk_version \u003d None"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def __init__(self):"},{"line_number":246,"context_line":"        \"\"\"Initialize Openstack base class."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f6b1bfe_af6de599","line":243,"range":{"start_line":243,"start_character":29,"end_line":243,"end_character":33},"updated":"2020-10-15 11:03:01.000000000","message":"It should be \"0.12.0\", see line 153","commit_id":"c91aed35bc24da2ea4db5eb8a0bd8c7ad2f4259a"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dda6adf4d002e97f4c40665df46f1f8363bfbef4","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    if min_version:"},{"line_number":164,"context_line":"        min_version \u003d max(StrictVersion(MINIMUM_SDK_VERSION), StrictVersion(min_version))"},{"line_number":165,"context_line":"    else:"},{"line_number":166,"context_line":"        min_version \u003d StrictVersion(MINIMUM_SDK_VERSION)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    if StrictVersion(sdk_version.__version__) \u003c min_version:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f681702_ddff4d32","line":165,"updated":"2020-10-19 10:41:22.000000000","message":"Can min_version even be false?","commit_id":"da17fefb8f76cc8676e65d5c3fbb6f81286716d8"},{"author":{"_account_id":14369,"name":"Mark Chappell","email":"mchappel@redhat.com","username":"tremble"},"change_message_id":"993a035c2d8aae39a47a41317b44e62248a5caea","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    if min_version:"},{"line_number":164,"context_line":"        min_version \u003d max(StrictVersion(MINIMUM_SDK_VERSION), StrictVersion(min_version))"},{"line_number":165,"context_line":"    else:"},{"line_number":166,"context_line":"        min_version \u003d StrictVersion(MINIMUM_SDK_VERSION)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    if StrictVersion(sdk_version.__version__) \u003c min_version:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f681702_d8e2bb01","line":165,"in_reply_to":"5f681702_ddff4d32","updated":"2020-10-19 11:24:00.000000000","message":"Someone could try setting it to none.","commit_id":"da17fefb8f76cc8676e65d5c3fbb6f81286716d8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dda6adf4d002e97f4c40665df46f1f8363bfbef4","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        # Fail if the available SDK version doesn\u0027t meet the minimum version"},{"line_number":307,"context_line":"        # requirements"},{"line_number":308,"context_line":"        if self.module_min_sdk_version:"},{"line_number":309,"context_line":"            min_version \u003d max(StrictVersion(MINIMUM_SDK_VERSION), StrictVersion(self.module_min_sdk_version))"},{"line_number":310,"context_line":"        else:"},{"line_number":311,"context_line":"            min_version \u003d StrictVersion(MINIMUM_SDK_VERSION)"},{"line_number":312,"context_line":"        if min_version and StrictVersion(self.sdk_version) \u003c min_version:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f681702_3dfda13a","line":309,"updated":"2020-10-19 10:41:22.000000000","message":"nit: please wrap lines","commit_id":"da17fefb8f76cc8676e65d5c3fbb6f81286716d8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"dda6adf4d002e97f4c40665df46f1f8363bfbef4","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            min_version \u003d max(StrictVersion(MINIMUM_SDK_VERSION), StrictVersion(self.module_min_sdk_version))"},{"line_number":310,"context_line":"        else:"},{"line_number":311,"context_line":"            min_version \u003d StrictVersion(MINIMUM_SDK_VERSION)"},{"line_number":312,"context_line":"        if min_version and StrictVersion(self.sdk_version) \u003c min_version:"},{"line_number":313,"context_line":"            self.fail("},{"line_number":314,"context_line":"                msg\u003d\"To utilize this module, the installed version of \""},{"line_number":315,"context_line":"                    \"the openstacksdk library MUST be \u003e\u003d{min_version}.\".format("}],"source_content_type":"text/x-python","patch_set":4,"id":"5f681702_1dfa6541","line":312,"updated":"2020-10-19 10:41:22.000000000","message":"nit: min_version cannot be none here","commit_id":"da17fefb8f76cc8676e65d5c3fbb6f81286716d8"}]}