)]}'
{"ci/roles/subnet/tasks/subnet-allocation.yml":[{"author":{"_account_id":29605,"name":"Siavash Sardari","email":"siavash.sardari@gmail.com","username":"siavash.sardari"},"change_message_id":"b87b12f59d46ae7d6de8301add3554496892f8e3","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":18,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Create subnet {{ subnet_name }} on network {{ network_name }} again"},{"line_number":21,"context_line":"  openstack.cloud.subnet:"},{"line_number":22,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":23,"context_line":"    network_name: \"{{ network_name }}\""},{"line_number":24,"context_line":"    enable_dhcp: \"{{ enable_subnet_dhcp }}\""},{"line_number":25,"context_line":"    name: \"{{ subnet_name }}\""},{"line_number":26,"context_line":"    state: present"},{"line_number":27,"context_line":"    cidr: 192.168.0.0/24"},{"line_number":28,"context_line":"    gateway_ip: 192.168.0.1"},{"line_number":29,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":30,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":31,"context_line":"  register: idem1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Update subnet {{ subnet_name }} allocation pools"},{"line_number":34,"context_line":"  openstack.cloud.subnet:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"130c0c3a_3cd33300","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":17},"updated":"2020-11-25 08:16:40.000000000","message":"this is a good test and we should keep it, but out of scope of the bug description.\nmaybe we should add another commit for this?","commit_id":"046e6e9bf178c09ece5b0d894e90c561be05b968"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f5a1c1a009d530d56acde4e60e31236214e09ba2","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":18,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Create subnet {{ subnet_name }} on network {{ network_name }} again"},{"line_number":21,"context_line":"  openstack.cloud.subnet:"},{"line_number":22,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":23,"context_line":"    network_name: \"{{ network_name }}\""},{"line_number":24,"context_line":"    enable_dhcp: \"{{ enable_subnet_dhcp }}\""},{"line_number":25,"context_line":"    name: \"{{ subnet_name }}\""},{"line_number":26,"context_line":"    state: present"},{"line_number":27,"context_line":"    cidr: 192.168.0.0/24"},{"line_number":28,"context_line":"    gateway_ip: 192.168.0.1"},{"line_number":29,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":30,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":31,"context_line":"  register: idem1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Update subnet {{ subnet_name }} allocation pools"},{"line_number":34,"context_line":"  openstack.cloud.subnet:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"8c058229_bffa110d","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":17},"in_reply_to":"130c0c3a_3cd33300","updated":"2020-11-25 14:10:58.000000000","message":"Why is it out of scope? It\u0027s exactly was broken in your description - when you run again same task with subnet.","commit_id":"046e6e9bf178c09ece5b0d894e90c561be05b968"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"722fa9544c8f0628e6b97741cdb6e5f0e2f1c13a","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":18,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Create subnet {{ subnet_name }} on network {{ network_name }} again"},{"line_number":21,"context_line":"  openstack.cloud.subnet:"},{"line_number":22,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":23,"context_line":"    network_name: \"{{ network_name }}\""},{"line_number":24,"context_line":"    enable_dhcp: \"{{ enable_subnet_dhcp }}\""},{"line_number":25,"context_line":"    name: \"{{ subnet_name }}\""},{"line_number":26,"context_line":"    state: present"},{"line_number":27,"context_line":"    cidr: 192.168.0.0/24"},{"line_number":28,"context_line":"    gateway_ip: 192.168.0.1"},{"line_number":29,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":30,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":31,"context_line":"  register: idem1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Update subnet {{ subnet_name }} allocation pools"},{"line_number":34,"context_line":"  openstack.cloud.subnet:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"990b4d61_a02a9433","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":17},"in_reply_to":"7d237bf4_2cbcd63b","updated":"2020-11-25 19:16:18.000000000","message":"If module runs with same config and trying to change something it\u0027s NOT idempotent","commit_id":"046e6e9bf178c09ece5b0d894e90c561be05b968"},{"author":{"_account_id":29605,"name":"Siavash Sardari","email":"siavash.sardari@gmail.com","username":"siavash.sardari"},"change_message_id":"3308e797637946bd825a421942f53108bf29b92a","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":18,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Create subnet {{ subnet_name }} on network {{ network_name }} again"},{"line_number":21,"context_line":"  openstack.cloud.subnet:"},{"line_number":22,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":23,"context_line":"    network_name: \"{{ network_name }}\""},{"line_number":24,"context_line":"    enable_dhcp: \"{{ enable_subnet_dhcp }}\""},{"line_number":25,"context_line":"    name: \"{{ subnet_name }}\""},{"line_number":26,"context_line":"    state: present"},{"line_number":27,"context_line":"    cidr: 192.168.0.0/24"},{"line_number":28,"context_line":"    gateway_ip: 192.168.0.1"},{"line_number":29,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":30,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":31,"context_line":"  register: idem1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Update subnet {{ subnet_name }} allocation pools"},{"line_number":34,"context_line":"  openstack.cloud.subnet:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7d237bf4_2cbcd63b","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":17},"in_reply_to":"8c058229_bffa110d","updated":"2020-11-25 14:56:05.000000000","message":"the bug wasn\u0027t about the idempotency of subnet module, actually the module was and is idempotent. The problem was about the logic of updating a subnet. (maybe my understanding about idempotency is not complete)\nanyways I\u0027m happy whit this test, it was just a suggestion.","commit_id":"046e6e9bf178c09ece5b0d894e90c561be05b968"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"1010ab9441bcd49c63cda4765d4900d07540ea05","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":18,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Create subnet {{ subnet_name }} on network {{ network_name }} again"},{"line_number":21,"context_line":"  openstack.cloud.subnet:"},{"line_number":22,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":23,"context_line":"    network_name: \"{{ network_name }}\""},{"line_number":24,"context_line":"    enable_dhcp: \"{{ enable_subnet_dhcp }}\""},{"line_number":25,"context_line":"    name: \"{{ subnet_name }}\""},{"line_number":26,"context_line":"    state: present"},{"line_number":27,"context_line":"    cidr: 192.168.0.0/24"},{"line_number":28,"context_line":"    gateway_ip: 192.168.0.1"},{"line_number":29,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":30,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":31,"context_line":"  register: idem1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Update subnet {{ subnet_name }} allocation pools"},{"line_number":34,"context_line":"  openstack.cloud.subnet:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"156d584f_8cbebe5c","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":17},"in_reply_to":"98c4a7ea_e3179517","updated":"2020-11-26 11:41:44.000000000","message":"Yeah, I think I agree with you here.","commit_id":"046e6e9bf178c09ece5b0d894e90c561be05b968"},{"author":{"_account_id":29605,"name":"Siavash Sardari","email":"siavash.sardari@gmail.com","username":"siavash.sardari"},"change_message_id":"240877810c38f086c05468616b1e97e2fadd01da","unresolved":true,"context_lines":[{"line_number":17,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":18,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"- name: Create subnet {{ subnet_name }} on network {{ network_name }} again"},{"line_number":21,"context_line":"  openstack.cloud.subnet:"},{"line_number":22,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":23,"context_line":"    network_name: \"{{ network_name }}\""},{"line_number":24,"context_line":"    enable_dhcp: \"{{ enable_subnet_dhcp }}\""},{"line_number":25,"context_line":"    name: \"{{ subnet_name }}\""},{"line_number":26,"context_line":"    state: present"},{"line_number":27,"context_line":"    cidr: 192.168.0.0/24"},{"line_number":28,"context_line":"    gateway_ip: 192.168.0.1"},{"line_number":29,"context_line":"    allocation_pool_start: 192.168.0.2"},{"line_number":30,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":31,"context_line":"  register: idem1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Update subnet {{ subnet_name }} allocation pools"},{"line_number":34,"context_line":"  openstack.cloud.subnet:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"98c4a7ea_e3179517","line":31,"range":{"start_line":20,"start_character":0,"end_line":31,"end_character":17},"in_reply_to":"990b4d61_a02a9433","updated":"2020-11-26 08:37:06.000000000","message":"I know that, let me explain my logic here.\nThere are two different cases here:\n1. First case, the current subnet module with this config:\n```yaml\n      endpoint_type: internal\n      cloud: default_project_scope\n      state: present\n      name: subnet\n      project: admin\n      network_name: network\n      ip_version: 4\n      cidr: 172.16.16.0/24\n      gateway_ip: 172.16.16.1\n      enable_dhcp: false\n      allocation_pool_start: 172.16.16.65\n      allocation_pool_end: 172.16.16.254\n      dns_nameservers:\n        - 4.2.2.4\n```\nIn this case if we apply the current master branch subnet module any number of times, the result is the same without any changes (well ,except the first time which will create the subnet). And thus, based on the definition of idempotent operations, the subnet module is idempotent.\n\n2. Second case, run the subnet module with above config for the first time to create subnet, then change the config to this:\n```yaml\n      endpoint_type: internal\n      cloud: default_project_scope\n      state: present\n      name: subnet\n      project: admin\n      network_name: network\n      ip_version: 4\n      cidr: 172.16.16.0/24\n      gateway_ip: 172.16.16.1\n      enable_dhcp: true\n      allocation_pool_start: 172.16.16.65\n      allocation_pool_end: 172.16.16.254\n      dns_nameservers:\n        - 4.2.2.4\n```\napplying the module for the second time, due to change of ```enable_dhcp``` in config, will try to change the subnet. In my point of view, this falls in the category of updating and logic behind it.\nThe definition of idempotent operations says that op(x) \u003d\u003d op(op(x)), but in the second case we changed the argument x to y (the ```enable_dhcp``` in subnet config), and op(x) !\u003d op(y). So this is not against the definition of idempotent operations\n\nDid I get something wrong here? should the second case count as idempotency?","commit_id":"046e6e9bf178c09ece5b0d894e90c561be05b968"},{"author":{"_account_id":29605,"name":"Siavash Sardari","email":"siavash.sardari@gmail.com","username":"siavash.sardari"},"change_message_id":"b87b12f59d46ae7d6de8301add3554496892f8e3","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":31,"context_line":"  register: idem1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Update subnet {{ subnet_name }} allocation pools"},{"line_number":34,"context_line":"  openstack.cloud.subnet:"},{"line_number":35,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":36,"context_line":"    network_name: \"{{ network_name }}\""},{"line_number":37,"context_line":"    name: \"{{ subnet_name }}\""},{"line_number":38,"context_line":"    state: present"},{"line_number":39,"context_line":"    cidr: 192.168.0.0/24"},{"line_number":40,"context_line":"    allocation_pool_start: 192.168.0.5"},{"line_number":41,"context_line":"    allocation_pool_end: 192.168.0.8"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Get Subnet Info"},{"line_number":44,"context_line":"  openstack.cloud.subnets_info:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"72ada9a4_cf943bcb","line":41,"range":{"start_line":33,"start_character":1,"end_line":41,"end_character":36},"updated":"2020-11-25 08:16:40.000000000","message":"I think we should change this task to test the subnet allocation pools.\nalso I say let\u0027s add another task and update another attr of the subnet, like enable_dhcp of maybe dns_nameservers","commit_id":"046e6e9bf178c09ece5b0d894e90c561be05b968"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"f5a1c1a009d530d56acde4e60e31236214e09ba2","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":31,"context_line":"  register: idem1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Update subnet {{ subnet_name }} allocation pools"},{"line_number":34,"context_line":"  openstack.cloud.subnet:"},{"line_number":35,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":36,"context_line":"    network_name: \"{{ network_name }}\""},{"line_number":37,"context_line":"    name: \"{{ subnet_name }}\""},{"line_number":38,"context_line":"    state: present"},{"line_number":39,"context_line":"    cidr: 192.168.0.0/24"},{"line_number":40,"context_line":"    allocation_pool_start: 192.168.0.5"},{"line_number":41,"context_line":"    allocation_pool_end: 192.168.0.8"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Get Subnet Info"},{"line_number":44,"context_line":"  openstack.cloud.subnets_info:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f3a02f45_85d1f07a","line":41,"range":{"start_line":33,"start_character":1,"end_line":41,"end_character":36},"in_reply_to":"72ada9a4_cf943bcb","updated":"2020-11-25 14:10:58.000000000","message":"Yes, the more tests the better. I suggest to do them in followups, currently only fixed wrong tests.","commit_id":"046e6e9bf178c09ece5b0d894e90c561be05b968"},{"author":{"_account_id":29605,"name":"Siavash Sardari","email":"siavash.sardari@gmail.com","username":"siavash.sardari"},"change_message_id":"3308e797637946bd825a421942f53108bf29b92a","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    allocation_pool_end: 192.168.0.4"},{"line_number":31,"context_line":"  register: idem1"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"- name: Update subnet {{ subnet_name }} allocation pools"},{"line_number":34,"context_line":"  openstack.cloud.subnet:"},{"line_number":35,"context_line":"    cloud: \"{{ cloud }}\""},{"line_number":36,"context_line":"    network_name: \"{{ network_name }}\""},{"line_number":37,"context_line":"    name: \"{{ subnet_name }}\""},{"line_number":38,"context_line":"    state: present"},{"line_number":39,"context_line":"    cidr: 192.168.0.0/24"},{"line_number":40,"context_line":"    allocation_pool_start: 192.168.0.5"},{"line_number":41,"context_line":"    allocation_pool_end: 192.168.0.8"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"- name: Get Subnet Info"},{"line_number":44,"context_line":"  openstack.cloud.subnets_info:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"83e32c9d_e4889cfc","line":41,"range":{"start_line":33,"start_character":1,"end_line":41,"end_character":36},"in_reply_to":"f3a02f45_85d1f07a","updated":"2020-11-25 14:56:05.000000000","message":"in my view this test should get fixed, if updating allocation pool to 192.168.0.2,192.168.0.8 is the purpose of this test, then it was wrong to begin with.","commit_id":"046e6e9bf178c09ece5b0d894e90c561be05b968"}]}