)]}'
{"plugins/modules/router.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"06ad308db98d895b14ccea074e2eb15c2422352e","unresolved":true,"context_lines":[{"line_number":220,"context_line":"])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"def _router_internal_interfaces(cloud, router):"},{"line_number":224,"context_line":"    for port in cloud.list_router_interfaces(router, \u0027internal\u0027):"},{"line_number":225,"context_line":"        if port[\u0027device_owner\u0027] in ROUTER_INTERFACE_OWNERS:"},{"line_number":226,"context_line":"            yield port"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"def _needs_update(cloud, module, router, network, internal_subnet_ids, internal_port_ids, filters\u003dNone):"},{"line_number":230,"context_line":"    \"\"\"Decide if the given router needs an update."},{"line_number":231,"context_line":"    \"\"\""},{"line_number":232,"context_line":"    if router[\u0027admin_state_up\u0027] !\u003d module.params[\u0027admin_state_up\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f92f68c7_4fc80f9b","line":229,"range":{"start_line":223,"start_character":0,"end_line":229,"end_character":104},"updated":"2020-12-02 16:38:30.000000000","message":"I\u0027d like all these functions to be methods of the main class if they use \"module\", \"cloud\", etc. Only functions that are not using any of these might be outside of the class.","commit_id":"25b41ea5e2d59952c647f5ca01ca8196ac949f74"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"06ad308db98d895b14ccea074e2eb15c2422352e","unresolved":true,"context_lines":[{"line_number":425,"context_line":"                                             filters)"},{"line_number":426,"context_line":"            )"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":429,"context_line":"            changed \u003d False"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"            if not router:"}],"source_content_type":"text/x-python","patch_set":1,"id":"70fc2f44_88cb98b9","line":428,"range":{"start_line":428,"start_character":8,"end_line":428,"end_character":30},"updated":"2020-12-02 16:38:30.000000000","message":"can we maybe to extract these \"if\"s to separate functions? To keep \"run\" function compact.","commit_id":"25b41ea5e2d59952c647f5ca01ca8196ac949f74"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"66427d5dd0f3054b6e2e840b9b0222172455a71b","unresolved":true,"context_lines":[{"line_number":220,"context_line":"])"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"class RouterModule(OpenStackModule):"},{"line_number":224,"context_line":"    argument_spec \u003d dict("},{"line_number":225,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"},{"line_number":226,"context_line":"        name\u003ddict(required\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"368d98af_07b39934","line":223,"range":{"start_line":223,"start_character":0,"end_line":223,"end_character":36},"updated":"2020-12-03 13:37:10.000000000","message":"Please add deprecated names (os_router)","commit_id":"b0bc1539af38a8a9d806c1b8bb1c8a3c6de5cdcd"}]}