)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"936d411b7c341aa65a87dfcaf8e91f4d4860ee86","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     anbanerj \u003canbanerj@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2020-12-01 11:24:30 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Migrating metwork from AnsibleModule to OpenStackModule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic4ddedb43044434df0a18f8aacacd21149e6f0b0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9bd146c7_16ea4066","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":17},"updated":"2020-12-01 22:40:50.000000000","message":"typo - network","commit_id":"388df8e7a330860b2aa32b20643754c65dc709ba"}],"plugins/modules/network.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"936d411b7c341aa65a87dfcaf8e91f4d4860ee86","unresolved":true,"context_lines":[{"line_number":188,"context_line":"        provider_segmentation_id \u003d self.params[\u0027provider_segmentation_id\u0027]"},{"line_number":189,"context_line":"        project \u003d self.params[\u0027project\u0027]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        net_create_kwargs \u003d {}"},{"line_number":192,"context_line":"        # min_version \u003d None"},{"line_number":193,"context_line":"        self.check_versioned("},{"line_number":194,"context_line":"            mtu\u003dself.params[\u0027mtu\u0027], port_security_enabled\u003dself.params[\u0027port_security_enabled\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"d45fa415_e3cf3bb0","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":30},"updated":"2020-12-01 22:40:50.000000000","message":"this is not needed anymore I suppose","commit_id":"388df8e7a330860b2aa32b20643754c65dc709ba"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"55145575146b3193727ad1d14c69097e41007e25","unresolved":true,"context_lines":[{"line_number":188,"context_line":"        provider_segmentation_id \u003d self.params[\u0027provider_segmentation_id\u0027]"},{"line_number":189,"context_line":"        project \u003d self.params[\u0027project\u0027]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        net_create_kwargs \u003d {}"},{"line_number":192,"context_line":"        # min_version \u003d None"},{"line_number":193,"context_line":"        self.check_versioned("},{"line_number":194,"context_line":"            mtu\u003dself.params[\u0027mtu\u0027], port_security_enabled\u003dself.params[\u0027port_security_enabled\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"27a2d8e6_8189301f","line":191,"range":{"start_line":191,"start_character":8,"end_line":191,"end_character":30},"in_reply_to":"d45fa415_e3cf3bb0","updated":"2020-12-07 15:44:24.000000000","message":"Updated","commit_id":"388df8e7a330860b2aa32b20643754c65dc709ba"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"936d411b7c341aa65a87dfcaf8e91f4d4860ee86","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        project \u003d self.params[\u0027project\u0027]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        net_create_kwargs \u003d {}"},{"line_number":192,"context_line":"        # min_version \u003d None"},{"line_number":193,"context_line":"        self.check_versioned("},{"line_number":194,"context_line":"            mtu\u003dself.params[\u0027mtu\u0027], port_security_enabled\u003dself.params[\u0027port_security_enabled\u0027],"},{"line_number":195,"context_line":"            dns_domain\u003dself.params[\u0027dns_domain\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"c402e815_0500bbc6","line":192,"range":{"start_line":192,"start_character":8,"end_line":192,"end_character":28},"updated":"2020-12-01 22:40:50.000000000","message":"should be deleted","commit_id":"388df8e7a330860b2aa32b20643754c65dc709ba"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"55145575146b3193727ad1d14c69097e41007e25","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        project \u003d self.params[\u0027project\u0027]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        net_create_kwargs \u003d {}"},{"line_number":192,"context_line":"        # min_version \u003d None"},{"line_number":193,"context_line":"        self.check_versioned("},{"line_number":194,"context_line":"            mtu\u003dself.params[\u0027mtu\u0027], port_security_enabled\u003dself.params[\u0027port_security_enabled\u0027],"},{"line_number":195,"context_line":"            dns_domain\u003dself.params[\u0027dns_domain\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"0fa5a4e9_50e1c94e","line":192,"range":{"start_line":192,"start_character":8,"end_line":192,"end_character":28},"in_reply_to":"c402e815_0500bbc6","updated":"2020-12-07 15:44:24.000000000","message":"Ack","commit_id":"388df8e7a330860b2aa32b20643754c65dc709ba"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"936d411b7c341aa65a87dfcaf8e91f4d4860ee86","unresolved":true,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        net_create_kwargs \u003d {}"},{"line_number":192,"context_line":"        # min_version \u003d None"},{"line_number":193,"context_line":"        self.check_versioned("},{"line_number":194,"context_line":"            mtu\u003dself.params[\u0027mtu\u0027], port_security_enabled\u003dself.params[\u0027port_security_enabled\u0027],"},{"line_number":195,"context_line":"            dns_domain\u003dself.params[\u0027dns_domain\u0027]"},{"line_number":196,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"94306acf_bcc04c8a","line":193,"range":{"start_line":193,"start_character":12,"end_line":193,"end_character":29},"updated":"2020-12-01 22:40:50.000000000","message":"for that to work we need to add \"min_ver\" to all versioned arguments, like:\n\n  dns_domain\u003ddict(required\u003dFalse, min_ver\u003d\u00270.29.0\u0027)\n\nAnd also include it in tests to see that it\u0027s really filtered out in old branches and modules doesn\u0027t fail.","commit_id":"388df8e7a330860b2aa32b20643754c65dc709ba"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"55145575146b3193727ad1d14c69097e41007e25","unresolved":true,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        net_create_kwargs \u003d {}"},{"line_number":192,"context_line":"        # min_version \u003d None"},{"line_number":193,"context_line":"        self.check_versioned("},{"line_number":194,"context_line":"            mtu\u003dself.params[\u0027mtu\u0027], port_security_enabled\u003dself.params[\u0027port_security_enabled\u0027],"},{"line_number":195,"context_line":"            dns_domain\u003dself.params[\u0027dns_domain\u0027]"},{"line_number":196,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c3d4354_6527112e","line":193,"range":{"start_line":193,"start_character":12,"end_line":193,"end_character":29},"in_reply_to":"94306acf_bcc04c8a","updated":"2020-12-07 15:44:24.000000000","message":"Updated","commit_id":"388df8e7a330860b2aa32b20643754c65dc709ba"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"936d411b7c341aa65a87dfcaf8e91f4d4860ee86","unresolved":true,"context_lines":[{"line_number":194,"context_line":"            mtu\u003dself.params[\u0027mtu\u0027], port_security_enabled\u003dself.params[\u0027port_security_enabled\u0027],"},{"line_number":195,"context_line":"            dns_domain\u003dself.params[\u0027dns_domain\u0027]"},{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":"        # if self.params[\u0027mtu\u0027] is not None:"},{"line_number":198,"context_line":"        #     min_version \u003d \u00270.18.0\u0027"},{"line_number":199,"context_line":"        #     net_create_kwargs[\u0027mtu_size\u0027] \u003d self.params[\u0027mtu\u0027]"},{"line_number":200,"context_line":"        #"},{"line_number":201,"context_line":"        # if self.params[\u0027port_security_enabled\u0027] is not None:"},{"line_number":202,"context_line":"        #     min_version \u003d \u00270.18.0\u0027"},{"line_number":203,"context_line":"        #     net_create_kwargs[\u0027port_security_enabled\u0027] \u003d self.params[\u0027port_security_enabled\u0027]"},{"line_number":204,"context_line":"        #"},{"line_number":205,"context_line":"        # if self.params[\u0027dns_domain\u0027] is not None:"},{"line_number":206,"context_line":"        #     min_version \u003d \u00270.29.0\u0027"},{"line_number":207,"context_line":"        #     net_create_kwargs[\u0027dns_domain\u0027] \u003d self.params[\u0027dns_domain\u0027]"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        if project is not None:"},{"line_number":210,"context_line":"            proj \u003d self.conn.get_project(project)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3cbdd7f2_8d9b0939","line":207,"range":{"start_line":197,"start_character":8,"end_line":207,"end_character":73},"updated":"2020-12-01 22:40:50.000000000","message":"This should be deleted, we don\u0027t comment code.","commit_id":"388df8e7a330860b2aa32b20643754c65dc709ba"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"55145575146b3193727ad1d14c69097e41007e25","unresolved":true,"context_lines":[{"line_number":194,"context_line":"            mtu\u003dself.params[\u0027mtu\u0027], port_security_enabled\u003dself.params[\u0027port_security_enabled\u0027],"},{"line_number":195,"context_line":"            dns_domain\u003dself.params[\u0027dns_domain\u0027]"},{"line_number":196,"context_line":"        )"},{"line_number":197,"context_line":"        # if self.params[\u0027mtu\u0027] is not None:"},{"line_number":198,"context_line":"        #     min_version \u003d \u00270.18.0\u0027"},{"line_number":199,"context_line":"        #     net_create_kwargs[\u0027mtu_size\u0027] \u003d self.params[\u0027mtu\u0027]"},{"line_number":200,"context_line":"        #"},{"line_number":201,"context_line":"        # if self.params[\u0027port_security_enabled\u0027] is not None:"},{"line_number":202,"context_line":"        #     min_version \u003d \u00270.18.0\u0027"},{"line_number":203,"context_line":"        #     net_create_kwargs[\u0027port_security_enabled\u0027] \u003d self.params[\u0027port_security_enabled\u0027]"},{"line_number":204,"context_line":"        #"},{"line_number":205,"context_line":"        # if self.params[\u0027dns_domain\u0027] is not None:"},{"line_number":206,"context_line":"        #     min_version \u003d \u00270.29.0\u0027"},{"line_number":207,"context_line":"        #     net_create_kwargs[\u0027dns_domain\u0027] \u003d self.params[\u0027dns_domain\u0027]"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        if project is not None:"},{"line_number":210,"context_line":"            proj \u003d self.conn.get_project(project)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9c646af4_8a0c142b","line":207,"range":{"start_line":197,"start_character":8,"end_line":207,"end_character":73},"in_reply_to":"3cbdd7f2_8d9b0939","updated":"2020-12-07 15:44:24.000000000","message":"Updated in patchset 4. But create_network method uses \"mtu_size\" and not \"mtu\". While defining net_create_kwargs individually we are updating \"mtu\" as \"mtu_size\" in kwargs, but that will not work with check_versioned method (which expects the key in arguments to be the same as in self.params. So I have changed \"mtu\" to \"mtu_size\" in the arguments spec and added \"mtu\" as alias.","commit_id":"388df8e7a330860b2aa32b20643754c65dc709ba"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b6221070a6ab7c84fbe3ab0e3b2034c0b4fa3ac4","unresolved":true,"context_lines":[{"line_number":172,"context_line":"        provider_segmentation_id\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027),"},{"line_number":173,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"},{"line_number":174,"context_line":"        project\u003ddict(default\u003dNone),"},{"line_number":175,"context_line":"        port_security_enabled\u003ddict(type\u003d\u0027bool\u0027, min_version\u003d\u00270.18.0\u0027),"},{"line_number":176,"context_line":"        mtu_size\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, min_version\u003d\u00270.18.0\u0027, aliases\u003d[\u0027mtu\u0027]),"},{"line_number":177,"context_line":"        dns_domain\u003ddict(required\u003dFalse, min_ver\u003d\u00270.29.0\u0027)"},{"line_number":178,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":10,"id":"519dfa6f_a5451510","line":175,"range":{"start_line":175,"start_character":48,"end_line":175,"end_character":59},"updated":"2020-12-15 12:13:16.000000000","message":"min_ver","commit_id":"f93504e587d390d4d39492c0b4d557307240db20"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"b6221070a6ab7c84fbe3ab0e3b2034c0b4fa3ac4","unresolved":true,"context_lines":[{"line_number":173,"context_line":"        state\u003ddict(default\u003d\u0027present\u0027, choices\u003d[\u0027absent\u0027, \u0027present\u0027]),"},{"line_number":174,"context_line":"        project\u003ddict(default\u003dNone),"},{"line_number":175,"context_line":"        port_security_enabled\u003ddict(type\u003d\u0027bool\u0027, min_version\u003d\u00270.18.0\u0027),"},{"line_number":176,"context_line":"        mtu_size\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, min_version\u003d\u00270.18.0\u0027, aliases\u003d[\u0027mtu\u0027]),"},{"line_number":177,"context_line":"        dns_domain\u003ddict(required\u003dFalse, min_ver\u003d\u00270.29.0\u0027)"},{"line_number":178,"context_line":"    )"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"a9966fde_49983262","line":176,"range":{"start_line":176,"start_character":50,"end_line":176,"end_character":61},"updated":"2020-12-15 12:13:16.000000000","message":"min_ver","commit_id":"f93504e587d390d4d39492c0b4d557307240db20"}]}