)]}'
{"plugins/modules/volume.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d086e4935a0ba9595a09ea89cbef8fc75445aa2f","unresolved":true,"context_lines":[{"line_number":105,"context_line":"class VolumeModule(OpenStackModule):"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    argument_spec \u003d dict("},{"line_number":108,"context_line":"        size\u003ddict(default\u003dNone, type\u003d\u0027int\u0027),"},{"line_number":109,"context_line":"        volume_type\u003ddict(default\u003dNone, type\u003d\u0027str\u0027),"},{"line_number":110,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027], type\u003d\u0027str\u0027),"},{"line_number":111,"context_line":"        display_description\u003ddict(default\u003dNone, aliases\u003d[\u0027description\u0027], type\u003d\u0027str\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"cc90c38c_98ca3f96","line":108,"range":{"start_line":108,"start_character":18,"end_line":108,"end_character":30},"updated":"2020-12-07 09:26:59.000000000","message":"this can be removed, all ansible arguments are None by default","commit_id":"23d5719a5276c871a36dcdbaeaa60cd2118d21d0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d086e4935a0ba9595a09ea89cbef8fc75445aa2f","unresolved":true,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    argument_spec \u003d dict("},{"line_number":108,"context_line":"        size\u003ddict(default\u003dNone, type\u003d\u0027int\u0027),"},{"line_number":109,"context_line":"        volume_type\u003ddict(default\u003dNone, type\u003d\u0027str\u0027),"},{"line_number":110,"context_line":"        display_name\u003ddict(required\u003dTrue, aliases\u003d[\u0027name\u0027], type\u003d\u0027str\u0027),"},{"line_number":111,"context_line":"        display_description\u003ddict(default\u003dNone, aliases\u003d[\u0027description\u0027], type\u003d\u0027str\u0027),"},{"line_number":112,"context_line":"        image\u003ddict(default\u003dNone, type\u003d\u0027str\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"c7b64d52_b5cb3d5b","line":109,"range":{"start_line":109,"start_character":25,"end_line":109,"end_character":37},"updated":"2020-12-07 09:26:59.000000000","message":"and all such cases below","commit_id":"23d5719a5276c871a36dcdbaeaa60cd2118d21d0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d086e4935a0ba9595a09ea89cbef8fc75445aa2f","unresolved":true,"context_lines":[{"line_number":233,"context_line":"    def run(self):"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        state \u003d self.params[\u0027state\u0027]"},{"line_number":236,"context_line":"        if state \u003d\u003d \u0027present\u0027 and not self.params[\u0027size\u0027]:"},{"line_number":237,"context_line":"            self.fail_json(msg\u003d\"Size is required when state is \u0027present\u0027\")"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"        if self.conn.volume_exists(self.params[\u0027display_name\u0027]):"},{"line_number":240,"context_line":"            volume \u003d self.conn.get_volume(self.params[\u0027display_name\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3d373289_1cf4aebe","line":237,"range":{"start_line":236,"start_character":7,"end_line":237,"end_character":74},"updated":"2020-12-07 09:26:59.000000000","message":"this can be done in argument spec, as:\n\n    module_kwargs \u003d dict(\n        required_if\u003d[\n            [\u0027state\u0027, \u0027present\u0027, [\u0027size\u0027]],\n            ]\n\nsee https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/contrib/module_info_template.py.j2#L57","commit_id":"23d5719a5276c871a36dcdbaeaa60cd2118d21d0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d086e4935a0ba9595a09ea89cbef8fc75445aa2f","unresolved":true,"context_lines":[{"line_number":241,"context_line":"        else:"},{"line_number":242,"context_line":"            volume \u003d None"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"        try:"},{"line_number":245,"context_line":"            if state \u003d\u003d \u0027present\u0027:"},{"line_number":246,"context_line":"                if not volume:"},{"line_number":247,"context_line":"                    self._present_volume()"}],"source_content_type":"text/x-python","patch_set":1,"id":"14a32d78_4ad05a30","line":244,"range":{"start_line":244,"start_character":8,"end_line":244,"end_character":11},"updated":"2020-12-07 09:26:59.000000000","message":"should be removed, see below","commit_id":"23d5719a5276c871a36dcdbaeaa60cd2118d21d0"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"d086e4935a0ba9595a09ea89cbef8fc75445aa2f","unresolved":true,"context_lines":[{"line_number":251,"context_line":"                    self.exit_json(changed\u003dFalse, id\u003dvolume[\u0027id\u0027], volume\u003dvolume)"},{"line_number":252,"context_line":"            if state \u003d\u003d \u0027absent\u0027:"},{"line_number":253,"context_line":"                self._absent_volume(volume)"},{"line_number":254,"context_line":"        except self.sdk.exceptions.OpenStackCloudException as e:"},{"line_number":255,"context_line":"            self.fail_json(msg\u003dstr(e))"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c0ec4e9_92924af7","line":255,"range":{"start_line":254,"start_character":5,"end_line":255,"end_character":38},"updated":"2020-12-07 09:26:59.000000000","message":"when moving to OpenstackModule class we don\u0027t need anymore to use try/except here, it\u0027s handled in OpenstackModule: https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/module_utils/openstack.py#L408-L417","commit_id":"23d5719a5276c871a36dcdbaeaa60cd2118d21d0"}]}