)]}'
{"meta/runtime.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8655e699a8b81c18a7fd3cddde9afc5bf5c8a5af","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    - volume_info"},{"line_number":95,"context_line":"    - volume_snapshot"},{"line_number":96,"context_line":"    - volume_snapshot_info"},{"line_number":97,"context_line":"  os:"},{"line_number":98,"context_line":"    - auth"},{"line_number":99,"context_line":"    - baremetal_inspect"},{"line_number":100,"context_line":"    - baremetal_inspect"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"026ef481_0971bbab","line":97,"range":{"start_line":97,"start_character":1,"end_line":97,"end_character":5},"updated":"2020-12-15 13:19:12.000000000","message":"please add it in this section as well","commit_id":"33877d9e621b703b27164960512d83f4946cde46"},{"author":{"_account_id":32673,"name":"Tino Schreiber","username":"tischrei"},"change_message_id":"f44b7b00cfc87e99efce45a1100277c6412f69a0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    - volume_info"},{"line_number":95,"context_line":"    - volume_snapshot"},{"line_number":96,"context_line":"    - volume_snapshot_info"},{"line_number":97,"context_line":"  os:"},{"line_number":98,"context_line":"    - auth"},{"line_number":99,"context_line":"    - baremetal_inspect"},{"line_number":100,"context_line":"    - baremetal_inspect"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"4b07925c_d71750bf","line":97,"range":{"start_line":97,"start_character":1,"end_line":97,"end_character":5},"in_reply_to":"026ef481_0971bbab","updated":"2021-01-20 15:21:27.000000000","message":"Done","commit_id":"33877d9e621b703b27164960512d83f4946cde46"}],"plugins/modules/security_group_rule_info.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"748a3207c8a260463db57c0980eca36f070d3145","unresolved":true,"context_lines":[{"line_number":213,"context_line":"            filters[\u0027direction\u0027] \u003d direction"},{"line_number":214,"context_line":"        if ethertype:"},{"line_number":215,"context_line":"            filters[\u0027ethertype\u0027] \u003d ethertype"},{"line_number":216,"context_line":"        if port_range_min:"},{"line_number":217,"context_line":"            filters[\u0027port_range_min\u0027] \u003d port_range_min"},{"line_number":218,"context_line":"        if port_range_max:"},{"line_number":219,"context_line":"            filters[\u0027port_range_max\u0027] \u003d port_range_max"}],"source_content_type":"text/x-python","patch_set":7,"id":"f166dfcc_c7727390","line":216,"updated":"2021-01-20 19:01:38.000000000","message":"Seems like in rocky and stein parameters below are not supported:\n\"msg\": \"Invalid query params: remote_ip_prefix,port_range_min,port_range_max\"\n\nWe can set for them minimum SDK version of train: 0.36.4\nFor example in argument spec above:\n\n  port_range_min\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, min_ver\u003d\"0.36.4\"),\n\nlike done in network module: https://github.com/openstack/ansible-collections-openstack/blob/c03284abecfe67ebba12bb724dc77f4b161cf3f3/plugins/modules/network.py#L175-L176\n\nAnd then filter all this like:\nhttps://github.com/openstack/ansible-collections-openstack/blob/c03284abecfe67ebba12bb724dc77f4b161cf3f3/plugins/modules/network.py#L192-L195\n\n  kwargs \u003d self.check_versioned(\n            description\u003dself.params[\u0027description\u0027], direction\u003dself.params[\u0027direction\u0027],\n            ethertype\u003dself.params[\u0027ethertype\u0027], etc, etc\n        )\n\nall parameters that don\u0027t align with minimum version will be dropped\nor maybe in your case without changing much:\n\n  filters \u003d self.check_versioned(**filters)","commit_id":"200989d4f7ee3d844f97e3123bf127569eb81b0b"},{"author":{"_account_id":32673,"name":"Tino Schreiber","username":"tischrei"},"change_message_id":"8f1377c4cc6faa5918de52b78694a6798c598c44","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            filters[\u0027direction\u0027] \u003d direction"},{"line_number":214,"context_line":"        if ethertype:"},{"line_number":215,"context_line":"            filters[\u0027ethertype\u0027] \u003d ethertype"},{"line_number":216,"context_line":"        if port_range_min:"},{"line_number":217,"context_line":"            filters[\u0027port_range_min\u0027] \u003d port_range_min"},{"line_number":218,"context_line":"        if port_range_max:"},{"line_number":219,"context_line":"            filters[\u0027port_range_max\u0027] \u003d port_range_max"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ab56a7f_a62df86b","line":216,"in_reply_to":"f166dfcc_c7727390","updated":"2021-01-21 14:08:53.000000000","message":"Done","commit_id":"200989d4f7ee3d844f97e3123bf127569eb81b0b"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"748a3207c8a260463db57c0980eca36f070d3145","unresolved":true,"context_lines":[{"line_number":239,"context_line":"            filters[\u0027security_group_id\u0027] \u003d sec_grp.id"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        for item in self.conn.network.security_group_rules(**filters):"},{"line_number":242,"context_line":"            item \u003d item.to_dict()"},{"line_number":243,"context_line":"            data.append(item)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        self.exit_json(changed\u003dchanged,"}],"source_content_type":"text/x-python","patch_set":7,"id":"2d0077ab_7cadf012","line":242,"range":{"start_line":242,"start_character":12,"end_line":242,"end_character":33},"updated":"2021-01-20 19:01:38.000000000","message":"I think in rocky and stein this method is not available, so let\u0027s do it something like this:\nhttps://opendev.org/openstack/ansible-collections-openstack/commit/049a2de7252f472d253b51450b4160d16aedcad9","commit_id":"200989d4f7ee3d844f97e3123bf127569eb81b0b"},{"author":{"_account_id":32673,"name":"Tino Schreiber","username":"tischrei"},"change_message_id":"8f1377c4cc6faa5918de52b78694a6798c598c44","unresolved":true,"context_lines":[{"line_number":239,"context_line":"            filters[\u0027security_group_id\u0027] \u003d sec_grp.id"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        for item in self.conn.network.security_group_rules(**filters):"},{"line_number":242,"context_line":"            item \u003d item.to_dict()"},{"line_number":243,"context_line":"            data.append(item)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        self.exit_json(changed\u003dchanged,"}],"source_content_type":"text/x-python","patch_set":7,"id":"215006fe_78c1f987","line":242,"range":{"start_line":242,"start_character":12,"end_line":242,"end_character":33},"in_reply_to":"2d0077ab_7cadf012","updated":"2021-01-21 14:08:53.000000000","message":"\u003e I think in rocky and stein this method is not available, so let\u0027s do it something like this:\n\u003e https://opendev.org/openstack/ansible-collections-openstack/commit/049a2de7252f472d253b51450b4160d16aedcad9\n\nI had a look into the releases repo and the min_version is 0.17.3 for sdk and \u0027def to_dict\u0027 is available.","commit_id":"200989d4f7ee3d844f97e3123bf127569eb81b0b"}]}