)]}'
{"id":"openstack%2Fansible-collections-openstack~767710","triplet_id":"openstack%2Fansible-collections-openstack~master~I8f19359e70f8565ebfb096d30ab75e727f748be6","project":"openstack/ansible-collections-openstack","branch":"master","topic":"subnet","hashtags":[],"change_id":"I8f19359e70f8565ebfb096d30ab75e727f748be6","subject":"Migrating subnet module from AnsibleModule to OpenStackModule","status":"MERGED","created":"2020-12-18 12:50:02.000000000","updated":"2020-12-21 14:21:11.000000000","submitted":"2020-12-21 14:21:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"767710-subnet","meta_rev_id":"ffa27344788b95bd0370bf3272097f654a2f7d3b","_number":767710,"virtual_id_number":767710,"owner":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-12-21 14:20:59.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":2,"date":"2020-12-21 12:29:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":1,"date":"2020-12-21 13:26:41.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-12-18 14:17:13.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-12-21 12:29:45.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"}],"messages":[{"id":"795761889d12007dc6f3e5a58c94f8a67703a607","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"date":"2020-12-18 12:50:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"119ce017ab43593567c5f0e387470cc9c87dc3de","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-18 14:17:13.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/392396fe2a5542e5ab99c22739c4ffd5 : SUCCESS in 3m 58s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/5b7e1ffeca104faa8de8f7760b50f7c3 : SUCCESS in 6m 03s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/84f4eb665dc54bc0bad7771806f36567 : SUCCESS in 6m 18s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/3ae89c16f5aa40a787c59a1132a4fd21 : SUCCESS in 7m 57s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/7495547034e943fb82c0a82546e2b294 : SUCCESS in 45m 44s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/7282b09639e24ea0a2d8a545d017550d : SUCCESS in 46m 36s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/ccf484284f9e4f02afddc84ebd4981bc : SUCCESS in 1h 09m 38s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/db75234c454646b889e68de901a7708d : SUCCESS in 47m 35s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/0756e24a415545af862cda7dca860148 : SUCCESS in 48m 59s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/a9df2b7076da45649ff2c4f639af8b04 : POST_FAILURE in 33m 08s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.10 https://zuul.opendev.org/t/openstack/build/5f2ab56702914d1380763d382e1cac68 : SUCCESS in 46m 38s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.10 https://zuul.opendev.org/t/openstack/build/e3b360cc83054fd3be3145757777a957 : SUCCESS in 43m 23s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.10 https://zuul.opendev.org/t/openstack/build/cd50e8f9404d495e94426eedae7ada05 : POST_FAILURE in 30m 25s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.10 https://zuul.opendev.org/t/openstack/build/4d8022b12a8149c98bbbab5cd8459b8d : SUCCESS in 57m 30s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.10 https://zuul.opendev.org/t/openstack/build/63e7d97d120e4212986bab47be3b47b1 : SUCCESS in 40m 19s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.10 https://zuul.opendev.org/t/openstack/build/bcfbb63633324ab0a7e994a82aabe280 : SUCCESS in 37m 02s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/54a3f567c21c4e2d82f2cb4fb667fb90 : SUCCESS in 22m 01s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/a9a651bfc20c401bbd09d13ce673f521 : SUCCESS in 28m 17s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1cd98e1888279bca792a1d99bcfd191e02516f3f","author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"date":"2020-12-21 11:35:03.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"e9c155773e32ecdb7f6540c21f1c9099470331ca","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-12-21 12:29:45.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"ed5ad3c5b801bfa4c08f39c2e35756391a34033f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-21 13:06:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/f3b50e7f43da4b91af7887b27b8701c4 : SUCCESS in 2m 41s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/2c72c51d950f469e861a4c539f19c30c : SUCCESS in 6m 16s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/1cda78abd4d544fcb4c0bb55b3f9035b : SUCCESS in 5m 37s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/2603a2fda84b445a9f5335e671ca743a : SUCCESS in 6m 23s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/dd1f5ae3560b418ca2ba9cd17ec9e38d : SUCCESS in 43m 38s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/279556a6247d4758a67a61ada1607c98 : SUCCESS in 43m 02s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/5fb2b0f0b34e4c6180793dc6218bf4c9 : SUCCESS in 48m 25s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/2d7b4e02616642088b7677edb794fe6f : SUCCESS in 49m 00s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/7e237999499e4fbea6256faf1d890e71 : SUCCESS in 1h 01m 38s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/3138bcdcccf64fa88f176761f76e5ae3 : SUCCESS in 41m 35s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.10 https://zuul.opendev.org/t/openstack/build/e3b080901f1e4acbb3bcabfcb22580d1 : SUCCESS in 43m 42s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.10 https://zuul.opendev.org/t/openstack/build/32082ffa40424a298c93e55713147292 : SUCCESS in 1h 12m 45s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.10 https://zuul.opendev.org/t/openstack/build/382c445711e24db0ae1fd5c579bf8ac1 : POST_FAILURE in 28m 19s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.10 https://zuul.opendev.org/t/openstack/build/4cced253da8145cea8d1743160ef236a : SUCCESS in 38m 09s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.10 https://zuul.opendev.org/t/openstack/build/124ba2de35964e6c8582a761aa28ac88 : SUCCESS in 40m 36s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.10 https://zuul.opendev.org/t/openstack/build/a7db425be2db4b39b8f62c140e402e4e : SUCCESS in 34m 44s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/e755e83e4ed34f7b8ea723ba69a053ae : SUCCESS in 29m 14s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/86005fda7e224c2fa3f1e9b5b09f4b4f : SUCCESS in 27m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d17aefca96e1e8fea673c6d3e9600ef558a7a258","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2020-12-21 13:26:41.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"bb80bc3940e266b764f240aac5ce45e9984edba8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-21 13:26:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"72819b23c98a7395ffd632e6d380c5f3a3a6e2ac","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-21 14:20:59.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/f0447050d2f84934959dcab55fa44627 : SUCCESS in 3m 04s\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/53b7d26df1e443d488272b4772bf554e : SUCCESS in 6m 25s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/4d2019556c6e4223913a3bb5392a9382 : SUCCESS in 8m 19s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/2178d2d9b2a04e6884e4b139b816c91f : SUCCESS in 42m 01s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/64ab6a69bd714b44bb1c30625e5e060b : SUCCESS in 44m 39s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/0b9a9d80aa1a405baa81f97cc00afaa8 : SUCCESS in 44m 06s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/d38cae0e24b04a76a8efda59864a872f : SUCCESS in 45m 59s\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/c154122d969140f787567061e0b7f6ad : SUCCESS in 47m 08s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.10 https://zuul.opendev.org/t/openstack/build/db8874f7ba60465eb8155fa1664cc91a : SUCCESS in 43m 02s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.10 https://zuul.opendev.org/t/openstack/build/6276742ee267427686de73d68343aee2 : SUCCESS in 35m 43s\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.10 https://zuul.opendev.org/t/openstack/build/cc1126fa275041b0a1923d58048e82e4 : SUCCESS in 32m 35s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.10 https://zuul.opendev.org/t/openstack/build/a356d099dde1435380624ca221ca9805 : SUCCESS in 39m 55s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.10 https://zuul.opendev.org/t/openstack/build/a48514f470964ad78dc9a09d2bfd32d4 : SUCCESS in 36m 34s","accounts_in_message":[],"_revision_number":1},{"id":"ffa27344788b95bd0370bf3272097f654a2f7d3b","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-12-21 14:21:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ea1f1df80570459890c1afe754ca5adc062c6740","revisions":{"ea1f1df80570459890c1afe754ca5adc062c6740":{"kind":"REWORK","_number":1,"created":"2020-12-18 12:50:02.000000000","uploader":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"ref":"refs/changes/10/767710/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/10/767710/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/767710/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/767710/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/767710/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/10/767710/1"}}},"commit":{"parents":[{"commit":"d004e0af056b15294bb33a0325d50511c48c938f","subject":"Merge \"Migrating dns_zone from AnsibleModule to OpenStackModule\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/d004e0af056b15294bb33a0325d50511c48c938f"}]}],"author":{"name":"anbanerj","email":"anbanerj@redhat.com","date":"2020-12-18 12:49:34.000000000","tz":60},"committer":{"name":"anbanerj","email":"anbanerj@redhat.com","date":"2020-12-18 12:49:52.000000000","tz":60},"subject":"Migrating subnet module from AnsibleModule to OpenStackModule","message":"Migrating subnet module from AnsibleModule to OpenStackModule\n\n1. Created class SubnetModule with run method\n2. Changed argument_spec from openstack_full_argument_spec to dict\n3. Moved \"netid !\u003d subnet[\u0027network_id\u0027]:\" check inside \"if network:\" loop\n4. Moved the methods using \"module\" inside SubnetModule class\n\nChange-Id: I8f19359e70f8565ebfb096d30ab75e727f748be6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/ea1f1df80570459890c1afe754ca5adc062c6740"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/ea1f1df80570459890c1afe754ca5adc062c6740"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}