)]}'
{"plugins/modules/subnet.py":[{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e15d0221b9ac672b9824e836284e17353f7b2364","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                subnet \u003d self.conn.create_subnet(network_name, **kwargs)"},{"line_number":335,"context_line":"                changed \u003d True"},{"line_number":336,"context_line":"            else:"},{"line_number":337,"context_line":"                if self._needs_update(subnet, filters):"},{"line_number":338,"context_line":"                    # Only apply necessary changes to prevent errors like \"Current gateway ip 192.168.0.1 already in use"},{"line_number":339,"context_line":"                    # by port efc64a9f-264e-4c1e-bdbb-0c4e97bc5a06. Unable to update.\""},{"line_number":340,"context_line":"                    kwargs \u003d dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da56724a_f599d58b","line":337,"updated":"2021-01-11 17:45:49.000000000","message":"The new code more or less duplicates needs_update. I think you can remove it and just check if kwargs is empty in the end.","commit_id":"fb0f0b7e5bad3736bfadd051aa3868fb30882169"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"cfc787fb5b90c831eed0cd9b28f451a106a7f545","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        if pool_start and pool_end:"},{"line_number":225,"context_line":"            pool \u003d dict(start\u003dpool_start, end\u003dpool_end)"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            pool \u003d None"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        changes \u003d dict()"},{"line_number":230,"context_line":"        if subnet[\u0027enable_dhcp\u0027] !\u003d enable_dhcp:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da8c1001_d19ee079","line":227,"updated":"2021-01-12 15:48:52.000000000","message":"Is [None] an actually valid value? The previous version was {\u0027pool_start\u0027: None, \u0027pool_end\u0027: None}","commit_id":"6e3eab0bf31794e3c10893eb79458bfb22879c7c"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"8c9275d4512ac3dc840786ed4f645fc177ea920c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        if pool_start and pool_end:"},{"line_number":225,"context_line":"            pool \u003d dict(start\u003dpool_start, end\u003dpool_end)"},{"line_number":226,"context_line":"        else:"},{"line_number":227,"context_line":"            pool \u003d None"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        changes \u003d dict()"},{"line_number":230,"context_line":"        if subnet[\u0027enable_dhcp\u0027] !\u003d enable_dhcp:"}],"source_content_type":"text/x-python","patch_set":4,"id":"cf635976_a25a350f","line":227,"in_reply_to":"da8c1001_d19ee079","updated":"2021-01-12 20:06:18.000000000","message":"The previous case \"{\u0027pool_start\u0027: None, \u0027pool_end\u0027: None}\" was a bug which caused Ansible to fail.\n\n\"[None]\" is not possible, because I added \"if pool and ...\" in line 234.","commit_id":"6e3eab0bf31794e3c10893eb79458bfb22879c7c"}]}
