)]}'
{"id":"openstack%2Fansible-collections-openstack~770267","triplet_id":"openstack%2Fansible-collections-openstack~master~I5b7adc399f19da08f02202af64a226c92bb9bf41","project":"openstack/ansible-collections-openstack","branch":"master","topic":"story_2008136_os_volume_info_for_pre_0_19_sdk","hashtags":[],"change_id":"I5b7adc399f19da08f02202af64a226c92bb9bf41","subject":"Fix volume_info result for SDK \u003c 0.19","status":"MERGED","created":"2021-01-12 11:00:13.000000000","updated":"2021-01-15 16:46:14.000000000","submitted":"2021-01-15 16:46:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":6,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"770267-story_2008136_os_volume_info_for_pre_0_19_sdk","meta_rev_id":"66f3c190053c08bfde50bc23a4d636962089dab7","_number":770267,"virtual_id_number":770267,"owner":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-01-15 16:46:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-01-14 12:06:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-01-15 15:41:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-01-12 11:03:20.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"},{"updated":"2021-01-12 12:27:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b8698a87b229dd02d760fdb04694ee5a4ad18a05","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-12 11:00:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cfe7a73cd6350ccd84f4e31b6110701556fff6e4","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-01-12 11:03:20.000000000","message":"Patch Set 1: Code-Review-2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"26dee2e23e861ea023d6f00d456420119d936dff","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-12 11:18:52.000000000","message":"Patch Set 1:\n\nIf i understand \u0027check_versioned\u0027 right, then \u0027min_ver\u0027 will only prevent the usage of \u0027all_projects\u0027 var in older sdk versions. But the module will fail on older sdk versions anyway because the result of \u0027volumes()\u0027 is not a list of dict\u0027s on older sdk versions. I am currently testing with sdk 0.17.2 from Debian 10 (Buster).","accounts_in_message":[],"_revision_number":1},{"id":"b22caf08cceead68a0ff9d867db0d28b3936a54a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-12 12:27:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/1f22e84fb725464d845d611ef0eef4a4 : SUCCESS in 2m 54s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/168305670cb64eaca68e7472d63bda4c : SUCCESS in 5m 55s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/9fa7a10716e24b4f818880d10e6eaeaa : SUCCESS in 6m 15s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/f66f662849a94f7db3e41a0b738e24a5 : SUCCESS in 6m 05s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/ac2bbc598c6947a3b094310cedefceba : SUCCESS in 44m 36s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/18b1f3c838af41ec9fa279bb1bf0ce02 : SUCCESS in 55m 38s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/d4c8c93cfb30438d8117d1f7e383d417 : SUCCESS in 1h 07m 12s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/9d7ce97428f644a3adaf46c1310be2a9 : SUCCESS in 58m 06s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/c32aa9ba1083422c8b15f59043bda971 : SUCCESS in 1h 00m 56s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/8f1dc396cf66419aa7fb8339ef8c6d49 : SUCCESS in 48m 21s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.10 https://zuul.opendev.org/t/openstack/build/3a1d214716a74f1b847bee3ed1cccd9c : SUCCESS in 42m 45s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.10 https://zuul.opendev.org/t/openstack/build/14e66305d5fb4a8383078265be3c4ba0 : SUCCESS in 53m 44s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.10 https://zuul.opendev.org/t/openstack/build/99f49c2561d740fb9f0c068f91f4f2f3 : SUCCESS in 44m 37s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.10 https://zuul.opendev.org/t/openstack/build/34a425acc36949a685ceb0ee41ec8fb7 : SUCCESS in 45m 29s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.10 https://zuul.opendev.org/t/openstack/build/1f64a0bff4744e37aaefcdfee47d0498 : SUCCESS in 45m 03s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.10 https://zuul.opendev.org/t/openstack/build/45d6a056a4054c4da435e0b5ce090e79 : SUCCESS in 37m 04s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/badb7ce180804cf99e2d67bba883e461 : SUCCESS in 19m 47s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/ae50aea535cf48a68182aa9c50bcf740 : SUCCESS in 22m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"49f42147160500c7513d003cc312284de6feb851","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-12 12:30:08.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b959bce3b035c5a25f5ffea90616947ef5d5bd86","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-12 12:34:33.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"cfb1d1642db7dbc9c377baa1c5839c3425337a54","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-01-12 12:35:08.000000000","message":"Patch Set 2: Code-Review-1\n\n\u003e Patch Set 1:\n\u003e \n\u003e If i understand \u0027check_versioned\u0027 right, then \u0027min_ver\u0027 will only prevent the usage of \u0027all_projects\u0027 var in older sdk versions. But the module will fail on older sdk versions anyway because the result of \u0027volumes()\u0027 is not a list of dict\u0027s on older sdk versions. I am currently testing with sdk 0.17.2 from Debian 10 (Buster).\n\nOK, then it\u0027s a different problem and commit msg should be updated. We run job with 0.17.4 version, it\u0027s \u0027rocky\u0027 job, you can check there the results.","accounts_in_message":[],"_revision_number":2},{"id":"253b345d12ed2caa2acc9d99056ece84f799759b","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-01-12 12:36:45.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"40a16d2bc27a4ea5aadced2d8353d16658e3362e","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-12 12:45:44.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 2: Code-Review-1\n\u003e \n\u003e \u003e Patch Set 1:\n\u003e \u003e \n\u003e \u003e If i understand \u0027check_versioned\u0027 right, then \u0027min_ver\u0027 will only prevent the usage of \u0027all_projects\u0027 var in older sdk versions. But the module will fail on older sdk versions anyway because the result of \u0027volumes()\u0027 is not a list of dict\u0027s on older sdk versions. I am currently testing with sdk 0.17.2 from Debian 10 (Buster).\n\u003e \n\u003e OK, then it\u0027s a different problem and commit msg should be updated. We run job with 0.17.4 version, it\u0027s \u0027rocky\u0027 job, you can check there the results.\n\nLooking at \u0027ci/roles/volume/tasks/volume_info.yml\u0027 it looks like there is currently no unit test that runs for sdk 0.17.4 and is not \u0027ignore_errors: true\u0027. The second test (\u0027Get info about volumes for all SDK\u0027) does not fail but only because it returns no volumes at all ([]). I will think about adding a unit test for older sdks..","accounts_in_message":[],"_revision_number":2},{"id":"6fa10a3ba6c6b9f3462fd1e5ed685ac4a7c55fce","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-12 12:50:14.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5305ada88b2c9771d1d62746b5fe42fcd70fee26","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-12 12:54:16.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"aa60ad8bb46babadd35bf73af69a0859d1be530b","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-01-12 12:58:16.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"004610df7268cf321ca3914cc56ebea950d44cb9","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-01-12 13:04:37.000000000","message":"Patch Set 3:\n\nTo be honest, I\u0027d rather set supported version for this module from stein (0.27) and would drop everything related to versions before. Rocky (0.17) SDK is extremely old, not supported and shouldn\u0027t be used in real life. It just doesn\u0027t worth the time spent on it, there are much more important issues we can solve.\nIf it requires a special care and some additional complicating code, please consider just to set module_min_sdk for 0.27 and exclude it from rocky tests completely.","accounts_in_message":[],"_revision_number":3},{"id":"497835d1059933cea062df217827272b8f3dacbd","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-12 13:08:05.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"1e300454ac78b7ef3e3b466f35f45d0b18043141","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-12 15:28:06.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/5009a5590ddb4136b349fe9d2f1c6bf6 : SUCCESS in 2m 46s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/0bf6b4359f3f488b91c40c51eff722d0 : SUCCESS in 6m 06s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/430fa6db251b4831a845b10cdd4cd23b : SUCCESS in 6m 19s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/a3a72d434a46476ab2adae7d95ec8d94 : SUCCESS in 7m 17s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/4620fea4b7494e29b7e71c942e803a40 : SUCCESS in 49m 41s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/3ff344971872406087fcf8322350c724 : SUCCESS in 58m 55s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/3246dae67b2a4f22824828c505139400 : SUCCESS in 1h 39m 20s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/a3d2d8da04fe4a6b9b9e7890149d2160 : SUCCESS in 1h 05m 30s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/bcd52e112adf49d5a4fd65e74d1cff72 : SUCCESS in 40m 53s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/a3eedef7094a44d9be9069337ceac066 : SUCCESS in 48m 46s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.10 https://zuul.opendev.org/t/openstack/build/66dbcd4aa4cb4975830177f556df25c0 : SUCCESS in 50m 47s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.10 https://zuul.opendev.org/t/openstack/build/67eae3d9fa9441109e1457a56d4fe94f : SUCCESS in 41m 58s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.10 https://zuul.opendev.org/t/openstack/build/6c9762f0eddb44b6b8cdf53a79d249e0 : SUCCESS in 49m 52s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.10 https://zuul.opendev.org/t/openstack/build/1d77c81440fe4b1cabd40cd62589353c : FAILURE in 45m 32s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.10 https://zuul.opendev.org/t/openstack/build/7aef524f33bc40909d0b709a6b8a6dcb : FAILURE in 1h 28m 23s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.10 https://zuul.opendev.org/t/openstack/build/aed66296d3ba4fa4822f6e302feaac90 : SUCCESS in 1h 20m 03s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/b9fae15f0cea484cba7c779f452cce24 : SUCCESS in 38m 35s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/b62669726e904253aca9fa42266a853e : SUCCESS in 30m 14s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"929fb26bc020bacf8fc2a5f7ee6efc91b25e0a82","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-12 20:01:55.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"4896abf60c1d761e6ae97e20cd2310bd278f6832","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-12 22:11:50.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/ceb670cf228342acaa015660ee283b6d : SUCCESS in 3m 11s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/0fb84114cd394c16a3f9578ccb91c78a : SUCCESS in 5m 59s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/28b2ceda0570405faa05a63672294e28 : SUCCESS in 5m 55s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/be57f3be500c4d9f889945e3a9cb5054 : SUCCESS in 6m 45s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/077b2e35e6cb4b20beb33bee410d15bd : SUCCESS in 37m 11s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/aaa009b51a94402db944748c9484cb05 : SUCCESS in 1h 26m 54s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/f13e4894b9094878a407e40b34a294a7 : SUCCESS in 47m 38s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/fa1064a0362547baa1e080fe469bee6d : SUCCESS in 47m 08s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/b4b29d7644b04f9bbc02b48c627366ff : SUCCESS in 1h 03m 05s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/9b60cc3a52c04bfba704e7357aae9ff4 : SUCCESS in 39m 00s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.10 https://zuul.opendev.org/t/openstack/build/cb0e5efbf41047d88fcd16008048e9d8 : SUCCESS in 54m 49s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.10 https://zuul.opendev.org/t/openstack/build/10e0fca00dcf4eb795e87bdb7c2090ef : SUCCESS in 1h 16m 23s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.10 https://zuul.opendev.org/t/openstack/build/ce13aa2088784a2fbcf9fa2f6e41c0e0 : SUCCESS in 42m 12s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.10 https://zuul.opendev.org/t/openstack/build/3c1689dd3fd2434b94039cff2ff58c91 : FAILURE in 51m 29s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.10 https://zuul.opendev.org/t/openstack/build/be6d07944058488bb01c8130e94dec39 : SUCCESS in 1h 01m 13s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.10 https://zuul.opendev.org/t/openstack/build/5a802a6362cc47bb945835303948bc10 : SUCCESS in 44m 35s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/27fc8fbf020c4c58bbe798249e532bb1 : SUCCESS in 26m 19s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/7a88ac18748d4433936128be42bfac35 : SUCCESS in 28m 01s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"1789009fa29360e044c5d83e4289ea73c9433c90","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-13 07:14:22.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":4},{"id":"c3cda642b00b41821adf12471cec01202f76763e","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-13 13:18:17.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"238d61fadc3f5437f35e09c1365700ecf13b6e46","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-13 13:18:53.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":5},{"id":"8ef0b6fedb5ef44ede55ec37ea95012bf450dd15","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-13 13:45:16.000000000","message":"Patch Set 5:\n\n\u003e Patch Set 3:\n\u003e \n\u003e To be honest, I\u0027d rather set supported version for this module from stein (0.27) and would drop everything related to versions before. Rocky (0.17) SDK is extremely old, not supported and shouldn\u0027t be used in real life. It just doesn\u0027t worth the time spent on it, there are much more important issues we can solve.\n\u003e If it requires a special care and some additional complicating code, please consider just to set module_min_sdk for 0.27 and exclude it from rocky tests completely.\n\nPlease have a look at my latest patchset. It changes just one line of code to make it compatible with SDK \u003c 0.19. I did test it with SDK 0.17.2 which is currently in Debian 10 (Buster) and it works fine. I understand that you do not want to invest time into unsupported sdk versions, but unfortunately it\u0027s still in use in Debian. Updating to a newer sdk version pulls in a lot of other dependencies and thus fixing the bug is less work :-)\n\nIn the previous patchset 4 [1], i copied and adapted some of the unit tests for volume_info so that they get executed on all SDK versions. The Zuul build logs show that my bugfix also works on Rocky (0.17) [2]. It does not work on Stein (0.27) though due to another bug that causes all returned volume properties to be \u0027null\u0027/None [3].\n\nFor the latest patchset 5 [4], i dropped the unit tests because they are more or less just a copy of the existing unit tests and obscure/pollute the unit test file.\n\nRef.:\n[1] https://review.opendev.org/plugins/gitiles/openstack/ansible-collections-openstack/+/0c6a348c83c75bbbd260fb856547f58f69471ef5%5E!/\n[2] https://zuul.opendev.org/t/openstack/build/be6d07944058488bb01c8130e94dec39/logs\n[3] https://zuul.opendev.org/t/openstack/build/3c1689dd3fd2434b94039cff2ff58c91/logs\n[4] https://review.opendev.org/plugins/gitiles/openstack/ansible-collections-openstack/+/69947cd9fda9e2c742dc21d5e5ed3fa20f14e955","accounts_in_message":[],"_revision_number":5},{"id":"1675f5ce38701e096a99ad06ca1291f422e232b2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-13 14:50:09.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/46aebc92e71f4f3ea0a58c646392507e : SUCCESS in 3m 22s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/c2a81b1539824635ba900443321ad4ac : SUCCESS in 6m 38s (non-voting)\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/c211bfa5c5a444f8a2a893b108b66b28 : SUCCESS in 5m 00s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/1250e7507eeb4fb4b00c0fb677ee5a63 : SUCCESS in 7m 13s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/27798877d52b45cb8cee1695647e37c2 : SUCCESS in 43m 02s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/a846350acb234a2d952cc80d9c9830ae : SUCCESS in 47m 00s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/1976c86a6ecd4c3a8019d0a05b6b906b : SUCCESS in 1h 04m 51s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/5eda25994bb649ffbfba93af7ab11557 : SUCCESS in 47m 16s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/70e723e2e14746a4956b72b740fb9800 : SUCCESS in 49m 26s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/55f78eb5b6e54c52b28e870264bc5ec6 : SUCCESS in 47m 09s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.10 https://zuul.opendev.org/t/openstack/build/8fd5cc30e6c44bd18d2df5644d484a97 : SUCCESS in 48m 53s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.10 https://zuul.opendev.org/t/openstack/build/3e4d2850e6074a29a39624ed248311bf : SUCCESS in 45m 17s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.10 https://zuul.opendev.org/t/openstack/build/21ac99cf442a4442a3130feb822fd1c7 : SUCCESS in 44m 40s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.10 https://zuul.opendev.org/t/openstack/build/b523a4aceab34985a892099e630d25fb : SUCCESS in 41m 02s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.10 https://zuul.opendev.org/t/openstack/build/bed68ba5a6864551a0418c11d657813d : SUCCESS in 43m 07s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.10 https://zuul.opendev.org/t/openstack/build/d43f1ece888d42d79c0865b7fbb9432c : SUCCESS in 41m 22s\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/00f32d5bb94240a39b1e32c9125f8db3 : SUCCESS in 26m 05s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/940189bbef3940489d535895f5af5d6d : SUCCESS in 25m 50s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"110f0d5c6a4cce0f55a8da0664e978cf721a3ee7","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-01-14 12:06:55.000000000","message":"Patch Set 5: Code-Review+2\n\nGreat, thanks.\nIt\u0027s interesting about Debian, can\u0027t you just install latest SDK with pip?","accounts_in_message":[],"_revision_number":5},{"id":"cad2c9cc7cbc84fc6f1e85a975c53d052735b5d2","author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"date":"2021-01-14 12:54:05.000000000","message":"Patch Set 5:\n\n\u003e Patch Set 5: Code-Review+2\n\u003e \n\u003e Great, thanks.\n\u003e It\u0027s interesting about Debian, can\u0027t you just install latest SDK with pip?\n\nThanks for the review :-)\n\nNewer SDK releases require updated python modules of e.g. cryptography, decorator, dogpile.cache, importlib_metadata, keystoneauth1 and os-service-types. Who knows what breaks when upgrading those packages but at the same time keeping the ancient versions of the rest of the Python ecosystem on Debian 10 (Buster)?!? One could go with a virtualenv instead of system-wide pip but there is an simpler way:\n\nUpdating Ansible to the 2.9 and (optionally) pulling the latest Ansible OpenStack Collection on Debian 10 is easy. It just requires installing the latest Ansible package (single file) from Debian 11 (Bullseye) or Sid and (optionally) git-clone the collection. In comparison to upgrading the SDK this is a rather small change and works fine.","accounts_in_message":[],"_revision_number":5},{"id":"ce2b173b129d168b9a7746d282b5ae3f6239e8e6","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-01-15 15:41:09.000000000","message":"Patch Set 5:\n\n\u003e Patch Set 5:\n\n\u003e Updating Ansible to the 2.9 and (optionally) pulling the latest Ansible OpenStack Collection on Debian 10 is easy. It just requires installing the latest Ansible package (single file) from Debian 11 (Bullseye) or Sid and (optionally) git-clone the collection. In comparison to upgrading the SDK this is a rather small change and works fine.\n\nTBH I\u0027m not sure it\u0027s simpler solution than just having virtualenv with any version of Ansible and OpenstackSDK there. 😊","accounts_in_message":[],"_revision_number":5},{"id":"08fcb0d3e87e420a81d96c90902aca81c4bd0658","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-01-15 15:41:26.000000000","message":"Patch Set 5: Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"313e636ab4545e4f7b007021c3751a9208879c8f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-15 15:41:40.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"d0fb5995b4aa0dbd13e1897eb45d4b786a07e8fe","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-15 16:46:11.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/f00bd2660c0140df88f154e7b2ff3dfc : SUCCESS in 2m 56s\n- openstack-tox-linters-ansible-2.10 https://zuul.opendev.org/t/openstack/build/2d2c715243644692ad71f72270750b5e : SUCCESS in 6m 22s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/7513a2cd3ff44eefa9e84acc38f9d1d2 : SUCCESS in 7m 33s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/41db3f677c7d4876ac55e7455054af38 : SUCCESS in 49m 49s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/c682e6938565407b9cd0da01b8f18274 : SUCCESS in 48m 17s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/2e21931fcd814e7fbf68e43895cdc906 : SUCCESS in 52m 59s\n- ansible-collections-openstack-functional-devstack-ansible-2.10 https://zuul.opendev.org/t/openstack/build/7d689c65b6a84428a4aea0f490cc34de : SUCCESS in 47m 11s\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/6791aa9375764b2c841338384e256b99 : SUCCESS in 48m 08s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.10 https://zuul.opendev.org/t/openstack/build/6278d2a7af174bb387be28d48597c797 : SUCCESS in 1h 01m 43s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.10 https://zuul.opendev.org/t/openstack/build/e79ca5022c9d42198301e288891e2703 : SUCCESS in 42m 56s\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.10 https://zuul.opendev.org/t/openstack/build/20b4392a588a490e9c8529a1daa0f019 : SUCCESS in 35m 20s\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.10 https://zuul.opendev.org/t/openstack/build/9a946c1e74ba42f7a2903a2fca3b5129 : SUCCESS in 37m 56s\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.10 https://zuul.opendev.org/t/openstack/build/9e5c46565d93481e9d9c8f363312f7d1 : SUCCESS in 55m 17s","accounts_in_message":[],"_revision_number":5},{"id":"66f3c190053c08bfde50bc23a4d636962089dab7","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-01-15 16:46:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"69947cd9fda9e2c742dc21d5e5ed3fa20f14e955","revisions":{"17f5d0537680987cc54c5c190c815a1927729e3a":{"kind":"REWORK","_number":1,"created":"2021-01-12 11:00:13.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/67/770267/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/67/770267/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/1"}}},"commit":{"parents":[{"commit":"a4e6d1b67ce1ec8282fddc021acb715a04ddf546","subject":"Merge \"Add support for new features\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a4e6d1b67ce1ec8282fddc021acb715a04ddf546"}]}],"author":{"name":"Jakob Meng","email":"jakobmeng@web.de","date":"2021-01-12 10:58:16.000000000","tz":60},"committer":{"name":"Jakob Meng","email":"jakobmeng@web.de","date":"2021-01-12 10:58:16.000000000","tz":60},"subject":"Fix volume_info result for SDK \u003c 0.19","message":"Fix volume_info result for SDK \u003c 0.19\n\nWith openstacksdk prior to 0.19, volume_info fails with:\n  TypeError: Value of unknown type: \u003cclass \u0027openstack.block_storage.v2.volume.Volume\u0027\u003e ...\n\nProblem is that \u0027self.conn.block_storage.volumes()\u0027 returns an instance of\n\u0027openstack.block_storage.v2.volume.Volume\u0027, which inherits from\n\u0027openstack.resource.Resource\u0027, which is a \u0027dict\u0027 subclass only since 0.19.\nHence the result of \u0027self.conn.block_storage.volumes\u0027 has to be treated\ndifferently for older versions of the openstacksdk, i.e. we have to use\nthe \u0027to_dict\u0027 function of \u0027Volume\u0027.\n\nTask: 41571\nStory: 2008136\nChange-Id: I5b7adc399f19da08f02202af64a226c92bb9bf41\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/17f5d0537680987cc54c5c190c815a1927729e3a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/17f5d0537680987cc54c5c190c815a1927729e3a"}]},"branch":"refs/heads/master"},"c28c14bcccb8677dfba7a5f9c0ad3346db92c0bb":{"kind":"REWORK","_number":2,"created":"2021-01-12 12:30:08.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/67/770267/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/67/770267/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/2"}}},"commit":{"parents":[{"commit":"a4e6d1b67ce1ec8282fddc021acb715a04ddf546","subject":"Merge \"Add support for new features\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a4e6d1b67ce1ec8282fddc021acb715a04ddf546"}]}],"author":{"name":"Jakob Meng","email":"jakobmeng@web.de","date":"2021-01-12 10:58:16.000000000","tz":60},"committer":{"name":"Jakob Meng","email":"jakobmeng@web.de","date":"2021-01-12 12:29:59.000000000","tz":60},"subject":"Fix volume_info result for SDK \u003c 0.19","message":"Fix volume_info result for SDK \u003c 0.19\n\nWith openstacksdk prior to 0.19, volume_info fails with:\n  TypeError: Value of unknown type: \u003cclass \u0027openstack.block_storage.v2.volume.Volume\u0027\u003e ...\n\nProblem is that \u0027self.conn.block_storage.volumes()\u0027 returns an instance of\n\u0027openstack.block_storage.v2.volume.Volume\u0027, which inherits from\n\u0027openstack.resource.Resource\u0027, which is a \u0027dict\u0027 subclass only since 0.19.\nHence the result of \u0027self.conn.block_storage.volumes\u0027 has to be treated\ndifferently for older versions of the openstacksdk, i.e. we have to use\nthe \u0027to_dict\u0027 function of \u0027Volume\u0027.\n\nTask: 41571\nStory: 2008136\nChange-Id: I5b7adc399f19da08f02202af64a226c92bb9bf41\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/c28c14bcccb8677dfba7a5f9c0ad3346db92c0bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/c28c14bcccb8677dfba7a5f9c0ad3346db92c0bb"}]},"branch":"refs/heads/master"},"1d426f03bfbd4453ba76ebb870009779310f18cc":{"kind":"REWORK","_number":3,"created":"2021-01-12 12:50:14.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/67/770267/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/67/770267/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/3"}}},"commit":{"parents":[{"commit":"a4e6d1b67ce1ec8282fddc021acb715a04ddf546","subject":"Merge \"Add support for new features\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a4e6d1b67ce1ec8282fddc021acb715a04ddf546"}]}],"author":{"name":"Jakob Meng","email":"jakobmeng@web.de","date":"2021-01-12 10:58:16.000000000","tz":60},"committer":{"name":"Jakob Meng","email":"jakobmeng@web.de","date":"2021-01-12 12:49:39.000000000","tz":60},"subject":"Fix volume_info result for SDK \u003c 0.19","message":"Fix volume_info result for SDK \u003c 0.19\n\nWith openstacksdk prior to 0.19, volume_info fails with:\n  TypeError: Value of unknown type: \u003cclass \u0027openstack.block_storage.v2.volume.Volume\u0027\u003e ...\n\nProblem is that \u0027self.conn.block_storage.volumes()\u0027 returns an instance of\n\u0027openstack.block_storage.v2.volume.Volume\u0027, which inherits from\n\u0027openstack.resource.Resource\u0027, which is a \u0027dict\u0027 subclass only since 0.19.\nHence the result of \u0027self.conn.block_storage.volumes\u0027 has to be treated\ndifferently for older versions of the openstacksdk, i.e. we have to use\nthe \u0027to_dict\u0027 function of \u0027Volume\u0027.\n\nTask: 41571\nStory: 2008136\nChange-Id: I5b7adc399f19da08f02202af64a226c92bb9bf41\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1d426f03bfbd4453ba76ebb870009779310f18cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/1d426f03bfbd4453ba76ebb870009779310f18cc"}]},"branch":"refs/heads/master"},"0c6a348c83c75bbbd260fb856547f58f69471ef5":{"kind":"REWORK","_number":4,"created":"2021-01-12 20:01:55.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/67/770267/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/67/770267/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/4"}}},"commit":{"parents":[{"commit":"a4e6d1b67ce1ec8282fddc021acb715a04ddf546","subject":"Merge \"Add support for new features\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a4e6d1b67ce1ec8282fddc021acb715a04ddf546"}]}],"author":{"name":"Jakob Meng","email":"jakobmeng@web.de","date":"2021-01-12 10:58:16.000000000","tz":60},"committer":{"name":"Jakob Meng","email":"jakobmeng@web.de","date":"2021-01-12 20:01:42.000000000","tz":60},"subject":"Fix volume_info result for SDK \u003c 0.19","message":"Fix volume_info result for SDK \u003c 0.19\n\nWith openstacksdk prior to 0.19, volume_info fails with:\n  TypeError: Value of unknown type: \u003cclass \u0027openstack.block_storage.v2.volume.Volume\u0027\u003e ...\n\nProblem is that \u0027self.conn.block_storage.volumes()\u0027 returns an instance of\n\u0027openstack.block_storage.v2.volume.Volume\u0027, which inherits from\n\u0027openstack.resource.Resource\u0027, which is a \u0027dict\u0027 subclass only since 0.19.\nHence the result of \u0027self.conn.block_storage.volumes\u0027 has to be treated\ndifferently for older versions of the openstacksdk, i.e. we have to use\nthe \u0027to_dict\u0027 function of \u0027Volume\u0027.\n\nTask: 41571\nStory: 2008136\nChange-Id: I5b7adc399f19da08f02202af64a226c92bb9bf41\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/0c6a348c83c75bbbd260fb856547f58f69471ef5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/0c6a348c83c75bbbd260fb856547f58f69471ef5"}]},"branch":"refs/heads/master"},"69947cd9fda9e2c742dc21d5e5ed3fa20f14e955":{"kind":"REWORK","_number":5,"created":"2021-01-13 13:18:17.000000000","uploader":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"ref":"refs/changes/67/770267/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/67/770267/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/67/770267/5"}}},"commit":{"parents":[{"commit":"a4e6d1b67ce1ec8282fddc021acb715a04ddf546","subject":"Merge \"Add support for new features\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/a4e6d1b67ce1ec8282fddc021acb715a04ddf546"}]}],"author":{"name":"Jakob Meng","email":"jakobmeng@web.de","date":"2021-01-12 10:58:16.000000000","tz":60},"committer":{"name":"Jakob Meng","email":"jakobmeng@web.de","date":"2021-01-13 13:17:58.000000000","tz":60},"subject":"Fix volume_info result for SDK \u003c 0.19","message":"Fix volume_info result for SDK \u003c 0.19\n\nWith openstacksdk prior to version 0.19, module volume_info fails with:\n  TypeError: Value of unknown type: \u003cclass\n  \u0027openstack.block_storage.v2.volume.Volume\u0027\u003e ...\n\nThe call to \u0027self.conn.block_storage.volumes()\u0027 returns an instance\nof class \u0027openstack.block_storage.v2.volume.Volume\u0027. This class\ninherits from \u0027openstack.resource.Resource\u0027, which is a \u0027dict\u0027\nsubclass since 0.19. For older sdk versions prior to 0.19 it was\nnot, hence we have to use the \u0027to_dict\u0027 function to convert each\n\u0027Volume\u0027 to \u0027dict\u0027 explicitly.\n\nRef.: https://github.com/openstack/openstacksdk/commit/2f973948473b52a6f1eb9e2eae5962d1df7a992f\n\nTask: 41571\nStory: 2008136\nChange-Id: I5b7adc399f19da08f02202af64a226c92bb9bf41\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/69947cd9fda9e2c742dc21d5e5ed3fa20f14e955"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/69947cd9fda9e2c742dc21d5e5ed3fa20f14e955"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}