)]}'
{"plugins/modules/baremetal_node_action.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd8d6c9453b5e0fe85cdd4dcef71ec2a236dd871","unresolved":true,"context_lines":[{"line_number":242,"context_line":""},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"def _set_node_boot_device(module, cloud, node):"},{"line_number":245,"context_line":"    if _is_true(node[\u0027boot_interface\u0027]):"},{"line_number":246,"context_line":"        cloud.baremetal.set_node_boot_device(node[\u0027uuid\u0027], node[\u0027boot_interface\u0027], False)"},{"line_number":247,"context_line":"        module.exit_json(changed\u003dTrue, msg\u003d\"Boot device set\")"},{"line_number":248,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"6236af67_02e581b6","line":245,"range":{"start_line":245,"start_character":16,"end_line":245,"end_character":38},"updated":"2021-01-19 17:18:30.000000000","message":"A node\u0027s boot_interface has no meaning in this context. It is code, not a device on the baremetal node. For example, possible values match to items in this list: https://github.com/openstack/ironic/blob/master/setup.cfg#L67\n\nI think what is needed is a parameter option that someone can set, which overrides or \"short cuts\" the behavior to set the boot device. Example boot device options:  bios, cdrom, disk, pxe","commit_id":"1cc33cff1374fc83c6d31076a555cc41f2eb1323"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e3238d697246283d67482a41b3734d18a67d478d","unresolved":true,"context_lines":[{"line_number":244,"context_line":"def _set_node_boot_device(module, cloud, node):"},{"line_number":245,"context_line":"    if _is_true(node[\u0027boot_interface\u0027]):"},{"line_number":246,"context_line":"        cloud.baremetal.set_node_boot_device(node[\u0027uuid\u0027], node[\u0027boot_interface\u0027], False)"},{"line_number":247,"context_line":"        module.exit_json(changed\u003dTrue, msg\u003d\"Boot device set\")"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":2,"id":"5b96c5e4_91615b76","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":61},"updated":"2021-01-17 15:53:01.000000000","message":"Why exiting from module instead of return true?","commit_id":"1cc33cff1374fc83c6d31076a555cc41f2eb1323"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd8d6c9453b5e0fe85cdd4dcef71ec2a236dd871","unresolved":true,"context_lines":[{"line_number":244,"context_line":"def _set_node_boot_device(module, cloud, node):"},{"line_number":245,"context_line":"    if _is_true(node[\u0027boot_interface\u0027]):"},{"line_number":246,"context_line":"        cloud.baremetal.set_node_boot_device(node[\u0027uuid\u0027], node[\u0027boot_interface\u0027], False)"},{"line_number":247,"context_line":"        module.exit_json(changed\u003dTrue, msg\u003d\"Boot device set\")"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef19f462_4f91e0c5","line":247,"range":{"start_line":247,"start_character":8,"end_line":247,"end_character":61},"in_reply_to":"5b96c5e4_91615b76","updated":"2021-01-19 17:18:30.000000000","message":"So exiting makes sense because setting boot device is a one-off operation. You going \"Hi, please go change this setting right now.","commit_id":"1cc33cff1374fc83c6d31076a555cc41f2eb1323"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"e3238d697246283d67482a41b3734d18a67d478d","unresolved":true,"context_lines":[{"line_number":321,"context_line":"            node \u003d cloud.get_machine(node_id)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        if _set_node_boot_device(module, cloud, node):"},{"line_number":324,"context_line":"            changed \u003d True"},{"line_number":325,"context_line":"            node \u003d cloud.get_machine(node_id)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        if _is_true(module.params[\u0027state\u0027]):"},{"line_number":328,"context_line":"            if _is_false(module.params[\u0027deploy\u0027]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"deb111be_80f401fc","line":325,"range":{"start_line":324,"start_character":12,"end_line":325,"end_character":45},"updated":"2021-01-17 15:53:01.000000000","message":"It never executes AFAIU?","commit_id":"1cc33cff1374fc83c6d31076a555cc41f2eb1323"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dd8d6c9453b5e0fe85cdd4dcef71ec2a236dd871","unresolved":true,"context_lines":[{"line_number":321,"context_line":"            node \u003d cloud.get_machine(node_id)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        if _set_node_boot_device(module, cloud, node):"},{"line_number":324,"context_line":"            changed \u003d True"},{"line_number":325,"context_line":"            node \u003d cloud.get_machine(node_id)"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        if _is_true(module.params[\u0027state\u0027]):"},{"line_number":328,"context_line":"            if _is_false(module.params[\u0027deploy\u0027]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2396f22c_3cf595d0","line":325,"range":{"start_line":324,"start_character":12,"end_line":325,"end_character":45},"in_reply_to":"deb111be_80f401fc","updated":"2021-01-19 17:18:30.000000000","message":"Correct, it is not.","commit_id":"1cc33cff1374fc83c6d31076a555cc41f2eb1323"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"b1f21e0be14807e360b231ed67b4559532aad8af","unresolved":true,"context_lines":[{"line_number":97,"context_line":"      type: bool"},{"line_number":98,"context_line":"    boot_device:"},{"line_number":99,"context_line":"      description:"},{"line_number":100,"context_line":"        - The boot device for a Node, eg. “pxe” or “disk”."},{"line_number":101,"context_line":"      type: str"},{"line_number":102,"context_line":"requirements:"},{"line_number":103,"context_line":"    - \"python \u003e\u003d 3.6\""}],"source_content_type":"text/x-python","patch_set":4,"id":"c27141f6_4ccc4298","line":100,"updated":"2021-01-21 11:11:54.000000000","message":"Let\u0027s indicate it only applies to next boot. Or maybe cover persistent devices too with a bit more complex:\n\n boot_device:\n   type: pxe\n   persistent: False","commit_id":"c345db4d7929556b284cdaa83abfa9e79a321001"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"058f07738c0ba60d0333fc7130e74d3a0369d083","unresolved":true,"context_lines":[{"line_number":98,"context_line":"    boot_device:"},{"line_number":99,"context_line":"      description:"},{"line_number":100,"context_line":"        - The boot device for a Node, eg. “pxe” or “disk”."},{"line_number":101,"context_line":"      type: str"},{"line_number":102,"context_line":"      persistent: False"},{"line_number":103,"context_line":"requirements:"},{"line_number":104,"context_line":"    - \"python \u003e\u003d 3.6\""}],"source_content_type":"text/x-python","patch_set":8,"id":"d85fb28d_6040b756","line":101,"updated":"2021-01-26 17:25:37.000000000","message":"This is actually a dictionary.\n\nSomething like\n   suboptions:\n        type:\n          description:\n            - Add a description here\n        persistent:\n          description:\n            - add a description here.","commit_id":"470d7ba015e095efb1dee47f154de5ec7f445507"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"058f07738c0ba60d0333fc7130e74d3a0369d083","unresolved":true,"context_lines":[{"line_number":273,"context_line":"        wait\u003ddict(type\u003d\u0027bool\u0027, required\u003dFalse, default\u003dFalse),"},{"line_number":274,"context_line":"        timeout\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, default\u003d1800),"},{"line_number":275,"context_line":"        validate\u003ddict(type\u003d\u0027bool\u0027, required\u003dFalse),"},{"line_number":276,"context_line":"        boot_device\u003ddict(persistent\u003dFalse, required\u003dFalse),"},{"line_number":277,"context_line":"    )"},{"line_number":278,"context_line":"    module_kwargs \u003d openstack_module_kwargs()"},{"line_number":279,"context_line":"    module \u003d IronicModule(argument_spec, **module_kwargs)"}],"source_content_type":"text/x-python","patch_set":8,"id":"e44b9977_ff7303ee","line":276,"range":{"start_line":276,"start_character":25,"end_line":276,"end_character":42},"updated":"2021-01-26 17:25:37.000000000","message":"This should just be:\n\ntype\u003d\u0027dict\u0027","commit_id":"470d7ba015e095efb1dee47f154de5ec7f445507"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"df3831cc501a573abef7709e4819b955e546a663","unresolved":true,"context_lines":[{"line_number":108,"context_line":"          description:"},{"line_number":109,"context_line":"            - A boolean value instructing the module to use a persistent"},{"line_number":110,"context_line":"              or non-persistent boot."},{"line_number":111,"context_line":"          default: True"},{"line_number":112,"context_line":"requirements:"},{"line_number":113,"context_line":"    - \"python \u003e\u003d 3.6\""},{"line_number":114,"context_line":"    - \"openstacksdk\""}],"source_content_type":"text/x-python","patch_set":12,"id":"72d2841a_47413e94","line":111,"updated":"2021-01-28 16:16:37.000000000","message":"This does not match line 266 which defaults to False.","commit_id":"1c9e2d61feeabf8d8043f56e86f536e49225f589"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"df3831cc501a573abef7709e4819b955e546a663","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    if _is_true(node[\u0027boot_device\u0027]):"},{"line_number":260,"context_line":"        boot_params \u003d module.params[\u0027boot_device\u0027]"},{"line_number":261,"context_line":"        boot_device \u003d boot_params.get(\u0027type\u0027, None)"},{"line_number":262,"context_line":"        if boot_device is not None:"},{"line_number":263,"context_line":"            cloud.baremetal.set_node_boot_device("},{"line_number":264,"context_line":"                node[\u0027uuid\u0027],"},{"line_number":265,"context_line":"                boot_device,"}],"source_content_type":"text/x-python","patch_set":12,"id":"c9bf93d8_87ef1cd6","line":262,"range":{"start_line":262,"start_character":8,"end_line":262,"end_character":35},"updated":"2021-01-28 16:16:37.000000000","message":"you could do \"if boot_device:\". Any value being in present will allow the conditional to pass. You don\u0027t need to explicitly compare it to None.","commit_id":"1c9e2d61feeabf8d8043f56e86f536e49225f589"}]}