)]}'
{"plugins/modules/baremetal_node_action.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dbddec0d9989323455f995f40f5e997b33a48ff9","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    validate:"},{"line_number":95,"context_line":"      description:"},{"line_number":96,"context_line":"        - A boolean value instructing the module to validate a node."},{"line_number":97,"context_line":"      type: bool"},{"line_number":98,"context_line":"requirements:"},{"line_number":99,"context_line":"    - \"python \u003e\u003d 3.6\""},{"line_number":100,"context_line":"    - \"openstacksdk\""}],"source_content_type":"text/x-python","patch_set":3,"id":"b9427f99_e9d38461","line":97,"updated":"2021-01-26 17:05:14.000000000","message":"maybe add a \"raid_config\" parameter here?","commit_id":"73bea5ae1da713d51b98c5abf51a06cdc4a0d419"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dbddec0d9989323455f995f40f5e997b33a48ff9","unresolved":true,"context_lines":[{"line_number":254,"context_line":"        deploy\u003ddict(required\u003dFalse, default\u003d\u0027yes\u0027),"},{"line_number":255,"context_line":"        wait\u003ddict(type\u003d\u0027bool\u0027, required\u003dFalse, default\u003dFalse),"},{"line_number":256,"context_line":"        timeout\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, default\u003d1800),"},{"line_number":257,"context_line":"        validate\u003ddict(type\u003d\u0027bool\u0027, required\u003dFalse),"},{"line_number":258,"context_line":"    )"},{"line_number":259,"context_line":"    module_kwargs \u003d openstack_module_kwargs()"},{"line_number":260,"context_line":"    module \u003d IronicModule(argument_spec, **module_kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"87b6f0fe_6dfaba2e","line":257,"updated":"2021-01-26 17:05:14.000000000","message":"Add a raid_config parameter to the argument spec here.","commit_id":"73bea5ae1da713d51b98c5abf51a06cdc4a0d419"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dbddec0d9989323455f995f40f5e997b33a48ff9","unresolved":true,"context_lines":[{"line_number":313,"context_line":"        _initiate_node_validate(module, cloud, node)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        raid_config_patch \u003d {\u0027op\u0027: \u0027replace\u0027,"},{"line_number":316,"context_line":"                             \u0027path\u0027: \u0027/target_raid_config\u0027,"},{"line_number":317,"context_line":"                             \u0027value\u0027: \u0027raid_config\u0027}"},{"line_number":318,"context_line":"        cloud.update_machine(node_id, raid_config_patch)"},{"line_number":319,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bd480626_f2757ca6","line":316,"range":{"start_line":316,"start_character":39,"end_line":316,"end_character":59},"updated":"2021-01-26 17:05:14.000000000","message":"target_raid_config is a transient field used by the ironic-conductor. You should set the path to be \"/raid_config\"","commit_id":"73bea5ae1da713d51b98c5abf51a06cdc4a0d419"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"dbddec0d9989323455f995f40f5e997b33a48ff9","unresolved":true,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        raid_config_patch \u003d {\u0027op\u0027: \u0027replace\u0027,"},{"line_number":316,"context_line":"                             \u0027path\u0027: \u0027/target_raid_config\u0027,"},{"line_number":317,"context_line":"                             \u0027value\u0027: \u0027raid_config\u0027}"},{"line_number":318,"context_line":"        cloud.update_machine(node_id, raid_config_patch)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"        if _is_true(module.params[\u0027state\u0027]):"}],"source_content_type":"text/x-python","patch_set":3,"id":"652985b8_45f3b13d","line":317,"range":{"start_line":317,"start_character":38,"end_line":317,"end_character":52},"updated":"2021-01-26 17:05:14.000000000","message":"\u0027raid_config\u0027 should be a variable, and most likely an argument to be supplied in.\n\nmodule.params[\u0027raid_config\u0027] ?","commit_id":"73bea5ae1da713d51b98c5abf51a06cdc4a0d419"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7a7ca65be55faf254188bb574f0638074c09420d","unresolved":true,"context_lines":[{"line_number":99,"context_line":"      description:"},{"line_number":100,"context_line":"        - The requested RAID configuration of the node, which will be"},{"line_number":101,"context_line":"          applied when the Node next transitions through the CLEANING state."},{"line_number":102,"context_line":"      type: str"},{"line_number":103,"context_line":"requirements:"},{"line_number":104,"context_line":"    - \"python \u003e\u003d 3.6\""},{"line_number":105,"context_line":"    - \"openstacksdk\""}],"source_content_type":"text/x-python","patch_set":4,"id":"ecb377c6_ac93a42a","line":102,"updated":"2021-02-02 17:34:46.000000000","message":"This is dictionary a dictionary I believe.","commit_id":"7f5b05c8a1da049d49b7dff5dd1198d0f3e3fe66"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7a7ca65be55faf254188bb574f0638074c09420d","unresolved":true,"context_lines":[{"line_number":260,"context_line":"        wait\u003ddict(type\u003d\u0027bool\u0027, required\u003dFalse, default\u003dFalse),"},{"line_number":261,"context_line":"        timeout\u003ddict(required\u003dFalse, type\u003d\u0027int\u0027, default\u003d1800),"},{"line_number":262,"context_line":"        validate\u003ddict(type\u003d\u0027bool\u0027, required\u003dFalse),"},{"line_number":263,"context_line":"        raid_config\u003ddict(required\u003dFalse),"},{"line_number":264,"context_line":"    )"},{"line_number":265,"context_line":"    module_kwargs \u003d openstack_module_kwargs()"},{"line_number":266,"context_line":"    module \u003d IronicModule(argument_spec, **module_kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b3be0576_d922da20","line":263,"updated":"2021-02-02 17:34:46.000000000","message":"This should be type\u003d\u0027dict\u0027 as well, like instance_info.","commit_id":"7f5b05c8a1da049d49b7dff5dd1198d0f3e3fe66"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"7a7ca65be55faf254188bb574f0638074c09420d","unresolved":true,"context_lines":[{"line_number":318,"context_line":""},{"line_number":319,"context_line":"        _initiate_node_validate(module, cloud, node)"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"        raid_config_patch \u003d {\u0027op\u0027: \u0027replace\u0027,"},{"line_number":322,"context_line":"                             \u0027path\u0027: \u0027/raid_config\u0027,"},{"line_number":323,"context_line":"                             \u0027value\u0027: module.params[\u0027raid_config\u0027]}"},{"line_number":324,"context_line":"        cloud.update_machine(node_id, raid_config_patch)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        if _is_true(module.params[\u0027state\u0027]):"}],"source_content_type":"text/x-python","patch_set":4,"id":"8e08019b_de71ac91","line":323,"range":{"start_line":321,"start_character":0,"end_line":323,"end_character":67},"updated":"2021-02-02 17:34:46.000000000","message":"I learned on ?Friday? that /raid_config cannot be directly patched.\n\nSo this is ultimately going to require a special method to be added to openstacksdk to handle the post operation of of data to the API as the destination endpoint that is required to be posted to for raid configuration is apparently /v1/nodes/\u003cuuid\u003e/states/raid\n\nSo I think the best option here is to prototype this with a method, and realistically it may be instead of update_machine below, something like set_machine_raid_config(node_id, raid_config)\n\nthe plus side, is you won\u0027t need to worry about creating a json patch like on line 321.","commit_id":"7f5b05c8a1da049d49b7dff5dd1198d0f3e3fe66"}]}