)]}'
{"plugins/modules/baremetal_node_action.py":[{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ab72b29cc265355378899107e8c84ed4e74293e2","unresolved":true,"context_lines":[{"line_number":245,"context_line":"    # Default False if no action has been taken."},{"line_number":246,"context_line":"    return False"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def _list_node_vendor_passthru(module, cloud, node):"},{"line_number":250,"context_line":"    if _is_true(module.params[\u0027vendor_passthru\u0027]):"},{"line_number":251,"context_line":"        cloud.get_vendor_passthru(node[\u0027uuid\u0027])"},{"line_number":252,"context_line":"        # This method does not yet exist in the sdk"},{"line_number":253,"context_line":"        return True"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"def _call_node_vendor_passthru(module, cloud, node):"}],"source_content_type":"text/x-python","patch_set":4,"id":"39234816_5c2bbdd9","line":253,"range":{"start_line":248,"start_character":0,"end_line":253,"end_character":19},"updated":"2021-02-02 17:16:30.000000000","message":"I don\u0027t see this being used, and I\u0027m not really sure it returns value. \n\nPutting my ironic hat on, I\u0027m not sure there is lots of value in allowing operators to enumerate the vendor pass-through methods through the ansible interface.","commit_id":"4f6527b7d0d18e28e9d5d24f6a7dd496c4a2a618"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ab72b29cc265355378899107e8c84ed4e74293e2","unresolved":true,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"def _call_node_vendor_passthru(module, cloud, node):"},{"line_number":257,"context_line":"    if _is_true(module.params[\u0027vendor_passthru\u0027]):"},{"line_number":258,"context_line":"        passthru_params \u003d module.params[\u0027vendor_passthru\u0027]"},{"line_number":259,"context_line":"        http_method \u003d passthru_params.get(\u0027http_method\u0027, None)"},{"line_number":260,"context_line":"        method_name \u003d passthru_params.get(\u0027method_name\u0027, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"960fcd8a_276ad26e","line":257,"updated":"2021-02-02 17:16:30.000000000","message":"Also: I\u0027d add a note to highlight the underlying SDK method still needs to be added.","commit_id":"4f6527b7d0d18e28e9d5d24f6a7dd496c4a2a618"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ab72b29cc265355378899107e8c84ed4e74293e2","unresolved":true,"context_lines":[{"line_number":268,"context_line":"            http_method is not None"},{"line_number":269,"context_line":"            and method_name is not None"},{"line_number":270,"context_line":"        ):"},{"line_number":271,"context_line":"            cloud.call_vendor_passthru("},{"line_number":272,"context_line":"                # This method does not yet exist in the sdk"},{"line_number":273,"context_line":"                node[\u0027uuid\u0027],"},{"line_number":274,"context_line":"                http_method,"}],"source_content_type":"text/x-python","patch_set":4,"id":"6a106bc5_f597e35f","line":271,"updated":"2021-02-02 17:16:30.000000000","message":"The method output or return value should be captured\n\nresults \u003d cloud.call...\n\nand then we likely should cause the ansible module to exit.","commit_id":"4f6527b7d0d18e28e9d5d24f6a7dd496c4a2a618"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ba0110edff9269cf2d0369287007d85971b3798f","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"def _call_node_vendor_passthru(module, cloud, node):"},{"line_number":250,"context_line":"    if _is_true(module.params[\u0027vendor_passthru\u0027]):"},{"line_number":251,"context_line":"        passthru_params \u003d module.params[\u0027vendor_passthru\u0027]"},{"line_number":252,"context_line":"        http_method \u003d passthru_params.get(\u0027http_method\u0027, None)"},{"line_number":253,"context_line":"        method_name \u003d passthru_params.get(\u0027method_name\u0027, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"79b36689_ca157212","line":250,"range":{"start_line":250,"start_character":7,"end_line":250,"end_character":29},"updated":"2021-02-18 17:00:37.000000000","message":"this would be better to do as \"if module.params[\u0027vendor_passthru\u0027]:\n\nSince your calling _is_true with a dictionary, I\u0027m not sure it can ever return True. I think it will always be false.","commit_id":"ab36d44706668c89675915d14ab63a07b735d90c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ba0110edff9269cf2d0369287007d85971b3798f","unresolved":true,"context_lines":[{"line_number":336,"context_line":"            changed \u003d True"},{"line_number":337,"context_line":"            node \u003d cloud.get_machine(node_id)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        if _call_node_vendor_passthru(module, cloud, node):"},{"line_number":340,"context_line":"            changed \u003d True"},{"line_number":341,"context_line":"            node \u003d cloud.get_machine(node_id)"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e575ba74_4e4d67da","line":339,"updated":"2021-02-18 17:00:37.000000000","message":"maybe not use an if statement, and just have: _call_node_vendor_passthru(module, cloud, node) ?","commit_id":"ab36d44706668c89675915d14ab63a07b735d90c"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"ba0110edff9269cf2d0369287007d85971b3798f","unresolved":true,"context_lines":[{"line_number":337,"context_line":"            node \u003d cloud.get_machine(node_id)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        if _call_node_vendor_passthru(module, cloud, node):"},{"line_number":340,"context_line":"            changed \u003d True"},{"line_number":341,"context_line":"            node \u003d cloud.get_machine(node_id)"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        if _is_true(module.params[\u0027state\u0027]):"},{"line_number":344,"context_line":"            if _is_false(module.params[\u0027deploy\u0027]):"},{"line_number":345,"context_line":"                module.exit_json("}],"source_content_type":"text/x-python","patch_set":5,"id":"74cf6dd8_c57ef505","line":342,"range":{"start_line":340,"start_character":10,"end_line":342,"end_character":0},"updated":"2021-02-18 17:00:37.000000000","message":"So these two lines will never be reached... The module exit_json will never allow it.","commit_id":"ab36d44706668c89675915d14ab63a07b735d90c"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bad8f11076a91f6801565db4b43e1e368887305e","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            and method_name is not None"},{"line_number":259,"context_line":"        ):"},{"line_number":260,"context_line":"            results \u003d cloud.call_vendor_passthru("},{"line_number":261,"context_line":"                # This method does not yet exist in the sdk (TODO)"},{"line_number":262,"context_line":"                node[\u0027uuid\u0027],"},{"line_number":263,"context_line":"                http_method,"},{"line_number":264,"context_line":"                method_name,"}],"source_content_type":"text/x-python","patch_set":6,"id":"23be87fb_8ce4e314","line":261,"updated":"2021-04-22 09:20:35.000000000","message":"It\u0027s in-progress: https://review.opendev.org/c/openstack/openstacksdk/+/785445","commit_id":"a6a9519ab7827035474deec0465e0ed57c7b78e3"}]}