)]}'
{"id":"openstack%2Fansible-collections-openstack~786416","triplet_id":"openstack%2Fansible-collections-openstack~master~I34697db9a6c3b56720fdaed8dc4f06518f61afc9","project":"openstack/ansible-collections-openstack","branch":"master","hashtags":["ansible","os_stack"],"change_id":"I34697db9a6c3b56720fdaed8dc4f06518f61afc9","subject":"Adding new parameter for the os_stack module","status":"ABANDONED","created":"2021-04-15 12:38:34.000000000","updated":"2024-11-03 12:22:38.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"306ca3664f8ffd0fd8c55b79289c24f76be03a4f","_number":786416,"virtual_id_number":786416,"owner":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"tag":"autogenerated:zuul:check","value":1,"date":"2021-04-15 16:10:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"all":[{"value":-1,"date":"2021-04-16 07:22:19.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-15 13:14:26.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-15 22:57:24.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"},{"updated":"2021-04-16 07:22:19.000000000","updated_by":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2022-11-03 21:28:08.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REMOVED"}],"messages":[{"id":"705992ac23733701d78a3323eaff5b0d741dccd3","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 12:38:34.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dc2c8c4c8c03cdd9779e14a1465e93821f10124e","tag":"autogenerated:gerrit:newWipPatchSet","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 12:56:33.000000000","message":"Patch Set 2: Published edit on patch set 1.","accounts_in_message":[],"_revision_number":2},{"id":"4837b5efcae1a4da43b1cfa733d4ad3ba870feb6","tag":"autogenerated:gerrit:setReadyForReview","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 12:56:46.000000000","message":"Set Ready For Review","accounts_in_message":[],"_revision_number":2},{"id":"d394010e2c65fbd9c26ec4a2bbdae40389d164c2","tag":"autogenerated:gerrit:setPsDescription","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 13:00:25.000000000","message":"Description of patch set 2 set to \"Updated os_stack module with new parameter\"","accounts_in_message":[],"_revision_number":2},{"id":"ebf453fa44a9aaeee148f3e7225bdeadbbaa61ae","tag":"autogenerated:gerrit:setPsDescription","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 13:00:35.000000000","message":"Description \"Updated os_stack module with new parameter\" removed from patch set 2","accounts_in_message":[],"_revision_number":2},{"id":"bc517a7cf314b34c8814dcded62364d71536b254","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 13:01:02.000000000","message":"Hashtag added: os_stack","accounts_in_message":[],"_revision_number":2},{"id":"a48bcbd0d9e4cacc0aa0b252ed11a8359f9e3a98","tag":"autogenerated:gerrit:setHashtag","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 13:01:16.000000000","message":"Hashtag added: ansible","accounts_in_message":[],"_revision_number":2},{"id":"ab8b7b29004011902c7d0746e36046654b2ceb86","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 13:03:33.000000000","message":"Patch Set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"6f9b716800f2926b9b9a96d0610ca74b6a903a13","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-15 13:14:26.000000000","message":"Patch Set 3: Verified-1\n\n(4 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/5d111739124b499da576f75a39d93fa9 : FAILURE in 4m 36s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/6f12e5adab3d4c1180d94ee2e8525020 : FAILURE in 4m 47s (non-voting)\n- openstack-tox-linters-ansible-2.11 https://zuul.opendev.org/t/openstack/build/1bc4361410f242efb22498348f98445d : FAILURE in 5m 51s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/b46f60c4f9a64dbda11c86a80dfacc50 : FAILURE in 6m 26s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n\nWarning:\n  Job tox-pep8: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_stack.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-devel: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_stack.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-2.11: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_stack.py has only 1 lines\u0027\n  Job openstack-tox-linters-ansible-2.9: unable to map line for file comments: \n  stderr: \u0027fatal: file plugins/modules/os_stack.py has only 1 lines\u0027\n  Comments left for invalid file plugins/modules/os_stack.py","accounts_in_message":[],"_revision_number":3},{"id":"e9744727000fe518fcda4c137815af09cd8d0be6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 13:34:06.000000000","message":"Patch Set 4: Published edit on patch set 3.","accounts_in_message":[],"_revision_number":4},{"id":"73e690b51a6fdbb7dc89b9bfd62a88e7a7e475ad","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 13:44:46.000000000","message":"Patch Set 5: Commit message was updated.","accounts_in_message":[],"_revision_number":5},{"id":"f4b3065f057bc6ad40c2cd272636d1a54cabff4d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-15 13:53:48.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/dc057c7d39a145f3aa81b4e00edebe28 : SUCCESS in 4m 45s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/c91ec96213244a44b9be305dda95cebc : FAILURE in 6m 36s (non-voting)\n- openstack-tox-linters-ansible-2.11 https://zuul.opendev.org/t/openstack/build/ba7d89b42e1a4bae8573001a215630b9 : FAILURE in 6m 42s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/d09ecc58032240458e0b1e0867fadcc4 : FAILURE in 7m 51s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.11 https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/None : SKIPPED (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"ab46c3853049fde8c2661039413a4abf80eea187","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-15 14:50:10.000000000","message":"Patch Set 6: Published edit on patch set 5.","accounts_in_message":[],"_revision_number":6},{"id":"6ff8e0d6ace90596b4ac110ffda71dd3927fc6d2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-15 16:10:41.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/28d3ed37b21148e9bfc8404e41374187 : SUCCESS in 3m 44s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/6e993dfbc1934198a7919c128a6ceb03 : SUCCESS in 6m 17s (non-voting)\n- openstack-tox-linters-ansible-2.11 https://zuul.opendev.org/t/openstack/build/472051f254824968983268f83f86f987 : SUCCESS in 5m 57s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/76d581c933ca4f8a9c0410f7e13e3b84 : SUCCESS in 7m 16s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/97fae9d7b0864c4abf06bbb60b6510e2 : SUCCESS in 41m 07s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/2d8f21aa89124a9da5ce260de054cb4e : SUCCESS in 44m 15s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/61cfb1e5818b4e95adeb35c63747cbea : SUCCESS in 47m 39s\n- ansible-collections-openstack-functional-devstack-ansible-2.11 https://zuul.opendev.org/t/openstack/build/6a67f7f963a040f394f1d61f2363f436 : SUCCESS in 44m 55s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/29a6f73a19fc4f499d519255cdeab845 : SUCCESS in 44m 44s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/6038533ea596419fa1ed19fc36f9e104 : SUCCESS in 52m 41s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.11 https://zuul.opendev.org/t/openstack/build/b14c1e45521d4329ad415ff876660795 : SUCCESS in 51m 26s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.11 https://zuul.opendev.org/t/openstack/build/cbb00e35b69743aebbb7c784183b0f63 : SUCCESS in 46m 36s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/c4685341031346138fe767828cc866c9 : SUCCESS in 46m 38s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.11 https://zuul.opendev.org/t/openstack/build/35fe2eca5b7d41fbaa6957378dcfe137 : SUCCESS in 42m 16s (non-voting)\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.11 https://zuul.opendev.org/t/openstack/build/5d0266b22a9148108145db10f52db076 : SUCCESS in 44m 57s (non-voting)\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.11 https://zuul.opendev.org/t/openstack/build/985c3bbb6b194c3e8d8cb9bf4cf52578 : SUCCESS in 52m 49s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/cd41971df5c84605b4645570ff4065b9 : SUCCESS in 29m 38s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/76018797b63e421297d689d68a621be8 : SUCCESS in 29m 15s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"07a3296406cdf1f68a563abf71bd77cbe5bf1306","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-04-15 22:57:24.000000000","message":"Patch Set 6: Code-Review+2","accounts_in_message":[],"_revision_number":6},{"id":"b6402713804b393f722c08cfe0b48a194600ac04","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-04-16 07:22:19.000000000","message":"Patch Set 6: Code-Review-1\n\nThis is way too confusing to be accepted in this form:\n- param name \"updateonretry\" is absolutely misleading. I can not guess from the name what it suppose to do\n- description tells: \"If stack is present skip stack update\"\n- code is repeating update in any case, even if update was successful\n\nI do not really understand what you want to achieve with that (and it is clearly changes default behavior: default: true which enables \"retry\")","accounts_in_message":[],"_revision_number":6},{"id":"b50cc18b65cba761c13cfa1e655ccf56fd0a2c34","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-16 09:41:18.000000000","message":"Patch Set 6:\n\n\u003e Patch Set 6: Code-Review-1\n\u003e \n\u003e This is way too confusing to be accepted in this form:\n\u003e - param name \"updateonretry\" is absolutely misleading. I can not guess from the name what it suppose to do\n\u003e - description tells: \"If stack is present skip stack update\"\n\u003e - code is repeating update in any case, even if update was successful\n\u003e \n\u003e I do not really understand what you want to achieve with that (and it is clearly changes default behavior: default: true which enables \"retry\")\n\nHi Artem, \n\nThank You for the comments. \n\nThe Default behavior of the os_stack module is\n1. Stack will be created if it is not present in Openstack. \n2. stack will be updated if it is already present in Openstack. (Stack status will change to UPDATE_COMPLETE)\n\nTo persist the default behavior I have set the param value to True.\n\nWith the introduction of new parameter, we are providing an option to the user whether to update the stack or not when stack is already present in Openstack. (Default is set to update the stack)\n\nWhen the parameter value is set to False(updateOnRetry: False) we will not update the stack in openstack. This will not have impact on creation of stack. \nPlease let me know your suggestions. \n\nThank You.\nVenkata.","accounts_in_message":[],"_revision_number":6},{"id":"16bffce59ec4170291a6393d281b15482d91204d","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-04-16 10:25:00.000000000","message":"Patch Set 6:\n\n\u003e The Default behavior of the os_stack module is\n\u003e 1. Stack will be created if it is not present in Openstack. \n\u003e 2. stack will be updated if it is already present in Openstack. (Stack status will change to UPDATE_COMPLETE)\n\nAnd what is wrong with this behavior?\n\n\n\u003e To persist the default behavior I have set the param value to True.\n\u003e \n\u003e With the introduction of new parameter, we are providing an option to the user whether to update the stack or not when stack is already present in Openstack. (Default is set to update the stack)\n\u003e \n\u003e When the parameter value is set to False(updateOnRetry: False) we will not update the stack in openstack. This will not have impact on creation of stack. \n\u003e Please let me know your suggestions. \n\nDo you want to skip updating the stack? Then name the parameter skip_update, \"updateonretry\" is misleading. I do not know why would one want to skip updating (ensuring all resources are there), but the world is big enough for non standard use cases.","accounts_in_message":[],"_revision_number":6},{"id":"df9131f0a535ff765f4434eb802ec0dd26c3e499","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-16 11:31:32.000000000","message":"Patch Set 6:\n\n\u003e Patch Set 6:\n\u003e \n\u003e \u003e The Default behavior of the os_stack module is\n\u003e \u003e 1. Stack will be created if it is not present in Openstack. \n\u003e \u003e 2. stack will be updated if it is already present in Openstack. (Stack status will change to UPDATE_COMPLETE)\n\u003e \n\u003e And what is wrong with this behavior?\n\u003e \n\u003e \n\u003e \u003e To persist the default behavior I have set the param value to True.\n\u003e \u003e \n\u003e \u003e With the introduction of new parameter, we are providing an option to the user whether to update the stack or not when stack is already present in Openstack. (Default is set to update the stack)\n\u003e \u003e \n\u003e \u003e When the parameter value is set to False(updateOnRetry: False) we will not update the stack in openstack. This will not have impact on creation of stack. \n\u003e \u003e Please let me know your suggestions. \n\u003e \n\u003e Do you want to skip updating the stack? Then name the parameter skip_update, \"updateonretry\" is misleading. I do not know why would one want to skip updating (ensuring all resources are there), but the world is big enough for non standard use cases.\n\nHi Artem, \n\nWe are just giving more control to the user. By providing an option we make sure the status of the stack is intact even after multiple executions of the playbook.","accounts_in_message":[],"_revision_number":6},{"id":"17e13a04468c49e37dd47bdcc691491ee7cebb1f","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-04-16 11:33:43.000000000","message":"Patch Set 6:\n\n\u003e We are just giving more control to the user. By providing an option we make sure the status of the stack is intact even after multiple executions of the playbook.\n\nthat must be done through check mode of the module and dry_run of the Heat and not through custom attribute","accounts_in_message":[],"_revision_number":6},{"id":"184e414dcaa47462e9fd1014a3eec4f9110a7575","author":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"date":"2021-04-16 11:52:06.000000000","message":"Patch Set 6:\n\n\u003e Patch Set 6:\n\u003e \n\u003e \u003e We are just giving more control to the user. By providing an option we make sure the status of the stack is intact even after multiple executions of the playbook.\n\u003e \n\u003e that must be done through check mode of the module and dry_run of the Heat and not through custom attribute\n\nHi Artem, \n\nYes, For first time deployment we can use that. But given the scenario where user will try to create multiple stacks using Automation. Ex: Networks Stack, Ports Stack, Instance stack etc, If one of the stack is failed and user wants to retry the same playbook again, how user can skip the already created stacks without updating the status of the stacks. \n\nJust to give you a context, I am coming from a NFV background where we use Orchestrator/VNFM(uses Ansible) to talk to openstack to do multiple deployments and the fail scenario is very common thus added this parameter in our library.","accounts_in_message":[],"_revision_number":6},{"id":"913646522b9613fd7fc94ac4183add7ee0a2718a","author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"date":"2021-04-16 14:31:36.000000000","message":"Patch Set 6:\n\nAs I said - if there is real need for that, ok. But call the parameter differently, 99.9% of the use cases want the update to be performed. If there is a rare usecase this is not wanted - add ability to \"skip\" this, rather then saying others want to do it.\nI am still not confident in your case. What do you want to do if stack exists but is in a failed state? With that approach you clearly leave it not fixed, and that is the main idea of doing update unconditionally leaving Heat freedom to detect and decide whether it need to do something or not (it\u0027s same as to do `terraform apply` asking tool to ensure everything is according to the described state). But ok, it\u0027s your case.","accounts_in_message":[],"_revision_number":6},{"id":"e99721cf5a7a60d498dd159ad5ed9a2a7e97cf99","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-04-16 17:36:12.000000000","message":"Patch Set 6: -Code-Review\n\nI think checking for a stack status is worth doing. If it\u0027s in one of failed states, it doesn\u0027t make sense to leave it as is usually.","accounts_in_message":[],"_revision_number":6},{"id":"f698982776ff27f429ce6fa70d0b8fdf95532d22","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2022-11-03 21:28:08.000000000","message":"Removed reviewer \u003cGERRIT_ACCOUNT_10969\u003e.","accounts_in_message":[{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}],"_revision_number":6},{"id":"306ca3664f8ffd0fd8c55b79289c24f76be03a4f","tag":"autogenerated:gerrit:abandon","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2024-11-03 12:22:38.000000000","message":"Abandoned\n\nAbandoning since no activity, feel free to reopen if needed.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"84830a58c1cec2aa69f51380f302f009c664d2df","revisions":{"c21c5a71f25a7c6a4804a0b7314f10b9834b7524":{"kind":"REWORK","_number":1,"created":"2021-04-15 12:38:34.000000000","uploader":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"ref":"refs/changes/16/786416/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/16/786416/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/1"}}},"commit":{"parents":[{"commit":"f3e9c78c18a281259bd70526229fcd772ac78a59","subject":"Bump to dev version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/f3e9c78c18a281259bd70526229fcd772ac78a59"}]}],"author":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 12:38:34.000000000","tz":0},"committer":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 12:38:34.000000000","tz":0},"subject":"Adding new parameter for the os_stack module that provides option to skip the existing stack updation if the stack is present in Openstack.","message":"Adding new parameter for the os_stack module that provides option to skip the existing stack updation if the stack is present in Openstack.\n\nChange-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/c21c5a71f25a7c6a4804a0b7314f10b9834b7524"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/c21c5a71f25a7c6a4804a0b7314f10b9834b7524"}]},"branch":"refs/heads/master"},"cf819a432622f46420ef3f724a2a6d550d222d0d":{"kind":"REWORK","_number":2,"created":"2021-04-15 12:56:33.000000000","uploader":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"ref":"refs/changes/16/786416/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/16/786416/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/2"}}},"commit":{"parents":[{"commit":"f3e9c78c18a281259bd70526229fcd772ac78a59","subject":"Bump to dev version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/f3e9c78c18a281259bd70526229fcd772ac78a59"}]}],"author":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 12:38:34.000000000","tz":0},"committer":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 12:56:00.000000000","tz":0},"subject":"Adding new parameter for the os_stack module that provides option to skip the existing stack updation if the stack is present in Openstack.","message":"Adding new parameter for the os_stack module that provides option to skip the existing stack updation if the stack is present in Openstack.\n\nChange-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/cf819a432622f46420ef3f724a2a6d550d222d0d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/cf819a432622f46420ef3f724a2a6d550d222d0d"}]},"branch":"refs/heads/master","description":""},"30b2ed8f9055ea8867f94ecdb4d6f12b7ef18e7a":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2021-04-15 13:03:33.000000000","uploader":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"ref":"refs/changes/16/786416/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/16/786416/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/3"}}},"commit":{"parents":[{"commit":"f3e9c78c18a281259bd70526229fcd772ac78a59","subject":"Bump to dev version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/f3e9c78c18a281259bd70526229fcd772ac78a59"}]}],"author":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 12:38:34.000000000","tz":0},"committer":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 13:03:33.000000000","tz":0},"subject":"Adding new parameter for the os_stack module that provides option to skip the existing stack update. Change-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9","message":"Adding new parameter for the os_stack module that provides option to skip the existing stack update.\nChange-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/30b2ed8f9055ea8867f94ecdb4d6f12b7ef18e7a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/30b2ed8f9055ea8867f94ecdb4d6f12b7ef18e7a"}]},"branch":"refs/heads/master","description":"Edit commit message"},"d8a1a93ff76cd8f2278b817e433259b62f2474cf":{"kind":"REWORK","_number":4,"created":"2021-04-15 13:34:06.000000000","uploader":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"ref":"refs/changes/16/786416/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/16/786416/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/4"}}},"commit":{"parents":[{"commit":"f3e9c78c18a281259bd70526229fcd772ac78a59","subject":"Bump to dev version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/f3e9c78c18a281259bd70526229fcd772ac78a59"}]}],"author":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 12:38:34.000000000","tz":0},"committer":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 13:33:12.000000000","tz":0},"subject":"Adding new parameter for the os_stack module that provides option to skip the existing stack update. Change-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9","message":"Adding new parameter for the os_stack module that provides option to skip the existing stack update.\nChange-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/d8a1a93ff76cd8f2278b817e433259b62f2474cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/d8a1a93ff76cd8f2278b817e433259b62f2474cf"}]},"branch":"refs/heads/master"},"12e3aa87b5e1f55934b9d63a7cdf8e603592defb":{"kind":"NO_CODE_CHANGE","_number":5,"created":"2021-04-15 13:44:46.000000000","uploader":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"ref":"refs/changes/16/786416/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/16/786416/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/5"}}},"commit":{"parents":[{"commit":"f3e9c78c18a281259bd70526229fcd772ac78a59","subject":"Bump to dev version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/f3e9c78c18a281259bd70526229fcd772ac78a59"}]}],"author":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 12:38:34.000000000","tz":0},"committer":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 13:44:46.000000000","tz":0},"subject":"Adding new parameter for the os_stack module","message":"Adding new parameter for the os_stack module\n\nWhich provides an option to skip the existing stack update.\nBy adding this parameter we are not changing any default behavior.\n\nChange-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/12e3aa87b5e1f55934b9d63a7cdf8e603592defb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/12e3aa87b5e1f55934b9d63a7cdf8e603592defb"}]},"branch":"refs/heads/master","description":"Edit commit message"},"84830a58c1cec2aa69f51380f302f009c664d2df":{"kind":"REWORK","_number":6,"created":"2021-04-15 14:50:10.000000000","uploader":{"_account_id":17397,"name":"Guravareddy","display_name":"Venkata","email":"bsrgsit@gmail.com","username":"bsrgsit"},"ref":"refs/changes/16/786416/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/16/786416/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/16/786416/6"}}},"commit":{"parents":[{"commit":"f3e9c78c18a281259bd70526229fcd772ac78a59","subject":"Bump to dev version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/f3e9c78c18a281259bd70526229fcd772ac78a59"}]}],"author":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 12:38:34.000000000","tz":0},"committer":{"name":"Guravareddy","email":"bsrgsit@gmail.com","date":"2021-04-15 14:49:55.000000000","tz":0},"subject":"Adding new parameter for the os_stack module","message":"Adding new parameter for the os_stack module\n\nWhich provides an option to skip the existing stack update.\nBy adding this parameter we are not changing any default behavior.\n\nChange-Id: I34697db9a6c3b56720fdaed8dc4f06518f61afc9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/84830a58c1cec2aa69f51380f302f009c664d2df"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/84830a58c1cec2aa69f51380f302f009c664d2df"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}