)]}'
{"id":"openstack%2Fansible-collections-openstack~788236","triplet_id":"openstack%2Fansible-collections-openstack~master~I041cbcc0432051d795e2c3f0e7ac7378e1970008","project":"openstack/ansible-collections-openstack","branch":"master","hashtags":[],"change_id":"I041cbcc0432051d795e2c3f0e7ac7378e1970008","subject":"Fix the idempotent of compute_flavor module","status":"MERGED","created":"2021-04-27 10:12:32.000000000","updated":"2021-05-04 09:25:49.000000000","submitted":"2021-05-04 09:25:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"788236","meta_rev_id":"2eb95d07644680b1ea93ca6d3e688aba6a4f238d","_number":788236,"virtual_id_number":788236,"owner":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-04 09:25:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":2,"date":"2021-04-27 11:35:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-05-04 08:06:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"all":[{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2021-05-04 08:06:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"reviewers":{"REVIEWER":[{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-27 11:23:33.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-04-27 11:35:55.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"},{"updated":"2021-04-29 21:04:54.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2021-05-04 08:06:25.000000000","updated_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"reviewer":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"state":"REVIEWER"}],"messages":[{"id":"ddcd05195ed3c5be05e63f9ea4af0d914fe3a69c","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2021-04-27 10:12:32.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6f3998d7cb5b92e4aad6bee06659f4dbb166ee34","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-27 11:23:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/1613807f8d0e492688080d9fe4551362 : SUCCESS in 3m 55s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/7c4e6f44c13d4c979b4313875cf8361b : SUCCESS in 5m 20s (non-voting)\n- openstack-tox-linters-ansible-2.11 https://zuul.opendev.org/t/openstack/build/d3133604e9994ffd9a3226ab4d528f4a : SUCCESS in 6m 37s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/b84e16de40e54c299de7761f30e01ca4 : SUCCESS in 6m 44s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/e895c4da4b154ab196ebfbfa5212d322 : SUCCESS in 40m 02s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/dd21b38f3a56448a98d57261c80d0624 : SUCCESS in 40m 42s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/56b6ea8e3b1f447188b28c7cb8093609 : SUCCESS in 58m 40s\n- ansible-collections-openstack-functional-devstack-ansible-2.11 https://zuul.opendev.org/t/openstack/build/a503979e6af6422998d82dcac2c821d8 : SUCCESS in 43m 29s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/b6e2eb9b0d0f4796bde74bc760f66b83 : SUCCESS in 49m 13s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/26082a3327e043c6a1f33bec317088b2 : SUCCESS in 35m 48s\n- ansible-collections-openstack-functional-devstack-wallaby-ansible-2.11 https://zuul.opendev.org/t/openstack/build/ffcf80585a0248dca74d8ce80ddc4338 : SUCCESS in 40m 55s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.11 https://zuul.opendev.org/t/openstack/build/4b2ead9a245840eeb6b46b4df9738741 : SUCCESS in 53m 09s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.11 https://zuul.opendev.org/t/openstack/build/25ab99f430bc4ff5b8350475ef0ebef8 : SUCCESS in 52m 37s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/7b50fef60b704af79e93829ef20e4f5f : SUCCESS in 49m 59s (non-voting)\n- ansible-collections-openstack-functional-devstack-stein-ansible-2.11 https://zuul.opendev.org/t/openstack/build/f67e2f5b50f34b9b872d86e1c960b09c : SUCCESS in 44m 16s (non-voting)\n- ansible-collections-openstack-functional-devstack-rocky-ansible-2.11 https://zuul.opendev.org/t/openstack/build/b80d97ea1dad44efaa2310a023f835c5 : SUCCESS in 58m 26s (non-voting)\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.11 https://zuul.opendev.org/t/openstack/build/8bddbfea63e44ad6973e444bb0f3e864 : SUCCESS in 44m 16s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/f01ac94d3778404ea76224fc17da8dda : SUCCESS in 27m 40s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/04fe99addd3b42f0b820894c0868317e : SUCCESS in 28m 53s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f73a03365e498942c003550f17c7af4fa946d346","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-04-27 11:35:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"80df0ae5e0e3f32b3427ac37da11082e4fda1a4d","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-04-29 21:04:54.000000000","message":"Patch Set 1:\n\nArtem, is it something that worth to be done in SDK perhaps?","accounts_in_message":[],"_revision_number":1},{"id":"2f6cc44cb63fae3c6ff3a72351c3979044510d40","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2021-04-30 01:54:38.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Artem, is it something that worth to be done in SDK perhaps?\n\nDo you meaning the openstacksdk?  openstacksdk works properly,  just need specify the nova_compute_api_version.. but in ansible, we don\u0027t know which api_version we may used. so change the empty to 0 maybe a good idea.because we don\u0027t need to care which api version we used","accounts_in_message":[],"_revision_number":1},{"id":"ab4546a64acf2e28b20a213fb95d1e7b74fd159e","author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"date":"2021-05-04 08:06:25.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"cb9fad562e090e05f4ce1c5bf4619cbe63565655","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-04 08:06:57.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"76c7cd57d64d25d07b558e509d8d9ce1e55a7545","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-04 09:25:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/758766cfdea14152966edbd32ce460e5 : SUCCESS in 3m 29s\n- openstack-tox-linters-ansible-2.11 https://zuul.opendev.org/t/openstack/build/986f0590c2d949b28447c23ac6bc9c7c : SUCCESS in 5m 14s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/5acc5ee29e4b4b9aaed35a6f58838505 : SUCCESS in 6m 18s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/c1d5b9d931f64d7e8d415ab9915a9a02 : SUCCESS in 31m 58s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/a43f3f4270d34a3b95428ecd0155899f : SUCCESS in 31m 08s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/4b181209afa443b597e45a74bcccb992 : SUCCESS in 32m 04s\n- ansible-collections-openstack-functional-devstack-ansible-2.11 https://zuul.opendev.org/t/openstack/build/32413f23b0bd4e6e82777ced024512d3 : SUCCESS in 34m 35s\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/c1e736c9be5d4d22b58800ce7aadeebd : SUCCESS in 31m 04s\n- ansible-collections-openstack-functional-devstack-wallaby-ansible-2.11 https://zuul.opendev.org/t/openstack/build/f4a329f6f3ad417296a4e26b8a73bf1a : SUCCESS in 54m 40s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.11 https://zuul.opendev.org/t/openstack/build/08796662035a45f596324b6e25382f06 : SUCCESS in 1h 03m 30s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.11 https://zuul.opendev.org/t/openstack/build/b587d43335f14f7f96ace252fab07095 : SUCCESS in 48m 44s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/f170e5af841c4dedb9b102e379f8cdf0 : SUCCESS in 49m 47s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2eb95d07644680b1ea93ca6d3e688aba6a4f238d","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-04 09:25:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"77acba047b6c40d31f42bb9a61b3c71f29ef4a32","revisions":{"77acba047b6c40d31f42bb9a61b3c71f29ef4a32":{"kind":"REWORK","_number":1,"created":"2021-04-27 10:12:32.000000000","uploader":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"ref":"refs/changes/36/788236/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/36/788236/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/36/788236/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/36/788236/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/36/788236/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/36/788236/1"}}},"commit":{"parents":[{"commit":"8da4e852f05eb42f6615ddcbaa070f85e5cf46c7","subject":"Add wallaby job to CI","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/8da4e852f05eb42f6615ddcbaa070f85e5cf46c7"}]}],"author":{"name":"wuchunyang","email":"wuchunyang@yovole.com","date":"2021-04-27 09:38:19.000000000","tz":480},"committer":{"name":"wuchunyang","email":"wuchunyang@yovole.com","date":"2021-04-27 10:12:29.000000000","tz":480},"subject":"Fix the idempotent of compute_flavor module","message":"Fix the idempotent of compute_flavor module\n\nif flavor\u0027s swap is not set (or 0),nova returns empty string [0]\nrather than 0 when query flavor spec. this behavior will break\nthe idempotent of the ansible deployment. this ps changes the empty\nstring to 0 before compare them.\n[0]: https://docs.openstack.org/api-ref/compute/?expanded\u003dlist-flavors-detail,list-flavors-with-details-detail#list-flavors-with-details\n\nChange-Id: I041cbcc0432051d795e2c3f0e7ac7378e1970008\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/77acba047b6c40d31f42bb9a61b3c71f29ef4a32"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/77acba047b6c40d31f42bb9a61b3c71f29ef4a32"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}