)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0290959bf9d3b293ec99695b1bdd95f740ac9694","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Change I51105f11565c5ff33b04add36259c8703af11240 moved validate_certs default from None to False."},{"line_number":10,"context_line":"This causes checks to fail in openstack_cloud_from_module as validate_certs is never None anymore."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch changes the checks so that a failure is triggered when a non default value is supplied to"},{"line_number":13,"context_line":"validate_certs when a cloud_config is being used."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Task:  41776"},{"line_number":16,"context_line":"Story: 2008600"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"173d27ae_9930f064","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":49},"updated":"2021-05-18 09:34:34.000000000","message":"I\u0027m not sure I understand - why should we fail when validate_certs are true..? Maybe just to remove \"default\u003dFalse\"?","commit_id":"f97944939e1adadf9e34e3f5040cde7551c51fe9"}],"plugins/module_utils/openstack.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"de53a8737cda73a0956c0b5c7c3f81a39d5af1c4","unresolved":true,"context_lines":[{"line_number":189,"context_line":"            if module.params[\u0027interface\u0027] !\u003d \u0027public\u0027:"},{"line_number":190,"context_line":"                module.fail_json(msg\u003dfail_message.format(param\u003d\u0027interface\u0027))"},{"line_number":191,"context_line":"            # For \u0027validate_certs\u0027 parameter, fail if we receive a non-default value"},{"line_number":192,"context_line":"            if module.params[\u0027validate_certs\u0027] is not False:"},{"line_number":193,"context_line":"                module.fail_json(msg\u003dfail_message.format(param\u003d\u0027validate_certs\u0027))"},{"line_number":194,"context_line":"            return sdk, sdk.connect(**cloud_config)"},{"line_number":195,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"816b778f_989e8fcd","line":192,"range":{"start_line":192,"start_character":13,"end_line":192,"end_character":60},"updated":"2021-05-18 09:30:49.000000000","message":"Hi, Georgina, thanks for contribution!\nI think linters won\u0027t like it. \"is\" and \"is not\" are to use with \"None\" mostly.\nFor checking for \"True\" just do:\n\n  if module.params[\u0027validate_certs\u0027]:\n  ...\n\nFor checking for \"None\":\n\n  if module.params[\u0027validate_certs\u0027] is None:\n  ...\n\nFor checking for NOT \"None\" (True or False):\n\n  if module.params[\u0027validate_certs\u0027] is not None:\n  ...\n\nIn your case I suppose you want just to check if it\u0027s True (value is non default and explicitly set), so first option will work for you:\n\n  if module.params[\u0027validate_certs\u0027]:\n  ...","commit_id":"f97944939e1adadf9e34e3f5040cde7551c51fe9"},{"author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"change_message_id":"a313c40edeefdb78a8337dfda63db18188822e3a","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            if module.params[\u0027interface\u0027] !\u003d \u0027public\u0027:"},{"line_number":190,"context_line":"                module.fail_json(msg\u003dfail_message.format(param\u003d\u0027interface\u0027))"},{"line_number":191,"context_line":"            # For \u0027validate_certs\u0027 parameter, fail if we receive a non-default value"},{"line_number":192,"context_line":"            if module.params[\u0027validate_certs\u0027] is not False:"},{"line_number":193,"context_line":"                module.fail_json(msg\u003dfail_message.format(param\u003d\u0027validate_certs\u0027))"},{"line_number":194,"context_line":"            return sdk, sdk.connect(**cloud_config)"},{"line_number":195,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":4,"id":"f2f09e63_ab3e57ce","line":192,"range":{"start_line":192,"start_character":13,"end_line":192,"end_character":60},"in_reply_to":"816b778f_989e8fcd","updated":"2021-05-20 17:16:16.000000000","message":"That is such a silly mistake of me to make!! Thanks for reviewing.","commit_id":"f97944939e1adadf9e34e3f5040cde7551c51fe9"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"de53a8737cda73a0956c0b5c7c3f81a39d5af1c4","unresolved":true,"context_lines":[{"line_number":358,"context_line":"            if self.params[\u0027interface\u0027] !\u003d \u0027public\u0027:"},{"line_number":359,"context_line":"                self.fail_json(msg\u003dfail_message.format(param\u003d\u0027interface\u0027))"},{"line_number":360,"context_line":"            # For \u0027validate_certs\u0027 parameter, fail if we receive a non-default value"},{"line_number":361,"context_line":"            if self.params[\u0027validate_certs\u0027] is not False:"},{"line_number":362,"context_line":"                self.fail_json(msg\u003dfail_message.format(param\u003d\u0027validate_certs\u0027))"},{"line_number":363,"context_line":"        else:"},{"line_number":364,"context_line":"            cloud_config \u003d dict("}],"source_content_type":"text/x-python","patch_set":4,"id":"40de1bd9_71d1cbce","line":361,"range":{"start_line":361,"start_character":43,"end_line":361,"end_character":57},"updated":"2021-05-18 09:30:49.000000000","message":"ditto","commit_id":"f97944939e1adadf9e34e3f5040cde7551c51fe9"},{"author":{"_account_id":29865,"name":"Georgina Shippey","email":"georgina.shippey@outlook.com","username":"gshippey"},"change_message_id":"a313c40edeefdb78a8337dfda63db18188822e3a","unresolved":false,"context_lines":[{"line_number":358,"context_line":"            if self.params[\u0027interface\u0027] !\u003d \u0027public\u0027:"},{"line_number":359,"context_line":"                self.fail_json(msg\u003dfail_message.format(param\u003d\u0027interface\u0027))"},{"line_number":360,"context_line":"            # For \u0027validate_certs\u0027 parameter, fail if we receive a non-default value"},{"line_number":361,"context_line":"            if self.params[\u0027validate_certs\u0027] is not False:"},{"line_number":362,"context_line":"                self.fail_json(msg\u003dfail_message.format(param\u003d\u0027validate_certs\u0027))"},{"line_number":363,"context_line":"        else:"},{"line_number":364,"context_line":"            cloud_config \u003d dict("}],"source_content_type":"text/x-python","patch_set":4,"id":"bee201f6_4ae66d69","line":361,"range":{"start_line":361,"start_character":43,"end_line":361,"end_character":57},"in_reply_to":"40de1bd9_71d1cbce","updated":"2021-05-20 17:16:16.000000000","message":"Done","commit_id":"f97944939e1adadf9e34e3f5040cde7551c51fe9"}]}