)]}'
{"id":"openstack%2Fansible-collections-openstack~792138","triplet_id":"openstack%2Fansible-collections-openstack~master~Ie1211796929d0bc12c7a48764bd8efc7defdd2d7","project":"openstack/ansible-collections-openstack","branch":"master","topic":"inv-fix-ansible211","hashtags":[],"change_id":"Ie1211796929d0bc12c7a48764bd8efc7defdd2d7","subject":"Fix inventory plugin on Ansible 2.11","status":"MERGED","created":"2021-05-19 13:01:04.000000000","updated":"2021-06-10 00:46:35.000000000","submitted":"2021-05-25 19:59:49.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"792138-inv-fix-ansible211","meta_rev_id":"da8847534465196d4d79ad587cadb5d3020d329a","_number":792138,"virtual_id_number":792138,"owner":{"_account_id":33476,"name":"Per Lind","email":"per.lind@bonniernews.se","username":"per-lind"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-05-25 19:59:49.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31679,"name":"Alan","email":"arominge@redhat.com","username":"AlanCoding"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":2,"date":"2021-05-25 17:44:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31679,"name":"Alan","email":"arominge@redhat.com","username":"AlanCoding"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"all":[{"value":1,"date":"2021-05-25 18:55:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":31679,"name":"Alan","email":"arominge@redhat.com","username":"AlanCoding"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"}],"reviewers":{"REVIEWER":[{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},{"_account_id":31679,"name":"Alan","email":"arominge@redhat.com","username":"AlanCoding"}],"CC":[{"_account_id":33616,"name":"James Ladd","email":"jladd@redhat.com"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-05-19 13:59:07.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-19 18:09:23.000000000","updated_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"reviewer":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"state":"REVIEWER"},{"updated":"2021-05-19 19:38:13.000000000","updated_by":{"_account_id":31679,"name":"Alan","email":"arominge@redhat.com","username":"AlanCoding"},"reviewer":{"_account_id":31679,"name":"Alan","email":"arominge@redhat.com","username":"AlanCoding"},"state":"REVIEWER"},{"updated":"2021-05-21 10:46:30.000000000","updated_by":{"_account_id":30171,"name":"ITD27M01","display_name":"ITD27M01","email":"igortiunov@gmail.com","username":"ITD27M01"},"reviewer":{"_account_id":30171,"name":"ITD27M01","display_name":"ITD27M01","email":"igortiunov@gmail.com","username":"ITD27M01"},"state":"REVIEWER"},{"updated":"2021-05-24 07:24:33.000000000","updated_by":{"_account_id":30171,"name":"ITD27M01","display_name":"ITD27M01","email":"igortiunov@gmail.com","username":"ITD27M01"},"reviewer":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"state":"REVIEWER"},{"updated":"2021-05-24 07:24:35.000000000","updated_by":{"_account_id":30171,"name":"ITD27M01","display_name":"ITD27M01","email":"igortiunov@gmail.com","username":"ITD27M01"},"reviewer":{"_account_id":30171,"name":"ITD27M01","display_name":"ITD27M01","email":"igortiunov@gmail.com","username":"ITD27M01"},"state":"REMOVED"},{"updated":"2021-06-10 00:46:35.000000000","updated_by":{"_account_id":33616,"name":"James Ladd","email":"jladd@redhat.com"},"reviewer":{"_account_id":33616,"name":"James Ladd","email":"jladd@redhat.com"},"state":"CC"}],"messages":[{"id":"f7d40a412e23ec3609ec16db961e0abf5d73a77d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33476,"name":"Per Lind","email":"per.lind@bonniernews.se","username":"per-lind"},"date":"2021-05-19 13:01:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bfbfa711121792180d2a15fb75b4a56b924027e9","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-19 13:59:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/c10a4b11e3774c999437813f9bd7a91b : SUCCESS in 4m 09s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/1221a155286743c2b051aa605d5ab9c8 : SUCCESS in 5m 10s (non-voting)\n- openstack-tox-linters-ansible-2.11 https://zuul.opendev.org/t/openstack/build/5c37d19098ea4c1eb7aa2f653e990a5f : SUCCESS in 6m 32s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/5269fa53e79247ca91fd9058b89b624b : SUCCESS in 6m 33s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/24f5584067c64d189093fbcbf47e0b29 : SUCCESS in 37m 53s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/48baeb3b3e614a3a947741eb9750d330 : SUCCESS in 39m 13s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/1c51b125c8854b3397b84755d8541dbf : SUCCESS in 39m 39s\n- ansible-collections-openstack-functional-devstack-ansible-2.11 https://zuul.opendev.org/t/openstack/build/cdf783eb306c44838e0ebc7f59ac3737 : SUCCESS in 42m 58s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/848ac4cf33614d0895399b2f625dddeb : SUCCESS in 38m 04s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/2fdb7470321046f3b8aaec310728963e : SUCCESS in 39m 20s\n- ansible-collections-openstack-functional-devstack-wallaby-ansible-2.11 https://zuul.opendev.org/t/openstack/build/bd56ba64d4834484a923396c51d8d550 : SUCCESS in 45m 45s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.11 https://zuul.opendev.org/t/openstack/build/8d32989a8f6441159c91c2b645cef8ac : SUCCESS in 45m 36s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.11 https://zuul.opendev.org/t/openstack/build/2f5fcb4e950540dda6065d6b78d27196 : SUCCESS in 43m 10s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/2abae72078e346f191ddb40cb0657faf : SUCCESS in 43m 36s (non-voting)\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.11 https://zuul.opendev.org/t/openstack/build/bebda04cbb9242e99812cfd361fe28f9 : SUCCESS in 40m 44s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/f377cce9bfbf4b9db9900c483479d771 : SUCCESS in 25m 29s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/1e924d584a4b4832acdb2623209b3fb0 : SUCCESS in 28m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"39d757f2e9908311084b6d9eee8c96061df2f7a4","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-05-19 18:09:23.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"991e52c5eff4280ce3b56ea8103bd25c7d20e3c1","author":{"_account_id":31679,"name":"Alan","email":"arominge@redhat.com","username":"AlanCoding"},"date":"2021-05-19 19:38:13.000000000","message":"Patch Set 1: Code-Review+1\n\nAllowing either syntax will be the kindest approach for the user. As far as I can tell, there is no official guidance that only the short name or long name should be allowed.","accounts_in_message":[],"_revision_number":1},{"id":"95b22697187fa2de3502a2d4a9b081dd97caeecd","author":{"_account_id":30171,"name":"ITD27M01","display_name":"ITD27M01","email":"igortiunov@gmail.com","username":"ITD27M01"},"date":"2021-05-21 10:46:30.000000000","message":"Patch Set 1: Code-Review-1\n\nHi Guys,\nThe EXAMPLES should be changed accordingly because it is a part of the public user documentation.\n\nThere are also unit tests for inventory plugin config [1] and they should be changed accordingly to ensure plugin quality in the future.\n\nDespite this, I can confirm that change work for me.\n\n[1] https://opendev.org/openstack/ansible-collections-openstack/src/brashould be changed accordinglynch/master/tests/unit/plugins/inventory/test_openstack.py#L30","accounts_in_message":[],"_revision_number":1},{"id":"b8bbb2817fb00da7729b2de4694cb81320525f41","author":{"_account_id":31679,"name":"Alan","email":"arominge@redhat.com","username":"AlanCoding"},"date":"2021-05-21 14:29:27.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e Hi Guys,\n\u003e The EXAMPLES should be changed accordingly because it is a part of the public user documentation.\n\u003e \n\u003e There are also unit tests for inventory plugin config [1] and they should be changed accordingly to ensure plugin quality in the future.\n\u003e \n\u003e Despite this, I can confirm that change work for me.\n\u003e \n\u003e [1] https://opendev.org/openstack/ansible-collections-openstack/src/brashould be changed accordinglynch/master/tests/unit/plugins/inventory/test_openstack.py#L30\n\nThe documentation and test you link uses the \"plugin: openstack\" syntax.\n\nThat syntax is perfectly fine. The goal of the change is to allow either the short name, \"openstack\", or the long name \"openstack.cloud.openstack\". You could add test/docs for both, but I don\u0027t honestly feel that it\u0027s necessary.","accounts_in_message":[],"_revision_number":1},{"id":"24fa520304cf6eb02e15185670250735d7f228cf","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-05-23 18:06:59.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review-1\n\u003e \n\u003e Hi Guys,\n\u003e The EXAMPLES should be changed accordingly because it is a part of the public user documentation.\n\u003e \n\u003e There are also unit tests for inventory plugin config [1] and they should be changed accordingly to ensure plugin quality in the future.\n\u003e \n\u003e Despite this, I can confirm that change work for me.\n\u003e \n\u003e [1] https://opendev.org/openstack/ansible-collections-openstack/src/brashould be changed accordinglynch/master/tests/unit/plugins/inventory/test_openstack.py#L30\n\nCan we do it in followup? Let\u0027s not block on this and you can do it in the next patch?","accounts_in_message":[],"_revision_number":1},{"id":"09ee42f1ae2b5d2f87415e52806b42d0a9276177","tag":"autogenerated:gerrit:deleteVote","author":{"_account_id":30171,"name":"ITD27M01","display_name":"ITD27M01","email":"igortiunov@gmail.com","username":"ITD27M01"},"date":"2021-05-24 07:02:00.000000000","message":"Removed Code-Review-1 by ITD27M01 \u003cigortiunov@gmail.com\u003e\n","accounts_in_message":[],"_revision_number":1},{"id":"7011ca65f27fc97b2283ea653a8fcc0bd176aa76","author":{"_account_id":30171,"name":"ITD27M01","display_name":"ITD27M01","email":"igortiunov@gmail.com","username":"ITD27M01"},"date":"2021-05-24 07:24:33.000000000","message":"Patch Set 1:\n\nHi,\nI still would suggest to correct at least the example because it is a single line change in the same file. The Ansible doc motivates users to use fqdns [1] and as I see for ansible~\u003d2.10 only fqdn was working. So, it is good chance to clean up the mess.\n\n[1] https://docs.ansible.com/ansible/latest/user_guide/collections_using.html#using-collections-in-a-playbook","accounts_in_message":[],"_revision_number":1},{"id":"f80040abbbd82fa27df042152a428e127d379f78","tag":"autogenerated:gerrit:deleteReviewer","author":{"_account_id":30171,"name":"ITD27M01","display_name":"ITD27M01","email":"igortiunov@gmail.com","username":"ITD27M01"},"date":"2021-05-24 07:24:35.000000000","message":"Removed reviewer ITD27M01.","accounts_in_message":[],"_revision_number":1},{"id":"0fe217b6effa62b8e287539b89db42542e2abd5b","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-05-24 11:43:43.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Hi,\n\u003e I still would suggest to correct at least the example because it is a single line change in the same file. The Ansible doc motivates users to use fqdns [1] and as I see for ansible~\u003d2.10 only fqdn was working. So, it is good chance to clean up the mess.\n\u003e \n\u003e [1] https://docs.ansible.com/ansible/latest/user_guide/collections_using.html#using-collections-in-a-playbook\n\nYou can add it to this commit. Just send another patchset with the doc fix.","accounts_in_message":[],"_revision_number":1},{"id":"ba6e9e1b54cc0a03c133eb0c0d1e955c35044763","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33476,"name":"Per Lind","email":"per.lind@bonniernews.se","username":"per-lind"},"date":"2021-05-25 17:43:33.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4529bfffc1ba47eac039bfddd7e5d0cace35d96f","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-05-25 17:44:30.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"0d621cef33a8b7050a23d2ab35c3d133ed023358","author":{"_account_id":33476,"name":"Per Lind","email":"per.lind@bonniernews.se","username":"per-lind"},"date":"2021-05-25 17:46:00.000000000","message":"Patch Set 2:\n\n\u003e Patch Set 1:\n\u003e \n\u003e Hi,\n\u003e I still would suggest to correct at least the example because it is a single line change in the same file. The Ansible doc motivates users to use fqdns [1] and as I see for ansible~\u003d2.10 only fqdn was working. So, it is good chance to clean up the mess.\n\u003e \n\u003e [1] https://docs.ansible.com/ansible/latest/user_guide/collections_using.html#using-collections-in-a-playbook\n\nAdjusted the example to use fqdn","accounts_in_message":[],"_revision_number":2},{"id":"5e50552545937bc13f3a58594115d518b24a8fdd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-25 18:53:57.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/d97c481913c94918abf8830b279c2be2 : SUCCESS in 3m 59s\n- openstack-tox-linters-ansible-devel https://zuul.opendev.org/t/openstack/build/d5c857a1e35445e3a6033c4970b26ccd : SUCCESS in 5m 50s (non-voting)\n- openstack-tox-linters-ansible-2.11 https://zuul.opendev.org/t/openstack/build/ee7ca8890e204639a6cd2453bf8d220a : SUCCESS in 5m 52s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/a03a78475f35434aad4cb255934432e2 : SUCCESS in 7m 14s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/5b7e497d091d4d8e976f45b5a4bb68bd : SUCCESS in 37m 48s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/43fc9e2289a445238c84ef4bcf06ee7a : SUCCESS in 40m 16s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/275f20e07df3484a87361af049e6aeee : SUCCESS in 52m 59s\n- ansible-collections-openstack-functional-devstack-ansible-2.11 https://zuul.opendev.org/t/openstack/build/a6ddbb4d9df84f07b637b7414a3c70cc : SUCCESS in 40m 21s\n- ansible-collections-openstack-functional-devstack-ansible-devel https://zuul.opendev.org/t/openstack/build/dd257e1a58194dd0b33740d2ab8789c5 : SUCCESS in 38m 34s (non-voting)\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/75979b79d6bc480789b9ac27946ca53f : SUCCESS in 43m 48s\n- ansible-collections-openstack-functional-devstack-wallaby-ansible-2.11 https://zuul.opendev.org/t/openstack/build/c217cb3786124daa9cb5face093b97a5 : SUCCESS in 47m 26s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.11 https://zuul.opendev.org/t/openstack/build/bfb20ebb4c6143d0a2d5afc3d64867f7 : SUCCESS in 46m 20s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.11 https://zuul.opendev.org/t/openstack/build/c4f4be514ff544e1b6fe9e5b1d9cb463 : SUCCESS in 36m 43s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/9597b77bb5ba4b5f9d1c9f525897bcf9 : SUCCESS in 58m 12s (non-voting)\n- ansible-collections-openstack-functional-devstack-queens-ansible-2.11 https://zuul.opendev.org/t/openstack/build/120c646827d54d9989de0a5f414f7733 : SUCCESS in 34m 21s (non-voting)\n- bifrost-collections-src https://zuul.opendev.org/t/openstack/build/b84bf2bb200144a6ad4c3ff42d98276c : SUCCESS in 23m 45s (non-voting)\n- bifrost-keystone-collections-src https://zuul.opendev.org/t/openstack/build/7d30038247794265bff690157a89fd10 : SUCCESS in 22m 14s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e31f7d8f7689b25c9b2dfea6231e52bdaed54fd4","author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"date":"2021-05-25 18:55:08.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"87acc2b57cc75dc20111e627406d91d1ac257938","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-25 18:55:28.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"097c1af7136f12199955cf68ba892b59df659b78","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-25 19:59:49.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tox-pep8 https://zuul.opendev.org/t/openstack/build/9661b417d2f2429f8dc6348aaca163fe : SUCCESS in 3m 37s\n- openstack-tox-linters-ansible-2.11 https://zuul.opendev.org/t/openstack/build/9b3787dbbe7c413b80b21ce09a36ee58 : SUCCESS in 6m 16s\n- openstack-tox-linters-ansible-2.9 https://zuul.opendev.org/t/openstack/build/241a2483b51a4b05a33e3a388ffe0c86 : SUCCESS in 7m 32s\n- ansible-collections-openstack-functional-devstack https://zuul.opendev.org/t/openstack/build/03f2b017836a41f5b5cdf639a89a85fb : SUCCESS in 46m 42s\n- ansible-collections-openstack-functional-devstack-releases https://zuul.opendev.org/t/openstack/build/15a0d17cd2504dddae5a570b11dc9d23 : SUCCESS in 52m 11s\n- ansible-collections-openstack-functional-devstack-ansible-2.9 https://zuul.opendev.org/t/openstack/build/844cd879b51248f0b65317a6319075d1 : SUCCESS in 57m 10s\n- ansible-collections-openstack-functional-devstack-ansible-2.11 https://zuul.opendev.org/t/openstack/build/c91a7638747b456c8dd52276e9516aa4 : SUCCESS in 47m 08s\n- ansible-collections-openstack-functional-devstack-ansible-pip https://zuul.opendev.org/t/openstack/build/587d1e25eb33479e83c7314694e3cc41 : SUCCESS in 50m 53s\n- ansible-collections-openstack-functional-devstack-wallaby-ansible-2.11 https://zuul.opendev.org/t/openstack/build/4b862da28bf0430288b8a4c67ace8a4e : SUCCESS in 53m 54s\n- ansible-collections-openstack-functional-devstack-victoria-ansible-2.11 https://zuul.opendev.org/t/openstack/build/4a1b692fa72b43759ad7f402d242c60e : SUCCESS in 55m 04s\n- ansible-collections-openstack-functional-devstack-ussuri-ansible-2.11 https://zuul.opendev.org/t/openstack/build/98de75ae1e194b7d9a258c3ef2a60cd9 : SUCCESS in 56m 19s\n- ansible-collections-openstack-functional-devstack-train-ansible-2.11 https://zuul.opendev.org/t/openstack/build/b9313160181e4b76869d69ff01e2ccc8 : SUCCESS in 47m 23s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"2786bbe40a73e3c8c22926340b61518514730d92","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-05-25 19:59:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"da8847534465196d4d79ad587cadb5d3020d329a","author":{"_account_id":33616,"name":"James Ladd","email":"jladd@redhat.com"},"date":"2021-06-10 00:46:35.000000000","message":"Patch Set 2:\n\nI\u0027ve confirmed that this fix enables awx to successfully run an OpenStack inventory import using ansible core 2.11.0rc2.\n\nIn order for awx to consume this fix, we will need to point it to a new release of the collection. Can we cut a new release of the collection so we can pick this up?","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"42a5cb5601187dda6e460099889ac9d74cd628b0","revisions":{"f6abd4e89c06491e1feca3dea6f74f04dd23fe61":{"kind":"REWORK","_number":1,"created":"2021-05-19 13:01:04.000000000","uploader":{"_account_id":33476,"name":"Per Lind","email":"per.lind@bonniernews.se","username":"per-lind"},"ref":"refs/changes/38/792138/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/38/792138/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/38/792138/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/38/792138/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/38/792138/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/38/792138/1"}}},"commit":{"parents":[{"commit":"6b3bf3bba01055ca8e544ce258b44e4f5da3da34","subject":"Add support to setting image tags","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/6b3bf3bba01055ca8e544ce258b44e4f5da3da34"}]}],"author":{"name":"per-lind","email":"per.lind@bonniernews.se","date":"2021-05-19 13:00:24.000000000","tz":120},"committer":{"name":"per-lind","email":"per.lind@bonniernews.se","date":"2021-05-19 13:00:24.000000000","tz":120},"subject":"Fix inventory plugin on Ansible 2.11","message":"Fix inventory plugin on Ansible 2.11\n\nThe bug here is that the openstack inventory plugin will no longer work with Ansible 2.11. You can test an inventory file (named openstack.yml) with either of these syntaxes:\n\nplugin: openstack\nplugin: openstack.cloud.openstack\nThe first option errors due to custom validation present in openstack\u0027s own inventory plugin:\n\n[WARNING]: * Failed to parse /home/alancoding/repos/awx/testing/openstack/openstack.yml with auto plugin: plugin\nconfig file, but not for us: openstack\n\nBecause this was written back before FQCNs (fully-qualified collection names) were a thing. Before it migrated to a collection, \"openstack\" was the expectation, but then self.NAME for the inventory plugin changed to \"openstack.cloud.openstack\", meaning that \"openstack\" by itself would no longer work. That made sense until Ansible core introduced routing where it would recognize \"openstack\" and route it to \"openstack.cloud.openstack\" for purposes of the \"auto\" inventory plugin routing. See the routing entry at:\n\nhttps://github.com/ansible/ansible/blob/2cbfd1e350cbe1ca195d33306b5a9628667ddda8/lib/ansible/config/ansible_builtin_runtime.yml#L9548\n\nThe second option errors with:\n\n[WARNING]: * Failed to parse /home/alancoding/repos/awx/testing/openstack_fqcn/openstack.yml with auto plugin:\nInvalid value \"openstack.cloud.openstack\" for configuration option \"plugin_type: inventory plugin:\nansible_collections.openstack.cloud.plugins.inventory.openstack setting: plugin \", valid values are: [\u0027openstack\u0027]\n\nThis is due to Ansible core enforcing stricter validation of options. Merged in this PR ansible/ansible#73162\n\nThat broke many inventory plugins because the practice before the migration to collections was to list the name in the choices for the \"plugin\" option. This has been fixed in other collections.\n\nBecause neither of these options work, the inventory plugin is not usable in recent Ansible versions.\n\nSuggested patch here:\n\nhttps://github.com/AlanCoding/ansible-collections-openstack/compare/fqcn_name?expand\u003d1\n\nThis allows the user to use either syntax, because there\u0027s an argument for the validity of both.\n\ncredit to https://github.com/AlanCoding\n\nChange-Id: Ie1211796929d0bc12c7a48764bd8efc7defdd2d7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/f6abd4e89c06491e1feca3dea6f74f04dd23fe61"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/f6abd4e89c06491e1feca3dea6f74f04dd23fe61"}]},"branch":"refs/heads/master"},"42a5cb5601187dda6e460099889ac9d74cd628b0":{"kind":"REWORK","_number":2,"created":"2021-05-25 17:43:33.000000000","uploader":{"_account_id":33476,"name":"Per Lind","email":"per.lind@bonniernews.se","username":"per-lind"},"ref":"refs/changes/38/792138/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ansible-collections-openstack","ref":"refs/changes/38/792138/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/38/792138/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/38/792138/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/38/792138/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ansible-collections-openstack refs/changes/38/792138/2"}}},"commit":{"parents":[{"commit":"6b3bf3bba01055ca8e544ce258b44e4f5da3da34","subject":"Add support to setting image tags","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/6b3bf3bba01055ca8e544ce258b44e4f5da3da34"}]}],"author":{"name":"per-lind","email":"per.lind@bonniernews.se","date":"2021-05-19 13:00:24.000000000","tz":120},"committer":{"name":"per-lind","email":"per.lind@bonniernews.se","date":"2021-05-25 17:42:04.000000000","tz":120},"subject":"Fix inventory plugin on Ansible 2.11","message":"Fix inventory plugin on Ansible 2.11\n\nThe bug here is that the openstack inventory plugin will no longer work with Ansible 2.11. You can test an inventory file (named openstack.yml) with either of these syntaxes:\n\nplugin: openstack\nplugin: openstack.cloud.openstack\nThe first option errors due to custom validation present in openstack\u0027s own inventory plugin:\n\n[WARNING]: * Failed to parse /home/alancoding/repos/awx/testing/openstack/openstack.yml with auto plugin: plugin\nconfig file, but not for us: openstack\n\nBecause this was written back before FQCNs (fully-qualified collection names) were a thing. Before it migrated to a collection, \"openstack\" was the expectation, but then self.NAME for the inventory plugin changed to \"openstack.cloud.openstack\", meaning that \"openstack\" by itself would no longer work. That made sense until Ansible core introduced routing where it would recognize \"openstack\" and route it to \"openstack.cloud.openstack\" for purposes of the \"auto\" inventory plugin routing. See the routing entry at:\n\nhttps://github.com/ansible/ansible/blob/2cbfd1e350cbe1ca195d33306b5a9628667ddda8/lib/ansible/config/ansible_builtin_runtime.yml#L9548\n\nThe second option errors with:\n\n[WARNING]: * Failed to parse /home/alancoding/repos/awx/testing/openstack_fqcn/openstack.yml with auto plugin:\nInvalid value \"openstack.cloud.openstack\" for configuration option \"plugin_type: inventory plugin:\nansible_collections.openstack.cloud.plugins.inventory.openstack setting: plugin \", valid values are: [\u0027openstack\u0027]\n\nThis is due to Ansible core enforcing stricter validation of options. Merged in this PR ansible/ansible#73162\n\nThat broke many inventory plugins because the practice before the migration to collections was to list the name in the choices for the \"plugin\" option. This has been fixed in other collections.\n\nBecause neither of these options work, the inventory plugin is not usable in recent Ansible versions.\n\nSuggested patch here:\n\nhttps://github.com/AlanCoding/ansible-collections-openstack/compare/fqcn_name?expand\u003d1\n\nThis allows the user to use either syntax, because there\u0027s an argument for the validity of both.\n\ncredit to https://github.com/AlanCoding\n\nChange-Id: Ie1211796929d0bc12c7a48764bd8efc7defdd2d7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/42a5cb5601187dda6e460099889ac9d74cd628b0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ansible-collections-openstack/commit/42a5cb5601187dda6e460099889ac9d74cd628b0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}