)]}'
{".zuul.yaml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"addc69401083cb6191e46564367a45760713cd65","unresolved":true,"context_lines":[{"line_number":167,"context_line":"        override-checkout: stable-2.9"},{"line_number":168,"context_line":"    vars:"},{"line_number":169,"context_line":"      tox_envlist: ansible-2.9"},{"line_number":170,"context_line":"      tox_extra_args: network"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"- job:"},{"line_number":173,"context_line":"    name: ansible-collections-openstack-functional-devstack-ansible-2.9"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"ce1f18f7_d0815d19","line":170,"updated":"2022-04-20 10:39:08.000000000","message":"Please drop the tox_extra_args, zuul ran your tests once and they passed. once other modules have been fixed, your tests will run again. if we merge your current patch, then everyone has to add his tests to tox_extra_args for it to be executed.","commit_id":"35e06b3d89e24b3886fb651556345eb99d8ae68f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"c8769916aba25816c90bfe407f759ce6c9b2e1d6","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        override-checkout: stable-2.9"},{"line_number":168,"context_line":"    vars:"},{"line_number":169,"context_line":"      tox_envlist: ansible-2.9"},{"line_number":170,"context_line":"      tox_extra_args: network"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"- job:"},{"line_number":173,"context_line":"    name: ansible-collections-openstack-functional-devstack-ansible-2.9"}],"source_content_type":"text/x-yaml","patch_set":28,"id":"3dcca9a2_700ec844","line":170,"in_reply_to":"ce1f18f7_d0815d19","updated":"2022-04-20 17:35:17.000000000","message":"Done","commit_id":"35e06b3d89e24b3886fb651556345eb99d8ae68f"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"6697ece1b4e71eb49d4a25f9c707d1c2245979f4","unresolved":true,"context_lines":[{"line_number":71,"context_line":"        keystone_mapping"},{"line_number":72,"context_line":"        keystone_role"},{"line_number":73,"context_line":"        loadbalancer"},{"line_number":74,"context_line":"        network"},{"line_number":75,"context_line":"        nova_flavor"},{"line_number":76,"context_line":"        nova_services"},{"line_number":77,"context_line":"        object"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"23e619b1_e89d5dbe","line":74,"updated":"2022-05-02 10:12:33.000000000","message":"Zuul CI wont run this ci role because it is ignoring the updated tox_extra_args. What is going on here?","commit_id":"2949b65011ba24da0a68024013535c99102d5042"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        keystone_mapping"},{"line_number":72,"context_line":"        keystone_role"},{"line_number":73,"context_line":"        loadbalancer"},{"line_number":74,"context_line":"        network"},{"line_number":75,"context_line":"        nova_flavor"},{"line_number":76,"context_line":"        nova_services"},{"line_number":77,"context_line":"        object"}],"source_content_type":"text/x-yaml","patch_set":34,"id":"02ad042d_94881d63","line":74,"in_reply_to":"23e619b1_e89d5dbe","updated":"2022-05-04 10:36:06.000000000","message":"Unrelated to this patch, will be solved in a separate change.\n\nPlease drop all changes from .zuul.yaml except for uncommenting and moving the network tag.","commit_id":"2949b65011ba24da0a68024013535c99102d5042"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0098d7575166c37848427df44fe1c36c37bf4e7d","unresolved":true,"context_lines":[{"line_number":87,"context_line":"        keystone_mapping"},{"line_number":88,"context_line":"        loadbalancer"},{"line_number":89,"context_line":"        network"},{"line_number":90,"context_line":"        networks_info"},{"line_number":91,"context_line":"        nova_flavor"},{"line_number":92,"context_line":"        nova_services"},{"line_number":93,"context_line":"        object"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"5bada567_e6cf0c6a","line":90,"range":{"start_line":90,"start_character":16,"end_line":90,"end_character":18},"updated":"2022-06-02 10:20:28.000000000","message":"I don\u0027t think it should be a separate test.","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a149b949e51271a68d55641746dd47612fc96eae","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        keystone_mapping"},{"line_number":88,"context_line":"        loadbalancer"},{"line_number":89,"context_line":"        network"},{"line_number":90,"context_line":"        networks_info"},{"line_number":91,"context_line":"        nova_flavor"},{"line_number":92,"context_line":"        nova_services"},{"line_number":93,"context_line":"        object"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"0853d850_ff73de93","line":90,"range":{"start_line":90,"start_character":16,"end_line":90,"end_character":18},"in_reply_to":"5bada567_e6cf0c6a","updated":"2022-06-02 11:47:44.000000000","message":"Done","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"287039a8a55f8ab83f96adbd6b22cd7c3fa1f239","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c470d851_4c31b879","updated":"2022-01-31 08:06:58.000000000","message":"recheck","commit_id":"9374b05d4d1d147f2097d843565eddbefa63c154"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"73c308fe20024e3aba549545d8c5976e64c30367","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"dfe5d5d1_a83cd892","updated":"2022-04-20 10:23:50.000000000","message":"Thanks, Sagi 😊\n","commit_id":"35e06b3d89e24b3886fb651556345eb99d8ae68f"}],"ci/roles/network/tasks/main.yml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"73c308fe20024e3aba549545d8c5976e64c30367","unresolved":true,"context_lines":[{"line_number":29,"context_line":"  register: result"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Verify networks info - generic"},{"line_number":32,"context_line":"  assert:"},{"line_number":33,"context_line":"    that:"},{"line_number":34,"context_line":"      - result.openstack_networks.0.name \u003d\u003d network_name"},{"line_number":35,"context_line":"      - \"\u0027is_shared\u0027 in result.openstack_networks.0\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"7605544d_3e9011be","line":32,"updated":"2022-04-20 10:23:50.000000000","message":"Add return value check for networks_info module?","commit_id":"35e06b3d89e24b3886fb651556345eb99d8ae68f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"898d44687e0c12d51b62a31838da187c77f0578d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  register: result"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"- name: Verify networks info - generic"},{"line_number":32,"context_line":"  assert:"},{"line_number":33,"context_line":"    that:"},{"line_number":34,"context_line":"      - result.openstack_networks.0.name \u003d\u003d network_name"},{"line_number":35,"context_line":"      - \"\u0027is_shared\u0027 in result.openstack_networks.0\""}],"source_content_type":"text/x-yaml","patch_set":28,"id":"df913bfe_27d96121","line":32,"in_reply_to":"7605544d_3e9011be","updated":"2022-04-26 15:11:17.000000000","message":"Done","commit_id":"35e06b3d89e24b3886fb651556345eb99d8ae68f"}],"ci/roles/networks_info/tasks/main.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0098d7575166c37848427df44fe1c36c37bf4e7d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Create network"},{"line_number":3,"context_line":"  openstack.cloud.network:"},{"line_number":4,"context_line":"     cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":43,"id":"e6655944_57c0c3d6","line":1,"updated":"2022-06-02 10:20:28.000000000","message":"I don\u0027t think we need a separate role with tests, it should be tested together with networks module","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a149b949e51271a68d55641746dd47612fc96eae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Create network"},{"line_number":3,"context_line":"  openstack.cloud.network:"},{"line_number":4,"context_line":"     cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":43,"id":"69a1b662_a9e0ce35","line":1,"in_reply_to":"6d6e74d5_e39f7319","updated":"2022-06-02 11:47:44.000000000","message":"lets postpone the discussion and make sure these fixes land in master. I joined both ci roles into one role for now.","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"33357b10bd0c2219d22918d6615593717d921750","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: Create network"},{"line_number":3,"context_line":"  openstack.cloud.network:"},{"line_number":4,"context_line":"     cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":43,"id":"6d6e74d5_e39f7319","line":1,"in_reply_to":"e6655944_57c0c3d6","updated":"2022-06-02 10:38:29.000000000","message":"in the long run we want to get rid of tags and our current ci subfolder and replace it with ansible-test integration tests, dont we? ansible-test has a clean structure of one integration test per module","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"}],"ci/run-ansible-tests-collection.sh":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":128,"context_line":"    openstack --os-cloud\u003d${CLOUD} image set --tag amphora $OCTAVIA_AMP_IMAGE_NAME"},{"line_number":129,"context_line":"    # End of Octavia preparement"},{"line_number":130,"context_line":"else"},{"line_number":131,"context_line":"    tag_opt\u003d\"${tag_opt/loadbalancer,/} --skip-tags loadbalancer\""},{"line_number":132,"context_line":"fi"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Discover openstackSDK version"}],"source_content_type":"text/x-sh","patch_set":35,"id":"336814bf_69664906","line":131,"updated":"2022-05-04 10:36:06.000000000","message":"Not necessary, loadbalancer will be skipped even if it is part of the --tags list.","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"    openstack --os-cloud\u003d${CLOUD} image set --tag amphora $OCTAVIA_AMP_IMAGE_NAME"},{"line_number":129,"context_line":"    # End of Octavia preparement"},{"line_number":130,"context_line":"else"},{"line_number":131,"context_line":"    tag_opt\u003d\"${tag_opt/loadbalancer,/} --skip-tags loadbalancer\""},{"line_number":132,"context_line":"fi"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# Discover openstackSDK version"}],"source_content_type":"text/x-sh","patch_set":35,"id":"6fc08ecf_14ec197d","line":131,"in_reply_to":"336814bf_69664906","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"}],"ci/run-collection.yml":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0098d7575166c37848427df44fe1c36c37bf4e7d","unresolved":true,"context_lines":[{"line_number":37,"context_line":"      tags: keystone_federation_protocol"},{"line_number":38,"context_line":"      when: sdk_version is version(0.44, \u0027\u003e\u003d\u0027)"},{"line_number":39,"context_line":"    - { role: network, tags: network }"},{"line_number":40,"context_line":"    - { role: networks_info, tags: networks_info }"},{"line_number":41,"context_line":"    - role: neutron_rbac"},{"line_number":42,"context_line":"      tags:"},{"line_number":43,"context_line":"        - rbac"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"28cdb45e_56e8bdb5","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":50},"updated":"2022-06-02 10:20:28.000000000","message":"I don\u0027t think it should be a separate role","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a149b949e51271a68d55641746dd47612fc96eae","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      tags: keystone_federation_protocol"},{"line_number":38,"context_line":"      when: sdk_version is version(0.44, \u0027\u003e\u003d\u0027)"},{"line_number":39,"context_line":"    - { role: network, tags: network }"},{"line_number":40,"context_line":"    - { role: networks_info, tags: networks_info }"},{"line_number":41,"context_line":"    - role: neutron_rbac"},{"line_number":42,"context_line":"      tags:"},{"line_number":43,"context_line":"        - rbac"}],"source_content_type":"text/x-yaml","patch_set":43,"id":"8babe1f4_777e2e72","line":40,"range":{"start_line":40,"start_character":6,"end_line":40,"end_character":50},"in_reply_to":"28cdb45e_56e8bdb5","updated":"2022-06-02 11:47:44.000000000","message":"Done","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"}],"plugins/modules/network.py":[{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"86893dde2282d60159ac379953c0a6c00e3da154","unresolved":true,"context_lines":[{"line_number":216,"context_line":"                    provider[\u0027segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"                if project_id is not None:"},{"line_number":219,"context_line":"                    net \u003d self.conn.create_network(name, shared, admin_state_up,"},{"line_number":220,"context_line":"                                                   external, provider, project_id,"},{"line_number":221,"context_line":"                                                   **kwargs)"},{"line_number":222,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"f0917b0a_90fd5ea2","line":219,"updated":"2022-02-01 12:24:33.000000000","message":"Hey, a question:\nI see there are create_network methods both in cloud [1] and proxy [2]\nDon\u0027t we need to change the args to `**attrs` form so that we end up using the proxy method and not the cloud one?\n\n[1] https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/cloud/_network.py#L458\n[2] https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/network/v2/_proxy.py#L1724","commit_id":"c96f47c076c806d3680fb0a562f7d04913974308"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                    provider[\u0027segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"                if project_id is not None:"},{"line_number":219,"context_line":"                    net \u003d self.conn.create_network(name, shared, admin_state_up,"},{"line_number":220,"context_line":"                                                   external, provider, project_id,"},{"line_number":221,"context_line":"                                                   **kwargs)"},{"line_number":222,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9e074a92_d9ecc472","line":219,"in_reply_to":"4d20e0ee_6786f8da","updated":"2022-05-04 10:36:06.000000000","message":"Done","commit_id":"c96f47c076c806d3680fb0a562f7d04913974308"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"847fb208e147dff442ef276b777edd173df6d680","unresolved":true,"context_lines":[{"line_number":216,"context_line":"                    provider[\u0027segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"                if project_id is not None:"},{"line_number":219,"context_line":"                    net \u003d self.conn.create_network(name, shared, admin_state_up,"},{"line_number":220,"context_line":"                                                   external, provider, project_id,"},{"line_number":221,"context_line":"                                                   **kwargs)"},{"line_number":222,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"f300a13a_8d532004","line":219,"in_reply_to":"f0917b0a_90fd5ea2","updated":"2022-02-08 12:00:03.000000000","message":"I think we\u0027d better use **attrs, but still get named options from the module input.\nLike:\n  attrs \u003d {\"name\": name, ...}","commit_id":"c96f47c076c806d3680fb0a562f7d04913974308"},{"author":{"_account_id":27900,"name":"Artem Goncharov","email":"artem.goncharov@gmail.com","username":"gtema"},"change_message_id":"daaea58d9ab78d8dfb121559a3c551d2265f2841","unresolved":true,"context_lines":[{"line_number":216,"context_line":"                    provider[\u0027segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"                if project_id is not None:"},{"line_number":219,"context_line":"                    net \u003d self.conn.create_network(name, shared, admin_state_up,"},{"line_number":220,"context_line":"                                                   external, provider, project_id,"},{"line_number":221,"context_line":"                                                   **kwargs)"},{"line_number":222,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"4d20e0ee_6786f8da","line":219,"in_reply_to":"f0917b0a_90fd5ea2","updated":"2022-02-08 13:27:50.000000000","message":"yes, passing args like that is not going to work properly. What can be done, however, is: `self.conn.create_network(name\u003dname, is_shared\u003dshared, is_admin_state_up\u003dadmin_state_up, ...)`. But sure that passing single dict with attrs is going to be more flexible.","commit_id":"c96f47c076c806d3680fb0a562f7d04913974308"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"73c308fe20024e3aba549545d8c5976e64c30367","unresolved":true,"context_lines":[{"line_number":10,"context_line":"short_description: Creates/removes networks from OpenStack"},{"line_number":11,"context_line":"author: OpenStack Ansible SIG"},{"line_number":12,"context_line":"description:"},{"line_number":13,"context_line":"   - Add or remove network from OpenStack."},{"line_number":14,"context_line":"options:"},{"line_number":15,"context_line":"   name:"},{"line_number":16,"context_line":"     description:"}],"source_content_type":"text/x-python","patch_set":28,"id":"c2c2c825_3fb129bd","line":13,"updated":"2022-04-20 10:23:50.000000000","message":"Maybe add a hint that an existing network will not be updated by this module?","commit_id":"35e06b3d89e24b3886fb651556345eb99d8ae68f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"898d44687e0c12d51b62a31838da187c77f0578d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"short_description: Creates/removes networks from OpenStack"},{"line_number":11,"context_line":"author: OpenStack Ansible SIG"},{"line_number":12,"context_line":"description:"},{"line_number":13,"context_line":"   - Add or remove network from OpenStack."},{"line_number":14,"context_line":"options:"},{"line_number":15,"context_line":"   name:"},{"line_number":16,"context_line":"     description:"}],"source_content_type":"text/x-python","patch_set":28,"id":"5b9e5524_ee88fac4","line":13,"in_reply_to":"c2c2c825_3fb129bd","updated":"2022-04-26 15:11:17.000000000","message":"Done","commit_id":"35e06b3d89e24b3886fb651556345eb99d8ae68f"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"addc69401083cb6191e46564367a45760713cd65","unresolved":true,"context_lines":[{"line_number":141,"context_line":"        is_vlan_transparent:"},{"line_number":142,"context_line":"            description: Is vlan transparent"},{"line_number":143,"context_line":"            type: str"},{"line_number":144,"context_line":"        location:"},{"line_number":145,"context_line":"            description: Location"},{"line_number":146,"context_line":"            type: str"},{"line_number":147,"context_line":"        mtu:"}],"source_content_type":"text/x-python","patch_set":28,"id":"8123d277_e2d9212f","line":144,"updated":"2022-04-20 10:39:08.000000000","message":"this is dropped with computed\u003dFalse","commit_id":"35e06b3d89e24b3886fb651556345eb99d8ae68f"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"898d44687e0c12d51b62a31838da187c77f0578d","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        is_vlan_transparent:"},{"line_number":142,"context_line":"            description: Is vlan transparent"},{"line_number":143,"context_line":"            type: str"},{"line_number":144,"context_line":"        location:"},{"line_number":145,"context_line":"            description: Location"},{"line_number":146,"context_line":"            type: str"},{"line_number":147,"context_line":"        mtu:"}],"source_content_type":"text/x-python","patch_set":28,"id":"89acb0af_92cbde3b","line":144,"in_reply_to":"8123d277_e2d9212f","updated":"2022-04-26 15:11:17.000000000","message":"Done","commit_id":"35e06b3d89e24b3886fb651556345eb99d8ae68f"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":10,"context_line":"short_description: Creates/removes networks from OpenStack"},{"line_number":11,"context_line":"author: OpenStack Ansible SIG"},{"line_number":12,"context_line":"description:"},{"line_number":13,"context_line":"   - Add or remove network from OpenStack (doesn\u0027t update network properties)."},{"line_number":14,"context_line":"options:"},{"line_number":15,"context_line":"   name:"},{"line_number":16,"context_line":"     description:"}],"source_content_type":"text/x-python","patch_set":35,"id":"31ab998e_f6cc22b7","line":13,"updated":"2022-05-04 10:36:06.000000000","message":"Hehe, thanks for the warning ;)","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"short_description: Creates/removes networks from OpenStack"},{"line_number":11,"context_line":"author: OpenStack Ansible SIG"},{"line_number":12,"context_line":"description:"},{"line_number":13,"context_line":"   - Add or remove network from OpenStack (doesn\u0027t update network properties)."},{"line_number":14,"context_line":"options:"},{"line_number":15,"context_line":"   name:"},{"line_number":16,"context_line":"     description:"}],"source_content_type":"text/x-python","patch_set":35,"id":"cfeaed04_a195da74","line":13,"in_reply_to":"31ab998e_f6cc22b7","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        - Name to be assigned to the network."},{"line_number":18,"context_line":"     required: true"},{"line_number":19,"context_line":"     type: str"},{"line_number":20,"context_line":"   shared:"},{"line_number":21,"context_line":"     description:"},{"line_number":22,"context_line":"        - Whether this network is shared or not."},{"line_number":23,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":35,"id":"f1d13a9b_3821e787","line":20,"updated":"2022-05-04 10:36:06.000000000","message":"Rename to is_shared and add shared as an alias, to match sdk?","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c6c5c1fec9a039e1c8a67296001b746aae821776","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        - Name to be assigned to the network."},{"line_number":18,"context_line":"     required: true"},{"line_number":19,"context_line":"     type: str"},{"line_number":20,"context_line":"   shared:"},{"line_number":21,"context_line":"     description:"},{"line_number":22,"context_line":"        - Whether this network is shared or not."},{"line_number":23,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":35,"id":"2a0a0015_743e8b7a","line":20,"in_reply_to":"88a79e2d_d0ab51b5","updated":"2022-05-24 14:28:47.000000000","message":"Added a todo about changing module parameters to sdk names. Lets leave them for now, we have enough to do for now than worrying about module names.","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        - Name to be assigned to the network."},{"line_number":18,"context_line":"     required: true"},{"line_number":19,"context_line":"     type: str"},{"line_number":20,"context_line":"   shared:"},{"line_number":21,"context_line":"     description:"},{"line_number":22,"context_line":"        - Whether this network is shared or not."},{"line_number":23,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":35,"id":"88a79e2d_d0ab51b5","line":20,"in_reply_to":"f1d13a9b_3821e787","updated":"2022-05-13 09:41:44.000000000","message":"I\u0027d rather to leave it as is.","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        - Whether this network is shared or not."},{"line_number":23,"context_line":"     type: bool"},{"line_number":24,"context_line":"     default: \u0027no\u0027"},{"line_number":25,"context_line":"   admin_state_up:"},{"line_number":26,"context_line":"     description:"},{"line_number":27,"context_line":"        - Whether the state should be marked as up or down."},{"line_number":28,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":35,"id":"b5b9c50d_6278fd2b","line":25,"updated":"2022-05-04 10:36:06.000000000","message":"Rename to is_admin_state_up and add admin_state_up as an alias, to match sdk?","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c6c5c1fec9a039e1c8a67296001b746aae821776","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        - Whether this network is shared or not."},{"line_number":23,"context_line":"     type: bool"},{"line_number":24,"context_line":"     default: \u0027no\u0027"},{"line_number":25,"context_line":"   admin_state_up:"},{"line_number":26,"context_line":"     description:"},{"line_number":27,"context_line":"        - Whether the state should be marked as up or down."},{"line_number":28,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":35,"id":"4791fec3_9a8e03ca","line":25,"in_reply_to":"13f744b7_6f0e8295","updated":"2022-05-24 14:28:47.000000000","message":"ditto","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        - Whether this network is shared or not."},{"line_number":23,"context_line":"     type: bool"},{"line_number":24,"context_line":"     default: \u0027no\u0027"},{"line_number":25,"context_line":"   admin_state_up:"},{"line_number":26,"context_line":"     description:"},{"line_number":27,"context_line":"        - Whether the state should be marked as up or down."},{"line_number":28,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":35,"id":"13f744b7_6f0e8295","line":25,"in_reply_to":"b5b9c50d_6278fd2b","updated":"2022-05-13 09:41:44.000000000","message":"ditto","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        - Whether the state should be marked as up or down."},{"line_number":28,"context_line":"     type: bool"},{"line_number":29,"context_line":"     default: \u0027yes\u0027"},{"line_number":30,"context_line":"   external:"},{"line_number":31,"context_line":"     description:"},{"line_number":32,"context_line":"        - Whether this network is externally accessible."},{"line_number":33,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":35,"id":"286f571b_95099b5d","line":30,"updated":"2022-05-04 10:36:06.000000000","message":"Rename to is_router_external and add external as an alias, to match sdk?","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":true,"context_lines":[{"line_number":27,"context_line":"        - Whether the state should be marked as up or down."},{"line_number":28,"context_line":"     type: bool"},{"line_number":29,"context_line":"     default: \u0027yes\u0027"},{"line_number":30,"context_line":"   external:"},{"line_number":31,"context_line":"     description:"},{"line_number":32,"context_line":"        - Whether this network is externally accessible."},{"line_number":33,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":35,"id":"47554cb8_d041370b","line":30,"in_reply_to":"286f571b_95099b5d","updated":"2022-05-13 09:41:44.000000000","message":"ditto","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c6c5c1fec9a039e1c8a67296001b746aae821776","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        - Whether the state should be marked as up or down."},{"line_number":28,"context_line":"     type: bool"},{"line_number":29,"context_line":"     default: \u0027yes\u0027"},{"line_number":30,"context_line":"   external:"},{"line_number":31,"context_line":"     description:"},{"line_number":32,"context_line":"        - Whether this network is externally accessible."},{"line_number":33,"context_line":"     type: bool"}],"source_content_type":"text/x-python","patch_set":35,"id":"9934baa8_d5c988be","line":30,"in_reply_to":"47554cb8_d041370b","updated":"2022-05-24 14:28:47.000000000","message":"ditto","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":57,"context_line":"     description:"},{"line_number":58,"context_line":"        - Project name or ID containing the network (name admin-only)"},{"line_number":59,"context_line":"     type: str"},{"line_number":60,"context_line":"   port_security_enabled:"},{"line_number":61,"context_line":"     description:"},{"line_number":62,"context_line":"        -  Whether port security is enabled on the network or not."},{"line_number":63,"context_line":"           Network will use OpenStack defaults if this option is"}],"source_content_type":"text/x-python","patch_set":35,"id":"e78d02a9_63ab8c2c","line":60,"updated":"2022-05-04 10:36:06.000000000","message":"Rename to is_port_security_enabled and add port_security_enabled as an alias, to match sdk?","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c6c5c1fec9a039e1c8a67296001b746aae821776","unresolved":false,"context_lines":[{"line_number":57,"context_line":"     description:"},{"line_number":58,"context_line":"        - Project name or ID containing the network (name admin-only)"},{"line_number":59,"context_line":"     type: str"},{"line_number":60,"context_line":"   port_security_enabled:"},{"line_number":61,"context_line":"     description:"},{"line_number":62,"context_line":"        -  Whether port security is enabled on the network or not."},{"line_number":63,"context_line":"           Network will use OpenStack defaults if this option is"}],"source_content_type":"text/x-python","patch_set":35,"id":"ea0d4cc6_81d864c3","line":60,"in_reply_to":"a7258466_3682ae8e","updated":"2022-05-24 14:28:47.000000000","message":"ditto","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":true,"context_lines":[{"line_number":57,"context_line":"     description:"},{"line_number":58,"context_line":"        - Project name or ID containing the network (name admin-only)"},{"line_number":59,"context_line":"     type: str"},{"line_number":60,"context_line":"   port_security_enabled:"},{"line_number":61,"context_line":"     description:"},{"line_number":62,"context_line":"        -  Whether port security is enabled on the network or not."},{"line_number":63,"context_line":"           Network will use OpenStack defaults if this option is"}],"source_content_type":"text/x-python","patch_set":35,"id":"a7258466_3682ae8e","line":60,"in_reply_to":"e78d02a9_63ab8c2c","updated":"2022-05-13 09:41:44.000000000","message":"ditto","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":61,"context_line":"     description:"},{"line_number":62,"context_line":"        -  Whether port security is enabled on the network or not."},{"line_number":63,"context_line":"           Network will use OpenStack defaults if this option is"},{"line_number":64,"context_line":"           not utilised. Requires openstacksdk\u003e\u003d0.18."},{"line_number":65,"context_line":"     type: bool"},{"line_number":66,"context_line":"   mtu:"},{"line_number":67,"context_line":"     description:"}],"source_content_type":"text/x-python","patch_set":35,"id":"e8d9548e_3f47a78d","line":64,"updated":"2022-05-04 10:36:06.000000000","message":"Drop \"Requires openstacksdk\u003e\u003d0.18.\".","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"     description:"},{"line_number":62,"context_line":"        -  Whether port security is enabled on the network or not."},{"line_number":63,"context_line":"           Network will use OpenStack defaults if this option is"},{"line_number":64,"context_line":"           not utilised. Requires openstacksdk\u003e\u003d0.18."},{"line_number":65,"context_line":"     type: bool"},{"line_number":66,"context_line":"   mtu:"},{"line_number":67,"context_line":"     description:"}],"source_content_type":"text/x-python","patch_set":35,"id":"d7e2a38f_b9aa7f33","line":64,"in_reply_to":"e8d9548e_3f47a78d","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":67,"context_line":"     description:"},{"line_number":68,"context_line":"       -  The maximum transmission unit (MTU) value to address fragmentation."},{"line_number":69,"context_line":"          Network will use OpenStack defaults if this option is"},{"line_number":70,"context_line":"          not provided. Requires openstacksdk\u003e\u003d0.18."},{"line_number":71,"context_line":"     type: int"},{"line_number":72,"context_line":"     aliases: [\u0027mtu_size\u0027]"},{"line_number":73,"context_line":"   dns_domain:"}],"source_content_type":"text/x-python","patch_set":35,"id":"aeb1cd44_2addf55a","line":70,"updated":"2022-05-04 10:36:06.000000000","message":"Drop \"Requires openstacksdk\u003e\u003d0.18.\".","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"     description:"},{"line_number":68,"context_line":"       -  The maximum transmission unit (MTU) value to address fragmentation."},{"line_number":69,"context_line":"          Network will use OpenStack defaults if this option is"},{"line_number":70,"context_line":"          not provided. Requires openstacksdk\u003e\u003d0.18."},{"line_number":71,"context_line":"     type: int"},{"line_number":72,"context_line":"     aliases: [\u0027mtu_size\u0027]"},{"line_number":73,"context_line":"   dns_domain:"}],"source_content_type":"text/x-python","patch_set":35,"id":"59ce7cc4_ad46af45","line":70,"in_reply_to":"aeb1cd44_2addf55a","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":72,"context_line":"     aliases: [\u0027mtu_size\u0027]"},{"line_number":73,"context_line":"   dns_domain:"},{"line_number":74,"context_line":"     description:"},{"line_number":75,"context_line":"       -  The DNS domain value to set. Requires openstacksdk\u003e\u003d0.29."},{"line_number":76,"context_line":"          Network will use Openstack defaults if this option is"},{"line_number":77,"context_line":"          not provided."},{"line_number":78,"context_line":"     type: str"}],"source_content_type":"text/x-python","patch_set":35,"id":"d9f822fb_cf4f0697","line":75,"updated":"2022-05-04 10:36:06.000000000","message":"Drop \"Requires openstacksdk\u003e\u003d0.29.\".","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"     aliases: [\u0027mtu_size\u0027]"},{"line_number":73,"context_line":"   dns_domain:"},{"line_number":74,"context_line":"     description:"},{"line_number":75,"context_line":"       -  The DNS domain value to set. Requires openstacksdk\u003e\u003d0.29."},{"line_number":76,"context_line":"          Network will use Openstack defaults if this option is"},{"line_number":77,"context_line":"          not provided."},{"line_number":78,"context_line":"     type: str"}],"source_content_type":"text/x-python","patch_set":35,"id":"ca201e61_cfdaaae3","line":75,"in_reply_to":"d9f822fb_cf4f0697","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":97,"context_line":"network:"},{"line_number":98,"context_line":"    description: Dictionary describing the network."},{"line_number":99,"context_line":"    returned: On success when I(state) is \u0027present\u0027."},{"line_number":100,"context_line":"    type: complex"},{"line_number":101,"context_line":"    contains:"},{"line_number":102,"context_line":"        availability_zone_hints:"},{"line_number":103,"context_line":"            description: Availability zone hints"}],"source_content_type":"text/x-python","patch_set":35,"id":"cb407f8b_c9705981","line":100,"updated":"2022-05-04 10:36:06.000000000","message":"type: dict","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"network:"},{"line_number":98,"context_line":"    description: Dictionary describing the network."},{"line_number":99,"context_line":"    returned: On success when I(state) is \u0027present\u0027."},{"line_number":100,"context_line":"    type: complex"},{"line_number":101,"context_line":"    contains:"},{"line_number":102,"context_line":"        availability_zone_hints:"},{"line_number":103,"context_line":"            description: Availability zone hints"}],"source_content_type":"text/x-python","patch_set":35,"id":"9ec9add3_4bf6d0fc","line":100,"in_reply_to":"cb407f8b_c9705981","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":214,"context_line":"        provider_segmentation_id \u003d self.params[\u0027provider_segmentation_id\u0027]"},{"line_number":215,"context_line":"        project \u003d self.params[\u0027project\u0027]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        kwargs \u003d {}"},{"line_number":218,"context_line":"        for arg in (\u0027port_security_enabled\u0027, \u0027mtu\u0027, \u0027dns_domain\u0027):"},{"line_number":219,"context_line":"            if self.params[arg] is not None:"},{"line_number":220,"context_line":"                kwargs[arg] \u003d self.params[arg]"}],"source_content_type":"text/x-python","patch_set":35,"id":"3fccab96_47a96274","line":217,"updated":"2022-05-04 10:36:06.000000000","message":"I ❤ Python:\n\n  kwargs \u003d {(k, self.params[k]) for k in (\u0027port_security_enabled\u0027, \u0027mtu\u0027, \u0027dns_domain\u0027) if self.params[k] is not None}\n\nJust kidding 😋","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        provider_segmentation_id \u003d self.params[\u0027provider_segmentation_id\u0027]"},{"line_number":215,"context_line":"        project \u003d self.params[\u0027project\u0027]"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        kwargs \u003d {}"},{"line_number":218,"context_line":"        for arg in (\u0027port_security_enabled\u0027, \u0027mtu\u0027, \u0027dns_domain\u0027):"},{"line_number":219,"context_line":"            if self.params[arg] is not None:"},{"line_number":220,"context_line":"                kwargs[arg] \u003d self.params[arg]"}],"source_content_type":"text/x-python","patch_set":35,"id":"b76c713f_a01870b6","line":217,"in_reply_to":"3fccab96_47a96274","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":220,"context_line":"                kwargs[arg] \u003d self.params[arg]"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if project is not None:"},{"line_number":223,"context_line":"            proj \u003d self.conn.get_project(project)"},{"line_number":224,"context_line":"            if proj is None:"},{"line_number":225,"context_line":"                self.fail_json(msg\u003d\u0027Project %s could not be found\u0027 % project)"},{"line_number":226,"context_line":"            project_id \u003d proj[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":35,"id":"1508168b_359a61bd","line":223,"updated":"2022-05-04 10:36:06.000000000","message":"self.conn.identity.find_project?","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":220,"context_line":"                kwargs[arg] \u003d self.params[arg]"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"        if project is not None:"},{"line_number":223,"context_line":"            proj \u003d self.conn.get_project(project)"},{"line_number":224,"context_line":"            if proj is None:"},{"line_number":225,"context_line":"                self.fail_json(msg\u003d\u0027Project %s could not be found\u0027 % project)"},{"line_number":226,"context_line":"            project_id \u003d proj[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":35,"id":"4790c814_011e9aa9","line":223,"in_reply_to":"1508168b_359a61bd","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            project_id \u003d None"},{"line_number":230,"context_line":"            filters \u003d None"},{"line_number":231,"context_line":"        net \u003d self.conn.get_network(name, filters\u003dfilters)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":234,"context_line":"            if not net:"}],"source_content_type":"text/x-python","patch_set":35,"id":"b8b8e1dd_bfccf020","line":231,"updated":"2022-05-04 10:36:06.000000000","message":"Better rename filters to args (to illustrate that this is a query arg, not a filter) and use\n\n  self.conn.network.find_network(name_or_id\u003dname, **args)","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"8369b71acfe68df1cb2d29306d54a8d23f91e307","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            project_id \u003d None"},{"line_number":230,"context_line":"            filters \u003d None"},{"line_number":231,"context_line":"        net \u003d self.conn.get_network(name, filters\u003dfilters)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":234,"context_line":"            if not net:"}],"source_content_type":"text/x-python","patch_set":35,"id":"bb97234a_f13a8c08","line":231,"in_reply_to":"1df67879_d911bf17","updated":"2022-05-14 14:16:04.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":true,"context_lines":[{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            project_id \u003d None"},{"line_number":230,"context_line":"            filters \u003d None"},{"line_number":231,"context_line":"        net \u003d self.conn.get_network(name, filters\u003dfilters)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":234,"context_line":"            if not net:"}],"source_content_type":"text/x-python","patch_set":35,"id":"1df67879_d911bf17","line":231,"in_reply_to":"b8b8e1dd_bfccf020","updated":"2022-05-13 09:41:44.000000000","message":"renamed to net_kwargs, coz it\u0027s a dictionary","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":233,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":234,"context_line":"            if not net:"},{"line_number":235,"context_line":"                if provider_physical_network:"},{"line_number":236,"context_line":"                    kwargs[\u0027physical_network\u0027] \u003d provider_physical_network"},{"line_number":237,"context_line":"                if provider_network_type:"},{"line_number":238,"context_line":"                    kwargs[\u0027network_type\u0027] \u003d provider_network_type"},{"line_number":239,"context_line":"                if provider_segmentation_id:"}],"source_content_type":"text/x-python","patch_set":35,"id":"5dd9621e_73b8e68d","line":236,"updated":"2022-05-04 10:36:06.000000000","message":"Why not\n  kwargs[\u0027provider_physical_network\u0027] \u003d provider_physical_network","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":233,"context_line":"        if state \u003d\u003d \u0027present\u0027:"},{"line_number":234,"context_line":"            if not net:"},{"line_number":235,"context_line":"                if provider_physical_network:"},{"line_number":236,"context_line":"                    kwargs[\u0027physical_network\u0027] \u003d provider_physical_network"},{"line_number":237,"context_line":"                if provider_network_type:"},{"line_number":238,"context_line":"                    kwargs[\u0027network_type\u0027] \u003d provider_network_type"},{"line_number":239,"context_line":"                if provider_segmentation_id:"}],"source_content_type":"text/x-python","patch_set":35,"id":"513e6ffe_81f8b97c","line":236,"in_reply_to":"5dd9621e_73b8e68d","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":235,"context_line":"                if provider_physical_network:"},{"line_number":236,"context_line":"                    kwargs[\u0027physical_network\u0027] \u003d provider_physical_network"},{"line_number":237,"context_line":"                if provider_network_type:"},{"line_number":238,"context_line":"                    kwargs[\u0027network_type\u0027] \u003d provider_network_type"},{"line_number":239,"context_line":"                if provider_segmentation_id:"},{"line_number":240,"context_line":"                    kwargs[\u0027segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"57e7910e_4592dc90","line":238,"updated":"2022-05-04 10:36:06.000000000","message":"Why not\n  kwargs[\u0027provider_network_type\u0027] \u003d provider_network_type","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":235,"context_line":"                if provider_physical_network:"},{"line_number":236,"context_line":"                    kwargs[\u0027physical_network\u0027] \u003d provider_physical_network"},{"line_number":237,"context_line":"                if provider_network_type:"},{"line_number":238,"context_line":"                    kwargs[\u0027network_type\u0027] \u003d provider_network_type"},{"line_number":239,"context_line":"                if provider_segmentation_id:"},{"line_number":240,"context_line":"                    kwargs[\u0027segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":241,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"c2164322_91d22b9d","line":238,"in_reply_to":"57e7910e_4592dc90","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":237,"context_line":"                if provider_network_type:"},{"line_number":238,"context_line":"                    kwargs[\u0027network_type\u0027] \u003d provider_network_type"},{"line_number":239,"context_line":"                if provider_segmentation_id:"},{"line_number":240,"context_line":"                    kwargs[\u0027segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"                if project_id is not None:"},{"line_number":243,"context_line":"                    net \u003d self.conn.network.create_network(name\u003dname,"}],"source_content_type":"text/x-python","patch_set":35,"id":"d9feefb8_2567e697","line":240,"updated":"2022-05-04 10:36:06.000000000","message":"Why not\n  kwargs[\u0027provider_segmentation_id\u0027] \u003d provider_segmentation_id","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                if provider_network_type:"},{"line_number":238,"context_line":"                    kwargs[\u0027network_type\u0027] \u003d provider_network_type"},{"line_number":239,"context_line":"                if provider_segmentation_id:"},{"line_number":240,"context_line":"                    kwargs[\u0027segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"                if project_id is not None:"},{"line_number":243,"context_line":"                    net \u003d self.conn.network.create_network(name\u003dname,"}],"source_content_type":"text/x-python","patch_set":35,"id":"a56fc22c_550b2dcb","line":240,"in_reply_to":"d9feefb8_2567e697","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":239,"context_line":"                if provider_segmentation_id:"},{"line_number":240,"context_line":"                    kwargs[\u0027segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"                if project_id is not None:"},{"line_number":243,"context_line":"                    net \u003d self.conn.network.create_network(name\u003dname,"},{"line_number":244,"context_line":"                                                           shared\u003dshared,"},{"line_number":245,"context_line":"                                                           admin_state_up\u003dadmin_state_up,"}],"source_content_type":"text/x-python","patch_set":35,"id":"204ffc71_2e87db2b","line":242,"updated":"2022-05-04 10:36:06.000000000","message":"We could save code with:\n  if project_id:\n    kwargs[\u0027project_id\u0027] \u003d project_id\n  net \u003d self.conn.network.create_network(name\u003dname, ..., **kwargs)","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":239,"context_line":"                if provider_segmentation_id:"},{"line_number":240,"context_line":"                    kwargs[\u0027segmentation_id\u0027] \u003d provider_segmentation_id"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"                if project_id is not None:"},{"line_number":243,"context_line":"                    net \u003d self.conn.network.create_network(name\u003dname,"},{"line_number":244,"context_line":"                                                           shared\u003dshared,"},{"line_number":245,"context_line":"                                                           admin_state_up\u003dadmin_state_up,"}],"source_content_type":"text/x-python","patch_set":35,"id":"2d3562d9_ef40b453","line":242,"in_reply_to":"204ffc71_2e87db2b","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                net \u003d net.to_dict(computed\u003dFalse)"},{"line_number":257,"context_line":"            else:"},{"line_number":258,"context_line":"                changed \u003d False"},{"line_number":259,"context_line":"            self.exit(changed\u003dchanged, network\u003dnet, id\u003dnet[\u0027id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        elif state \u003d\u003d \u0027absent\u0027:"},{"line_number":262,"context_line":"            if not net:"}],"source_content_type":"text/x-python","patch_set":35,"id":"90594ce9_37a7d420","line":259,"updated":"2022-05-04 10:36:06.000000000","message":"Please document \u0027id\u0027 value in RETURN variable above.","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"ca6bb14c2382c3b07dbb5130966882a8f7cc9ea4","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                net \u003d net.to_dict(computed\u003dFalse)"},{"line_number":257,"context_line":"            else:"},{"line_number":258,"context_line":"                changed \u003d False"},{"line_number":259,"context_line":"            self.exit(changed\u003dchanged, network\u003dnet, id\u003dnet[\u0027id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        elif state \u003d\u003d \u0027absent\u0027:"},{"line_number":262,"context_line":"            if not net:"}],"source_content_type":"text/x-python","patch_set":35,"id":"45450356_51786d06","line":259,"in_reply_to":"19aaca25_88d23402","updated":"2022-05-14 08:53:15.000000000","message":"OK, seems I figured this out.","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                net \u003d net.to_dict(computed\u003dFalse)"},{"line_number":257,"context_line":"            else:"},{"line_number":258,"context_line":"                changed \u003d False"},{"line_number":259,"context_line":"            self.exit(changed\u003dchanged, network\u003dnet, id\u003dnet[\u0027id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        elif state \u003d\u003d \u0027absent\u0027:"},{"line_number":262,"context_line":"            if not net:"}],"source_content_type":"text/x-python","patch_set":35,"id":"c5d50454_4decc418","line":259,"in_reply_to":"90594ce9_37a7d420","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0832b38e949d407930e8e540672ba02a134bdd9c","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                net \u003d net.to_dict(computed\u003dFalse)"},{"line_number":257,"context_line":"            else:"},{"line_number":258,"context_line":"                changed \u003d False"},{"line_number":259,"context_line":"            self.exit(changed\u003dchanged, network\u003dnet, id\u003dnet[\u0027id\u0027])"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        elif state \u003d\u003d \u0027absent\u0027:"},{"line_number":262,"context_line":"            if not net:"}],"source_content_type":"text/x-python","patch_set":35,"id":"19aaca25_88d23402","line":259,"in_reply_to":"c5d50454_4decc418","updated":"2022-05-13 11:12:53.000000000","message":"Seems like it\u0027s impossible to add it, ansible-test complains.","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0098d7575166c37848427df44fe1c36c37bf4e7d","unresolved":true,"context_lines":[{"line_number":224,"context_line":"                kwargs[arg] \u003d self.params[arg]"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        if project is not None:"},{"line_number":227,"context_line":"            proj \u003d self.conn.identity.find_project(project, ignore_missing\u003dFalse)"},{"line_number":228,"context_line":"            project_id \u003d proj[\u0027id\u0027]"},{"line_number":229,"context_line":"            net_kwargs \u003d {\u0027project_id\u0027: project_id}"},{"line_number":230,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":43,"id":"d1da8355_303cc48e","line":227,"range":{"start_line":227,"start_character":60,"end_line":227,"end_character":80},"updated":"2022-06-02 10:20:28.000000000","message":"Nice, TIL","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"20b51700ba0ef4edae9b9a6db88fd6ff2a4dc171","unresolved":false,"context_lines":[{"line_number":224,"context_line":"                kwargs[arg] \u003d self.params[arg]"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"        if project is not None:"},{"line_number":227,"context_line":"            proj \u003d self.conn.identity.find_project(project, ignore_missing\u003dFalse)"},{"line_number":228,"context_line":"            project_id \u003d proj[\u0027id\u0027]"},{"line_number":229,"context_line":"            net_kwargs \u003d {\u0027project_id\u0027: project_id}"},{"line_number":230,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":43,"id":"faed1535_22602631","line":227,"range":{"start_line":227,"start_character":60,"end_line":227,"end_character":80},"in_reply_to":"d1da8355_303cc48e","updated":"2022-06-02 10:37:45.000000000","message":"Done","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"}],"plugins/modules/networks_info.py":[{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"a0f259c371adbcb13f0d7cc7e4c36694b169b96e","unresolved":true,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def run(self):"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        kwargs \u003d self.check_versioned("},{"line_number":134,"context_line":"            filters\u003dself.params[\u0027filters\u0027]"},{"line_number":135,"context_line":"        )"},{"line_number":136,"context_line":"        if self.params[\u0027name\u0027]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"dbf5dfd5_070fc81e","side":"PARENT","line":133,"updated":"2022-02-01 13:16:52.000000000","message":"Why are we removing check_versioned?","commit_id":"6ed02eff2dfd43ffa4171084ed44c38bbf2387d1"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a22935ae92d70977042db92c92acafa5609edb1b","unresolved":true,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def run(self):"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        kwargs \u003d self.check_versioned("},{"line_number":134,"context_line":"            filters\u003dself.params[\u0027filters\u0027]"},{"line_number":135,"context_line":"        )"},{"line_number":136,"context_line":"        if self.params[\u0027name\u0027]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"dfd58ea2_39fb284d","side":"PARENT","line":133,"in_reply_to":"dbf5dfd5_070fc81e","updated":"2022-02-08 06:24:34.000000000","message":"check_versioned is supposed to check versions limitations of module options, and in module we have \"name\" and \"filters\" only, so it doesn\u0027t make sense to run it here.","commit_id":"6ed02eff2dfd43ffa4171084ed44c38bbf2387d1"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"d293c9331ef8a505c42c1ce8e885566b467c4715","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def run(self):"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        kwargs \u003d self.check_versioned("},{"line_number":134,"context_line":"            filters\u003dself.params[\u0027filters\u0027]"},{"line_number":135,"context_line":"        )"},{"line_number":136,"context_line":"        if self.params[\u0027name\u0027]:"}],"source_content_type":"text/x-python","patch_set":10,"id":"674e3e32_1a227411","side":"PARENT","line":133,"in_reply_to":"dfd58ea2_39fb284d","updated":"2022-04-27 13:22:16.000000000","message":"Done","commit_id":"6ed02eff2dfd43ffa4171084ed44c38bbf2387d1"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":84,"context_line":"networks:"},{"line_number":85,"context_line":"    description: has all the openstack information about the networks"},{"line_number":86,"context_line":"    returned: always, but can be null"},{"line_number":87,"context_line":"    type: complex"},{"line_number":88,"context_line":"    contains:"},{"line_number":89,"context_line":"        availability_zone_hints:"},{"line_number":90,"context_line":"            description: Availability zone hints"}],"source_content_type":"text/x-python","patch_set":35,"id":"1b0d31ea_7dee92f7","line":87,"updated":"2022-05-04 10:36:06.000000000","message":"type: list\nelements: dict","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"networks:"},{"line_number":85,"context_line":"    description: has all the openstack information about the networks"},{"line_number":86,"context_line":"    returned: always, but can be null"},{"line_number":87,"context_line":"    type: complex"},{"line_number":88,"context_line":"    contains:"},{"line_number":89,"context_line":"        availability_zone_hints:"},{"line_number":90,"context_line":"            description: Availability zone hints"}],"source_content_type":"text/x-python","patch_set":35,"id":"6d2dac7e_c68d82e4","line":87,"in_reply_to":"1b0d31ea_7dee92f7","updated":"2022-05-13 09:41:44.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"ee9f280b03937491679f02b578ef84e399bece2b","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        kwargs \u003d self.params[\u0027filters\u0027] or {}"},{"line_number":190,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":191,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":192,"context_line":"        networks \u003d self.conn.network.networks(**kwargs)"},{"line_number":193,"context_line":"        networks \u003d [i.to_dict(computed\u003dFalse) for i in networks]"},{"line_number":194,"context_line":"        self.exit(changed\u003dFalse, networks\u003dnetworks)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"7fc78f59_cb2ae729","line":192,"updated":"2022-05-04 10:36:06.000000000","message":"Please change back to cloud layer because proxy layer does not support filters.","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"44accd3fc162a08b352af1e860e76f4f672a8fd6","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        kwargs \u003d self.params[\u0027filters\u0027] or {}"},{"line_number":190,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":191,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":192,"context_line":"        networks \u003d self.conn.network.networks(**kwargs)"},{"line_number":193,"context_line":"        networks \u003d [i.to_dict(computed\u003dFalse) for i in networks]"},{"line_number":194,"context_line":"        self.exit(changed\u003dFalse, networks\u003dnetworks)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"bd2065c8_1d9d9c5e","line":192,"in_reply_to":"2f762a05_775e2553","updated":"2022-06-01 07:02:35.000000000","message":"Done","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c6c5c1fec9a039e1c8a67296001b746aae821776","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        kwargs \u003d self.params[\u0027filters\u0027] or {}"},{"line_number":190,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":191,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":192,"context_line":"        networks \u003d self.conn.network.networks(**kwargs)"},{"line_number":193,"context_line":"        networks \u003d [i.to_dict(computed\u003dFalse) for i in networks]"},{"line_number":194,"context_line":"        self.exit(changed\u003dFalse, networks\u003dnetworks)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"97ef1d2a_e14a5a77","line":192,"in_reply_to":"3f83de27_efc5c4f8","updated":"2022-05-24 14:28:47.000000000","message":"Another inconsistency in the SDK. When cloud layer network functions were ported to proxy objects, the (post) filtering functionality was dropped. Nowadays \"filters\" is really nothing more than \"query\" in openstack/cloud/_network.py[1]. This is only for network cloud functions though, for identity cloud functions filters can still be used to filter the results.\n\nOn other modules we decided to stick to filters arguments in order to keep as much functionality from the past as possible. This is not possible here, still i am inclined to keep it the \"filters\" argument for two reasons: consistency with other *_info modules and because sdk might readd postfiltering in the future.\n\n[1] https://github.com/openstack/openstacksdk/blob/master/openstack/cloud/_network.py#L42","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"df9c5bf546ddcae5d1b3d0425e925ad27507626d","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        kwargs \u003d self.params[\u0027filters\u0027] or {}"},{"line_number":190,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":191,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":192,"context_line":"        networks \u003d self.conn.network.networks(**kwargs)"},{"line_number":193,"context_line":"        networks \u003d [i.to_dict(computed\u003dFalse) for i in networks]"},{"line_number":194,"context_line":"        self.exit(changed\u003dFalse, networks\u003dnetworks)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"3f83de27_efc5c4f8","line":192,"in_reply_to":"7fc78f59_cb2ae729","updated":"2022-05-13 09:41:44.000000000","message":"It\u0027s not filters, it\u0027s a \"query\" argument:\nhttps://github.com/openstack/openstacksdk/blob/master/openstack/network/v2/_proxy.py#L1794-L1815\n\nMaybe worth to rename it to \"query\" to avoid confusing.","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"72bd8b434c6c2cd1ecbeda1eeec6241408928e16","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        kwargs \u003d self.params[\u0027filters\u0027] or {}"},{"line_number":190,"context_line":"        if self.params[\u0027name\u0027]:"},{"line_number":191,"context_line":"            kwargs[\u0027name\u0027] \u003d self.params[\u0027name\u0027]"},{"line_number":192,"context_line":"        networks \u003d self.conn.network.networks(**kwargs)"},{"line_number":193,"context_line":"        networks \u003d [i.to_dict(computed\u003dFalse) for i in networks]"},{"line_number":194,"context_line":"        self.exit(changed\u003dFalse, networks\u003dnetworks)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"2f762a05_775e2553","line":192,"in_reply_to":"97ef1d2a_e14a5a77","updated":"2022-05-30 09:23:33.000000000","message":"Ack, will change it back to cloud layer.","commit_id":"d34c648a226a8d86b525f2d2f1dd0f0813be56f3"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"0098d7575166c37848427df44fe1c36c37bf4e7d","unresolved":true,"context_lines":[{"line_number":190,"context_line":"            \u0027filters\u0027: self.params[\u0027filters\u0027],"},{"line_number":191,"context_line":"            \u0027name_or_id\u0027: self.params[\u0027name\u0027]"},{"line_number":192,"context_line":"        }"},{"line_number":193,"context_line":"        kwargs \u003d {k: v for k, v in kwargs.items() if v is not None}"},{"line_number":194,"context_line":"        networks \u003d self.conn.search_networks(**kwargs)"},{"line_number":195,"context_line":"        networks \u003d [i.to_dict(computed\u003dFalse) for i in networks]"},{"line_number":196,"context_line":"        self.exit(changed\u003dFalse, networks\u003dnetworks)"}],"source_content_type":"text/x-python","patch_set":43,"id":"6d5973c1_65809311","line":193,"range":{"start_line":193,"start_character":0,"end_line":193,"end_character":3},"updated":"2022-06-02 10:20:28.000000000","message":"no need, it\u0027s None in function args: https://github.com/openstack/openstacksdk/blob/fcd5be224c19cb99a80cf1820159454d6026e0b9/openstack/cloud/_network.py#L42","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"20b51700ba0ef4edae9b9a6db88fd6ff2a4dc171","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            \u0027filters\u0027: self.params[\u0027filters\u0027],"},{"line_number":191,"context_line":"            \u0027name_or_id\u0027: self.params[\u0027name\u0027]"},{"line_number":192,"context_line":"        }"},{"line_number":193,"context_line":"        kwargs \u003d {k: v for k, v in kwargs.items() if v is not None}"},{"line_number":194,"context_line":"        networks \u003d self.conn.search_networks(**kwargs)"},{"line_number":195,"context_line":"        networks \u003d [i.to_dict(computed\u003dFalse) for i in networks]"},{"line_number":196,"context_line":"        self.exit(changed\u003dFalse, networks\u003dnetworks)"}],"source_content_type":"text/x-python","patch_set":43,"id":"df0a57ac_939dbe63","line":193,"range":{"start_line":193,"start_character":0,"end_line":193,"end_character":3},"in_reply_to":"6d5973c1_65809311","updated":"2022-06-02 10:37:45.000000000","message":"Right, removed it.","commit_id":"7611dba4114820d5e10757039e6c3132b1f27c94"}]}