)]}'
{"plugins/modules/baremetal_node_info.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a358dee8c956879b09ff79c36a832b09241587b2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":9,"context_line":"module: baremetal_node_info"},{"line_number":10,"context_line":"short_description: Retrieve information about Bare Metal nodes from OpenStack"},{"line_number":11,"context_line":"author: OpenStack Ansible SIG"}],"source_content_type":"text/x-python","patch_set":7,"id":"1e1c0bcd_30367b99","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":13},"updated":"2022-02-03 09:00:44.000000000","message":"please add this module to action_group openstack in meta: https://github.com/openstack/ansible-collections-openstack/blob/master/meta/runtime.yml#L3","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"edaa8768c1d243f0d1c8c4ff3aec7f0bfa538cbc","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"DOCUMENTATION \u003d \u0027\u0027\u0027"},{"line_number":9,"context_line":"module: baremetal_node_info"},{"line_number":10,"context_line":"short_description: Retrieve information about Bare Metal nodes from OpenStack"},{"line_number":11,"context_line":"author: OpenStack Ansible SIG"}],"source_content_type":"text/x-python","patch_set":7,"id":"e10f1ae6_5ea4c648","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":13},"in_reply_to":"1e1c0bcd_30367b99","updated":"2022-02-03 19:21:21.000000000","message":"Done","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d152ef8a57fbb11f47eb94b4ca80b3873a559aa4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    name:"},{"line_number":20,"context_line":"      description:"},{"line_number":21,"context_line":"        - unique name identifier to identify the host in Ironic."},{"line_number":22,"context_line":"      type: str"},{"line_number":23,"context_line":"    mac:"},{"line_number":24,"context_line":"      description:"},{"line_number":25,"context_line":"        - unique mac address that is used to attempt to identify the host."}],"source_content_type":"text/x-python","patch_set":7,"id":"aadff93c_3de074eb","line":22,"updated":"2022-02-03 14:07:55.000000000","message":"We\u0027ve set a bad precedence in baremetal_node_action. From ironic\u0027s perspective uuid and name are largely equivalent. Maybe we need just \"node\" here that accepts both a name and a UUID? And probably cahnge baremetal_node_action.","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"edaa8768c1d243f0d1c8c4ff3aec7f0bfa538cbc","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    name:"},{"line_number":20,"context_line":"      description:"},{"line_number":21,"context_line":"        - unique name identifier to identify the host in Ironic."},{"line_number":22,"context_line":"      type: str"},{"line_number":23,"context_line":"    mac:"},{"line_number":24,"context_line":"      description:"},{"line_number":25,"context_line":"        - unique mac address that is used to attempt to identify the host."}],"source_content_type":"text/x-python","patch_set":7,"id":"0a56629f_32507609","line":22,"in_reply_to":"aadff93c_3de074eb","updated":"2022-02-03 19:21:21.000000000","message":"Ack, I actually started with node and then changed it to match the existing modules.\n\nI\u0027ve changed it back to \u0027node\u0027. Lets do baremetal_node_action as a follow up.","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d152ef8a57fbb11f47eb94b4ca80b3873a559aa4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cloud: \"devstack\""},{"line_number":45,"context_line":"  register: result"},{"line_number":46,"context_line":"- debug:"},{"line_number":47,"context_line":"    msg: \"{{ result.openstack_baremetal_nodes }}\""},{"line_number":48,"context_line":"# Gather information about a baremeal node"},{"line_number":49,"context_line":"- openstack.cloud.baremetal_node_info:"},{"line_number":50,"context_line":"    cloud: \"devstack\""}],"source_content_type":"text/x-python","patch_set":7,"id":"f0ccb8e0_76a9cf85","line":47,"updated":"2022-02-03 14:07:55.000000000","message":"s/openstack_// (same below)","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"edaa8768c1d243f0d1c8c4ff3aec7f0bfa538cbc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    cloud: \"devstack\""},{"line_number":45,"context_line":"  register: result"},{"line_number":46,"context_line":"- debug:"},{"line_number":47,"context_line":"    msg: \"{{ result.openstack_baremetal_nodes }}\""},{"line_number":48,"context_line":"# Gather information about a baremeal node"},{"line_number":49,"context_line":"- openstack.cloud.baremetal_node_info:"},{"line_number":50,"context_line":"    cloud: \"devstack\""}],"source_content_type":"text/x-python","patch_set":7,"id":"c1c3cffa_9d330a6f","line":47,"in_reply_to":"f0ccb8e0_76a9cf85","updated":"2022-02-03 19:21:21.000000000","message":"Done","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d152ef8a57fbb11f47eb94b4ca80b3873a559aa4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\u0027\u0027\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":58,"context_line":"baremetal_node:"},{"line_number":59,"context_line":"    description: Bare Metal node dictionary. A subset of the dictionary keys"},{"line_number":60,"context_line":"                 listed below may be returned, depending on your cloud"},{"line_number":61,"context_line":"                 provider."}],"source_content_type":"text/x-python","patch_set":7,"id":"68e939e9_60bf1b70","line":58,"updated":"2022-02-03 14:07:55.000000000","message":"See below re the type of the result.","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"edaa8768c1d243f0d1c8c4ff3aec7f0bfa538cbc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\u0027\u0027\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":58,"context_line":"baremetal_node:"},{"line_number":59,"context_line":"    description: Bare Metal node dictionary. A subset of the dictionary keys"},{"line_number":60,"context_line":"                 listed below may be returned, depending on your cloud"},{"line_number":61,"context_line":"                 provider."}],"source_content_type":"text/x-python","patch_set":7,"id":"55a33d58_b3aa1661","line":58,"in_reply_to":"68e939e9_60bf1b70","updated":"2022-02-03 19:21:21.000000000","message":"Done","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"edaa8768c1d243f0d1c8c4ff3aec7f0bfa538cbc","unresolved":true,"context_lines":[{"line_number":374,"context_line":"    return None"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"def main():"},{"line_number":378,"context_line":"    argument_spec \u003d ironic_argument_spec("},{"line_number":379,"context_line":"        uuid\u003ddict(required\u003dFalse),"},{"line_number":380,"context_line":"        name\u003ddict(required\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":7,"id":"b13e1e45_5f8b6a05","line":377,"updated":"2022-02-03 19:21:21.000000000","message":"Should we add a list of properties we remove from the result?\n\nstates - Links to the collection of states\nAnd in the port(nics) structure \u0027links\u0027 and \u0027location\u0027 in each port seem not so useful.","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"1ca99358ea51b46fe6e4fc8be1c0e59291e139b1","unresolved":false,"context_lines":[{"line_number":374,"context_line":"    return None"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"def main():"},{"line_number":378,"context_line":"    argument_spec \u003d ironic_argument_spec("},{"line_number":379,"context_line":"        uuid\u003ddict(required\u003dFalse),"},{"line_number":380,"context_line":"        name\u003ddict(required\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":7,"id":"4e9bcdaa_95be131c","line":377,"in_reply_to":"b13e1e45_5f8b6a05","updated":"2022-02-03 19:21:50.000000000","message":"Done","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d152ef8a57fbb11f47eb94b4ca80b3873a559aa4","unresolved":false,"context_lines":[{"line_number":405,"context_line":"            servers \u003d cloud.list_machines()"},{"line_number":406,"context_line":"            for server in servers:"},{"line_number":407,"context_line":"                server.nics \u003d cloud.list_nics_for_machine(server.uuid)"},{"line_number":408,"context_line":"            module.exit_json(changed\u003dFalse, baremetal_node\u003dservers)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        module.exit_json(changed\u003dFalse, baremetal_node\u003dNone)"},{"line_number":411,"context_line":"    except sdk.exceptions.OpenStackCloudException as e:"}],"source_content_type":"text/x-python","patch_set":7,"id":"889bb63e_5d4e58cc","line":408,"updated":"2022-02-03 14:07:55.000000000","message":"Since it\u0027s possible to return several values, I think we should use plural form, i.e. baremetal_nodes. Seems consistent with server_info.","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"d152ef8a57fbb11f47eb94b4ca80b3873a559aa4","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                server.nics \u003d cloud.list_nics_for_machine(server.uuid)"},{"line_number":408,"context_line":"            module.exit_json(changed\u003dFalse, baremetal_node\u003dservers)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        module.exit_json(changed\u003dFalse, baremetal_node\u003dNone)"},{"line_number":411,"context_line":"    except sdk.exceptions.OpenStackCloudException as e:"},{"line_number":412,"context_line":"        module.fail_json(msg\u003dstr(e))"},{"line_number":413,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6c25a69c_f4b88fba","line":410,"updated":"2022-02-03 14:07:55.000000000","message":"... and here an empty list","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"edaa8768c1d243f0d1c8c4ff3aec7f0bfa538cbc","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                server.nics \u003d cloud.list_nics_for_machine(server.uuid)"},{"line_number":408,"context_line":"            module.exit_json(changed\u003dFalse, baremetal_node\u003dservers)"},{"line_number":409,"context_line":""},{"line_number":410,"context_line":"        module.exit_json(changed\u003dFalse, baremetal_node\u003dNone)"},{"line_number":411,"context_line":"    except sdk.exceptions.OpenStackCloudException as e:"},{"line_number":412,"context_line":"        module.fail_json(msg\u003dstr(e))"},{"line_number":413,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"e8c1fbbb_f368812c","line":410,"in_reply_to":"6c25a69c_f4b88fba","updated":"2022-02-03 19:21:21.000000000","message":"Done.","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"e8a4177d3b0c6937f62ec078539b53e67db033c7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      description:"},{"line_number":17,"context_line":"        - Name or globally unique identifier (UUID) to identify the host."},{"line_number":18,"context_line":"      type: str"},{"line_number":19,"context_line":"    mac:"},{"line_number":20,"context_line":"      description:"},{"line_number":21,"context_line":"        - Unique mac address that is used to attempt to identify the host."},{"line_number":22,"context_line":"      type: str"}],"source_content_type":"text/x-python","patch_set":9,"id":"f833f84a_50b11df8","line":19,"updated":"2022-02-09 08:42:21.000000000","message":"(mostly thinking aloud) we call it \"address\" in ports, but \"mac\" here. I wonder if we want to enforce consistency?","commit_id":"20329c0329f1114786f155e9b7bcad663665ffa3"}],"plugins/modules/os_ironic_node_info.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"a358dee8c956879b09ff79c36a832b09241587b2","unresolved":true,"context_lines":[{"line_number":1,"context_line":"baremetal_node_info.py"}],"source_content_type":"x-git/symlink","patch_set":7,"id":"f560f074_edd34dbb","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"updated":"2022-02-03 09:00:44.000000000","message":"no need to add this file, we keep old os_ names only for backward compatibility, they are deprecated","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"52ef9effb4aa4d27566c91fa0b6032c05100436b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"baremetal_node_info.py"}],"source_content_type":"x-git/symlink","patch_set":7,"id":"556b47bf_8bded5ff","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"in_reply_to":"f560f074_edd34dbb","updated":"2022-02-03 19:24:12.000000000","message":"Done","commit_id":"f629cc82b2e3cb81df3ee572f6566982e9574b26"}]}