)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"5dee6f21948a19f9209e0ce3a0a071ac69599c56","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     anbanerj \u003canbanerj@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-08 17:44:12 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Moves image_info from cloud to proxy object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes image_info compatible with new sdk version"},{"line_number":10,"context_line":"- This patch changes get_image (which is a cloud object method) to image.get_image (proxy object method)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a550a74c_eb95258b","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":5},"updated":"2022-02-09 21:06:24.000000000","message":"Looks great. Can you please also add a test for image_info with some properties here? https://github.com/openstack/ansible-collections-openstack/blob/master/ci/roles/image/tasks/main.yml#L19\nJust to test we pass and consume properties correctly. Thanks!","commit_id":"077fa4e80b602dc0719ec0bc6372f3862c91b256"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"8740653967e6ff06383066d6154873556068b68b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     anbanerj \u003canbanerj@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-08 17:44:12 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Moves image_info from cloud to proxy object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes image_info compatible with new sdk version"},{"line_number":10,"context_line":"- This patch changes get_image (which is a cloud object method) to image.get_image (proxy object method)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"515a141e_4f3bc006","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":5},"in_reply_to":"8236f43a_dbad53e2","updated":"2022-04-25 19:26:12.000000000","message":"Ack","commit_id":"077fa4e80b602dc0719ec0bc6372f3862c91b256"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"b334ea4a5ab685dce624e400bc92e73135d36f5a","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     anbanerj \u003canbanerj@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-08 17:44:12 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Moves image_info from cloud to proxy object"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This makes image_info compatible with new sdk version"},{"line_number":10,"context_line":"- This patch changes get_image (which is a cloud object method) to image.get_image (proxy object method)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8236f43a_dbad53e2","line":7,"range":{"start_line":7,"start_character":1,"end_line":7,"end_character":5},"in_reply_to":"a550a74c_eb95258b","updated":"2022-04-14 15:58:12.000000000","message":"ack, added tests to assert if we are returning the correct parameters in ci/roles/image_info/tasks/main.yml","commit_id":"077fa4e80b602dc0719ec0bc6372f3862c91b256"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"513c9a6fda913d43b1795f0f11c5ba359593bf06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4227bed7_c155919c","updated":"2022-02-14 09:21:14.000000000","message":"Please add tests and handle absent attributes as noted in comments.","commit_id":"077fa4e80b602dc0719ec0bc6372f3862c91b256"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"f334a01a8b117e527fbea7a7ed0c6234fd7b6643","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f74d18f4_a9d1bb36","updated":"2022-04-13 11:33:13.000000000","message":"List all image functionality is not being checked in the ci. -wf till I add a task to list all images","commit_id":"1f7b971bea7f67e23fcf3830a5f8329166e3982d"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"8571349cf38f9547ce93b6d0e994a01024e5da2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5caca2d3_c83cc3c5","updated":"2022-04-20 08:59:31.000000000","message":"wip","commit_id":"485071b857f3a31268181695577837347b5a7485"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"36ddbc626fc8da2b758e5836cf4ab7ab3a608eb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"e01f2a82_23905abf","updated":"2022-05-09 12:50:23.000000000","message":"Nice 😊 Some brief remarks, then it is ready for merge ^^","commit_id":"0d3c04e64c28288ec908cd46c48d1776f4fcc0a0"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"92ff17952004b8f1dae5dccf4b788b500a46e5f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"387dc4e7_be69b5f8","updated":"2022-05-09 19:09:04.000000000","message":"Thank you for being persistent with this patch, Ananya! That were a loooot of fields to document 😱 Let us rebase this onto master branch and then merge it 😊","commit_id":"149a13acc5f6c57a90deffa278a088c0b8f24812"}],"ci/roles/image_info/defaults/main.yml":[{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"882aec07d945c74dbf7a90c38231cc347891f9d1","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  - visibility"},{"line_number":63,"context_line":"  - vm_mode"},{"line_number":64,"context_line":"  - vmware_adaptertype"},{"line_number":65,"context_line":"  - vmware_ostype"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"601b4832_d6d6fdfd","line":65,"updated":"2022-05-09 13:10:00.000000000","message":"no new line at the end of file i think it will complain","commit_id":"0d3c04e64c28288ec908cd46c48d1776f4fcc0a0"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"07841b2a125263508b8bf906e3a7cfebde69b354","unresolved":false,"context_lines":[{"line_number":62,"context_line":"  - visibility"},{"line_number":63,"context_line":"  - vm_mode"},{"line_number":64,"context_line":"  - vmware_adaptertype"},{"line_number":65,"context_line":"  - vmware_ostype"}],"source_content_type":"text/x-yaml","patch_set":35,"id":"8321f705_cc81d50f","line":65,"in_reply_to":"601b4832_d6d6fdfd","updated":"2022-05-09 15:52:59.000000000","message":"done","commit_id":"0d3c04e64c28288ec908cd46c48d1776f4fcc0a0"}],"ci/roles/image_info/tasks/main.yml":[{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c2f576757d5b9f182eb8e67b910c7a120483763e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"- name: Assert fields"},{"line_number":8,"context_line":"  assert:"},{"line_number":9,"context_line":"    that:"},{"line_number":10,"context_line":"      - \u0027["},{"line_number":11,"context_line":"           \"checksum\","},{"line_number":12,"context_line":"           \"container_format\","},{"line_number":13,"context_line":"           \"created_at\","}],"source_content_type":"text/x-yaml","patch_set":10,"id":"15919120_f3001511","line":10,"updated":"2022-04-21 08:20:10.000000000","message":"I get a looooot more fields?!?","commit_id":"9fd4053b33a44e4c671ecc7aae22e898ed7257a3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"dd7b9b12b9558e96d44fda9385f2e41ff157ffc3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"- name: Assert fields"},{"line_number":8,"context_line":"  assert:"},{"line_number":9,"context_line":"    that:"},{"line_number":10,"context_line":"      - \u0027["},{"line_number":11,"context_line":"           \"checksum\","},{"line_number":12,"context_line":"           \"container_format\","},{"line_number":13,"context_line":"           \"created_at\","}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c15c9f73_cf312b5c","line":10,"in_reply_to":"15919120_f3001511","updated":"2022-05-02 11:53:15.000000000","message":"Done","commit_id":"9fd4053b33a44e4c671ecc7aae22e898ed7257a3"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"aa7222120cf840764722f8ac96d5fdeccf5e63a3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"- name: Assert fields"},{"line_number":8,"context_line":"  assert:"},{"line_number":9,"context_line":"    that:"},{"line_number":10,"context_line":"      - \u0027["},{"line_number":11,"context_line":"           \"checksum\","},{"line_number":12,"context_line":"           \"container_format\","},{"line_number":13,"context_line":"           \"created_at\","}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b50bbe19_4ba1deb0","line":10,"in_reply_to":"15919120_f3001511","updated":"2022-05-02 11:47:52.000000000","message":"ack, added","commit_id":"9fd4053b33a44e4c671ecc7aae22e898ed7257a3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c2f576757d5b9f182eb8e67b910c7a120483763e","unresolved":true,"context_lines":[{"line_number":31,"context_line":"           \"virtual_size\","},{"line_number":32,"context_line":"           \"visibility\""},{"line_number":33,"context_line":"         ] | difference(result.openstack_ports.0.keys()) | length \u003d\u003d 0\u0027"},{"line_number":34,"context_line":"  when: sdk_version is version(\u00270.62\u0027, \u0027\u003e\u003d\u0027)"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"615784d2_e1b6f0e2","line":34,"updated":"2022-04-21 08:20:10.000000000","message":"Please drop the when clause because master is only compatible to 1.0.0.\n\n0.62 has not been released yet and will definitely not contain the content of the master branch. (The 0.62 is calculated by the sdk based on the last released version 0.61 plus 1.)","commit_id":"9fd4053b33a44e4c671ecc7aae22e898ed7257a3"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"e3004f3a970edd374f5da171754c87a8aaa45b89","unresolved":false,"context_lines":[{"line_number":31,"context_line":"           \"virtual_size\","},{"line_number":32,"context_line":"           \"visibility\""},{"line_number":33,"context_line":"         ] | difference(result.openstack_ports.0.keys()) | length \u003d\u003d 0\u0027"},{"line_number":34,"context_line":"  when: sdk_version is version(\u00270.62\u0027, \u0027\u003e\u003d\u0027)"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"9d4141ef_e88c920a","line":34,"in_reply_to":"615784d2_e1b6f0e2","updated":"2022-04-25 14:30:53.000000000","message":"Ack","commit_id":"9fd4053b33a44e4c671ecc7aae22e898ed7257a3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"dd7b9b12b9558e96d44fda9385f2e41ff157ffc3","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: List all images"},{"line_number":3,"context_line":"  openstack.cloud.image_info:"},{"line_number":4,"context_line":"    cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"c403646b_9becb6b0","line":1,"updated":"2022-05-02 11:53:15.000000000","message":"please add image_info role+tag to ci/run-collection.yml and add tag to tox_extra_args in .zuul.yaml, so that your tests are actually run.","commit_id":"447bc7a062a3a38651f169ea5db555ea7cdce3a4"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"7b50c2484d0bcb3b83fcc488548495147d2d0d40","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"- name: List all images"},{"line_number":3,"context_line":"  openstack.cloud.image_info:"},{"line_number":4,"context_line":"    cloud: \"{{ cloud }}\""}],"source_content_type":"text/x-yaml","patch_set":22,"id":"c3293142_faff8a9f","line":1,"in_reply_to":"c403646b_9becb6b0","updated":"2022-05-03 10:05:21.000000000","message":"Ack","commit_id":"447bc7a062a3a38651f169ea5db555ea7cdce3a4"}],"plugins/modules/image_info.py":[{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6580cb03f86f56e97f18c2a59d40387095e2efb6","unresolved":true,"context_lines":[{"line_number":164,"context_line":"    def run(self):"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":167,"context_line":"            image \u003d self.conn.image.get_image(self.params[\u0027image\u0027])"},{"line_number":168,"context_line":"            image \u003d image.to_dict()"},{"line_number":169,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":170,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"95600e24_5ed00a56","line":167,"range":{"start_line":167,"start_character":35,"end_line":167,"end_character":45},"updated":"2022-02-07 18:57:34.000000000","message":"for finding by \"name or ID\" need to use .find_image()","commit_id":"80bc7f07d97fa5376b17aa4dc2c54f91c4407c89"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"b334ea4a5ab685dce624e400bc92e73135d36f5a","unresolved":true,"context_lines":[{"line_number":164,"context_line":"    def run(self):"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":167,"context_line":"            image \u003d self.conn.image.get_image(self.params[\u0027image\u0027])"},{"line_number":168,"context_line":"            image \u003d image.to_dict()"},{"line_number":169,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":170,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a6b404ac_143ea6c9","line":167,"range":{"start_line":167,"start_character":35,"end_line":167,"end_character":45},"in_reply_to":"95600e24_5ed00a56","updated":"2022-04-14 15:58:12.000000000","message":"updated","commit_id":"80bc7f07d97fa5376b17aa4dc2c54f91c4407c89"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c2f576757d5b9f182eb8e67b910c7a120483763e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def run(self):"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":167,"context_line":"            image \u003d self.conn.image.get_image(self.params[\u0027image\u0027])"},{"line_number":168,"context_line":"            image \u003d image.to_dict()"},{"line_number":169,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":170,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"0a05f768_5b63f7a0","line":167,"range":{"start_line":167,"start_character":35,"end_line":167,"end_character":45},"in_reply_to":"a6b404ac_143ea6c9","updated":"2022-04-21 08:20:10.000000000","message":"Done","commit_id":"80bc7f07d97fa5376b17aa4dc2c54f91c4407c89"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"6580cb03f86f56e97f18c2a59d40387095e2efb6","unresolved":true,"context_lines":[{"line_number":169,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            images \u003d self.conn.image.images(**self.params[\u0027properties\u0027])"},{"line_number":172,"context_line":"            images \u003d [img.to_dict() for img in [images]]"},{"line_number":173,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimages)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a0c29196_4dbee666","line":172,"range":{"start_line":172,"start_character":22,"end_line":172,"end_character":55},"updated":"2022-02-07 18:57:34.000000000","message":"need to add check if \"to_dict()\" is in attributes","commit_id":"80bc7f07d97fa5376b17aa4dc2c54f91c4407c89"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c2f576757d5b9f182eb8e67b910c7a120483763e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            images \u003d self.conn.image.images(**self.params[\u0027properties\u0027])"},{"line_number":172,"context_line":"            images \u003d [img.to_dict() for img in [images]]"},{"line_number":173,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimages)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0af97a71_31103d1e","line":172,"range":{"start_line":172,"start_character":22,"end_line":172,"end_character":55},"in_reply_to":"2b19734d_c8f42164","updated":"2022-04-21 08:20:10.000000000","message":"Done","commit_id":"80bc7f07d97fa5376b17aa4dc2c54f91c4407c89"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"b334ea4a5ab685dce624e400bc92e73135d36f5a","unresolved":true,"context_lines":[{"line_number":169,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            images \u003d self.conn.image.images(**self.params[\u0027properties\u0027])"},{"line_number":172,"context_line":"            images \u003d [img.to_dict() for img in [images]]"},{"line_number":173,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimages)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2b19734d_c8f42164","line":172,"range":{"start_line":172,"start_character":22,"end_line":172,"end_character":55},"in_reply_to":"a0c29196_4dbee666","updated":"2022-04-14 15:58:12.000000000","message":"updated","commit_id":"80bc7f07d97fa5376b17aa4dc2c54f91c4407c89"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"513c9a6fda913d43b1795f0f11c5ba359593bf06","unresolved":true,"context_lines":[{"line_number":170,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":171,"context_line":"        else:"},{"line_number":172,"context_line":"            images \u003d self.conn.image.images(**self.params[\u0027properties\u0027])"},{"line_number":173,"context_line":"            images \u003d [images.to_dict() if hasattr(images, \"to_dict\") else [img]"},{"line_number":174,"context_line":"                      for img in images]"},{"line_number":175,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimages)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ed769c68_56cac692","line":173,"updated":"2022-02-14 09:21:14.000000000","message":"Drop \u0027location\u0027 attribute? Refer to https://opendev.org/openstack/ansible-collections-openstack/src/branch/master/plugins/modules/floating_ip_info.py#L199\n\nMaybe we should use dict(...) instead of ...to_dict() when to_dict is not available?\n\nWith to_dict there will be no attribute \u0027protected\u0027 anymore. The dict will use \u0027is_protected\u0027 now, so please update the RETURN value doc.\n\nReturn value is_public has been dropped, please update RETURN value doc.","commit_id":"077fa4e80b602dc0719ec0bc6372f3862c91b256"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c2f576757d5b9f182eb8e67b910c7a120483763e","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":171,"context_line":"        else:"},{"line_number":172,"context_line":"            images \u003d self.conn.image.images(**self.params[\u0027properties\u0027])"},{"line_number":173,"context_line":"            images \u003d [images.to_dict() if hasattr(images, \"to_dict\") else [img]"},{"line_number":174,"context_line":"                      for img in images]"},{"line_number":175,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimages)"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3b767839_1f6911b2","line":173,"in_reply_to":"ed769c68_56cac692","updated":"2022-04-21 08:20:10.000000000","message":"Done","commit_id":"077fa4e80b602dc0719ec0bc6372f3862c91b256"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"ece5a9abf0f22c52c3f1d5dc138655e51eee54d8","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":159,"context_line":"            image \u003d self.conn.image.find_image(self.params[\u0027image\u0027])"},{"line_number":160,"context_line":"            if hasattr(image, \"to_dict\"):"},{"line_number":161,"context_line":"                image \u003d image.to_dict()"},{"line_number":162,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":163,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a9b4403_09382eb6","line":160,"updated":"2022-04-13 14:23:22.000000000","message":"remove the check if have the to_dict","commit_id":"412ecb1de9115a815e8bcd5d634ed7511218d4fe"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"ece5a9abf0f22c52c3f1d5dc138655e51eee54d8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":159,"context_line":"            image \u003d self.conn.image.find_image(self.params[\u0027image\u0027])"},{"line_number":160,"context_line":"            if hasattr(image, \"to_dict\"):"},{"line_number":161,"context_line":"                image \u003d image.to_dict()"},{"line_number":162,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":163,"context_line":"        else:"},{"line_number":164,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"}],"source_content_type":"text/x-python","patch_set":6,"id":"f6091ea8_4bfc4214","line":161,"updated":"2022-04-13 14:23:22.000000000","message":"use compute\u003dFalse","commit_id":"412ecb1de9115a815e8bcd5d634ed7511218d4fe"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"ece5a9abf0f22c52c3f1d5dc138655e51eee54d8","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        else:"},{"line_number":164,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"},{"line_number":165,"context_line":"            images \u003d self.conn.image.images(**image_properties)"},{"line_number":166,"context_line":"            images \u003d [images.to_dict() if hasattr(images, \"to_dict\")"},{"line_number":167,"context_line":"                      else dict(img) for img in images]"},{"line_number":168,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimages)"},{"line_number":169,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5a19e9e2_821d2d69","line":166,"updated":"2022-04-13 14:23:22.000000000","message":"ditto","commit_id":"412ecb1de9115a815e8bcd5d634ed7511218d4fe"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"d00aa3a151dce4f2b4b9607fc520b56fab3be938","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":159,"context_line":"            image \u003d self.conn.image.find_image(self.params[\u0027image\u0027])"},{"line_number":160,"context_line":"            if hasattr(image, \"to_dict\"):"},{"line_number":161,"context_line":"                image \u003d image.to_dict()"},{"line_number":162,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":163,"context_line":"        else:"},{"line_number":164,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"3562d241_d93f2850","line":161,"range":{"start_line":160,"start_character":12,"end_line":161,"end_character":39},"updated":"2022-04-20 10:35:34.000000000","message":"This can be removed, and the to_dict must have computed\u003dFalse","commit_id":"485071b857f3a31268181695577837347b5a7485"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c2f576757d5b9f182eb8e67b910c7a120483763e","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":159,"context_line":"            image \u003d self.conn.image.find_image(self.params[\u0027image\u0027])"},{"line_number":160,"context_line":"            if hasattr(image, \"to_dict\"):"},{"line_number":161,"context_line":"                image \u003d image.to_dict()"},{"line_number":162,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":163,"context_line":"        else:"},{"line_number":164,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"695e4f7a_4705cd29","line":161,"range":{"start_line":160,"start_character":12,"end_line":161,"end_character":39},"in_reply_to":"3562d241_d93f2850","updated":"2022-04-21 08:20:10.000000000","message":"Done","commit_id":"485071b857f3a31268181695577837347b5a7485"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"e3004f3a970edd374f5da171754c87a8aaa45b89","unresolved":true,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":159,"context_line":"            image \u003d self.conn.image.find_image(self.params[\u0027image\u0027])"},{"line_number":160,"context_line":"            if hasattr(image, \"to_dict\"):"},{"line_number":161,"context_line":"                image \u003d image.to_dict()"},{"line_number":162,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":163,"context_line":"        else:"},{"line_number":164,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"60ea639f_a6583251","line":161,"range":{"start_line":160,"start_character":12,"end_line":161,"end_character":39},"in_reply_to":"3562d241_d93f2850","updated":"2022-04-25 14:30:53.000000000","message":"ack, updated","commit_id":"485071b857f3a31268181695577837347b5a7485"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"aa7222120cf840764722f8ac96d5fdeccf5e63a3","unresolved":false,"context_lines":[{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":159,"context_line":"            image \u003d self.conn.image.find_image(self.params[\u0027image\u0027])"},{"line_number":160,"context_line":"            if hasattr(image, \"to_dict\"):"},{"line_number":161,"context_line":"                image \u003d image.to_dict()"},{"line_number":162,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":163,"context_line":"        else:"},{"line_number":164,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"}],"source_content_type":"text/x-python","patch_set":8,"id":"4c9b0127_95a2ab77","line":161,"range":{"start_line":160,"start_character":12,"end_line":161,"end_character":39},"in_reply_to":"60ea639f_a6583251","updated":"2022-05-02 11:47:52.000000000","message":"Done","commit_id":"485071b857f3a31268181695577837347b5a7485"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"c2f576757d5b9f182eb8e67b910c7a120483763e","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    msg: \"{{ result.openstack_image }}\""},{"line_number":67,"context_line":"\u0027\u0027\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":70,"context_line":"openstack_image:"},{"line_number":71,"context_line":"    description: has all the openstack information about the image"},{"line_number":72,"context_line":"    returned: always, but can be null"}],"source_content_type":"text/x-python","patch_set":10,"id":"8ccfabaa_8f4d62be","line":69,"updated":"2022-04-21 08:20:10.000000000","message":"The module returns a lot more values, maybe copy and paste the values and their descriptions from https://github.com/openstack/openstacksdk/blob/master/openstack/image/v2/image.py#L142 \n\nOr maybe there is a reason why you left them out?","commit_id":"9fd4053b33a44e4c671ecc7aae22e898ed7257a3"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"014455d4fa97a1eaa5eede5eb34b0efe7c7e5821","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    msg: \"{{ result.openstack_image }}\""},{"line_number":67,"context_line":"\u0027\u0027\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":70,"context_line":"openstack_image:"},{"line_number":71,"context_line":"    description: has all the openstack information about the image"},{"line_number":72,"context_line":"    returned: always, but can be null"}],"source_content_type":"text/x-python","patch_set":10,"id":"a89f89bc_680b09a2","line":69,"in_reply_to":"8ccfabaa_8f4d62be","updated":"2022-04-21 13:40:30.000000000","message":"Ananya added all return parameters which are present in OpenStack\u0027s Image API [1]\nWe have to decide whether we want to document in RETURN everything which is actually returned or only stuff which is definitely returned or something in between. For optional return values we could add \"returned: if added by owner or administrator\" or \"returned: when supported\" or something else to each optional value. Ansible has a plenty of modules where \"returned:\" in RETURN is defined as a freestyle string.\n\n[1] https://docs.openstack.org/api-ref/","commit_id":"9fd4053b33a44e4c671ecc7aae22e898ed7257a3"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"d946063f7ee2f84f475f1c6de286fe2358fccf47","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    msg: \"{{ result.openstack_image }}\""},{"line_number":67,"context_line":"\u0027\u0027\u0027"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":70,"context_line":"openstack_image:"},{"line_number":71,"context_line":"    description: has all the openstack information about the image"},{"line_number":72,"context_line":"    returned: always, but can be null"}],"source_content_type":"text/x-python","patch_set":10,"id":"0e4f8cd1_a2213056","line":69,"in_reply_to":"a89f89bc_680b09a2","updated":"2022-04-29 08:50:52.000000000","message":"Ack","commit_id":"9fd4053b33a44e4c671ecc7aae22e898ed7257a3"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"0ca3f663a921ef304a11d1a5c192cdfc17cddcba","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        else:"},{"line_number":163,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"},{"line_number":164,"context_line":"            images \u003d self.conn.image.images(**image_properties)"},{"line_number":165,"context_line":"            images \u003d images.to_dict(computed\u003dFalse)"},{"line_number":166,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimages)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"792edb39_eabaedbc","line":165,"updated":"2022-04-25 08:45:59.000000000","message":"images here can return more than one, should use [i.to_dict(computed\u003dFalse) for i in images]","commit_id":"75d6ba61e785dc38474f44d0aebb3b1fdbed65c3"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"488978cffb2d82ddee6787543d0cdeeb79fee71e","unresolved":true,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":175,"context_line":"            image \u003d self.conn.image.find_image(self.params[\u0027image\u0027])"},{"line_number":176,"context_line":"            image \u003d image.to_dict(computed\u003dFalse)"},{"line_number":177,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":178,"context_line":"        else:"},{"line_number":179,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"}],"source_content_type":"text/x-python","patch_set":13,"id":"7e4b66c6_41135828","line":176,"updated":"2022-04-26 14:51:19.000000000","message":"We should check if image is None before calling to_dict, otherwise we crash.","commit_id":"7ee09264704604b682f5ae29005fa9c61cc08b71"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"d946063f7ee2f84f475f1c6de286fe2358fccf47","unresolved":false,"context_lines":[{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":175,"context_line":"            image \u003d self.conn.image.find_image(self.params[\u0027image\u0027])"},{"line_number":176,"context_line":"            image \u003d image.to_dict(computed\u003dFalse)"},{"line_number":177,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":178,"context_line":"        else:"},{"line_number":179,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"}],"source_content_type":"text/x-python","patch_set":13,"id":"bf50e01b_e586fb44","line":176,"in_reply_to":"7e4b66c6_41135828","updated":"2022-04-29 08:50:52.000000000","message":"Ack","commit_id":"7ee09264704604b682f5ae29005fa9c61cc08b71"},{"author":{"_account_id":34208,"name":"Rafael Castillo","email":"rcastill@redhat.com","username":"rcastill"},"change_message_id":"488978cffb2d82ddee6787543d0cdeeb79fee71e","unresolved":true,"context_lines":[{"line_number":176,"context_line":"            image \u003d image.to_dict(computed\u003dFalse)"},{"line_number":177,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":178,"context_line":"        else:"},{"line_number":179,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"},{"line_number":180,"context_line":"            images \u003d self.conn.image.images(**image_properties)"},{"line_number":181,"context_line":"            images \u003d [i.to_dict(computed\u003dFalse) for i in images]"},{"line_number":182,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimages)"}],"source_content_type":"text/x-python","patch_set":13,"id":"241f1c41_2807bb22","line":179,"updated":"2022-04-26 14:51:19.000000000","message":"You don\u0027t need to put this all inside an else block since the block above returns.","commit_id":"7ee09264704604b682f5ae29005fa9c61cc08b71"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"d946063f7ee2f84f475f1c6de286fe2358fccf47","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            image \u003d image.to_dict(computed\u003dFalse)"},{"line_number":177,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimage)"},{"line_number":178,"context_line":"        else:"},{"line_number":179,"context_line":"            image_properties \u003d self.params[\u0027properties\u0027] or {}"},{"line_number":180,"context_line":"            images \u003d self.conn.image.images(**image_properties)"},{"line_number":181,"context_line":"            images \u003d [i.to_dict(computed\u003dFalse) for i in images]"},{"line_number":182,"context_line":"            self.exit(changed\u003dFalse, openstack_image\u003dimages)"}],"source_content_type":"text/x-python","patch_set":13,"id":"b84f906d_07b7bb1e","line":179,"in_reply_to":"241f1c41_2807bb22","updated":"2022-04-29 08:50:52.000000000","message":"Ack","commit_id":"7ee09264704604b682f5ae29005fa9c61cc08b71"},{"author":{"_account_id":10969,"name":"Shnaidman Sagi (Sergey)","display_name":"Shnaidman Sagi","email":"sshnaidm@redhat.com","username":"sergsh"},"change_message_id":"47ae27556232f19d019f06351bbcd4f89869a168","unresolved":true,"context_lines":[{"line_number":141,"context_line":"            returned: success"},{"line_number":142,"context_line":"            type: str"},{"line_number":143,"context_line":"        hw_cpu_thread_policy:"},{"line_number":144,"context_line":"            description:  Defines how hardware CPU threads in a simultaneous "},{"line_number":145,"context_line":"            multithreading-based (SMT) architecture be used."},{"line_number":146,"context_line":"            returned: success"},{"line_number":147,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":14,"id":"06c41862_2d2a1f3b","line":144,"range":{"start_line":144,"start_character":76,"end_line":144,"end_character":77},"updated":"2022-04-26 16:00:00.000000000","message":"need to remove all spaces in the line end","commit_id":"8a9081bd3a01f6c6f651650121cbdcc8a1e40f86"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"d946063f7ee2f84f475f1c6de286fe2358fccf47","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            returned: success"},{"line_number":142,"context_line":"            type: str"},{"line_number":143,"context_line":"        hw_cpu_thread_policy:"},{"line_number":144,"context_line":"            description:  Defines how hardware CPU threads in a simultaneous "},{"line_number":145,"context_line":"            multithreading-based (SMT) architecture be used."},{"line_number":146,"context_line":"            returned: success"},{"line_number":147,"context_line":"            type: str"}],"source_content_type":"text/x-python","patch_set":14,"id":"124d3e77_8af67c1f","line":144,"range":{"start_line":144,"start_character":76,"end_line":144,"end_character":77},"in_reply_to":"06c41862_2d2a1f3b","updated":"2022-04-29 08:50:52.000000000","message":"Ack","commit_id":"8a9081bd3a01f6c6f651650121cbdcc8a1e40f86"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"dd7b9b12b9558e96d44fda9385f2e41ff157ffc3","unresolved":true,"context_lines":[{"line_number":17,"context_line":"        - Name or ID of the image"},{"line_number":18,"context_line":"     required: false"},{"line_number":19,"context_line":"     type: str"},{"line_number":20,"context_line":"   properties:"},{"line_number":21,"context_line":"     description:"},{"line_number":22,"context_line":"        - Dict of properties of the images used for query"},{"line_number":23,"context_line":"     type: dict"}],"source_content_type":"text/x-python","patch_set":22,"id":"d15be219_c21c94aa","line":20,"updated":"2022-05-02 11:53:15.000000000","message":"Please rename this properties to filters and add properties as an alias (both here in options list as well as below in argument_spec. This makes it more consistent with other *_info modules and the sdk. For an example on how to add aliases, e.g. look at module volume_backup.","commit_id":"447bc7a062a3a38651f169ea5db555ea7cdce3a4"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"7b50c2484d0bcb3b83fcc488548495147d2d0d40","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        - Name or ID of the image"},{"line_number":18,"context_line":"     required: false"},{"line_number":19,"context_line":"     type: str"},{"line_number":20,"context_line":"   properties:"},{"line_number":21,"context_line":"     description:"},{"line_number":22,"context_line":"        - Dict of properties of the images used for query"},{"line_number":23,"context_line":"     type: dict"}],"source_content_type":"text/x-python","patch_set":22,"id":"f53d78df_bdbdf320","line":20,"in_reply_to":"d15be219_c21c94aa","updated":"2022-05-03 10:05:21.000000000","message":"Done","commit_id":"447bc7a062a3a38651f169ea5db555ea7cdce3a4"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"dd7b9b12b9558e96d44fda9385f2e41ff157ffc3","unresolved":true,"context_lines":[{"line_number":387,"context_line":"            self.exit(changed\u003dFalse, image\u003dimage)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        image_properties \u003d self.params[\u0027properties\u0027] or {}"},{"line_number":390,"context_line":"        images \u003d self.conn.image.images(**image_properties)"},{"line_number":391,"context_line":"        images \u003d [i.to_dict(computed\u003dFalse) for i in images]"},{"line_number":392,"context_line":"        self.exit(changed\u003dFalse, mage\u003dimages)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"cded211d_256557d2","line":390,"updated":"2022-05-02 11:53:15.000000000","message":"we have to stick to cloud layer function self.conn.search_images() here because proxy layer does not support the same filters.","commit_id":"447bc7a062a3a38651f169ea5db555ea7cdce3a4"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"7b50c2484d0bcb3b83fcc488548495147d2d0d40","unresolved":false,"context_lines":[{"line_number":387,"context_line":"            self.exit(changed\u003dFalse, image\u003dimage)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        image_properties \u003d self.params[\u0027properties\u0027] or {}"},{"line_number":390,"context_line":"        images \u003d self.conn.image.images(**image_properties)"},{"line_number":391,"context_line":"        images \u003d [i.to_dict(computed\u003dFalse) for i in images]"},{"line_number":392,"context_line":"        self.exit(changed\u003dFalse, mage\u003dimages)"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"ae636c6a_ced95c4f","line":390,"in_reply_to":"cded211d_256557d2","updated":"2022-05-03 10:05:21.000000000","message":"Done","commit_id":"447bc7a062a3a38651f169ea5db555ea7cdce3a4"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"dd7b9b12b9558e96d44fda9385f2e41ff157ffc3","unresolved":true,"context_lines":[{"line_number":384,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":385,"context_line":"            image \u003d self.conn.image.find_image(self.params[\u0027image\u0027])"},{"line_number":386,"context_line":"            image \u003d [image.to_dict(computed\u003dFalse)] if image else []"},{"line_number":387,"context_line":"            self.exit(changed\u003dFalse, image\u003dimage)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        image_properties \u003d self.params[\u0027properties\u0027] or {}"},{"line_number":390,"context_line":"        images \u003d self.conn.image.images(**image_properties)"}],"source_content_type":"text/x-python","patch_set":24,"id":"9f43f377_a0a39b82","line":387,"updated":"2022-05-02 11:53:15.000000000","message":"please rename \n\n  image\u003dimage\n\nto\n\n  images\u003dimages\n\nor easier:\n\n  images\u003d[image.to_dict(computed\u003dFalse)] if image else []","commit_id":"7c109bf59aca909de5423b3b6f0c56406380e5fc"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"7b50c2484d0bcb3b83fcc488548495147d2d0d40","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        if self.params[\u0027image\u0027]:"},{"line_number":385,"context_line":"            image \u003d self.conn.image.find_image(self.params[\u0027image\u0027])"},{"line_number":386,"context_line":"            image \u003d [image.to_dict(computed\u003dFalse)] if image else []"},{"line_number":387,"context_line":"            self.exit(changed\u003dFalse, image\u003dimage)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        image_properties \u003d self.params[\u0027properties\u0027] or {}"},{"line_number":390,"context_line":"        images \u003d self.conn.image.images(**image_properties)"}],"source_content_type":"text/x-python","patch_set":24,"id":"198a4b2d_7bf44c1a","line":387,"in_reply_to":"9f43f377_a0a39b82","updated":"2022-05-03 10:05:21.000000000","message":"Done","commit_id":"7c109bf59aca909de5423b3b6f0c56406380e5fc"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"dd7b9b12b9558e96d44fda9385f2e41ff157ffc3","unresolved":true,"context_lines":[{"line_number":389,"context_line":"        image_properties \u003d self.params[\u0027properties\u0027] or {}"},{"line_number":390,"context_line":"        images \u003d self.conn.image.images(**image_properties)"},{"line_number":391,"context_line":"        images \u003d [i.to_dict(computed\u003dFalse) for i in images]"},{"line_number":392,"context_line":"        self.exit(changed\u003dFalse, mage\u003dimages)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":24,"id":"2a932e1e_a1932310","line":392,"updated":"2022-05-02 11:53:15.000000000","message":"typo: \u0027mage\u003d\u0027 \u003d\u003e \u0027image\u003d\u0027","commit_id":"7c109bf59aca909de5423b3b6f0c56406380e5fc"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"7b50c2484d0bcb3b83fcc488548495147d2d0d40","unresolved":false,"context_lines":[{"line_number":389,"context_line":"        image_properties \u003d self.params[\u0027properties\u0027] or {}"},{"line_number":390,"context_line":"        images \u003d self.conn.image.images(**image_properties)"},{"line_number":391,"context_line":"        images \u003d [i.to_dict(computed\u003dFalse) for i in images]"},{"line_number":392,"context_line":"        self.exit(changed\u003dFalse, mage\u003dimages)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":24,"id":"04f81582_98b76faf","line":392,"in_reply_to":"2a932e1e_a1932310","updated":"2022-05-03 10:05:21.000000000","message":"Done","commit_id":"7c109bf59aca909de5423b3b6f0c56406380e5fc"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"0b90cfa782ba3e12423ff990aaad22dd9902bb1f","unresolved":true,"context_lines":[{"line_number":68,"context_line":"\u0027\u0027\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":71,"context_line":"images:"},{"line_number":72,"context_line":"    description: has all the openstack information about the image"},{"line_number":73,"context_line":"    returned: always, but can be null"},{"line_number":74,"context_line":"    type: complex"}],"source_content_type":"text/x-python","patch_set":27,"id":"f298a842_45f0ff6f","line":71,"updated":"2022-05-02 14:42:14.000000000","message":"Oh, thank you for the pointer, Ananya! It was inconsistent in the past because although it returned openstack_image it could be a list or a single munch object. We should make that consistent and return a list always like we do in other modules. So \u0027images\u0027 should be fine.","commit_id":"cfed146210888db38c3bda51de79034a68b83550"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"d05ac898cd2d5eb28cd031235f5dfb61275fb403","unresolved":true,"context_lines":[{"line_number":68,"context_line":"\u0027\u0027\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":71,"context_line":"images:"},{"line_number":72,"context_line":"    description: has all the openstack information about the image"},{"line_number":73,"context_line":"    returned: always, but can be null"},{"line_number":74,"context_line":"    type: complex"}],"source_content_type":"text/x-python","patch_set":27,"id":"bb2c1134_8df1472b","line":71,"in_reply_to":"697a89af_9c4dc1d7","updated":"2022-05-03 10:19:27.000000000","message":"Should we change https://opendev.org/openstack/ansible-collections-openstack/src/commit/3320c662c8030a33722a6a92a354045500b69dba/plugins/modules/image.py#L103 as well then for consistency ?","commit_id":"cfed146210888db38c3bda51de79034a68b83550"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"a4c6aebb6682b1d5685fb0c36872e6d6fdd361ae","unresolved":false,"context_lines":[{"line_number":68,"context_line":"\u0027\u0027\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":71,"context_line":"images:"},{"line_number":72,"context_line":"    description: has all the openstack information about the image"},{"line_number":73,"context_line":"    returned: always, but can be null"},{"line_number":74,"context_line":"    type: complex"}],"source_content_type":"text/x-python","patch_set":27,"id":"cfbc7494_b01cb11b","line":71,"in_reply_to":"bb2c1134_8df1472b","updated":"2022-05-09 12:26:01.000000000","message":"Nope, how to call modules is a different topic. There we want to use the FQCN because short names (e.g. os_image) are deprecated.","commit_id":"cfed146210888db38c3bda51de79034a68b83550"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"7b50c2484d0bcb3b83fcc488548495147d2d0d40","unresolved":false,"context_lines":[{"line_number":68,"context_line":"\u0027\u0027\u0027"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"RETURN \u003d \u0027\u0027\u0027"},{"line_number":71,"context_line":"images:"},{"line_number":72,"context_line":"    description: has all the openstack information about the image"},{"line_number":73,"context_line":"    returned: always, but can be null"},{"line_number":74,"context_line":"    type: complex"}],"source_content_type":"text/x-python","patch_set":27,"id":"697a89af_9c4dc1d7","line":71,"in_reply_to":"f298a842_45f0ff6f","updated":"2022-05-03 10:05:21.000000000","message":"Ack","commit_id":"cfed146210888db38c3bda51de79034a68b83550"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"36ddbc626fc8da2b758e5836cf4ab7ab3a608eb2","unresolved":true,"context_lines":[{"line_number":72,"context_line":"images:"},{"line_number":73,"context_line":"    description: has all the openstack information about the image"},{"line_number":74,"context_line":"    returned: always, but can be null"},{"line_number":75,"context_line":"    type: complex"},{"line_number":76,"context_line":"    contains:"},{"line_number":77,"context_line":"        id:"},{"line_number":78,"context_line":"            description: Unique UUID."}],"source_content_type":"text/x-python","patch_set":35,"id":"6117c264_241b5c21","line":75,"updated":"2022-05-09 12:50:23.000000000","message":"With new SDK we can change it to:\n\n  type: list\n  elements: dict\n\nwhich is more precise and might allow us to do some fancy tests later on.","commit_id":"0d3c04e64c28288ec908cd46c48d1776f4fcc0a0"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"07841b2a125263508b8bf906e3a7cfebde69b354","unresolved":false,"context_lines":[{"line_number":72,"context_line":"images:"},{"line_number":73,"context_line":"    description: has all the openstack information about the image"},{"line_number":74,"context_line":"    returned: always, but can be null"},{"line_number":75,"context_line":"    type: complex"},{"line_number":76,"context_line":"    contains:"},{"line_number":77,"context_line":"        id:"},{"line_number":78,"context_line":"            description: Unique UUID."}],"source_content_type":"text/x-python","patch_set":35,"id":"c304eff4_40e93321","line":75,"in_reply_to":"6117c264_241b5c21","updated":"2022-05-09 15:52:59.000000000","message":"Done","commit_id":"0d3c04e64c28288ec908cd46c48d1776f4fcc0a0"},{"author":{"_account_id":8367,"name":"Arx Cruz","email":"arxcruz@redhat.com","username":"arxcruz"},"change_message_id":"882aec07d945c74dbf7a90c38231cc347891f9d1","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            returned: success"},{"line_number":118,"context_line":"            type: str"},{"line_number":119,"context_line":"        has_auto_disk_config:"},{"line_number":120,"context_line":"            description: \u003e"},{"line_number":121,"context_line":"                If root partition on disk is automatically resized"},{"line_number":122,"context_line":"                before the instance boots."},{"line_number":123,"context_line":"            returned: success"}],"source_content_type":"text/x-python","patch_set":35,"id":"f3ced548_fc0e06af","line":120,"updated":"2022-05-09 13:10:00.000000000","message":"are these \u003e required?","commit_id":"0d3c04e64c28288ec908cd46c48d1776f4fcc0a0"},{"author":{"_account_id":32458,"name":"Ananya","display_name":"Ananya Banerjee","email":"anbanerj@redhat.com","username":"frenzyfriday"},"change_message_id":"07841b2a125263508b8bf906e3a7cfebde69b354","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            returned: success"},{"line_number":118,"context_line":"            type: str"},{"line_number":119,"context_line":"        has_auto_disk_config:"},{"line_number":120,"context_line":"            description: \u003e"},{"line_number":121,"context_line":"                If root partition on disk is automatically resized"},{"line_number":122,"context_line":"                before the instance boots."},{"line_number":123,"context_line":"            returned: success"}],"source_content_type":"text/x-python","patch_set":35,"id":"c858c146_21dddc5b","line":120,"in_reply_to":"f3ced548_fc0e06af","updated":"2022-05-09 15:52:59.000000000","message":"Without \u003e it is throwing yaml parsing errors when the description is multiline","commit_id":"0d3c04e64c28288ec908cd46c48d1776f4fcc0a0"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"36ddbc626fc8da2b758e5836cf4ab7ab3a608eb2","unresolved":true,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        image_properties \u003d self.params[\u0027filters\u0027] or {}"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        images \u003d self.conn.search_images(filters\u003dimage_properties)"},{"line_number":399,"context_line":"        self.exit(changed\u003dFalse, images\u003dimages)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"eb65fdbe_be2b7f1e","line":398,"updated":"2022-05-09 12:50:23.000000000","message":"search_images provides a name_or_id parameter, hence you can reduce L391-399 to:\n  args \u003d {\n    \u0027name_or_id\u0027: self.params[\u0027image\u0027],\n    \u0027filters\u0027: self.params[\u0027filters\u0027],\n  }\n  args \u003d {k: v for k, v in args.items() if v is not None}\n\n  images \u003d [image.to_dict(computed\u003dFalse) for image in self.conn.search_images(**args)]\n\nLess lines of code means less to test for.","commit_id":"0d3c04e64c28288ec908cd46c48d1776f4fcc0a0"},{"author":{"_account_id":32962,"name":"Jakob Meng","email":"code@jakobmeng.de","username":"jakobmeng@web.de"},"change_message_id":"92ff17952004b8f1dae5dccf4b788b500a46e5f5","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        image_properties \u003d self.params[\u0027filters\u0027] or {}"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"        images \u003d self.conn.search_images(filters\u003dimage_properties)"},{"line_number":399,"context_line":"        self.exit(changed\u003dFalse, images\u003dimages)"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":""}],"source_content_type":"text/x-python","patch_set":35,"id":"75b8af13_571ec390","line":398,"in_reply_to":"eb65fdbe_be2b7f1e","updated":"2022-05-09 19:09:04.000000000","message":"Done","commit_id":"0d3c04e64c28288ec908cd46c48d1776f4fcc0a0"}]}